[Issue 9283] New: Mutex leak in backend.c`backend_db_init()

List overview All Threads
Download

newer

older

[Issue 8882] Null Attribute Value...

[Issue 9157] return additional...

openldap-its＠openldap.org

1 Jul 2020 1 Jul '20

11:05 p.m.

https://bugs.openldap.org/show_bug.cgi?id=9283

Issue ID: 9283 Summary: Mutex leak in backend.c`backend_db_init() Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: --- Component: slapd Assignee: bugs@openldap.org Reporter: grapvar@gmail.com Target Milestone: ---

@backend_db_init: if bi_db_init() fails, but [BackendDB *be] is not listed in [slap_be_head backendDB] list of backends, then be->be_pcl_mutex is not destroyed.

| BackendDB * | backend_db_init( ... ) | { | ... | ldap_pvt_thread_mutex_init( &be->be_pcl_mutex ); | ... | if ( bi->bi_db_init ) | rc = bi->bi_db_init( be, cr ); | | if ( rc != 0 ) { | if ( !b0 ) { | ... | ldap_pvt_thread_mutex_destroy( &be->be_pcl_mutex ); | ch_free( be );

Additionally, it does not look like that owner of [b0] cares about destroying this mutex.

-- You are receiving this mail because: You are on the CC list for the issue.

Show replies by thread

openldap-its＠openldap.org

2 Jul 2 Jul

6:26 a.m.

New subject: [Issue 9283] Mutex leak in backend.c`backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Howard Chu hyc@openldap.org changed:

--- Comment #1 from Howard Chu hyc@openldap.org --- Not a bug. When init'ng a private backend, the caller is responsible for cleanup. See for example https://git.openldap.org/openldap/openldap/-/blob/master/servers/slapd/overl...

Closing this.

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

12:08 p.m.

New subject: [Issue 9283] Mutex leak in backend.c`backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

3 Jul 3 Jul

4:33 a.m.

New subject: [Issue 9283] Mutex leak in backend.c`backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Konstantin Andreev grapvar@gmail.com changed:

--- Comment #2 from Konstantin Andreev grapvar@gmail.com --- (In reply to Howard Chu from comment #1)

...

When init'ng a private backend, the caller is responsible for cleanup. See for example | translucent_db_destroy( BackendDB *be, ConfigReply *cr ) | { | ... | ldap_pvt_thread_mutex_destroy( &ov->db.be_pcl_mutex );

Other callers disagree. There are no destroy complements for this:

| bconfig.c`config_setup_ldif( ... ) { | ... | if ( backend_db_init( "ldif", &cfb->cb_db, -1, NULL ) == NULL ) | return 1;

and this

| overlays/pcache.c`pc_cf_gen( ... ) { | ... | if ( !backend_db_init( c->argv[1], &cm->db, -1, NULL )) { | // error report | return( 1 );

whatever it could mean.

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

8:11 a.m.

New subject: [Issue 9283] Mutex leak in backend.c`backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

--- Comment #3 from Howard Chu hyc@openldap.org --- (In reply to Konstantin Andreev from comment #2)

...

(In reply to Howard Chu from comment #1)

...
When init'ng a private backend, the caller is responsible for cleanup. See for example | translucent_db_destroy( BackendDB *be, ConfigReply *cr ) | { | ... | ldap_pvt_thread_mutex_destroy( &ov->db.be_pcl_mutex );

Other callers disagree. There are no destroy complements for this:

| bconfig.c`config_setup_ldif( ... ) { | ... | if ( backend_db_init( "ldif", &cfb->cb_db, -1, NULL ) == NULL ) | return 1;

The config backend cannot be destroyed without shutting down slapd, therefore any potential leaks are irrelevant.

...

and this

| overlays/pcache.c`pc_cf_gen( ... ) { | ... | if ( !backend_db_init( c->argv[1], &cm->db, -1, NULL )) { | // error report | return( 1 );

whatever it could mean.

Patches welcome.

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

6:44 p.m.

New subject: [Issue 9283] Mutex leak in backend.c`backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.5.0

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

2 Sep 2 Sep

4:04 p.m.

New subject: [Issue 9283] Mutex leak in backend.c backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Quanah Gibson-Mount quanah@openldap.org changed:

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

14 Oct 14 Oct

2:30 p.m.

New subject: [Issue 9283] Mutex leak in backend.c backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.5.0 |2.5.1

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

8 Feb 8 Feb

10:02 a.m.

New subject: [Issue 9283] Mutex leak in backend.c backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Quanah Gibson-Mount quanah@openldap.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|2.5.1 |2.5.3

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

25 Feb 25 Feb

9:50 a.m.

New subject: [Issue 9283] Mutex leak in backend.c backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Quanah Gibson-Mount quanah@openldap.org changed:

-- You are receiving this mail because: You are on the CC list for the issue.

openldap-its＠openldap.org

9:51 a.m.

New subject: [Issue 9283] Mutex leak in backend.c backend_db_init()

https://bugs.openldap.org/show_bug.cgi?id=9283

Quanah Gibson-Mount quanah@openldap.org changed:

-- You are receiving this mail because: You are on the CC list for the issue.

1157

Age (days ago)

1395

Last active (days ago)

openldap-bugs@openldap.org

10 comments

1 participants

tags (0)

participants (1)

openldap-its＠openldap.org