https://bugs.openldap.org/show_bug.cgi?id=9590
Issue ID: 9590 Summary: missed mutex unlock Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: --- Component: libraries Assignee: bugs@openldap.org Reporter: grapvar@gmail.com Target Milestone: ---
Unlikely causes a harm, but oughts fixing ...
diff --git a/libraries/libldap/open.c b/libraries/libldap/open.c index 7fe9f9c29..05f6a84c8 100644 --- a/libraries/libldap/open.c +++ b/libraries/libldap/open.c @@ -349,8 +349,9 @@ ldap_init_fd( LDAP_MUTEX_LOCK( &ld->ld_conn_mutex ); /* Attach the passed socket as the LDAP's connection */ conn = ldap_new_connection( ld, NULL, 1, 0, NULL, 0, 0 ); if( conn == NULL ) { + LDAP_MUTEX_UNLOCK( &ld->ld_conn_mutex ); ldap_unbind_ext( ld, NULL, NULL ); return( LDAP_NO_MEMORY ); } if( url )
https://bugs.openldap.org/show_bug.cgi?id=9590
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |TEST
--- Comment #1 from Howard Chu hyc@openldap.org --- Thanks, fixed in master
https://bugs.openldap.org/show_bug.cgi?id=9590
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- Commits: • 7bd1fac5 by Konstantin Andreev at 2021-06-24T13:40:44+01:00 ITS#9590 libldap: fix missing unlock on connection alloc failure
https://bugs.openldap.org/show_bug.cgi?id=9590
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.5.6
https://bugs.openldap.org/show_bug.cgi?id=9590
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- RE25:
Commits: • 181e5b2e by Konstantin Andreev at 2021-06-24T16:34:36+00:00 ITS#9590 libldap: fix missing unlock on connection alloc failure
https://bugs.openldap.org/show_bug.cgi?id=9590
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED Status|RESOLVED |VERIFIED