dhawes@vt.edu wrote:

Pierangelo Masarati wrote:

...

dhawes@vt.edu wrote:

...

Full_Name: David Hawes Version: 2.4.12 OS: URL: ftp://ftp.openldap.org/incoming/david-hawes-081021.patch Submission from: (NULL) (128.173.38.164)

This patch includes the following changes:

• -fPIC added to the Makefile for compilation on x86_64 systems.
• No longer use be_search() to retrieve the entry that is to be

compared. Use be_entry_get_rw() instead.

You should probably use overlay_entry_get_ov() rather than be_entry_get_rw() from inside an overlay (AFAIR).

Okay, I'll make that change, thanks.

I notice that most overlays seem to use be_entry_get_rw(), and one (translucent) uses both. What is the reasoning to use one over the other?

Most of those overlays were written before overlay_entry_get_ov() was written. It's just a convenience function so you don't have to juggle bd_info pointers all the time.