https://bugs.openldap.org/show_bug.cgi?id=9368
Issue ID: 9368 Summary: openldap-2.4.54/contrib/slapd-modules/nssov/nssov.c:95 0:3: warning: Suss picious use of ; at the end of 'if' statement. Product: OpenLDAP Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: --- Component: contrib Assignee: bugs@openldap.org Reporter: dcb314@hotmail.com Target Milestone: ---
Source code is
if (ni->ni_socket >= 0); { if (close(ni->ni_socket))
Suggest drop ;
https://bugs.openldap.org/show_bug.cgi?id=9368
--- Comment #1 from Howard Chu hyc@openldap.org --- (In reply to dcb314@hotmail.com from comment #0)
Source code is
if (ni->ni_socket >= 0); { if (close(ni->ni_socket))
Suggest drop ;
Looks like this was fixed in master as part of 129dcfbd867605ffc1da31ed90c8316cf7c59523 but overlooked for 2.4.
https://bugs.openldap.org/show_bug.cgi?id=9368
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|openldap-2.4.54/contrib/sla |nssov/nssov.c:950:3: |pd-modules/nssov/nssov.c:95 |warning: Suspicious use of |0:3: warning: Suss picious |; at the end of 'if' |use of ; at the end of 'if' |statement. |statement. |
https://bugs.openldap.org/show_bug.cgi?id=9368
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.4.55
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- MR: https://git.openldap.org/openldap/openldap/-/merge_requests/192
https://bugs.openldap.org/show_bug.cgi?id=9368
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- Fixed in:
Commits: • d3cccc35 by Ondřej Kuzník at 2020-10-15T17:58:31+00:00 ITS#8731 General Debug() related fixes
https://bugs.openldap.org/show_bug.cgi?id=9368
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED