https://bugs.openldap.org/show_bug.cgi?id=9725
Issue ID: 9725 Summary: attribute olcLastBindPrecision redefined in slapo-lastbind Product: OpenLDAP Version: 2.6.0 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: slapd Assignee: bugs@openldap.org Reporter: michael@stroeder.com Target Milestone: ---
An attribute type description for 'olcLastBindPrecision' is present in servers/slapd/bconfig.c and contrib/slapd-modules/lastbind/lastbind.c.
Thus the migration of deployments using slapo-lastbind is not as smooth as it should be. With release 2.6.0 one is forced to disable slapo-lastbind.
Removing the attribute type description for 'olcLastBindPrecision' from contrib/slapd-modules/lastbind/lastbind.c should work.
https://bugs.openldap.org/show_bug.cgi?id=9725
--- Comment #1 from Michael Ströder michael@stroeder.com --- Created attachment 848 --> https://bugs.openldap.org/attachment.cgi?id=848&action=edit Remove attribute type description for 'olcLastBindPrecision' from slapo-lastbind.
https://bugs.openldap.org/show_bug.cgi?id=9725
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.6.1
https://bugs.openldap.org/show_bug.cgi?id=9725
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_review | Assignee|bugs@openldap.org |ondra@mistotebe.net
https://bugs.openldap.org/show_bug.cgi?id=9725
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- See if man page needs updating as well as to when the overlay should be used now that portions of this overlay are integrated into slapd proper.
https://bugs.openldap.org/show_bug.cgi?id=9725
--- Comment #3 from Ondřej Kuzník ondra@mistotebe.net --- Getting the two OIDs to match is not enough, it does fix olcLastBindPrecision on the overlay's config entry but slapd.conf will keep ignoring it (it is a DB level keyword and so it never hits the overlay).
We could rename the slapd keyword in core, that would break slapd.conf for those that have migrated to 2.6.0 already, maybe that's something we need to accept?
I thought bconfig should pick the most specific keyword that matched (preferring overlay's version to database/global ones) but that's not a change we can make any time soon, if ever.
https://bugs.openldap.org/show_bug.cgi?id=9725
Ondřej Kuzník ondra@mistotebe.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |IN_PROGRESS
--- Comment #4 from Ondřej Kuzník ondra@mistotebe.net --- See also https://git.openldap.org/openldap/openldap/-/merge_requests/433
https://bugs.openldap.org/show_bug.cgi?id=9725
--- Comment #5 from Howard Chu hyc@openldap.org --- Since lastbindprecision is now a db-level setting in 2.6, there is no good reason to keep it as an overlay setting. This setting should be deleted from the overlay and it should just use the value of the db-level setting.
For migration purposes the overlay can continue to recognize the setting, but only as a no-op, and perhaps with emitting a warning. Though it may just be safer not to recognize it, and let the config fail with an error.
https://bugs.openldap.org/show_bug.cgi?id=9725
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |TEST Status|IN_PROGRESS |RESOLVED
--- Comment #6 from Quanah Gibson-Mount quanah@openldap.org --- • 7a4b4260 by Ondřej Kuzník at 2021-11-11T17:12:45+00:00 ITS#9725 Use backend's timestamp precision
• 6327f45d by Ondřej Kuzník at 2021-11-11T17:12:45+00:00 ITS#9725 Update lastbind manpage to document core functionality
https://bugs.openldap.org/show_bug.cgi?id=9725
--- Comment #7 from Quanah Gibson-Mount quanah@openldap.org --- RE26:
commit 9081ec97ff146ba57bed1c909ee799d393d35cb0 Author: Ondřej Kuzník ondra@mistotebe.net Date: Mon Nov 8 15:46:59 2021 +0000
ITS#9725 Note that lastbind overlay might need reconfiguring in 2.6
• a77005cb by Ondřej Kuzník at 2021-11-12T21:11:22+00:00 ITS#9725 Use backend's timestamp precision
• 080d8abb by Ondřej Kuzník at 2021-11-12T21:11:26+00:00 ITS#9725 Update lastbind manpage to document core functionality
https://bugs.openldap.org/show_bug.cgi?id=9725
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED Status|RESOLVED |VERIFIED
-
openldap-its＠openldap.org