https://bugs.openldap.org/show_bug.cgi?id=9382

Issue ID: 9382 Summary: client tools ldapvc.c tracks criticality but doesn't use it Product: OpenLDAP Version: 2.5 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: --- Component: client tools Assignee: bugs@openldap.org Reporter: quanah@openldap.org Target Milestone: ---

In clients/toolsldapv.c, we have:

switch ( i ) { char *control, *cvalue; int crit;

...

case 'E': /* vc extension */ crit = 0; if( optarg[0] == '!' ) { crit = 1;

and then we never use "crit" again. It would appear the intention was to determine whether or not this control is marked critical and then do something based on that, but there is in fact nothing ever done.

This leads to a warning that crit is set but unused.

If the criticality of the control doesn't matter, than this variable should be eliminated. If it does matter, then the missing code needs to be added.