https://bugs.openldap.org/show_bug.cgi?id=9541
Issue ID: 9541 Summary: Typos in ldap_pvt_gettimeofday() in libraries/libldap/util-int.c Product: OpenLDAP Version: 2.5.4 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: --- Component: build Assignee: bugs@openldap.org Reporter: brecht@sanders.org Target Milestone: ---
In openldap 2.544 there appear to be some typos in libraries/libldap/util-int.c - there is an int between the ldap_pvt_gettimeofday() function definition and the next curly brace - tv_spec is not a member of struct timeval, should be tv_sec
patch -ulbf libraries/libldap/util-int.c << EOF @@ -300,3 +300,2 @@ ldap_pvt_gettimeofday( struct timeval *tv, void *unused ) -int { @@ -304,3 +303,3 @@ ldap_pvt_clock_gettime( 0, &ts ); - tv->tv_sec = ts.tv_spec; + tv->tv_sec = ts.tv_sec; tv->tv_usec = ts.tv_nsec / 1000; EOF
https://bugs.openldap.org/show_bug.cgi?id=9541
--- Comment #1 from brecht@sanders.org --- I also found that 1 call to ch_calloc() in servers/slapd/daemon.c was missing a parameter.
# fix servers/slapd/daemon.c (version >= 2.5.4) patch -ulbf servers/slapd/daemon.c << EOF @@ -1486,3 +1486,3 @@ for ( i = 0; i<n; i++ ) { - sap[i] = ch_calloc(sizeof(struct sockaddr_in)); + sap[i] = ch_calloc(1, sizeof(struct sockaddr_in)); sap[i]->sa_family = AF_INET; EOF
https://bugs.openldap.org/show_bug.cgi?id=9541
--- Comment #2 from brecht@sanders.org --- P.S.: I noticed these build issues when compiling for Windows with MinGW-w64
https://bugs.openldap.org/show_bug.cgi?id=9541
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |TEST Status|UNCONFIRMED |RESOLVED
--- Comment #3 from Howard Chu hyc@openldap.org --- (In reply to brecht from comment #2)
P.S.: I noticed these build issues when compiling for Windows with MinGW-w64
Thanks, fixed in master
https://bugs.openldap.org/show_bug.cgi?id=9541
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- OS|All |Windows
https://bugs.openldap.org/show_bug.cgi?id=9541
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |2.5.5
https://bugs.openldap.org/show_bug.cgi?id=9541
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED Resolution|TEST |FIXED