https://bugs.openldap.org/show_bug.cgi?id=10092
Issue ID: 10092 Summary: Local logging doesn't build on Windows Product: OpenLDAP Version: 2.6.6 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: slapd Assignee: bugs@openldap.org Reporter: hyc@openldap.org Target Milestone: ---
slapd/logging.c uses writev() to write a prefix and the log message together in one call. This feature doesn't exist on Windows. The closest equivalent, WriteFileGather, only works on page sized and aligned writes. On Windows the only way to write as desired is to copy the message into a new buffer first.
https://bugs.openldap.org/show_bug.cgi?id=10092
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|0 |1 Status|UNCONFIRMED |IN_PROGRESS
--- Comment #1 from Howard Chu hyc@openldap.org --- https://git.openldap.org/openldap/openldap/-/merge_requests/645
https://bugs.openldap.org/show_bug.cgi?id=10092
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|bugs@openldap.org |hyc@openldap.org Target Milestone|--- |2.6.7 Keywords|needs_review |
https://bugs.openldap.org/show_bug.cgi?id=10092
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|IN_PROGRESS |RESOLVED Resolution|--- |TEST
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- head:
• 247e5bcd by Howard Chu at 2023-11-16T18:47:34+00:00 ITS#10092 fix local logger for Windows
• 0b10f4a5 by Howard Chu at 2023-11-16T18:47:34+00:00 ITS#10092 logging: fix strftime for Windows
• 595d1774 by Howard Chu at 2023-12-08T03:25:22+00:00 ITS#10092 logging: fix EOL when logfile-format is explicitly set
• a6929410 by Howard Chu at 2023-12-08T03:41:40+00:00 ITS#10092 fix prev commit for non-Windows
https://bugs.openldap.org/show_bug.cgi?id=10092
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- RE26:
• e820a79f by Howard Chu at 2024-01-16T19:04:44+00:00 ITS#10092 fix local logger for Windows
https://bugs.openldap.org/show_bug.cgi?id=10092
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED