https://bugs.openldap.org/show_bug.cgi?id=9659
Issue ID: 9659 Summary: slapd fails to compile with LDAP_PF_LOCAL_SENDMSG: redefinition of 'peerbv' Product: OpenLDAP Version: 2.5.7 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: slapd Assignee: bugs@openldap.org Reporter: ryan@openldap.org Target Milestone: ---
Thanks for fixing issue 9658. The same test environment (Debian GNU/Hurd 11.0) now fails to compile slapd (RE25 and master):
cc -g -O2 -I../../include -I. -I./slapi -I. -I../../include -c -o daemon.o daemon.c daemon.c: In function 'slap_listener': daemon.c:2113:16: error: redefinition of 'peerbv' 2113 | struct berval peerbv = BER_BVNULL; | ^~~~~~ daemon.c:2110:16: note: previous definition of 'peerbv' was here 2110 | struct berval peerbv = BER_BVC(peername); | ^~~~~~ <builtin>: recipe for target 'daemon.o' failed make[2]: *** [daemon.o] Error 1
The relevant code in daemon.c:
char peername[LDAP_IPADDRLEN]; struct berval peerbv = BER_BVC(peername); #ifdef LDAP_PF_LOCAL_SENDMSG char peerbuf[8]; struct berval peerbv = BER_BVNULL; #endif
When LDAP_PF_LOCAL_SENDMSG is defined, the variable 'peerbv' is declared twice.
https://bugs.openldap.org/show_bug.cgi?id=9659
Howard Chu hyc@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |TEST
--- Comment #1 from Howard Chu hyc@openldap.org --- Looks like this broke in 1748ec59a69, fixed in master
https://bugs.openldap.org/show_bug.cgi?id=9659
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords|needs_review | Target Milestone|--- |2.5.8
--- Comment #2 from Quanah Gibson-Mount quanah@openldap.org --- Commits: • 73be971a by Howard Chu at 2021-09-01T04:00:57+01:00 ITS#9659 remove redundant peerbv def
https://bugs.openldap.org/show_bug.cgi?id=9659
--- Comment #3 from Ryan Tandy ryan@openldap.org --- Fix confirmed. With current git master './configure && make' completes successfully on this Hurd system. Thank you!
https://bugs.openldap.org/show_bug.cgi?id=9659
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|TEST |FIXED
--- Comment #4 from Quanah Gibson-Mount quanah@openldap.org --- RE25:
Commits: • 315751d7 by Howard Chu at 2021-09-03T18:19:11+00:00 ITS#9659 remove redundant peerbv def
https://bugs.openldap.org/show_bug.cgi?id=9659
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED