https://bugs.openldap.org/show_bug.cgi?id=10648
Issue ID: 10648 Summary: More fixes to pcache Product: OpenLDAP Version: 2.6.15 Hardware: All OS: All Status: UNCONFIRMED Keywords: needs_review Severity: normal Priority: --- Component: overlays Assignee: bugs@openldap.org Reporter: aweits@rit.edu Target Milestone: ---
Created attachment 1237 --> https://bugs.openldap.org/attachment.cgi?id=1237&action=edit Fixes for pcache.c
Hello, I have some more fixes for the pcache overlay for issues we're seen. These are based on 2.6.15.
https://bugs.openldap.org/show_bug.cgi?id=10648
--- Comment #1 from Howard Chu hyc@openldap.org --- You should describe the actual problems.
The patch you've attached is 2.63KB, you probably need to provide an Intellectual Property Rights statement before we can read it.
https://bugs.openldap.org/show_bug.cgi?id=10648
--- Comment #2 from aweits@rit.edu aweits@rit.edu --- I. the consistency checker was not expiring all entries, only the "last" one. II. refresh_query() prepares a uuid filter that was not used. III. url2query() was attaching queries loaded from disk to the wrong template.
The largest line change in each patch was 2 lines. Is it better to open an ITS per issue?
https://bugs.openldap.org/show_bug.cgi?id=10648
--- Comment #3 from Howard Chu hyc@openldap.org --- I think since it's all in pcache a single ticket is fine. The fixes maybe should be one commit per fix, but if they're all that small it's ok either way.