https://bugs.openldap.org/show_bug.cgi?id=9509
Issue ID: 9509 Summary: ldap_pvt_tls_check_hostname missing prototype Product: OpenLDAP Version: 2.4.57 Hardware: Other OS: Mac OS Status: UNCONFIRMED Severity: normal Priority: --- Component: libraries Assignee: bugs@openldap.org Reporter: noloader@gmail.com Target Milestone: ---
Hi Everyone,
I'm building OpenLDAP 2.4.57 on Apple M1. Apple turned on -Werror for missing prototypes. It results in:
tls2.c:378:9: error: implicit declaration of function 'ldap_pvt_tls_check_hostname' is invalid in C99 [-Werror,-Wimplicit-function-declaration] err = ldap_pvt_tls_check_hostname( ld, ssl, host );
You can access an Apple M1 machine on the GCC Compile Farm. It is GCC304, port 2409. If needed you can get an account at https://cfarm.tetaneutral.net/users/new/.
https://bugs.openldap.org/show_bug.cgi?id=9509
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED
--- Comment #1 from Quanah Gibson-Mount quanah@openldap.org --- Already fixed for OpenLDAP 2.5:
commit cd914149a665167b2c5ae16baa0c438824588819 Author: Ondřej Kuzník ondra@openldap.org Date: Tue Feb 19 10:26:39 2019 +0000
Make prototypes available where needed
https://bugs.openldap.org/show_bug.cgi?id=9509
Quanah Gibson-Mount quanah@openldap.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |VERIFIED Target Milestone|--- |2.5.0
https://bugs.openldap.org/show_bug.cgi?id=9509
--- Comment #2 from noloader@gmail.com noloader@gmail.com --- (In reply to Quanah Gibson-Mount from comment #1)
Already fixed for OpenLDAP 2.5:
commit cd914149a665167b2c5ae16baa0c438824588819
Thanks Quanah. Sorry I missed that. I did search the bug tracker before filing.
Sorry again.
https://bugs.openldap.org/show_bug.cgi?id=9509
--- Comment #3 from Quanah Gibson-Mount quanah@openldap.org --- (In reply to noloader@gmail.com from comment #2)
(In reply to Quanah Gibson-Mount from comment #1)
Already fixed for OpenLDAP 2.5:
commit cd914149a665167b2c5ae16baa0c438824588819
Thanks Quanah. Sorry I missed that. I did search the bug tracker before filing.
Sorry again.
No worries, it unfortunately was not tracked in a bug. Generally always check the HEAD working branch too :)