hyc@symas.com wrote:
Kris Zyp wrote:
Sorry to keep pestering, but just pinging about this patch again, as I still think this fix could benefit windows users. And at this point, I think I can say we have tested it pretty well, running on our servers for almost a year :).
Looks like this patch is against the 0.9 release branch. I hit a bunch of conflicts trying to apply it to mdb.master. We'll be stopping work on 0.9 soon, and getting LMDB 1.0 out the door finally, so can you please verify that your changes will work on mdb.master as well?
I was manually applying this patch to mdb.master and see something odd in the changes to mdb_page_flush. Why did you move the MIPS-specific CACHEFLUSH invocation?
Thanks, Kris
On Wed, Sep 18, 2019 at 12:56 PM Kris Zyp <kriszyp@gmail.com mailto:kriszyp@gmail.com> wrote:
Checking on this again, is this still a possibility for merging into LMDB? This fix is still working great (improved performance) on our systems. Thanks, Kris On Mon, Jun 17, 2019 at 1:04 PM Kris Zyp <kriszyp@gmail.com <mailto:kriszyp@gmail.com>> wrote: Is this still being considered/reviewed? Let me know if there are any other changes you would like me to make. This patch has continued to yield significant and reliable performance improvements for us, and seems like it would be nice for this to be available for other Windows users. On Fri, May 3, 2019 at 3:52 PM Kris Zyp <kriszyp@gmail.com <mailto:kriszyp@gmail.com>> wrote: For the sake of putting this in the email thread (other code discussion in GitHub), here is the latest squashed commit of the proposed patch (with the on-demand, retained overlapped array to reduce re-malloc and opening event handles): https://github.com/kriszyp/node-lmdb/commit/726a9156662c703bf3d453aab75ee222072b990f