Michael Str=C3=B6der wrote:
hyc@symas.com wrote:
There's a weird indent at extended.c:50 or so, the if() statement.
Would be better to use op->o_tmpalloc instead of ber_memalloc since you'r=3D e=3D20 immediately freeing the buffer again anyway.
I can fix those here if you don't care.
=20 Yes, I'd highly appreciate if you simply adjust it to your coding style=
.
=20 One additional point: Currently the external program is not able to produce a custom extended=
=20
operation response. Mainly it should always return CONTINUE or an error=
=20
response. I wanted to make this limitation clear in the man-page but wa=
s=20
unsure about the appropriate section.
You could add a LIMITATIONS section, as slapd-monitor.5 and slapd-shell.5= =20 does. The manpage now needs an update to note that the exop value is base= 64=20 encoded. Also, since it is encoded, I don't believe it's necessary to=20 explicitly send the valuelen.
--=20 -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/