Domagoj Babic wrote:
But, expanding on Kurt's comments - most of the items you reported are in one-shot client or test code. The probability of an alloc routine returning NULL here is near zero, and since it is in code that is either (a) only used for one-shot tests or (b) only invoked for a single request and then exited, we really don't care. For any cases that you find that are in library code that can be executed multiple times in an app or server, we probably need to pay attention.
Even though the probability is near zero, it still will happen, considering the large user base you have.
If a malloc fails in a one-shot command, that means the runtime environment is broken, not any of our code. Whether it is very probable or totally unlikely is irrelevant in that case.