On 22.01.2019 19:55, OndÅ™ej KuznÃk wrote:
> The problem is not that it's still scheduled when the pause is
> requested, scheduled tasks don't prevent a pause (and I think some
> of them need to be a bit more aware of that fact), but that it's been
> picked up by a worker thread and is running while cn=config waits for
> them to pause.
_And_ that a pause request is all-or-nothing. This demo code
of graduated wait-for-pause works for me. For RE24, it doesn't
combine easily with Git master's multiple tpool queues:-(
ftp://ftp.openldap.org/incoming/Hallvard-Furuseth-190124.patch.gz
But I'm not volunteering to write one for master anytime soon,
unless someone has less complicated ideas for that than I do.
A real version looks like more work than I expected anyway.
> What I was suggesting was that it could check every so often whether it
> might be holding up a pause and join it just like some other tasks do.
> But that's only a good idea if it's able to handle the changes that
> happen during the pause (indexes reconfigured again, the database going
> away, ...) as well as being able to release any locks temporarily.
Yes. I should have answered that, but I still cannot decide what I
think of it. I see no locks to worry about in that code, but the rest
does make me nervous.
Possibly we can find some times where we can pause safely, but not a
general case. For example, in the case of back-mdb we could register
scheduled config operations the database itself, in a "(TODO)" LMDB DB.
Doesn't help with schema changes, but does help renumbering slapd DBs.
--
Hallvard
--On Thursday, January 24, 2019 6:26 PM +0000 ruga(a)protonmail.com wrote:
> Full_Name: Rupert
> Version: 2.4.47
> OS: Darwin alice 17.7.0 Darwin Kernel Version 17.7.0: Fri Nov 2 20:43:16
> PDT 2018; root:xnu-4570.71.17~1/RELEASE_X86_64 x86_64 URL:
> ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (5.170.120.126)
Builds fine for me using clang compiler on FreeBSD. Also appears to work
fine for Apple, since it ships the OpenLDAP libraries. You'll need to
provide more details as to exactly what you're doing to encounter this
issue.
--Quanah
--
Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
--On Thursday, January 24, 2019 6:47 PM +0000 ruga(a)protonmail.com wrote:
> Full_Name: Rupert
> Version: -
> OS: -
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (5.170.120.126)
>
>
> The source code of openldap went through lumnify's meat grinder,
> receiving a score of 1 (fail) out of 5. Score 1 means "A lot of patch
Sounds like lumnify is a poor quality product. You may wish to use
something better written?
In any case, the ITS system is for bug reports, this is clearly not a bug
report. It will be closed.
--Quanah
--
Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
Full_Name: Rupert
Version: -
OS: -
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (5.170.120.126)
The source code of openldap went through lumnify's meat grinder, receiving a
score of 1 (fail) out of 5. Score 1 means "A lot of patch work and bandages,
project is most likely in initial stage of development. Most of source code is
highly unmaintainable and feels a bit chaotic. It is good starting point, but
plenty of work ahead. Don't give up yet!". I see old bugs pending. Is the
project active?
[1] https://sysadmin.libhunt.com/openldap-alternatives
[2] https://lumnify.com/grades/?rel=libhunt