openldap-bugs

openldap-bugs@openldap.org

1 participants
20960 discussions

Re: (ITS#5112) memory leak in pcache overlay
by rhafer＠suse.de 29 Aug '07

29 Aug '07

On Wednesday 29 August 2007 18:10, Howard Chu wrote: > Ralf Haferkamp wrote: > > On Wednesday 29 August 2007 17:36, Howard Chu wrote: > >> rhafer(a)suse.de wrote: > >>> Full_Name: Ralf Haferkamp > >>> Version: RE23, HEAD > >>> > >>> Valgrind gives me the log pasted below when I abort an ldapsearch > >>> command (CTRL-C) that is running against a back-ldap database that uses > >>> the pcache overlay. > >> > >> Makes sense. We need to use the cleanup handler and free the saved query > >> info if op->o_abandon is set. Do you want to code this up? > > > > I am still working on that, but checking for op->o_abandon doesn't seem > > to be enough. E.g. if I abort the ldapsearch while slapd is updating its > > cache (all entries have been returned, but the final LDAP_RESULT to the > > client is still missing) a filter_free in the cleanup handler will > > invalidly free the filter. > > > > We somehow need to make sure that the query is only free'd if nothing has > > been written to the cache database. > > I don't understand the problem. Nothing can get written to the DB until the > LDAP_RESULT has been sent. I.e., rs->sr_result == REP_RESULT. Hm, but the ldapsearch command only returns after the complete query result has been written to the cache (at least here it behaves so), which can take quite a while. So it seems to me that the client has not received the LDAP_RESULT. With the suggested fix I get this, if I abort the ldapsearch during that time, as the op->o_abandon is set in cleanup handler: ==26949== Invalid free() / delete / delete[] ==26949== at 0x4C226DB: free (in /usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so) ==26949== by 0x508A819: ber_memfree_x (memory.c:152) ==26949== by 0x4AC9D7: slap_sl_free (sl_malloc.c:455) ==26949== by 0x44797D: filter_free_x (filter.c:526) ==26949== by 0x4478C9: filter_free_x (filter.c:509) ==26949== by 0x4479D9: filter_free (filter.c:538) ==26949== by 0x5A7794: free_query (pcache.c:1126) ==26949== by 0x5AF9B0: pcache_db_close (pcache.c:3282) ==26949== by 0x4C2F87: over_db_close (backover.c:192) ==26949== by 0x452658: backend_shutdown (backend.c:365) ==26949== by 0x47C03E: slap_shutdown (init.c:253) ==26949== by 0x422D65: main (main.c:943) ==26949== Address 0xA533A68 is 0 bytes inside a block of size 24 free'd ==26949== at 0x4C226DB: free (in /usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so) ==26949== by 0x508A819: ber_memfree_x (memory.c:152) ==26949== by 0x4AC9D7: slap_sl_free (sl_malloc.c:455) ==26949== by 0x44797D: filter_free_x (filter.c:526) ==26949== by 0x4478C9: filter_free_x (filter.c:509) ==26949== by 0x4479D9: filter_free (filter.c:538) ==26949== by 0x5A9F7F: pcache_op_cleanup (pcache.c:1886) ==26949== by 0x456A69: slap_cleanup_play (result.c:344) ==26949== by 0x4571DC: send_ldap_response (result.c:526) ==26949== by 0x457935: slap_send_ldap_result (result.c:632) ==26949== by 0x4F7AE4: ldap_back_search (search.c:528) ==26949== by 0x4C3FD0: overlay_op_walk (backover.c:652) -- Ralf

1 0

Re: (ITS#5114) pcache cache results for searches that hit size/timelimit
by hyc＠symas.com 29 Aug '07

29 Aug '07

rhafer(a)suse.de wrote: > Full_Name: Ralf Haferkamp > Version: RE23, HEAD > OS: - > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (89.166.180.39) > > > pcache currently cache the results of search that hit server- or clientside > size- or timelimits. That means that subsequent search will get the (incomplete) > results from the cache. I guess pcache should only cache operations that > returned LDAP_SUCCESS. Makes sense... -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5112) memory leak in pcache overlay
by rhafer＠suse.de 29 Aug '07

29 Aug '07

On Wednesday 29 August 2007 17:36, Howard Chu wrote: > rhafer(a)suse.de wrote: > > Full_Name: Ralf Haferkamp > > Version: RE23, HEAD > > > > Valgrind gives me the log pasted below when I abort an ldapsearch command > > (CTRL-C) that is running against a back-ldap database that uses the > > pcache overlay. > > Makes sense. We need to use the cleanup handler and free the saved query > info if op->o_abandon is set. Do you want to code this up? I am still working on that, but checking for op->o_abandon doesn't seem to be enough. E.g. if I abort the ldapsearch while slapd is updating its cache (all entries have been returned, but the final LDAP_RESULT to the client is still missing) a filter_free in the cleanup handler will invalidly free the filter. We somehow need to make sure that the query is only free'd if nothing has been written to the cache database. -- Ralf

1 0

Re: (ITS#5112) memory leak in pcache overlay
by hyc＠symas.com 29 Aug '07

29 Aug '07

rhafer(a)suse.de wrote: > Full_Name: Ralf Haferkamp > Version: RE23, HEAD > Valgrind gives me the log pasted below when I abort an ldapsearch command > (CTRL-C) that is running against a back-ldap database that uses the pcache > overlay. Makes sense. We need to use the cleanup handler and free the saved query info if op->o_abandon is set. Do you want to code this up? > ==20850== 53,092 (35,830 direct, 17,262 indirect) bytes in 883 blocks are > definitely lost in loss record 17 of 18 > ==20850== at 0x4C22AC6: malloc (in > /usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so) > ==20850== by 0x508A940: ber_memalloc_x (memory.c:226) > ==20850== by 0x4ABEEE: slap_sl_malloc (sl_malloc.c:273) > ==20850== by 0x4487C0: filter_dup (filter.c:801) > ==20850== by 0x5AB151: pcache_op_search (pcache.c:2237) > ==20850== by 0x4C3F41: overlay_op_walk (backover.c:642) > ==20850== by 0x4C41D3: over_op_func (backover.c:704) > ==20850== by 0x4C4269: over_op_search (backover.c:726) > ==20850== by 0x446210: fe_op_search (search.c:369) > ==20850== by 0x445B2E: do_search (search.c:217) > ==20850== by 0x4427DB: connection_operation (connection.c:1145) > ==20850== by 0x442CA6: connection_read_thread (connection.c:1271) > > The database configuration looks like this: > ----------------------------- > database ldap > suffix o=test > uri ldap://xxxxxxxxxxxxxxxxx > readonly on > lastmod off > > overlay pcache > proxycache bdb 100000 1 10000 180 > proxyattrset 0 givenname uid ou o cn sn mail objectclass > > ### > proxytemplate (|(cn=)(mail=)(uid=)) 0 86400 > > directory /var/lib/ldap/pcache > cachesize 10000 > index objectclass,queryid eq > index sn,cn,givenname,uid,mail pres,eq,sub > ----------------------------- > > > -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#5114) pcache cache results for searches that hit size/timelimit
by rhafer＠suse.de 29 Aug '07

29 Aug '07

Full_Name: Ralf Haferkamp Version: RE23, HEAD OS: - URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (89.166.180.39) pcache currently cache the results of search that hit server- or clientside size- or timelimits. That means that subsequent search will get the (incomplete) results from the cache. I guess pcache should only cache operations that returned LDAP_SUCCESS.

1 0

(ITS#5113) pcache returns incomplete results
by rhafer＠suse.de 29 Aug '07

29 Aug '07

Full_Name: Ralf Haferkamp Version: HEAD OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (89.166.180.39) While the results of a query are being cached, slapo-pcache will answer queries that match the same template from the cache that is currently being populated. This means that subsequent queries will get incomplete results until the original query is completely cached. This doesn't happen with current RE23 code.

1 0

(ITS#5112) memory leak in pcache overlay
by rhafer＠suse.de 29 Aug '07

29 Aug '07

Full_Name: Ralf Haferkamp Version: RE23, HEAD OS: - URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (89.166.180.39) Valgrind gives me the log pasted below when I abort an ldapsearch command (CTRL-C) that is running against a back-ldap database that uses the pcache overlay. ==20850== 53,092 (35,830 direct, 17,262 indirect) bytes in 883 blocks are definitely lost in loss record 17 of 18 ==20850== at 0x4C22AC6: malloc (in /usr/lib64/valgrind/amd64-linux/vgpreload_memcheck.so) ==20850== by 0x508A940: ber_memalloc_x (memory.c:226) ==20850== by 0x4ABEEE: slap_sl_malloc (sl_malloc.c:273) ==20850== by 0x4487C0: filter_dup (filter.c:801) ==20850== by 0x5AB151: pcache_op_search (pcache.c:2237) ==20850== by 0x4C3F41: overlay_op_walk (backover.c:642) ==20850== by 0x4C41D3: over_op_func (backover.c:704) ==20850== by 0x4C4269: over_op_search (backover.c:726) ==20850== by 0x446210: fe_op_search (search.c:369) ==20850== by 0x445B2E: do_search (search.c:217) ==20850== by 0x4427DB: connection_operation (connection.c:1145) ==20850== by 0x442CA6: connection_read_thread (connection.c:1271) The database configuration looks like this: ----------------------------- database ldap suffix o=test uri ldap://xxxxxxxxxxxxxxxxx readonly on lastmod off overlay pcache proxycache bdb 100000 1 10000 180 proxyattrset 0 givenname uid ou o cn sn mail objectclass ### proxytemplate (|(cn=)(mail=)(uid=)) 0 86400 directory /var/lib/ldap/pcache cachesize 10000 index objectclass,queryid eq index sn,cn,givenname,uid,mail pres,eq,sub -----------------------------

1 0

Re: (ITS#5106) LDAPI problem on amd64
by ando＠sys-net.it 29 Aug '07

29 Aug '07

> I updated to 2.3.38 and the problem seems to have vanished. > Thanks for the hint. Thanks for the prompt feedback. I've closed this ITS. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati(a)sys-net.it ---------------------------------------

1 0

Re: (ITS#5106) LDAPI problem on amd64
by svgmuc＠bluebottle.com 29 Aug '07

29 Aug '07

Hi, Quoting Pierangelo Masarati <ando(a)sys-net.it>: > You should be using the latest 2.3 release; there was quite a bit > of > work on ldapi between 2.3.32 and 2.3.38 (ITS#4893 and > other possibly related fixes). Having said this, I don't know if it > will solve your problem, but at least it would make sure it's not > fixed yet. No need to say that things work fine here on > Linux/amd64. I updated to 2.3.38 and the problem seems to have vanished. Thanks for the hint. Best, Sven ---------------------------------------------------------------------- Finally - A spam blocker that actually works. http://www.bluebottle.com/tag/4

1 0

Re: (ITS#5065) out of order ctxcsn from old entryCSN
by ando＠sys-net.it 29 Aug '07

29 Aug '07

> Old entryCSN values imported into the data from another server, can crash > replicas. The ITS reports that this is now fixed in HEAD. I would appreciate if you feedback using a fresh HEAD build, since the CSN syntax is now more thoroughly checked, although it is supposed to allow the old one in input. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati(a)sys-net.it ---------------------------------------

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs