- openldap-bugs - openldap.org

(ITS#4992) cldap ber_write assertion fix
by mba2000＠ioplex.com 31 May '07

31 May '07

Full_Name: Michael B Allen Version: 2.3.33 OS: Linux 2.6 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (69.142.196.170) ldap_search_ext with cldap:// will assert because it calls ldap_build_search_req which calls ber_write w/ a NULL ld->ld_options.ldo_peer. The following patch defers encoding the address with ber_write until after the ldo_peer is initialized in request.c. Note that cldap functionality is still not optimal. The transport hangs if there is no reply. --- search.c-2007-05-30 2007-05-30 21:20:06.000000000 -0400 +++ search.c 2007-05-30 21:50:45.000000000 -0400 @@ -259,8 +259,9 @@ LDAP_NEXT_MSGID( ld, *idp ); #ifdef LDAP_CONNECTIONLESS if ( LDAP_IS_UDP(ld) ) { - err = ber_write( ber, ld->ld_options.ldo_peer, - sizeof(struct sockaddr), 0); + struct sockaddr sa; + memset(&sa, 0, sizeof sa); + err = ber_write( ber, &sa, sizeof(struct sockaddr), 0); } if ( LDAP_IS_UDP(ld) && ld->ld_options.ldo_version == LDAP_VERSION2) { char *dn = ld->ld_options.ldo_cldapdn; --- request.c-2007-05-30 2007-05-30 21:39:05.000000000 -0400 +++ request.c 2007-05-30 21:54:33.000000000 -0400 @@ -222,6 +222,19 @@ use_connection( ld, lc ); +#ifdef LDAP_CONNECTIONLESS + if ( LDAP_IS_UDP(ld) ) { + BerElement tmp = *ber; + ber_rewind( &tmp ); /* encode addr at start */ + rc = ber_write( &tmp, ld->ld_options.ldo_peer, + sizeof(struct sockaddr), 0); + if ( rc == -1 ) { + ld->ld_errno = LDAP_ENCODING_ERROR; + return( -1 ); + } + } +#endif + /* If we still have an incomplete write, try to finish it before * dealing with the new request. If we don't finish here, return * LDAP_BUSY and let the caller retry later. We only allow a single

1 0

Re: (ITS#4991) pcache and rwm don't play well together
by rhafer＠suse.de 31 May '07

31 May '07

Fix is in rwm.c (r1.85) and pcache.c (r1.105) -- Ralf

1 0

(ITS#4991) pcache and rwm don't play well together
by rhafer＠suse.de 31 May '07

31 May '07

Full_Name: Ralf Haferkamp Version: RE23, HEAD OS: Linux (Kernel 2.6) URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (89.166.181.19) The rwm and pcache overlays don't work very well together on a single database. The main reason for this seems to be that both overlays touch the list of requested Attributes in a search request and are not prepared for the fact that other overlays might touch that list as well. As a result the Entries returned by a Search against such a database can be incomplete and the server crashes because the various AttributeList arrays are free'd multiple times (or in the wrong place). I think I've a fix for HEAD is mostly ready, still testing it. I'll commit it shortly.

1 0

Re: (ITS#4943) tpool.c pause vs. finish
by h.b.furuseth＠usit.uio.no 31 May '07

31 May '07

hyc(a)symas.com wrote: >h.b.furuseth(a)usit.uio.no wrote: >> (...) >> But it would cleaner to ch_malloc an integer instead of the (void*) >> cast. Then it won't depend on integer->pointer->integer conversions >> preserving the value either. > > Ugh. That's just silly. We should just typedef a union that's big enough > to hold a pointer or an integer... Eh? Then we'd need to change every setkey/getkey call to use set/get that union instead of a simple pointer. > (...) >> Was that an instruction/permission to axe it or not? > > Yes, go ahead. Too late, I #ifdeffed instead:-) >> (...) >> I do not understand the calls to ldap_pvt_thread_pool_context_reset() >> in slapd (init.c and bconfig.c). That frees the thread's sl_malloc >> memory with slap_sl_mem_destroy(), which seems rather hazardous until >> the thread is really, really done. > > Those calls are from the main thread, and only occur during startup. And in slap_destroy(). > The point is to free up that memory since the main thread will never > need it again. Ah. I guess I need to figure out just what is allowed to use slap_sl_malloc() and what isn't. >> For that matter, I guess that means context_reset() had better release >> keys in the reverse order of how they were set. That usually happened, >> but not always, and my clear_key_idx() made the "not always" more >> common. So to close the gap from a deleted key I'll make it move all >> later keys forward, instead of just moving the latest key to the gap. > > I don't think the order is really important... ?? Well, I was thinking if some key could manage to get in front of the sl_malloc key and then be deleted, and then some key which sl_malloced memory ended up before it. But as noted above I don't have a clue:-) Also see tpool.c 1.30.2.17: "ITS#4805 free thread keys in reverse order". However I don't see from the ITS notes how it is related. >> Bdb uses the database environment address as a key to pool_setkey(). >> So there can be at most ~30 BDB databases with an active key at the >> same time in the same thread. What does that mean - 30 overlays >> all using bdb? Access control groups spanning 30 databases? > > Seems so. We could raise this limit if it's a problem, but I don't see > why anyone would use 30 separate databases instead of just one. > Configuring the caches would be a real bear... Well, it's the most natural way to set up an LDAP hotel - 1 database per hosted organization, where each org can configure its own indexes etc. But cache config is definitely an argument against it. It's no less strange to have e.g. 100 databases than 30, so I'm not suggesting to raise the limit in OpenLDAP. Though I suppose we could make it a default, overridden by CPPFLAGS=-DLDAP_THREAD_MAXKEYS=<num>. >> Nitpick: Slapd uses both function pointers and data pointers as keys to >> pool_[sg]etkey(). That makes it possible for two "different" keys to >> compare equal, on a host where functions and data live in different >> segments that otherwise share the same address space. So I guess I >> should clean up and replace (void*)<function> keys with the address of >> static char <function>_key; > > Hosts such as ... ? Not even OS/390 is so strange. Don't know, but it wouldn't surprise me if SINTRAN on ND-500 worked that way. What I do remember is that a program or library consisted of 2-3 files: program segment, data segment and optionally link segment. But it's likely less uncommon for function pointers to be wider than data pointers, which OpenLDAP doesn't support anyway. > The use of function pointers was just a convenience, since the address > is guaranteed to be a unique value within the process and easily > recognizable in a debugger. We could easily use addresses of static > variables instead but it's silly to introduce new variables just for > this purpose. Someday I want to revisit this and use OS-supported thread-specific keys, then it'll change anyway. -- Regards, Hallvard

1 0

(ITS#4990) memory debugging issues
by h.b.furuseth＠usit.uio.no 31 May '07

31 May '07

Full_Name: Hallvard B Furuseth Version: HEAD, RE23 OS: URL: Submission from: (NULL) (129.240.202.105) Submitted by: hallvard CPPFLAGS=-DLDAP_MEMORY_DEBUG won't build: ber_int_meminuse is not defined. sl_malloc.c needs s/ber_malloc_x/ber_memalloc_x/ under SLAP_NO_SL_MALLOC. There are both #if and #ifdef LDAP_MEMORY_DEBUG statements, but value 0 breaks compilation. LDAP_MEMORY_DEBUG enables a number of assert()s that break OpenLDAP code, like ldap_control_free(NULL). Until they are cleaned up (if they are still considered errors) I'll disable them by default unless LDAP_MEMORY_DEBUG & 2. Could do the opposite if someone wants. I'll insert LDAP_MEMORY_DEBUG code in slap_sl_malloc() as well (insert memory signature before each returned chunk, check upon free/realloc).

1 0

Re: (ITS#4943) tpool.c pause vs. finish
by hyc＠symas.com 31 May '07

31 May '07

h.b.furuseth(a)usit.uio.no wrote: > I wrote in the tpool.c 1.66 -> 1.67 patch: > >> API changes, need review - I'm not sure what's indented here: >> - setkey(data=NULL, kfree!=NULL) searched as if intended to reset >> the key, but updated by setting the key. Now always updates. > > Right. That matches the one place it can happen: In bdb_locker_id() > with setkey(,,data=(void *)(long)lockid,). I don't know if lockid > can be 0, but it doesn't need to for data to be NULL. lockid will never be zero. > But it would cleaner to ch_malloc an integer instead of the (void*) > cast. Then it won't depend on integer->pointer->integer conversions > preserving the value either. Ugh. That's just silly. We should just typedef a union that's big enough to hold a pointer or an integer... > BTW, is there a reason for the cast to long? lockid is u_int32_t, > and the getkey 'long' result is restored to a u_int32_t. I don't recall. > Howard Chu wrote: > >>> Also if ctx is invalid (another thread handled it) and a new >>> pending request has gotten the now-unused ctx, then the >>> 'if (pool->ltp_open_count == 0)' code will free that new >>> pending request instead of the old one. >> Most likely this is due to unlocking and relocking the mutex around >> the semaphore code. Axe that, remove the gratuitous unlock/relock, >> and then that problem goes away. > > Was that an instruction/permission to axe it or not? Yes, go ahead. > If not I'll just move the unlock/lock into the #ifdef for now. > >> Thus far we've only had to worry about a single pool. If anyone can >> come up with a reason to need multiple pools, I guess we need to >> hear it. > > I'll insert "static int initialized; assert(!initialized++);" > in pool_init() and see if anyone complains. Sounds fine. >>> - setkey does not free the old data with ltk_free. Possibly that's >>> intentional, but if so that requires weird code elsewhere. >> Yes, that's intentional. ltk_free is only intended for cleanup if a key >> is still set by the time a thread exits. All of the keys we set are live >> for the entire life of a thread, they don't get re-assigned. > > Even the (void*)slap_sasl_bind key? > lutil_passwd() looks like it can be recursive: Register a password > scheme which finds an entry in LDAP and authenticates via that > entry's userPassword - which again could call lutil_passwd(). > If that's legal, this code in be_isroot_pw()/slap_passwd_check() > can break: > pool_setkey(, slap_sasl_bind, <ctx>, <freefunc> ); > ... /* slap_passwd_check() does access_allowed() here */ > lutil_passwd(); > ... > pool_setkey(, slap_sasl_bind, NULL, NULL); > The final setkey would need to restore the old key. I guess so. > I'm not sure of contrib/slapd-modules/smbk5pwd/smbk5pwd.c + some > overlay either. rwm + back-relay which uses another smbk5pwd or > something. (And I have no idea of the BDB cache stuff, but since > you wrote it I assume you know:-) > > If it's a problem, we can replace code like that with > void *data = <ctx>; > ldap_pvt_thread_pool_keyfree_t *kfree = <freefunc>; > pool_swapkey(, slap_sasl_bind, &data, &kfree ); /* new function */ > lutil_passwd(); > pool_setkey(, slap_sasl_bind, data, kfree ); > or if setkey reverts to ignoring kfree when it checks whether we are > setting or deleting a key, the kfree function can be passed directly. > > > I wrote: > >> But this reminds me: How much should an ltk_free() function be allowed >> to do? >> - pool_context_reset() calls ltk_free(). Should pool_wrapper() go >> active (wait for !pause, increment ltp_active_count, unlock ltp_mutex) >> before calling pool_context_reset()? > > I think so. It makes slapi safer, and I don't see that it can hurt: > context_reset() can call connection_fake_destroy(), which via > slapi_int_free_object_extensions() calls slapi module destructors, > which can do who-knows-what. > > Another stray thought: It would similarly be safer for context_reset() > and purgekey() to delete the key before calling ltk_free, so that > function can't access the key's data after freeing it. OTOH that would > break any slapi module whose ltk_free calls a function which uses the > key before freeing it. I'll leave it alone unless someone says otherwise. > > > Other matters: > > pool->ltp_active_list is maintained but not used for anything. > Do I delete it? Or does tpool maintain the list to ease debugging? No idea. > Use of tpool: > > Another bug: > Slapd does not always check if pool_submit() and pool_setkey() succeed, > even though failure is not a bug. (They can run into some limits.) > > > I do not understand the calls to ldap_pvt_thread_pool_context_reset() > in slapd (init.c and bconfig.c). That frees the thread's sl_malloc > memory with slap_sl_mem_destroy(), which seems rather hazardous until > the thread is really, really done. Those calls are from the main thread, and only occur during startup. The point is to free up that memory since the main thread will never need it again. > For that matter, I guess that means context_reset() had better release > keys in the reverse order of how they were set. That usually happened, > but not always, and my clear_key_idx() made the "not always" more > common. So to close the gap from a deleted key I'll make it move all > later keys forward, instead of just moving the latest key to the gap. I don't think the order is really important... ?? > Bdb uses the database environment address as a key to pool_setkey(). > So there can be at most ~30 BDB databases with an active key at the > same time in the same thread. What does that mean - 30 overlays > all using bdb? Access control groups spanning 30 databases? Seems so. We could raise this limit if it's a problem, but I don't see why anyone would use 30 separate databases instead of just one. Configuring the caches would be a real bear... > Nitpick: Slapd uses both function pointers and data pointers as keys to > pool_[sg]etkey(). That makes it possible for two "different" keys to > compare equal, on a host where functions and data live in different > segments that otherwise share the same address space. So I guess I > should clean up and replace (void*)<function> keys with the address of > static char <function>_key; Hosts such as ... ? Not even OS/390 is so strange. The use of function pointers was just a convenience, since the address is guaranteed to be a unique value within the process and easily recognizable in a debugger. We could easily use addresses of static variables instead but it's silly to introduce new variables just for this purpose. -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#4989) Quirk in Dynlist overlay configuration
by marg＠rz.tu-clausthal.de 31 May '07

31 May '07

Full_Name: Christian Marg Version: 2.3.34 OS: FreeBSD 6.2-RELEASE-p3 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (91.3.23.106) I found a behaviour issue with the dynlist overlay configuration: I tried the following configuration: overlay dynlist dynlist-attrset posixGroup memberURL dynlist-attrset groupOfURLs memberURL owner but slaptest complains about it - and the slapd doesn't start with it: @(#) $OpenLDAP: slapd 2.3.34[...] /usr/local/etc/openldap/slapd.conf: line 91: "dynlist-attrset <oc> <URL-ad> [<member-ad>]": URL attributeDescription "memberURL" already mapped. slapd stopped. When I use multiple "overlay dynlist"-entries like: overlay dynlist dynlist-attrset posixGroup memberURL overlay dynlist dynlist-attrset groupOfURLs memberURL owner it works as expected, but there is a warning: overlay_config(): warning, overlay "dynlist" already in list PS: Although the new Version 2.3.35 isn't available via FreeBSD Ports yet, I don't think that it would change anything, because the source file of the dynlist-overlay doesn't seem to have changed in any part that matters to this issue.

1 0

Quirk in Dynlist overlay configuration
by Christian Marg 31 May '07

31 May '07

Hello, in the FAQ-o-Matic http://www.openldap.org/faq/index.cgi?file=1209 it says Unlike previous versions, you do not have to have multiple overlay dynlist entries in your configuration; multiple occurrences of the dynlist-attrpair/ dynlist-attrset statement must be used instead, with a caveat: only the first match on the dyn-oc is used. I tried this with the following configuration: overlay dynlist dynlist-attrset posixGroup memberURL dynlist-attrset groupOfURLs memberURL owner but slaptest complains about it - and the slapd doesn't start with it: @(#) $OpenLDAP: slapd 2.3.34[...] /usr/local/etc/openldap/slapd.conf: line 91: "dynlist-attrset <oc> <URL-ad> [<member-ad>]": URL attributeDescription "memberURL" already mapped. slapd stopped. When I use multiple "overlay dynlist"-entries like: overlay dynlist dynlist-attrset posixGroup memberURL overlay dynlist dynlist-attrset groupOfURLs memberURL owner it works as expected, even though there is a warning: overlay_config(): warning, overlay "dynlist" already in list BTW: Although the new Version 2.3.35 isn't available via FreeBSD Ports yet, I don't think that it would change anything, because the source file of the dynlist-overlay doesn't seem to have changed in any part that matters to this issue. bye Christian -- Christian Marg mail: mailto:marg@rz.tu-clausthal.de Rechenzentrum TU Clausthal web : http://www.rz.tu-clausthal.de D-38678 Clausthal-Zellerfeld fon : 05323/72-2043 Germany ICQ : <on request>

2 1

Re: (ITS#4980) misaligned memory access (openssl?)
by richton＠nbcs.rutgers.edu 31 May '07

31 May '07

I'm going to claim this as possible corruption because the RADIUS module was definitely overstepping bounds when this happened...feel free to close this out, I'll keep an eye out for recurrences. On Wed, 23 May 2007, Howard Chu wrote: > This stack trace is pretty exclusively OpenSSL and libc code. Unless there's > been a heap corruption somewhere, it appears to be an OpenSSL issue.

1 0

Re: (ITS#4951) [contrib] RADIUS password module fixes
by richton＠nbcs.rutgers.edu 31 May '07

31 May '07

I think this does it; I'm now happy with RADIUS in production. --- ldap-src/contrib/slapd-modules/passwd/radius.c 2007-05-30 19:38:29.210866000 -0400 +++ radius.c 2007-05-29 11:02:09.728936000 -0400 @@ -17,6 +17,7 @@ #include <lber.h> #include <lber_pvt.h> /* BER_BVC definition */ #include "lutil.h" +#include <portable.h> #include <ldap_pvt_thread.h> #include <ac/string.h> #include <ac/unistd.h> On Tue, 29 May 2007, Aaron Richton wrote: > Boy, that was some real quality time with dbx...ugh. > > > I'm fairly confident that the issue is that portable.h isn't included and > should have been as part of my patch. This worked in a development > environment; I'll be putting it through some more tests and, most likely, in > production soon (the =NULL workaround is just a time bomb).

1 0

Re: (ITS#4972) thr_debug problems
by h.b.furuseth＠usit.uio.no 30 May '07

30 May '07

I wrote: > RE23/thr_debug.c has some other problems that are fixed in HEAD, but > take a bit more work to fix and test. I'll align it with HEAD if > anyone is interested. Apparenlty not. I'll import the fixes local to thr_debug.c to RE23, but not the ones that need changes in include/. -- Regards, Hallvard

1 0

(ITS#4988) --disable-overlays breaks overlays/Makefile
by h.b.furuseth＠usit.uio.no 29 May '07

29 May '07

Full_Name: Hallvard B Furuseth Version: RE23 OS: HPUX URL: Submission from: (NULL) (129.240.202.105) Submitted by: hallvard 'make' on HP-UX does not like '\' - newline - blank line, produced by OBJS = overlays.o \ statover.o \ @SLAPD_STATIC_OVERLAYS@ in overlays/Makefile.in with --disable-overlays. Fixed in HEAD overlays/Makefile.in rev 1.46, importing to RE23 now.

1 0

Re: (ITS#4943) tpool.c pause vs. finish
by h.b.furuseth＠usit.uio.no 29 May '07

29 May '07

Some more comments, review, planned changes, and questions. I guess I should summarize the bugs I've fixed in HEAD first, for completeness. (I was a bit too busy at the time.) Restating the CVS log comments, nothing new but maybe a bit clearer. Possibly some of the issues are tpool-only issues and can't happen the way slapd uses tpool. ---------------------------------------- rev 1.63: ldap_pvt_thread_pool_submit(), after failed thread creation: - ltp_pending_count++ should be --. - should signal if there are no more threads, in case pool_destroy() is waiting for that. (Not sure if that can happen.) ldap_int_thread_pool_wrapper(): - The 'if(ltp_state...)' was spurious: It would always be true, and if it were not we'd get an eternal loop. rev 1.64: pool_pause(): - would cancel states FINISHING and STOPPING, pool_resume() would set it back to RUNNING. - could hang when waiting for another pool_pause(), since it did not signal ltp_pcond if it decremented ltp_active_count to 1. pool_wrapper(): - could update thread_keys[] during a pause while initializing and possibly while finishing, - just after initializing, could handle a new ctx during a pause. pool_destroy(): - would go on with destruction if pool_resume() was called, since it used an if(){wait} instead of while() and they use the same cond. rev 1.65: - pool_context() read thread_keys[] without mutex protection. pool_purgekey() too, but it expected a pause to protect the keys. pool_wrapper() protected with ltp_mutex while writing, and did not quite ensure a pause. rev 1.66: - thread_keys[] is a (poor) open-addessed hash table, but it lacked a "deleted item" mark. So keys (contexts) could become hidden and re-emerge later if threads exited and then new ones were started. - TID_HASH() did hash calculation in signed arithmetic, thus depending on friendly integer overflow. rev 1.67: - setkey/getkey expected ldap_int_thread_userctx_t.ltu_key[] to be NULL-terminated when not full. purgekey() could set a NULL in the middle, hiding later keys until a new key overwrote the NULL. API changes: - setkey(data=NULL, kfree!=NULL) searched as if intended to reset the key, but updated by setting the key. Now always updates. - setkey(key=<not found>, data=NULL) could return either success or failure. Now succeeds iff (data == NULL && kfree == NULL). rev 1.68: - ltp_max_count <= 0 meant allow an unlimited number of threads, but thread #LDAP_MAXTHR+1 and later would loop forever looking for a free thread_keys[] slot. (Not fixed for multi-pool applications.) ---------------------------------------- I wrote in the tpool.c 1.66 -> 1.67 patch: > API changes, need review - I'm not sure what's indented here: > - setkey(data=NULL, kfree!=NULL) searched as if intended to reset > the key, but updated by setting the key. Now always updates. Right. That matches the one place it can happen: In bdb_locker_id() with setkey(,,data=(void *)(long)lockid,). I don't know if lockid can be 0, but it doesn't need to for data to be NULL. But it would cleaner to ch_malloc an integer instead of the (void*) cast. Then it won't depend on integer->pointer->integer conversions preserving the value either. BTW, is there a reason for the cast to long? lockid is u_int32_t, and the getkey 'long' result is restored to a u_int32_t. Howard Chu wrote: >> Also if ctx is invalid (another thread handled it) and a new >> pending request has gotten the now-unused ctx, then the >> 'if (pool->ltp_open_count == 0)' code will free that new >> pending request instead of the old one. > > Most likely this is due to unlocking and relocking the mutex around > the semaphore code. Axe that, remove the gratuitous unlock/relock, > and then that problem goes away. Was that an instruction/permission to axe it or not? If not I'll just move the unlock/lock into the #ifdef for now. > Thus far we've only had to worry about a single pool. If anyone can > come up with a reason to need multiple pools, I guess we need to > hear it. I'll insert "static int initialized; assert(!initialized++);" in pool_init() and see if anyone complains. >> - setkey does not free the old data with ltk_free. Possibly that's >> intentional, but if so that requires weird code elsewhere. > > Yes, that's intentional. ltk_free is only intended for cleanup if a key > is still set by the time a thread exits. All of the keys we set are live > for the entire life of a thread, they don't get re-assigned. Even the (void*)slap_sasl_bind key? lutil_passwd() looks like it can be recursive: Register a password scheme which finds an entry in LDAP and authenticates via that entry's userPassword - which again could call lutil_passwd(). If that's legal, this code in be_isroot_pw()/slap_passwd_check() can break: pool_setkey(, slap_sasl_bind, <ctx>, <freefunc> ); ... /* slap_passwd_check() does access_allowed() here */ lutil_passwd(); ... pool_setkey(, slap_sasl_bind, NULL, NULL); The final setkey would need to restore the old key. I'm not sure of contrib/slapd-modules/smbk5pwd/smbk5pwd.c + some overlay either. rwm + back-relay which uses another smbk5pwd or something. (And I have no idea of the BDB cache stuff, but since you wrote it I assume you know:-) If it's a problem, we can replace code like that with void *data = <ctx>; ldap_pvt_thread_pool_keyfree_t *kfree = <freefunc>; pool_swapkey(, slap_sasl_bind, &data, &kfree ); /* new function */ lutil_passwd(); pool_setkey(, slap_sasl_bind, data, kfree ); or if setkey reverts to ignoring kfree when it checks whether we are setting or deleting a key, the kfree function can be passed directly. I wrote: > But this reminds me: How much should an ltk_free() function be allowed > to do? > - pool_context_reset() calls ltk_free(). Should pool_wrapper() go > active (wait for !pause, increment ltp_active_count, unlock ltp_mutex) > before calling pool_context_reset()? I think so. It makes slapi safer, and I don't see that it can hurt: context_reset() can call connection_fake_destroy(), which via slapi_int_free_object_extensions() calls slapi module destructors, which can do who-knows-what. Another stray thought: It would similarly be safer for context_reset() and purgekey() to delete the key before calling ltk_free, so that function can't access the key's data after freeing it. OTOH that would break any slapi module whose ltk_free calls a function which uses the key before freeing it. I'll leave it alone unless someone says otherwise. Other matters: pool->ltp_active_list is maintained but not used for anything. Do I delete it? Or does tpool maintain the list to ease debugging? Use of tpool: Another bug: Slapd does not always check if pool_submit() and pool_setkey() succeed, even though failure is not a bug. (They can run into some limits.) I do not understand the calls to ldap_pvt_thread_pool_context_reset() in slapd (init.c and bconfig.c). That frees the thread's sl_malloc memory with slap_sl_mem_destroy(), which seems rather hazardous until the thread is really, really done. For that matter, I guess that means context_reset() had better release keys in the reverse order of how they were set. That usually happened, but not always, and my clear_key_idx() made the "not always" more common. So to close the gap from a deleted key I'll make it move all later keys forward, instead of just moving the latest key to the gap. Bdb uses the database environment address as a key to pool_setkey(). So there can be at most ~30 BDB databases with an active key at the same time in the same thread. What does that mean - 30 overlays all using bdb? Access control groups spanning 30 databases? Nitpick: Slapd uses both function pointers and data pointers as keys to pool_[sg]etkey(). That makes it possible for two "different" keys to compare equal, on a host where functions and data live in different segments that otherwise share the same address space. So I guess I should clean up and replace (void*)<function> keys with the address of static char <function>_key; -- Regards, Hallvard

1 0

Re: (ITS#4951) [contrib] RADIUS password module fixes
by richton＠nbcs.rutgers.edu 29 May '07

29 May '07

Boy, that was some real quality time with dbx...ugh. I'm fairly confident that the issue is that portable.h isn't included and should have been as part of my patch. This worked in a development environment; I'll be putting it through some more tests and, most likely, in production soon (the =NULL workaround is just a time bomb). On Thu, 24 May 2007, Aaron Richton wrote: > On Tue, 22 May 2007, Pierangelo Masarati wrote: >> If that's an issue, I have no problem in explicitly setting that pointer >> to NULL. > > I got some more dbx time on this, and it looks like that's a workaround for > something that shouldn't be happening/needs to be fixed anyway. > config_filename is always NULL at dlopen() time, just as it should be. > > Calling lock(&libradius_mutex) apparently overwrites config_filename, and > explicitly initializing to NULL somehow stops this from happening. I can't > see anything wrong with radius.c (as in HEAD), though; if anybody can weigh > in on this, it'd be much appreciated. I suppose it could still be a compiler > or a libthread bug, but I'm still missing a smoking gun here. > >

1 0

Re: (ITS#4985) pthread.h: present but cannot be compiled
by maugustine＠phsyes.com 29 May '07

29 May '07

This is a multi-part message in MIME format. ------=_NextPart_000_0004_01C7A1C1.FB9C6800 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit For those of you that may have this same issue, I discovered that the problem was with gcc version 4.0.0 that loads with AIX 5.3. After I upgraded to 4.1.1, this problem went away. ------=_NextPart_000_0004_01C7A1C1.FB9C6800 Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable <html xmlns:o=3D"urn:schemas-microsoft-com:office:office" = xmlns:w=3D"urn:schemas-microsoft-com:office:word" = xmlns=3D"http://www.w3.org/TR/REC-html40"> <head> <META HTTP-EQUIV=3D"Content-Type" CONTENT=3D"text/html; = charset=3Dus-ascii"> <meta name=3DGenerator content=3D"Microsoft Word 11 (filtered medium)"> <style>  </style> </head> <body lang=3DEN-US link=3Dblue vlink=3Dpurple> <div class=3DSection1> <p class=3DMsoNormal><font size=3D2 face=3DArial><span = style=3D'font-size:10.0pt; font-family:Arial'>For those of you that may have this same issue, I = discovered that the problem was with gcc version 4.0.0 that loads with AIX = 5.3.  After I upgraded to 4.1.1, this problem went away.<o:p></o:p></span></font></p> </div> </body> </html> ------=_NextPart_000_0004_01C7A1C1.FB9C6800--

1 0

(ITS#4987) imporvement to slapo-constraint
by manu＠netbsd.org 29 May '07

29 May '07

Full_Name: Emmanuel Dreyfus Version: 4.4.4 OS: NetBSD URL: ftp://ftp.openldap.org/incoming/manu-070529.ext Submission from: (NULL) (213.41.141.172) I modified slapo-constraint so that it can verify that an attribute value is bound to the existing values of another attribute. The purpose is to make referential integrity easier to obtain. Attached is a draft patch for review. Then there is the UI question. For now it's configured in slapd.conf like this: database bdb suffix "dc=example,dc=net" overlay constraint constraint_attribute title key netExampleTitle Which means that add and modify on title will fail if the new value is not an existing netExampleTitle value. I used the keyword "key" with RDBMS referential integrity in mind, but I'm not sure it's that clear in this context. Suggestions are welcome. The update to man page is missing yet. I know. Also, I had trouble understanding the style used in these sources. Is there an official style guide for OpenLDAP?

1 0

(ITS#4986) manageDSAit might control cause problems in database selection
by nvoutsin＠noc.uoa.gr 28 May '07

28 May '07

Full_Name: Nikos Voutsinas Version: 2.3.35 OS: Solaris 9 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (195.134.100.207) With the following configuration, search operations in the local database ("dc=foo,dc=bar") will fail when manageDSAit control is set. .... .... backend bdb database bdb suffix "dc=foo,dc=bar" rootdn "uid=manager,dc=foo,dc=bar" rootpw "secret" directory /var/openldap/bdb access to * by * read database relay suffix "" relay "dc=foo,dc=bar" massage access to * by * read .... .... The problem has been tracked down in select_backend().

1 0

(ITS#4985) pthread.h: present but cannot be compiled
by maugustine＠phsyes.com 26 May '07

26 May '07

Full_Name: Matt Augustine Version: 2.3.32 OS: AIX 5.3 URL: Submission from: (NULL) (208.8.86.2) Dear help, I have currently installed openssl-0.9.8e and am looking to install openldap-2.3.32 on AIX 5.3. However, when I go to run the configure script it ends with the following warning: pthread.h: present but cannot be compiled / check for missing prerequisite headers? / see the Autoconf documentation secion "Present But cannot Be Compiled" proceeing with the preprocessor's result / in the future, the compiler will take precedence / Report this to <http://www.openldap.org/its/> I then went to check the config.log and tied it to the following errors: /usr/include/pthread.h:666: error: parse error before '*' token /usr/include/pthread.h:669: error: parse error before '*' token /usr/include/pthread.h:672: error: parse error before '*' token /usr/include/pthread.h:675: error: parse error before '*' token /usr/include/pthread.h:678: error: parse error before '*' token /usr/include/pthread.h:686: error: parse error before '*' token /usr/include/pthread.h:689: error: parse error before '*' token /usr/include/pthread.h:692: error: parse error before '*' token /usr/include/pthread.h:695: error: parse error before '*' token /usr/include/pthread.h:703: error: parse error before '*' token /usr/include/pthread.h:707: error: parse error before '*' token /usr/include/pthread.h:710: error: parse error before '*' token Those lines in pthread.h correspond to the following: 666: pthread_spin_init __((pthread_spinlock_t *, int)); 669: pthread_spin_destroy __((pthread_spinlock_t *)); 672: pthread_spin_lock __((pthread_spinlock_t *)); 675: pthread_spin_unlock __((pthread_spinlock_t *)); 678: pthread_spin_trylock __((pthread_spinlock_t *)); 686: pthread_barrierattr_init __((pthread_barrierattr_t *)); 689: pthread_barrierattr_destroy __((pthread_barrierattr_t *)); 692: pthread_barrierattr_getpshared __((const pthread_barrierattr_t *__restrict__, int *__restrict__)); 695: pthread_barrierattr_setpshared __((pthread_barrierattr_t *, int)); 703: pthread_barrier_init __((pthread_barrier_t *__restrict__, const pthread_barrierattr_t *__restrict__, unsigned)); 707: pthread_barrier_destroy __((pthread_barrier_t *)); 710: pthread_barrier_wait __((pthread_barrier_t *)); Unfortunately, I'm fairly new to AIX, and building things from source, so these lines really don't mean much to me. Any help that you can provide would be greatly appreciated. Thanks!

1 0

Re: (ITS#4966) OpenLDAP 2.3.35 crashes on valsort overlay
by hyc＠symas.com 25 May '07

25 May '07

eagle(a)windlord.stanford.edu wrote: > We've reproduced the crash and I have it in a crashed state in gdb right > now. Should be fixed now in valsort.c in HEAD. > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 1107294576 (LWP 32735)] > valsort_modify (op=0x2aabaeae0058, rs=0x41ffef10) at valsort.c:455 > 455 for (i=0; !BER_BVISNULL( &ml->sml_values[i] ); i++) { > (gdb) bt > #0 valsort_modify (op=0x2aabaeae0058, rs=0x41ffef10) at valsort.c:455 > #1 0x0000000000478a2a in overlay_op_walk (op=0x2aabaeae0058, rs=0x41ffef10, > which=op_modify, oi=0x2b240a786518, on=0x2b240a786cd8) at backover.c:498 > #2 0x0000000000478e65 in over_op_func (op=0x2aabaeae0058, rs=0x41ffef10, > which=op_modify) at backover.c:560 > #3 0x000000000043c962 in fe_op_modify (op=0x2aabaeae0058, rs=0x41ffef10) > at modify.c:395 > #4 0x000000000043d45a in do_modify (op=0x2aabaeae0058, rs=0x41ffef10) > at modify.c:200 > #5 0x0000000000427af9 in connection_operation (ctx=Variable "ctx" is not available. > ) at connection.c:1133 > #6 0x0000000000427fa4 in connection_read_thread (ctx=0x41fff060, argv=Variable "argv" is not available. > ) > at connection.c:1261 > #7 0x00002b2408673894 in ldap_int_thread_pool_wrapper (xpool=0x2b2409d10058) > at tpool.c:478 > #8 0x00002b24083ad9af in startMeUp () from /usr/local/lib/libhoard.so > #9 0x00002b24090bfb55 in start_thread () from /lib/libpthread.so.0 > #10 0x00002b24092a07f0 in clone () from /lib/libc.so.6 > [...] > (gdb) frame 0 > #0 valsort_modify (op=0x2aabaeae0058, rs=0x41ffef10) at valsort.c:455 > 455 for (i=0; !BER_BVISNULL( &ml->sml_values[i] ); i++) { > (gdb) list > 450 if ( ml->sml_desc == vi->vi_ad ) > 451 break; > 452 } > 453 if ( !ml ) > 454 continue; > 455 for (i=0; !BER_BVISNULL( &ml->sml_values[i] ); i++) { > 456 ptr = ber_bvchr(&ml->sml_values[i], '{' ); > 457 if ( !ptr ) { > 458 Debug(LDAP_DEBUG_TRACE, "weight missing from attribute %s\n", > 459 vi->vi_ad->ad_cname.bv_val, 0, 0); > (gdb) print *ml > $2 = {sml_mod = {sm_op = 1, sm_flags = 0, sm_desc = 0x2b2409a344d0, sm_type = { > bv_len = 20, bv_val = 0x2aabaea1f8e9 "suorgcontactstanford"}, > sm_values = 0x0, sm_nvalues = 0x0}, sml_next = 0x2aabaeaf4770} > (gdb) print i > No symbol "i" in current context. > (gdb) print ml->sml_mod.sm_values > $3 = 0x0 > > I'll leave it running in gdb so that I can find additional information for > you as needed. > > > -- -- Howard Chu Chief Architect, Symas Corp. Director, Highland Sun http://www.symas.com http://highlandsun.com/hyc Symas: Premier OpenSource Development and Support

1 0

Re: (ITS#4966) OpenLDAP 2.3.35 crashes on valsort overlay
by eagle＠windlord.stanford.edu 24 May '07

24 May '07

Here are the logs of the connection that led to the crash. We think that it may be attempting a delete after the last logged MOD, but so far we haven't been able to get any more detailed information from the authors of the application making the change. May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=0 BIND dn="" method=163 May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=0 RESULT tag=97 err=14 text= May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=1 BIND dn="" method=163 May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=1 RESULT tag=97 err=14 text= May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=2 BIND dn="" method=163 May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=2 BIND authcid="service/slog-org(a)stanford.edu" authzid="service/slog-org(a)stanford.edu" May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=2 BIND dn="cn=slog-org,cn=service,cn=applications,dc=stanford,dc=edu" mech=GSSAPI ssf=56 May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=2 RESULT tag=97 err=0 text= May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=3 SRCH base="" scope=0 deref=3 filter="(objectClass=*)" May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=3 SRCH attr=subschemasubentry May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=3 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=4 SRCH base="cn=Subschema" scope=0 deref=3 filter="(objectClass=subschema)" May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=4 SRCH attr=objectClasses attributeTypes matchingRules ldapSyntaxes objectClass javaSerializedData javaClassName javaFactory javaCodeBase javaReferenceAddress javaClassNames javaRemoteLocation May 24 14:34:01 ldap-test0 slapd[32729]: conn=13 op=4 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:02 ldap-test0 slapd[32729]: conn=12 op=5 ABANDON msg=5 May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=5 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=0 deref=3 filter="(objectClass=*)" May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=5 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=6 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=1 deref=3 filter="(suRegID=dab33c07fe4f5bee9901a10446424016)" May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=6 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=7 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=0 deref=3 filter="(objectClass=*)" May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=7 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=8 MOD dn="suRegID=dab33c07fe4f5bee9901a10446424016,cn=organizations,dc=stanford,dc=edu" May 24 14:34:08 ldap-test0 slapd[32729]: conn=13 op=8 MOD attr=sugeneralid suseealsoorgregid suorgcontactstanford May 24 14:34:09 ldap-test0 slapd[32729]: conn=13 op=8 RESULT tag=103 err=0 text= May 24 14:34:11 ldap-test0 slapd[32729]: conn=13 op=9 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=0 deref=3 filter="(objectClass=*)" May 24 14:34:11 ldap-test0 slapd[32729]: conn=13 op=9 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:11 ldap-test0 slapd[32729]: conn=13 op=10 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=1 deref=3 filter="(suRegID=dab33c07fe4f5bee9901a10446424016)" May 24 14:34:11 ldap-test0 slapd[32729]: conn=13 op=10 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=11 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=0 deref=3 filter="(objectClass=*)" May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=11 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=12 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=1 deref=3 filter="(suRegID=41559190986611d3acf6ab400b0baa77)" May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=12 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=13 SRCH base="cn=organizations,dc=stanford,dc=edu" scope=0 deref=3 filter="(objectClass=*)" May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=13 SEARCH RESULT tag=101 err=0 nentries=1 text= May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=14 MOD dn="suRegID=41559190986611d3acf6ab400b0baa77,cn=organizations,dc=stanford,dc=edu" May 24 14:34:12 ldap-test0 slapd[32729]: conn=13 op=14 MOD attr=suorgcontactlabelstanford eduorghomepageuri telephonenumber sugworgaddress facsimiletelephonenumber street postaladdress suorgcontactstanford suprintsection labeleduri sugeneralid and then crash.

1 0

Re: (ITS#4966) OpenLDAP 2.3.35 crashes on valsort overlay
by eagle＠windlord.stanford.edu 24 May '07

24 May '07

We've reproduced the crash and I have it in a crashed state in gdb right now. Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 1107294576 (LWP 32735)] valsort_modify (op=0x2aabaeae0058, rs=0x41ffef10) at valsort.c:455 455 for (i=0; !BER_BVISNULL( &ml->sml_values[i] ); i++) { (gdb) bt #0 valsort_modify (op=0x2aabaeae0058, rs=0x41ffef10) at valsort.c:455 #1 0x0000000000478a2a in overlay_op_walk (op=0x2aabaeae0058, rs=0x41ffef10, which=op_modify, oi=0x2b240a786518, on=0x2b240a786cd8) at backover.c:498 #2 0x0000000000478e65 in over_op_func (op=0x2aabaeae0058, rs=0x41ffef10, which=op_modify) at backover.c:560 #3 0x000000000043c962 in fe_op_modify (op=0x2aabaeae0058, rs=0x41ffef10) at modify.c:395 #4 0x000000000043d45a in do_modify (op=0x2aabaeae0058, rs=0x41ffef10) at modify.c:200 #5 0x0000000000427af9 in connection_operation (ctx=Variable "ctx" is not available. ) at connection.c:1133 #6 0x0000000000427fa4 in connection_read_thread (ctx=0x41fff060, argv=Variable "argv" is not available. ) at connection.c:1261 #7 0x00002b2408673894 in ldap_int_thread_pool_wrapper (xpool=0x2b2409d10058) at tpool.c:478 #8 0x00002b24083ad9af in startMeUp () from /usr/local/lib/libhoard.so #9 0x00002b24090bfb55 in start_thread () from /lib/libpthread.so.0 #10 0x00002b24092a07f0 in clone () from /lib/libc.so.6 [...] (gdb) frame 0 #0 valsort_modify (op=0x2aabaeae0058, rs=0x41ffef10) at valsort.c:455 455 for (i=0; !BER_BVISNULL( &ml->sml_values[i] ); i++) { (gdb) list 450 if ( ml->sml_desc == vi->vi_ad ) 451 break; 452 } 453 if ( !ml ) 454 continue; 455 for (i=0; !BER_BVISNULL( &ml->sml_values[i] ); i++) { 456 ptr = ber_bvchr(&ml->sml_values[i], '{' ); 457 if ( !ptr ) { 458 Debug(LDAP_DEBUG_TRACE, "weight missing from attribute %s\n", 459 vi->vi_ad->ad_cname.bv_val, 0, 0); (gdb) print *ml $2 = {sml_mod = {sm_op = 1, sm_flags = 0, sm_desc = 0x2b2409a344d0, sm_type = { bv_len = 20, bv_val = 0x2aabaea1f8e9 "suorgcontactstanford"}, sm_values = 0x0, sm_nvalues = 0x0}, sml_next = 0x2aabaeaf4770} (gdb) print i No symbol "i" in current context. (gdb) print ml->sml_mod.sm_values $3 = 0x0 I'll leave it running in gdb so that I can find additional information for you as needed.

1 0

Re: (ITS#4959) replica seg faults if syncrepl searchbase =""
by h.b.furuseth＠usit.uio.no 24 May '07

24 May '07

ali.pouya(a)free.fr writes: > tls.c:2908: error: syntax error before '*' token > tls.c: In function `find_oid': > (...) That's from ITS#4975: The code was broken for builds without TLS. It's been fixed in HEAD. Does it work now? -- Regards, Hallvard

1 0

Re: AW: Documentation error in "ppolicy.schema" (ITS#4984)
by hyc＠symas.com 24 May '07

24 May '07

The text in this schema file comes directly from the IETF draft. It should not be changed unless the draft itself has changed. This ITS should be closed. arnim.rupp(a)lhsystems.com wrote: > hi Gavin, > > i think the sentence is ok, just in the wrong place. just move this sentence: > > # This attribute is not set > # due to any actions specified by this document, it is typically set by > # a password administrator after resetting a user's password. > > from "5.2.13 pwdMustChange" to "5.3.7 pwdReset". > > regards > arnim rupp > > --- > Arnim Rupp > > Lufthansa Systems Infratec GmbH > Middleware Competence Center > FRA AI/A-AM > > Am Weiher 24 > 65451 Kelsterbach > Germany > > Raum/Room: 4.U1.07 LIC A > > Tel: +49-69-696-94944 > Fax: +49-69-696-93932 > > Email: arnim.rupp(a)lhsystems.com > Internet: www.lhsystems.com > > Sitz der Gesellschaft/Corporate Headquarters: > Lufthansa Systems Infratec GmbH, Kelsterbach > > Registereintragung/Registration: > Amtsgericht Darmstadt HRB 83851 > > Vorsitzender des Aufsichtsrates/ > Chairman of the Supervisory Board: > Dr. Gunter Küchler > > Geschäftsführung/Management: > Dr. Hannes Pfister > > > > >> -----Ursprüngliche Nachricht----- >> Von: Gavin Henry [mailto:openldap-its@OpenLDAP.org] >> Gesendet: Donnerstag, 24. Mai 2007 16:01 >> An: RUPP, ARNIM >> Cc: openldap-its(a)OpenLDAP.org >> Betreff: Re: Documentation error in "ppolicy.schema" (ITS#4984) >> >> Hi, >> >> Thank for your documentation report. >> >> How would you like it to be worded? >> >> Can you provide an example sentance? >> >> Thanks, >> >> Gavin. >> > > > -- -- Howard Chu Chief Architect, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

AW: Documentation error in "ppolicy.schema" (ITS#4984)
by arnim.rupp＠lhsystems.com 24 May '07

24 May '07

hi Gavin, i think the sentence is ok, just in the wrong place. just move this sentence: # This attribute is not set # due to any actions specified by this document, it is typically set by # a password administrator after resetting a user's password. from "5.2.13 pwdMustChange" to "5.3.7 pwdReset". regards arnim rupp --- Arnim Rupp Lufthansa Systems Infratec GmbH Middleware Competence Center FRA AI/A-AM Am Weiher 24 65451 Kelsterbach Germany Raum/Room: 4.U1.07 LIC A Tel: +49-69-696-94944 Fax: +49-69-696-93932 Email: arnim.rupp(a)lhsystems.com Internet: www.lhsystems.com Sitz der Gesellschaft/Corporate Headquarters: Lufthansa Systems Infratec GmbH, Kelsterbach Registereintragung/Registration: Amtsgericht Darmstadt HRB 83851 Vorsitzender des Aufsichtsrates/ Chairman of the Supervisory Board: Dr. Gunter Küchler Geschäftsführung/Management: Dr. Hannes Pfister > -----Ursprüngliche Nachricht----- > Von: Gavin Henry [mailto:openldap-its@OpenLDAP.org] > Gesendet: Donnerstag, 24. Mai 2007 16:01 > An: RUPP, ARNIM > Cc: openldap-its(a)OpenLDAP.org > Betreff: Re: Documentation error in "ppolicy.schema" (ITS#4984) > > Hi, > > Thank for your documentation report. > > How would you like it to be worded? > > Can you provide an example sentance? > > Thanks, > > Gavin. >

1 0

(ITS#4984) Documentation error in "ppolicy.schema"
by arnim.rupp＠lhsystems.com 24 May '07

24 May '07

Full_Name: arnim rupp Version: 2.3.35 OS: linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (87.106.39.109) hello, there's some wrong documentation in ./servers/slapd/schema/ppolicy.schema in the "chapter" #5.2.13 pwdMustChange is the sentence: # This attribute is not set # due to any actions specified by this document, it is typically set by # a password administrator after resetting a user's password. this doesn't make any sense there since no admin would change a server-wide setting after reseting a users password. instead it is missing in the chapter "#5.3.7 pwdReset". without this sentence it sounds like openldap automatically sets pwdReset (like good old netscape LDAP does). regards arnim

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs