openldap-bugs

openldap-bugs@openldap.org

1 participants
20959 discussions

Re: (ITS#6041) opendir() and closedir() bugs on Windows
by hyc＠symas.com 30 Mar '09

30 Mar '09

test.007(a)seznam.cz wrote: > Full_Name: Test Seven > Version: 2.4.15 > OS: Windows > URL: > Submission from: (NULL) (195.113.184.20) Thanks for the patch. The Windows code is known to work fine using gcc. Use of MSVC is discouraged since there have been so many incompatible CRT version changes in such a short span of time. (Actually, use of Microsoft-anything is generally discouraged; the same OpenLDAP code is at least 2-3x faster on the same hardware when using Linux instead of Windows.) > Two problems solved in the patch: > 1. closedir()'s retval is used, thus it must not be void. Windows uses implicit > declaration ``int closedir(int)'' because the function is not declared in > headers, thus the call in ldif.c compiles, but uses random value in EAX. > > 2. opendir() must set errno, because ldif_readdir() reads it. The patch converts > the most common Windows error codes to errno codes after FindFirstFile() WinAPI > call. > > The bugs prevent me from loading cn=config configuration. > > --- utils.c.orig 2009-01-22 01:00:58.000000000 +0100 > +++ utils.c 2009-03-27 14:28:33.500000000 +0100 > @@ -466,6 +466,40 @@ int mkstemp( char * template ) > #endif > > #ifdef _MSC_VER > +/* Equivalent of MS CRT's _dosmaperr(). > + * @param lastError[in] Result of GetLastError(). > + */ > +static errno_t win2errno(DWORD lastError) > +{ > + const struct { > + DWORD windows_code; > + errno_t errno_code; > + } WIN2ERRNO_TABLE[] = { > + { ERROR_SUCCESS, 0 }, > + { ERROR_FILE_NOT_FOUND, ENOENT }, > + { ERROR_PATH_NOT_FOUND, ENOENT }, > + { ERROR_TOO_MANY_OPEN_FILES, EMFILE }, > + { ERROR_ACCESS_DENIED, EACCES }, > + { ERROR_INVALID_HANDLE, EBADF }, > + { ERROR_NOT_ENOUGH_MEMORY, ENOMEM }, > + { ERROR_NOT_ENOUGH_MEMORY, ENOMEM }, > + { ERROR_LOCK_VIOLATION, EACCES }, > + { ERROR_FILE_EXISTS, EEXIST }, > + { ERROR_INVALID_PARAMETER, EINVAL }, > + { ERROR_FILENAME_EXCED_RANGE, ENAMETOOLONG }, > + }; > + const unsigned int WIN2ERRNO_TABLE_SIZE = sizeof(WIN2ERRNO_TABLE) / > sizeof(WIN2ERRNO_TABLE[0]); > + const errno_t DEFAULT_ERRNO_ERROR = -1; > + unsigned int i; > + > + for (i = 0; i< WIN2ERRNO_TABLE_SIZE; ++i) { > + if (WIN2ERRNO_TABLE[i].windows_code == lastError) { > + return WIN2ERRNO_TABLE[i].errno_code; > + } > + } > + return DEFAULT_ERRNO_ERROR; > +} > + > struct dirent { > char *d_name; > }; > @@ -493,9 +527,10 @@ DIR *opendir( char *path ) > > h = FindFirstFile( tmp,&data ); > > - if ( h == INVALID_HANDLE_VALUE ) > + if ( h == INVALID_HANDLE_VALUE ) { > + errno = win2errno(GetLastError()); > return NULL; > - > + } > d = ber_memalloc( sizeof(DIR) ); > if ( !d ) > return NULL; > @@ -518,10 +553,11 @@ struct dirent *readdir(DIR *dir) > } > return&dir->data; > } > -void closedir(DIR *dir) > +int closedir(DIR *dir) > { > FindClose(dir->dir); > ber_memfree(dir); > + return 0; > } > #endif > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#6038) Write slapadd progress meter to stdout
by michael＠stroeder.com 27 Mar '09

27 Mar '09

rein(a)OpenLDAP.org wrote: > For programs that produce real output (slapcat, ldapsearch) this might > be true, but for those that don't (slapadd, slapd) I totally disagree. > Stderr is for errors, not chatty progress or debug messages. I always > hate it when the error messages gets burried in lots of noice. > > My preference is to have progress and debug messages on stdout, enabled > by options or at least possible to disable by options. Real output must > be possible to send to a file specified as argument, to separate it from > the progress and debug noice. Stderr is for error messages, and > possibly out-of-band messages. +1 Ciao, Michael.

1 0

(ITS#6041) opendir() and closedir() bugs on Windows
by test.007＠seznam.cz 27 Mar '09

27 Mar '09

Full_Name: Test Seven Version: 2.4.15 OS: Windows URL: Submission from: (NULL) (195.113.184.20) Two problems solved in the patch: 1. closedir()'s retval is used, thus it must not be void. Windows uses implicit declaration ``int closedir(int)'' because the function is not declared in headers, thus the call in ldif.c compiles, but uses random value in EAX. 2. opendir() must set errno, because ldif_readdir() reads it. The patch converts the most common Windows error codes to errno codes after FindFirstFile() WinAPI call. The bugs prevent me from loading cn=config configuration. --- utils.c.orig 2009-01-22 01:00:58.000000000 +0100 +++ utils.c 2009-03-27 14:28:33.500000000 +0100 @@ -466,6 +466,40 @@ int mkstemp( char * template ) #endif #ifdef _MSC_VER +/* Equivalent of MS CRT's _dosmaperr(). + * @param lastError[in] Result of GetLastError(). + */ +static errno_t win2errno(DWORD lastError) +{ + const struct { + DWORD windows_code; + errno_t errno_code; + } WIN2ERRNO_TABLE[] = { + { ERROR_SUCCESS, 0 }, + { ERROR_FILE_NOT_FOUND, ENOENT }, + { ERROR_PATH_NOT_FOUND, ENOENT }, + { ERROR_TOO_MANY_OPEN_FILES, EMFILE }, + { ERROR_ACCESS_DENIED, EACCES }, + { ERROR_INVALID_HANDLE, EBADF }, + { ERROR_NOT_ENOUGH_MEMORY, ENOMEM }, + { ERROR_NOT_ENOUGH_MEMORY, ENOMEM }, + { ERROR_LOCK_VIOLATION, EACCES }, + { ERROR_FILE_EXISTS, EEXIST }, + { ERROR_INVALID_PARAMETER, EINVAL }, + { ERROR_FILENAME_EXCED_RANGE, ENAMETOOLONG }, + }; + const unsigned int WIN2ERRNO_TABLE_SIZE = sizeof(WIN2ERRNO_TABLE) / sizeof(WIN2ERRNO_TABLE[0]); + const errno_t DEFAULT_ERRNO_ERROR = -1; + unsigned int i; + + for (i = 0; i < WIN2ERRNO_TABLE_SIZE; ++i) { + if (WIN2ERRNO_TABLE[i].windows_code == lastError) { + return WIN2ERRNO_TABLE[i].errno_code; + } + } + return DEFAULT_ERRNO_ERROR; +} + struct dirent { char *d_name; }; @@ -493,9 +527,10 @@ DIR *opendir( char *path ) h = FindFirstFile( tmp, &data ); - if ( h == INVALID_HANDLE_VALUE ) + if ( h == INVALID_HANDLE_VALUE ) { + errno = win2errno(GetLastError()); return NULL; - + } d = ber_memalloc( sizeof(DIR) ); if ( !d ) return NULL; @@ -518,10 +553,11 @@ struct dirent *readdir(DIR *dir) } return &dir->data; } -void closedir(DIR *dir) +int closedir(DIR *dir) { FindClose(dir->dir); ber_memfree(dir); + return 0; } #endif

1 0

Re: (ITS#6033) Segmentation fault - somewhere below syncprov_matchops / test_filter
by Howard Chu 27 Mar '09

27 Mar '09

Please test with RE24 instead of 2.4.15 and followup with your results.

1 0

Re: (ITS#6040) SEGV - hdb_cache_lru_purge / bdb_cache_delete_internal / ldap_pvt_thread_mutex_lock
by Howard Chu 27 Mar '09

27 Mar '09

Please use RE24 instead of 2.4.15 and followup with your results.

1 0

Re: (ITS#6038) Write slapadd progress meter to stdout
by hyc＠symas.com 27 Mar '09

27 Mar '09

Rein Tollevik wrote: > hyc(a)symas.com wrote: >> Hallvard B Furuseth wrote: >>> hyc(a)symas.com writes: >>>> Just redirect stdin, and the meter will automatically turn itself off. >>> It was stderr, not stdin - which after all can be the ldif. >>> Stdout is better. >>> >> No, you misunderstand. >> >> Redirecting stderr (or stdout) merely sends the progress info to that >> destination. Piping input on stdin will turn it off, so there's no progress >> info to redirect. > > No, the code only enables the meter if stdout (was: stderr) is a tty, so > redirecting it anywhere disables it. The meter was enabled both by > "slapadd -l file" and "slapadd< file", but "cat file | slapadd" did > disable it. IMHO not exactly an obvious way.. > > An option sounds more and more like the solution, what about "-m" for > meter? Though I'm not sure whether I prefer that it should be enabled > by default and the option disable it, or the other way around.. We already decided it should be enabled by default. Setting any explicit debug flag already disables it. >> Writing progress to stderr is the correct thing to do, because it's transient >> info that isn't meant to be saved. Checking whether stdout is redirected or >> not is fine, but writing progress info to stdout is not. > > For programs that produce real output (slapcat, ldapsearch) this might > be true, but for those that don't (slapadd, slapd) I totally disagree. > Stderr is for errors, not chatty progress or debug messages. I always > hate it when the error messages gets burried in lots of noice. Stderr is for any diagnostic info. Progress reports are diagnostic, they are certainly not the main purpose of any of these programs. Stdout is for anything related to the primary purpose of these programs. For slapcat, that's obvious. For slapadd/slapindex, these programs' purpose is not to produce any textual output at all; stdout is unused. That doesn't mean it's correct to ignore these long-standard Unix I/O usage conventions and suddenly switch stderr output to stdout. And as already noted, if you're looking for debug messages, then the meter will be disabled. > My preference is to have progress and debug messages on stdout, enabled > by options or at least possible to disable by options. Quite simply, this is completely wrong. It also introduces an unnecessary inconsistency between slapcat and slapadd behavior. Progress belongs on stderr, period. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#6040) SEGV - hdb_cache_lru_purge / bdb_cache_delete_internal / ldap_pvt_thread_mutex_lock
by oskar＠deckle.co.za 27 Mar '09

27 Mar '09

Full_Name: Oskar Pearson Version: 2.4.15 OS: Ubuntu hardy URL: ftp://ftp.openldap.org/incoming/slapd-configs-qualica-1.tar.gz Submission from: (NULL) (94.194.140.71) This is the same machine as ITS #6033. Details included here for easy reference: Openldap 2.4.15 (with no patches) was self-compiled with no patches (CFLAGS="-ggdb3 -O0" ./configure), linked against standard OS libraries (ubuntu hardy) for BDB etc. BDB is 4.6.21-6ubuntu1. Kernel is 2.6.24-19-server, libc is libc6-i686/2.7-10ubuntu3. I do not have a debug log of this crash as it occurred on a live server, which is too busy for that level of logging. I also do not have a replaceable example. I have core dumps and can print out whatever is necessary there - I appreciate your time and help. If I've missed some important info, please let me know and I'll rectify asap. System overview: We have a master server which replicates to > 100 machines for Samba purposes across ADSL lines with a VPN. These lines are quite busy, so replication writes may be slow across the network, which may have implications for locks. Config files are included at the url below. I've realised through looking at the code and config files that I should probably increase the dncachesize parameter, as the number of DNs in the db is > 2000. This would help reduce the possibility of the bug occurring, but I think the bug will still exist. gdb --core=/root/core.26366 servers/slapd/slapd ... (gdb) bt #0 0xb7dd3540 in pthread_mutex_lock () from /lib/tls/i686/cmov/libpthread.so.0 #1 0x0817beef in ldap_pvt_thread_mutex_lock (mutex=0x34) at thr_posix.c:296 #2 0x08144215 in bdb_cache_delete_internal (cache=0x82b6df4, e=0x84017d8, decr=0) at cache.c:1335 #3 0x081430e5 in hdb_cache_lru_purge (bdb=0x82b6db8) at cache.c:749 #4 0x081438ba in hdb_cache_find_id (op=0x86c01d0, tid=0x86d0a30, id=1792, eip=0x9f6f1e68, flag=2, lock=0x9f6f1e00) at cache.c:1016 #5 0x08115c29 in hdb_search (op=0x86c01d0, rs=0x9f6f3100) at search.c:705 #6 0x080f179a in overlay_op_walk (op=0x86c01d0, rs=0x9f6f3100, which=op_search, oi=0x82d2b88, on=0x0) at backover.c:669 #7 0x080f19a2 in over_op_func (op=0x86c01d0, rs=0x9f6f3100, which=op_search) at backover.c:721 #8 0x080f1a46 in over_op_search (op=0x86c01d0, rs=0x9f6f3100) at backover.c:743 #9 0x080724ed in fe_op_search (op=0x86c01d0, rs=0x9f6f3100) at search.c:366 #10 0x08071e60 in do_search (op=0x86c01d0, rs=0x9f6f3100) at search.c:217 #11 0x0806eb44 in connection_operation (ctx=0x9f6f31f0, arg_v=0x86c01d0) at connection.c:1133 #12 0x0806f01e in connection_read_thread (ctx=0x9f6f31f0, argv=0x46) at connection.c:1259 #13 0x0817ad1f in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:663 #14 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #15 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 (gdb) frame 2 #2 0x08144215 in bdb_cache_delete_internal (cache=0x82b6df4, e=0x84017d8, decr=0) at cache.c:1335 1335 bdb_cache_entryinfo_lock( e->bei_parent ); (gdb) p e->bei_parent $1 = (struct bdb_entry_info *) 0x0 (gdb) up #3 0x081430e5 in hdb_cache_lru_purge (bdb=0x82b6db8) at cache.c:749 749 bdb_cache_delete_internal( &bdb->bi_cache, elru, 0 ); (gdb) p *elru $2 = {bei_parent = 0x0, bei_id = 17, bei_lockpad = 0, bei_state = 0, bei_finders = 0, bei_nrdn = {bv_len = 24, bv_val = 0x0}, bei_rdn = {bv_len = 24, bv_val = 0x0}, bei_modrdns = 0, bei_ckids = 0, bei_dkids = 0, bei_e = 0x0, bei_kids = 0x0, bei_kids_mutex = {__data = {__lock = 1, __count = 0, __owner = 28050, __kind = 0, __nusers = 1, {__spins = 0, __list = {__next = 0x0}}}, __size = "\001\000\000\000\000\000\000\000\222m\000\000\000\000\000\000\001\000\000\000\000\000\000", __align = 1}, bei_lrunext = 0x83b5e70, bei_lruprev = 0x867b980} (gdb) p bdb->bi_cache.c_leaves $3 = 3737 (gdb) p eimax $4 = 2000 (gdb) p bdb->bi_cache $5 = {c_eifree = 0x8665b00, c_idtree = 0x9b322498, c_lruhead = 0x84017d8, c_lrutail = 0x867b980, c_dntree = {bei_parent = 0x0, bei_id = 0, bei_lockpad = 0, bei_state = 128, bei_finders = 0, bei_nrdn = {bv_len = 0, bv_val = 0x0}, bei_rdn = {bv_len = 0, bv_val = 0x0}, bei_modrdns = 0, bei_ckids = 1, bei_dkids = 2, bei_e = 0x8320704, bei_kids = 0x8320248, bei_kids_mutex = {__data = {__lock = 0, __count = 0, __owner = 0, __kind = 0, __nusers = 0, { __spins = 0, __list = {__next = 0x0}}}, __size = '\0' <repeats 23 times>, __align = 0}, bei_lrunext = 0x0, bei_lruprev = 0x0}, c_maxsize = 1000, c_cursize = 117171, c_minfree = 1, c_eimax = 2000, c_eiused = 3740, c_leaves = 3737, c_purging = 1, c_txn = 0x8320188, c_rwlock = {__data = {__lock = 0, __nr_readers = 0, __readers_wakeup = 8985, __writer_wakeup = 9500, __nr_readers_queued = 0, __nr_writers_queued = 0, __flags = 0 '\0', __shared = 0 '\0', __pad1 = 0 '\0', __pad2 = 0 '\0', __writer = 0}, __size = "\000\000\000\000\000\000\000\000\031#\000\000\034%", '\0' <repeats 17 times>, __align = 0}, c_lru_mutex = {__data = {__lock = 1, __count = 0, __owner = 28050, __kind = 0, __nusers = 1, {__spins = 0, __list = {__next = 0x0}}}, __size = "\001\000\000\000\000\000\000\000\222m\000\000\000\000\000\000\001\000\000\000\000\000\000", __align = 1}, c_count_mutex = {__data = { __lock = 0, __count = 0, __owner = 0, __kind = 0, __nusers = 0, {__spins = 0, __list = {__next = 0x0}}}, __size = '\0' <repeats 23 times>, __align = 0}, c_eifree_mutex = {__data = {__lock = 0, __count = 0, __owner = 0, __kind = 0, __nusers = 0, {__spins = 0, __list = {__next = 0x0}}}, __size = '\0' <repeats 23 times>, __align = 0}} If there's anything else you'd like me to print out, please let me know. thread apply all bt follows: Thread 10 (process 26366): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd2775 in pthread_join () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817be19 in ldap_pvt_thread_join (thread=2730888080, thread_return=0x0) at thr_posix.c:197 #3 0x0806bca3 in slapd_daemon () at daemon.c:2740 #4 0x0804e8c7 in main (argc=1, argv=0xbfc63124) at main.c:948 Thread 9 (process 26372): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7ba1676 in epoll_wait () from /lib/tls/i686/cmov/libc.so.6 #2 0x0806ae3a in slapd_daemon_task (ptr=0x0) at daemon.c:2366 #3 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #4 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 8 (process 26374): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd5aa5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817beae in ldap_pvt_thread_cond_wait (cond=0x829cb0c, mutex=0x829caf4) at thr_posix.c:277 #3 0x0817acac in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:654 #4 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #5 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 7 (process 27916): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd5aa5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817beae in ldap_pvt_thread_cond_wait (cond=0x829cb0c, mutex=0x829caf4) at thr_posix.c:277 #3 0x0817acac in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:654 #4 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #5 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 6 (process 28043): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd5aa5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817beae in ldap_pvt_thread_cond_wait (cond=0x829cb0c, mutex=0x829caf4) at thr_posix.c:277 #3 0x0817acac in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:654 #4 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #5 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 5 (process 28044): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd5aa5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817beae in ldap_pvt_thread_cond_wait (cond=0x829cb0c, mutex=0x829caf4) at thr_posix.c:277 #3 0x0817acac in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:654 #4 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #5 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 4 (process 28045): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd5aa5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817beae in ldap_pvt_thread_cond_wait (cond=0x829cb0c, mutex=0x829caf4) at thr_posix.c:277 #3 0x0817acac in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:654 #4 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #5 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 3 (process 28046): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd5aa5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817beae in ldap_pvt_thread_cond_wait (cond=0x829cb0c, mutex=0x829caf4) at thr_posix.c:277 #3 0x0817acac in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:654 #4 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #5 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 2 (process 28048): #0 0xb7f18410 in __kernel_vsyscall () #1 0xb7dd5aa5 in pthread_cond_wait@@GLIBC_2.3.2 () from /lib/tls/i686/cmov/libpthread.so.0 #2 0x0817beae in ldap_pvt_thread_cond_wait (cond=0x829cb0c, mutex=0x829caf4) at thr_posix.c:277 #3 0x0817acac in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:654 #4 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #5 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6 Thread 1 (process 28050): #0 0xb7dd3540 in pthread_mutex_lock () from /lib/tls/i686/cmov/libpthread.so.0 #1 0x0817beef in ldap_pvt_thread_mutex_lock (mutex=0x34) at thr_posix.c:296 #2 0x08144215 in bdb_cache_delete_internal (cache=0x82b6df4, e=0x84017d8, decr=0) at cache.c:1335 #3 0x081430e5 in hdb_cache_lru_purge (bdb=0x82b6db8) at cache.c:749 #4 0x081438ba in hdb_cache_find_id (op=0x86c01d0, tid=0x86d0a30, id=1792, eip=0x9f6f1e68, flag=2, lock=0x9f6f1e00) at cache.c:1016 #5 0x08115c29 in hdb_search (op=0x86c01d0, rs=0x9f6f3100) at search.c:705 #6 0x080f179a in overlay_op_walk (op=0x86c01d0, rs=0x9f6f3100, which=op_search, oi=0x82d2b88, on=0x0) at backover.c:669 #7 0x080f19a2 in over_op_func (op=0x86c01d0, rs=0x9f6f3100, which=op_search) at backover.c:721 #8 0x080f1a46 in over_op_search (op=0x86c01d0, rs=0x9f6f3100) at backover.c:743 #9 0x080724ed in fe_op_search (op=0x86c01d0, rs=0x9f6f3100) at search.c:366 #10 0x08071e60 in do_search (op=0x86c01d0, rs=0x9f6f3100) at search.c:217 #11 0x0806eb44 in connection_operation (ctx=0x9f6f31f0, arg_v=0x86c01d0) at connection.c:1133 #12 0x0806f01e in connection_read_thread (ctx=0x9f6f31f0, argv=0x46) at connection.c:1259 #13 0x0817ad1f in ldap_int_thread_pool_wrapper (xpool=0x829caf0) at tpool.c:663 #14 0xb7dd14fb in start_thread () from /lib/tls/i686/cmov/libpthread.so.0 #15 0xb7ba0e5e in clone () from /lib/tls/i686/cmov/libc.so.6

1 0

Re: (ITS#6038) Write slapadd progress meter to stdout
by rein＠OpenLDAP.org 27 Mar '09

27 Mar '09

hyc(a)symas.com wrote: > Hallvard B Furuseth wrote: >> hyc(a)symas.com writes: >>> Just redirect stdin, and the meter will automatically turn itself off. >> It was stderr, not stdin - which after all can be the ldif. >> Stdout is better. >> > No, you misunderstand. > > Redirecting stderr (or stdout) merely sends the progress info to that > destination. Piping input on stdin will turn it off, so there's no progress > info to redirect. No, the code only enables the meter if stdout (was: stderr) is a tty, so redirecting it anywhere disables it. The meter was enabled both by "slapadd -l file" and "slapadd < file", but "cat file | slapadd" did disable it. IMHO not exactly an obvious way.. An option sounds more and more like the solution, what about "-m" for meter? Though I'm not sure whether I prefer that it should be enabled by default and the option disable it, or the other way around.. > Writing progress to stderr is the correct thing to do, because it's transient > info that isn't meant to be saved. Checking whether stdout is redirected or > not is fine, but writing progress info to stdout is not. For programs that produce real output (slapcat, ldapsearch) this might be true, but for those that don't (slapadd, slapd) I totally disagree. Stderr is for errors, not chatty progress or debug messages. I always hate it when the error messages gets burried in lots of noice. My preference is to have progress and debug messages on stdout, enabled by options or at least possible to disable by options. Real output must be possible to send to a file specified as argument, to separate it from the progress and debug noice. Stderr is for error messages, and possibly out-of-band messages. Rein

1 0

(ITS#6039) Windows sockets initialization and shutdown bugs in slapd
by test.007＠seznam.cz 27 Mar '09

27 Mar '09

Full_Name: Test Seven Version: 2.4.15 OS: Windows URL: Submission from: (NULL) (195.113.184.20) I'm afraid slapd won't run on Windows without the first half of the following patch. AppVerifier will choke on double tcp_close() without the second part. --- daemon.c.orig 2009-02-13 03:35:40.000000000 +0100 +++ daemon.c 2009-03-27 09:24:22.515625000 +0100 @@ -537,6 +537,7 @@ static struct slap_daemon { slap_daemon.sd_flags = (char *)(slapd_ws_sockets + dtblsize); \ slap_daemon.sd_rflags = slap_daemon.sd_flags + dtblsize; \ memset( slapd_ws_sockets, -1, dtblsize * sizeof(SOCKET) ); \ + memset(slap_daemon.sd_flags, 0, dtblsize); /* Don't forget to initialize this, used in slapd_add() called from slapd_daemon_task() */ \ slapd_ws_sockets[0] = wake_sds[0]; \ slapd_ws_sockets[1] = wake_sds[1]; \ wake_sds[0] = 0; \ @@ -1646,7 +1647,7 @@ slapd_daemon_destroy( void ) { connections_destroy(); #ifdef HAVE_WINSOCK - if ( wake_sds[1] != INVALID_SOCKET && wake_sds[1] != wake_sds[0] ) + if ( wake_sds[1] != INVALID_SOCKET && SLAP_FD2SOCK(wake_sds[1]) != SLAP_FD2SOCK(wake_sds[0]) ) #endif /* HAVE_WINSOCK */ tcp_close( SLAP_FD2SOCK(wake_sds[1]) ); #ifdef HAVE_WINSOCK

1 0

RE: (ITS#5919) URI syntaxe (ldap:///dc=my%2cdc=domaine)
by philippe.eychart＠informatique.gov.pf 27 Mar '09

27 Mar '09

"result waited" : sorry, I wanted to say "result such as hoped" ;-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs