openldap-bugs February 2015

openldap-bugs@openldap.org

28 participants
71 discussions

(ITS#8057) slapo-unique can be bypassed by anyone
by ondra＠mistotebe.net 14 Feb '15

14 Feb '15

Full_Name: Ondrej Kuznik Version: master OS: URL: ftp://ftp.openldap.org/pub/Ondrej-Kuznik-20150214-ITS-8057-uniqueness-ACL.p… Submission from: (NULL) (86.177.93.243) This is caused by my fix for #6641. Since anyone can specify the manageDSAit control on an operation it is trivial to bypass the uniqueness check as it stands. The above patch is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the above patches were developed by Ondrej Kuznik <ondra(a)mistotebe.net>. I have not assigned rights and/or interest in this work to any party. I, Ondrej Kuznik, hereby place the above modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by jsynacek＠redhat.com 12 Feb '15

12 Feb '15

--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Howard Chu <hyc(a)symas.com> writes: > Jan Synacek wrote: >> Howard Chu <hyc(a)symas.com> writes: >>> jsynacek(a)redhat.com wrote: >>>> Full_Name: Jan Synacek >>>> Version: 2.4.40 >>>> OS: GNU/Linux >>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-= libdb-detection-with-gcc-5.patch >>>> Submission from: (NULL) (94.112.188.81) >>>> >>>> >>>> The old cpp version generated: >>>> __db_version 5 >>>> >>>> Configure then correctly picked up the version, since it greps for >>>> "__db_version". >>>> >>>> The new output: >>>> __db_version >>>> 5 >>>> >>>> Grepping no longer works and configure fails. >>>> >>>> Running cpp with -P (inhibit linemarkers generation) fixes this when u= sing gcc >>>> 5. >>>> Behavior with older versions of gcc is not changed. >>> >>> Your patch is simple enough but frankly this sounds like a bug in gcc >>> 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle >>> of lines, or inserting line breaks arbitrarily. >> >> Yes, probably. But in the meantime, I needed the package to build, so I >> wrote this patch. > > Please file a bug with the gcc project and followup here with a link to=20 > that bug, for future reference. Thanks. Filed as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D65037. > Adding this patch to git master. Thank you, =2D-=20 Jan Synacek Software Engineer, Red Hat --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU3GWXAAoJEL3BmMJQOtjB6HQQAKF6PH2e6OACvDZCAmCRj4qG OT/izonRts5+ZEN645TB6oPjTN1hU43/Z/+W7eZQBQoTfQrngTzBwfAC3deFfFXU vhwf+oZR3vTsPjGev5EwM+vl7OCXN5AYhU1JNkeXM65cVQsZHWHLTIjkVImodXSs Gl258ydoURg29F1DNNfs4IA4ImpTuVZ9SZBLg7XCyJBN7Refgrbie7xpevkUh/5o ctvN4AQpUese60GE+OKiYhnyViG/pzxamMdKyOtbf5AwN+4u0HdndUqPU6iJHEQ6 66D8iJsrQgBH0dl8ggX8uQKAoq+8Pkf3hs339NUrEOAk6O91lixSWTV4UQsAJK9q 0aGMDc1f0JcNDFq1ycCcHnnJ+TbEJRi/s/RmD1Ku87vGXpYTzXUbYZE8S5pRlkLl Y5Nz0vfp76j9GvfFwrsKtvYBQAStWmV/HVeW5DbVXzRWE71StVeGfHOLRxViPoBp 3u2jaArPUMpA+ZgYfBZ7HMMvchBhgTW+f/nnZCudCVukWdd/VIK/JSe/r3q5SWv5 9QVnUy9er0t4yMsH+waSRCgRZ0BR14e7YNzPfzaqEIeFb/k5bbVtdAEhkjIREMHT 8oSF2/K+tCORx0lqpxoXZfjVEGAQUkobw/a9ABNnoUYeuy+/9nIkp970PK48AsCC wEULvjRGsq9wvJorGDJI =k/xN -----END PGP SIGNATURE----- --=-=-=--

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by h.b.furuseth＠usit.uio.no 11 Feb '15

11 Feb '15

On 11/02/15 14:25, hyc(a)symas.com wrote: > Your patch is simple enough but frankly this sounds like a bug in gcc > 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle > of lines, or inserting line breaks arbitrarily. Not a gcc bug, the ITS report proved incomplete. gcc-5 inserts "# <file information>" lines (indicating where the macro expansion comes from, I think), so it needs the line breaks. This slightly different test program: #include <db.h> __db_version DB_VERSION_MAJOR+0000; ...produces this: # 2 "test.c" __db_version # 2 "test.c" 3 4 4 # 2 "test.c" +0000; -- Hallvard

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by hyc＠symas.com 11 Feb '15

11 Feb '15

Jan Synacek wrote: > Howard Chu <hyc(a)symas.com> writes: >> jsynacek(a)redhat.com wrote: >>> Full_Name: Jan Synacek >>> Version: 2.4.40 >>> OS: GNU/Linux >>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-libdb-dete… >>> Submission from: (NULL) (94.112.188.81) >>> >>> >>> The old cpp version generated: >>> __db_version 5 >>> >>> Configure then correctly picked up the version, since it greps for >>> "__db_version". >>> >>> The new output: >>> __db_version >>> 5 >>> >>> Grepping no longer works and configure fails. >>> >>> Running cpp with -P (inhibit linemarkers generation) fixes this when using gcc >>> 5. >>> Behavior with older versions of gcc is not changed. >> >> Your patch is simple enough but frankly this sounds like a bug in gcc >> 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle >> of lines, or inserting line breaks arbitrarily. > > Yes, probably. But in the meantime, I needed the package to build, so I > wrote this patch. Please file a bug with the gcc project and followup here with a link to that bug, for future reference. Thanks. Adding this patch to git master. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8054) Operation duration logging
by h.b.furuseth＠usit.uio.no 11 Feb '15

11 Feb '15

On 11. feb. 2015 12:38, Michael Ströder wrote: > h.b.furuseth(a)usit.uio.no wrote: >> Cool feture, but please use fewer characteres in the already >> bloated log. How about "time=<integer>us" or even omit the "us"? > > +1 > > But 'time' sounds a bit general. > How about 'tdu' or even 'td' as abbreviation for "time duration"? I don't think so. You can't see from that what it means unless you already know, so you have to look it up just to see if you're interested. 'time' you can decide to look up if you are interested. -- Hallvard

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by jsynacek＠redhat.com 11 Feb '15

11 Feb '15

--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Howard Chu <hyc(a)symas.com> writes: > jsynacek(a)redhat.com wrote: >> Full_Name: Jan Synacek >> Version: 2.4.40 >> OS: GNU/Linux >> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-li= bdb-detection-with-gcc-5.patch >> Submission from: (NULL) (94.112.188.81) >> >> >> The old cpp version generated: >> __db_version 5 >> >> Configure then correctly picked up the version, since it greps for >> "__db_version". >> >> The new output: >> __db_version >> 5 >> >> Grepping no longer works and configure fails. >> >> Running cpp with -P (inhibit linemarkers generation) fixes this when usi= ng gcc >> 5. >> Behavior with older versions of gcc is not changed. > > Your patch is simple enough but frankly this sounds like a bug in gcc=20 > 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle=20 > of lines, or inserting line breaks arbitrarily. Yes, probably. But in the meantime, I needed the package to build, so I wrote this patch. Cheers, =2D-=20 Jan Synacek Software Engineer, Red Hat --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU22YfAAoJEL3BmMJQOtjBgz0P/0C6vOFzNeDmB/6gJApRB97j qQ+eAfs+VVi1nzanutQUZWIHM8F1wFFUm1ULp76z8dkxrquI9VSpTzWSj2kMPMqY iGZfK6fRM84Weog2iCR9LoVqXrNCkih1pOi3SBaQE8pLxZh0iLCg5ZEW3QEgoVam UMQz0fU5fFKtvKB85Xcy02drn64dTSn5zyF59H0CgVCTC3GBYP/tR2qp//ZPb2jj WsOMdSzx9ENf56Y/r6fmMRpKN3+c8jLHf7/zbStDIgVnCv6Haf8bLevgSYYejkus Av5U88rM9proraf6DvjwpJFfk6OCzvVo0eOcE63orw+uHyYQz/vWCLaK4/Wwo1e/ 84MekmHm1G9pQMpnrgOkUqQv/MYVQpeIgrL29DZC4y4nDa68iL7+WdNqova3s5ST 6onQTdIR8YBwVRXAfnV00SmJAEslzouhEH5MF7mcLCI+/06EnaKzqtMuTsQZvC1I 9oucRZRgdnax3jTyzDwyvxvei5/yvIESvj3NOx2vq35NxE2vqSpRqIGVucDM4cnN HVzk7fd6nFGhG9ZKWgv+2+kz6lZlH+3duIR0nJydgUJJPlRS8NxysNw439Q+Wu2D ql+Vfl9BglSrCwiE6+QrVmE9W5PLj1/I5AgE6Wrdl6zrAxYI2fj7LgiavM8tmWIp RvUpCjFNkI6AiD2KmmpV =bSRG -----END PGP SIGNATURE----- --=-=-=--

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by hyc＠symas.com 11 Feb '15

11 Feb '15

jsynacek(a)redhat.com wrote: > Full_Name: Jan Synacek > Version: 2.4.40 > OS: GNU/Linux > URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-libdb-dete… > Submission from: (NULL) (94.112.188.81) > > > The old cpp version generated: > __db_version 5 > > Configure then correctly picked up the version, since it greps for > "__db_version". > > The new output: > __db_version > 5 > > Grepping no longer works and configure fails. > > Running cpp with -P (inhibit linemarkers generation) fixes this when using gcc > 5. > Behavior with older versions of gcc is not changed. Your patch is simple enough but frankly this sounds like a bug in gcc 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle of lines, or inserting line breaks arbitrarily. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8054) Operation duration logging
by michael＠stroeder.com 11 Feb '15

11 Feb '15

h.b.furuseth(a)usit.uio.no wrote: > Cool feture, but please use fewer characteres in the already > bloated log. How about "time=<integer>us" or even omit the "us"? +1 But 'time' sounds a bit general. How about 'tdu' or even 'td' as abbreviation for "time duration"? Ciao, Michael.

1 0

Re: (ITS#8054) Operation duration logging
by h.b.furuseth＠usit.uio.no 11 Feb '15

11 Feb '15

Cool feture, but please use fewer characteres in the already bloated log. How about "time=<integer>us" or even omit the "us"? When duration is of interest, what's usually interesting is probably which operations stand out as slower, not the actual speed. When duration is not of interest, then it's noise to keep small and boring. And we should document at least the default log format (Statslog). == About the code, ignoring the above suggestion for now: Once upon a time, floating-point was slow. Today, that extra code to avoid it is a pessimization at least on my Linux/x86. Try this: #define TIMEDIFF_MS(a,b) \ (((a)->tv_sec-(b)->tv_sec)*1000 + ((a)->tv_usec-(b)->tv_usec)/1000.0) OTOH floating-point printf is compex, you save a bit by doing msec = (int)t; printf("%d.%03d", msec, (int)((t-msec)*1000)); instead of printf("%4.3f", t); %d format requires 'int msec;' and (int)(duration.tv_usec % 1000). Since timersub() is use the same way each time, a macro could instead compute duration and msec, and maybe declare them too: DURATION_DECLARE(duration, msec, op->o_hr_time); For that matter, maybe we should get rid of the #ifdef-duplicated Statslog() statements and put the ugliness in macros instead. Like this, I think - an untested draft: DURATION_DECLARE(duration, msec, op->o_hr_time); StatslogDuration( LDAP_DEBUG_STATS, "%s DISCONNECT tag=%lu err=%d "DURATION_LOG_FMT" text=%s\n", op->o_log_prefix, rs->sr_tag, rs->sr_err, DURATION_LOG_ARG(duration, msec) /* no comma after this */ rs->sr_text ? rs->sr_text : "", 0 ); #ifdef HAVE_GETTIMEOFDAY #define DURATION_DECLARE(..blah..) <the duration code before Statslog> #define DURATION_LOG_FMT "duration=%d.%03dms " /* This is passed to StatslogDuration() without a comma before next arg. * So it is not an extra arg to StatslogDuration(), but it gives two * extra 'int' args to whatever StatslogDuration() passes it args on to. */ #define DURATION_LOG_ARG(duration,msec) (msec), (int)((duration).tv_usec%1000), #define StatslogDuration <like Statslog, but using Log7 instead of Log5> #else #define DURATION_DECLARE(..blah..) #define DURATION_LOG_FMT "" #define DURATION_LOG_ARG(duration, msec) #define StatslogDuration Statslog #endif

1 0

(ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by jsynacek＠redhat.com 11 Feb '15

11 Feb '15

Full_Name: Jan Synacek Version: 2.4.40 OS: GNU/Linux URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-libdb-dete… Submission from: (NULL) (94.112.188.81) The old cpp version generated: __db_version 5 Configure then correctly picked up the version, since it greps for "__db_version". The new output: __db_version 5 Grepping no longer works and configure fails. Running cpp with -P (inhibit linemarkers generation) fixes this when using gcc 5. Behavior with older versions of gcc is not changed.

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs February 2015