openldap-bugs October 2014

openldap-bugs@openldap.org

14 participants
76 discussions

Start a nNew thread

Re: (ITS#7636) slapd crash when multi-master replication (syncrepl) enabled
by leo＠yuriev.ru 14 Oct '14

14 Oct '14

It is one more relevant bug with patch http://www.OpenLDAP.org/its/index.cgi?findid=7965

1 0

Re: (ITS#7965) heap corruption due to returning a reference to the local variable
by leo＠yuriev.ru 14 Oct '14

14 Oct '14

The attached files is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned rights and/or interest in this work to any party. I, Leonid Yuriev am authorized by Peter-Service LLC, my employer, to release this work under the following terms. Peter-Service LLC hereby places the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. https://github.com/leo-yuriev/openldap-lmdb-challenge/commit/1d29214f60300c… Author: Leo Yuriev <leo(a)yuriev.ru> Date: 2014-10-14 14:49:25 +0400 BUGFIX - lmdb-backend: heap corruption due to returning a reference to the local variable. diff --git a/servers/slapd/back-mdb/dn2id.c b/servers/slapd/back-mdb/dn2id.c index 06e6ad3..41c4758 100644 --- a/servers/slapd/back-mdb/dn2id.c +++ b/servers/slapd/back-mdb/dn2id.c @@ -346,7 +346,7 @@ mdb_dn2id( cursor = mc; } else { rc = mdb_cursor_open( txn, dbi, &cursor ); - if ( rc ) return rc; + if ( rc ) goto done; } for (;;) { @@ -470,7 +470,7 @@ mdb_dn2sups( key.mv_size = sizeof(ID); rc = mdb_cursor_open( txn, dbi, &cursor ); - if ( rc ) return rc; + if ( rc ) goto done; for (;;) { key.mv_data = &pid;

1 0

(ITS#7965) heap corruption due to returning a reference to the local variable
by leo＠yuriev.ru 14 Oct '14

14 Oct '14

Full_Name: Leonid Yuriev Version: 2.4.40 OS: RHEL7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (31.130.36.33) #4 0x00000030e1834105 in abort () from /lib64/libc.so.6 #5 0x00000030e1876190 in malloc_printerr () from /lib64/libc.so.6 #6 0x00000000004cc593 in mdb_dn2entry (op=0x7ff36ef32380, tid=0xeb44d0, m2=0x0, dn=0x7ff36ef323b8, e=0x7ff36ef31188, nsubs=<value optimized out>, matched=1) at dn2entry.c:75 mdb = 0x7ff3980da010 rc = -30782 rc2 = <value optimized out> id = 18446744073709551615 0x7ff36ef30db8 mbv = {bv_len = 0, bv_val = 0x7ff36ef30ebe ""} nmbv = {bv_len = 0, bv_val = 0x0} mc = 0x0 while the rsp is 0x7ff36ef30db8 #7 0x00000000004a6707 in mdb_modify (op=0x7ff36ef32380, rs=0x7ff36ef31450) at modify.c:531 #8 0x0000000000487fc7 in overlay_op_walk (op=0x7ff36ef32380, rs=0x7ff36ef31450, which=op_modify, oi=0xe0e840, on=0x0) at backover.c:671 #9 0x00000000004889b3 in over_op_func (op=0x7ff36ef32380, rs=<value optimized out>, which=<value optimized out>) at backover.c:723 #10 0x000000000047c74inin syncrepl_del_nonpresent (op=0x7ff36ef32380, si=0xdcc570, uuids=<value optimized out>, sc=0x7ff36ef314c0, m=89008752) at syncrepl.c:3452 #11 0x0000000000480e92 in do_syncrep2 (op=0x7ff36ef32380, si=0xdcc570) at syncrepl.c:1335 #12 0x00000000004843c2 in do_syncrepl (ctx=<value optimized out>, arg=0xdcc9d0) at syncrepl.c:1539 #13 0x00007ff3987e2868 in ldap_int_thread_pool_wrapper (xpool=0xd79e80) at tpool.c:688

1 0

(ITS#7964) overlay rwm escape issue with more the 9 rules / rewrite statements
by uwe.werler＠retiolum.eu 13 Oct '14

13 Oct '14

Full_Name: Uwe Werler Version: 2.4.40 OS: Linux / SLES 11 SP3 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (155.56.68.214) If I have rewrite rules like this: 23 olcOverlay={1}rwm,olcDatabase={3}hdb,cn=config objectClass: olcOverlayConfig objectClass: olcRwmConfig olcOverlay: {1}rwm olcRwmRewrite: {0}rwm-rewriteEngine on olcRwmRewrite: {1}rwm-rewriteContext searchFilter olcRwmRewrite: {2}rwm-rewriteRule "(.*\$)uid=sapr3(\$.*)" "$1uid=dlmsapr3$2" olcRwmRewrite: {3}rwm-rewriteRule "(.*\$)uid=sdb(\$.*)" "$1uid=sdb$2" olcRwmRewrite: {4}rwm-rewriteRule "(.*\$)uid=sapadm(\$.*)%2"%2$1uid=dlmsapadm$2" olcRwmRewrite: {5}rwm-rewriteRule "(.*\$)uid=sapmnt(\$.*)" "$1uid=sapmnt$2" olcRwmRewrite: {6}rwm-rewriteRule "(.*\$)uid=[a-z0-9]{3}adm(\$.*)" "$1uid=dlmsidadm$2" olcRwmRewrite: {7}rwm-rewriteRule "(.*\$)uid=sqd[a-z0-9]%3%3}(\$.*)" "$1uid=dlmsqdsid$2" olcRwmRewrite: {8}rwm-rewriteRule "(.*\$)uid=ora[a-z0-9]{3}(\$.*)" "$1uid=dlmorasid$2" olcRwmRewrite: {9}rwm-rewriteRule "(.*\$)uid=sap[a-z0-9]{3}(\$.*)" "$1uid=dlmsapr3$2" olcRwmRewrite: {10}rwm-rewriteRule "(.*\$)uid=sap[a-z0-9]{3}db(\$.*)" "$1uid=dlmsapr3db$2" olcRwmRewrite: {11}rwm-rewriteRule "(.*\$)uid=db2[a-z0-9]{3}(\$.*)" "$1uid=dlmdb2sid$2" olcRwmRewrite: {12}rwm-rewriteRule "(.*\$)uid=db2[a-z0-9]{3}ap(\$.*)" "$1uid=dlmdb2sid$2" then the ninth rule / statent f failes to escape. In this example ora*** get's not correctly rewritten to dlmora***: See loglevel trace: 543b711d ==> rewrite_rule_apply rule='(.*$)uid=sapr3($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=sdb($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=sapadm($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=sapmnt($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==E E rewrite_rule_apply rule='(.*$)uid=[a-z0-9]{3}adm($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=sqd[a-z0-9]{3}($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*\$)uid=ora[a-z0-9]{3}(\$.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=sap[a-z0-9]{3}($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=sap[a-z0-9]{3}db($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=db2[a-z0-9]{3}($.*)' string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] 543b711d ==> rewrite_rule_apply rule='(.*$)uid=db2[a-z0-9]{3}ap($.*"727 string='(&(objectClass=dynamicObject)(entryExpireTimestamp<=20141013062840Z))' [1 pass(es)] If I insert a dummy statement like this: olcRwmRewrite: {0}rwm-rewriteEngine on olcRwmRewrite: {1}rwm-rewriteContext searchFilter olcRwmRewrite: {2}rwm-rewriteRule "(.*\$)uid=sapr3(\$.*)" "$1uid=dlmsapr3$2" olcRwmRewrite: {3}rwm-rewriteRule "(.*\$)uid=sdb(\$.*)" "$1uid=sdb$2" olcRwmRewrite: {4}rwm-rewriteRule "(.*\$)uid=sapadm(\$.*)" "$1uid=dlmsapadm$2" olcRwmRewrite: {5}rwm-rewriteRule "(.*\$)uid=sapmnt(\$.*)" "$1uid=sapmnt$2" olcRwmRewrite: {6}rwm-rewriteRule "(.*\$)uid=[a-z0-9]{3}adm(\$.*)" "$1uid=dlmsidadm$2" olcRwmRewrite: {7}rwm-rewriteRule "(.*\$)uid=sqd[a-z0-9]{3}(\$.*)" "$1uid=dlmsqdsid$2" olcRwmRewrite: {8}rwm-rewriteRule "(.*\$)uid=ora[a-z0-9]{3}(\$.*)" "$1uid=dlmorasid$2" olcRwmRewrite: {9}rwm-rewriteContext placeHolder alias searchFilter olcRwmRewrite: {10}rwm-rewriteRule "(.*\$)uid=sap[a-z0-9]{3}(\$.*)" "$1uid=dlmsapr3$2" olcRwmRewrite: {11}rwm-rewriteRule "(.*\$)uid=sap[a-z0-9]{3}db(\$.*)" "$1uid=dlmsapr3db$2" olcRwmRewrite: {12}rwm-rewriteRule "(.*\$)uid=db2[a-z0-9]{3}(\$.*)" "$1uid=dlmdb2sid$2" olcRwmRewrite: {13}rwm-rewriteRule "(.*\$)uid=db2[a-z0-9]{3}ap(\$.*)" "$1uid=dlmdb2sid$2" then the escapes are working properly. Sometimes this occurs with the last rule too. I first tried with 2.4.26 (standard version in SLES11 SP3) and now with 2.4.40. Regards Uwe

1 0

Re: (ITS#7963) Client paged results directive fails
by hyc＠symas.com 09 Oct '14

09 Oct '14

kenel.bastoon(a)gmail.com wrote: > Full_Name: Bastien Bonnefon > Version: 2.4.39 > OS: CentOS 7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (194.2.202.93) > > > Hi, > > I have installed openldap as meta directory to request multiple Active > Directory. > I have managed to install and make it work with dynamic configuration or > slapd.conf. > But one of the applications accessing the directory needs paged results due to > the large amount of entries returned. > > So I've searched and found the directive "client-pr", which seems to have been > enabled since this case : > http://www.openldap.org/its/index.cgi/Software%20Enhancements?id=6664;page=4 > > The directive is also dcribibed in the slapd-meta man page : > http://www.openldap.org/software/man.cgi?query=slapd-meta&apropos=0&sektion… Looking at the ITS history, it appears that this code was released in January 2011 but in fact, the released code is not actually enabled. (It is behind an #ifdef LDAP_DEVEL mask.) Most likely a mistake was made in releasing it at that time, since I see no actual test feedback in the ITS. If you want to test this you will have to compile back-meta yourself, and edit back-meta.h to make sure SLAPD_META_CLIENT_PR gets defined instead of being hidden. Please then send your test results as a followup to ITS#6664. > However, enabling the feature in slapd.conf (I just can't in olc format) doesn't > work. Syslog shows this : > "unknown directive <client-pr> inside backend database definition" > > I've started testing with CentOS 7 and package openldap 2.4.39 > I've then tried with Debian Wheezy and Ubuntu 14.04 (package slapd 2.4.31) > I've also tried installing openldap from the source with the version 2.4.24 > (client-pr should have been enabled in this version due to ITS#6664) => no way > :/ > > I think I've declared the directive as specified in the man page but maybe I > miss something. I have not found any other report on the web on how to use > "client-pr". > Thank you for your help. > > > Here is my slapd.conf > > # Include > include /etc/ldap/schema/core.schema > include /etc/ldap/schema/cosine.schema > include /etc/ldap/schema/inetorgperson.schema > include /etc/ldap/schema/nis.schema > > pidfile /var/run/slapd/slapd.pid > argsfile /var/run/slapd/slapd.args > > # Modules > moduleload back_ldap.la > moduleload back_meta.la > > # Database meta > database meta > suffix "dc=meta,dc=local" > > rootdn "cn=Manager,dc=meta,dc=local" > rootpw secret_password1 > > # First directory > uri "ldap://192.168.0.1/ou=test1,dc=meta,dc=local" > client-pr accept-unsolicited > lastmod off > suffixmassage "ou=test1,dc=meta,dc=local" "dc=test1,dc=local" > idassert-bind bimemethod=simple > binddn="cn=openldap,OU=users,OU=TEST,dc=test1,dc=local" > credentials="secret_password2" > mode=none > flags=non-prescriptive > idassert-authzFrom "dn.exact:cn=Manager,dc=meta,dc=local" > chase-referrals no > acl-authcDN cn=openldap,OU=users,OU=TEST,dc=test1,dc=local > acl-passwd secret_password2 > > # Second Directory > uri "ldap://192.168.0.2/ou=test2,dc=meta,dc=local" > client-pr accept-unsolicited > lastmod off > suffixmassage "ou=test2,dc=meta,dc=local" ,%c=test2,dc=local" > idassert-bind bindmethod=simple > binddn="cn=openldap,OU=users,OU=TEST,dc=test2,dc=local" > credentials="secret_password3" > mode=none > flags=non-prescriptive > idassert-authzFrom "dn.exact:cn=Manager,dc=meta,dc=local" > chase-referrals no > acl-authcDN "cn=openldap,OU=users,OU=TEST,dc=test2,dc=local" > acl-passwd secret_password3 > > > idletimeout 1800 > > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#7963) Client paged results directive fails
by kenel.bastoon＠gmail.com 09 Oct '14

09 Oct '14

Full_Name: Bastien Bonnefon Version: 2.4.39 OS: CentOS 7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (194.2.202.93) Hi, I have installed openldap as meta directory to request multiple Active Directory. I have managed to install and make it work with dynamic configuration or slapd.conf. But one of the applications accessing the directory needs paged results due to the large amount of entries returned. So I've searched and found the directive "client-pr", which seems to have been enabled since this case : http://www.openldap.org/its/index.cgi/Software%20Enhancements?id=6664;page=4 The directive is also dcribibed in the slapd-meta man page : http://www.openldap.org/software/man.cgi?query=slapd-meta&apropos=0&sektion… However, enabling the feature in slapd.conf (I just can't in olc format) doesn't work. Syslog shows this : "unknown directive <client-pr> inside backend database definition" I've started testing with CentOS 7 and package openldap 2.4.39 I've then tried with Debian Wheezy and Ubuntu 14.04 (package slapd 2.4.31) I've also tried installing openldap from the source with the version 2.4.24 (client-pr should have been enabled in this version due to ITS#6664) => no way :/ I think I've declared the directive as specified in the man page but maybe I miss something. I have not found any other report on the web on how to use "client-pr". Thank you for your help. Here is my slapd.conf # Include include /etc/ldap/schema/core.schema include /etc/ldap/schema/cosine.schema include /etc/ldap/schema/inetorgperson.schema include /etc/ldap/schema/nis.schema pidfile /var/run/slapd/slapd.pid argsfile /var/run/slapd/slapd.args # Modules moduleload back_ldap.la moduleload back_meta.la # Database meta database meta suffix "dc=meta,dc=local" rootdn "cn=Manager,dc=meta,dc=local" rootpw secret_password1 # First directory uri "ldap://192.168.0.1/ou=test1,dc=meta,dc=local" client-pr accept-unsolicited lastmod off suffixmassage "ou=test1,dc=meta,dc=local" "dc=test1,dc=local" idassert-bind bimemethod=simple binddn="cn=openldap,OU=users,OU=TEST,dc=test1,dc=local" credentials="secret_password2" mode=none flags=non-prescriptive idassert-authzFrom "dn.exact:cn=Manager,dc=meta,dc=local" chase-referrals no acl-authcDN cn=openldap,OU=users,OU=TEST,dc=test1,dc=local acl-passwd secret_password2 # Second Directory uri "ldap://192.168.0.2/ou=test2,dc=meta,dc=local" client-pr accept-unsolicited lastmod off suffixmassage "ou=test2,dc=meta,dc=local" ,%c=test2,dc=local" idassert-bind bindmethod=simple binddn="cn=openldap,OU=users,OU=TEST,dc=test2,dc=local" credentials="secret_password3" mode=none flags=non-prescriptive idassert-authzFrom "dn.exact:cn=Manager,dc=meta,dc=local" chase-referrals no acl-authcDN "cn=openldap,OU=users,OU=TEST,dc=test2,dc=local" acl-passwd secret_password3 idletimeout 1800

1 0

Re: (ITS#7958) LMDB: LIFO-reclaiming, write-performance improvement & bugfixes
by leo＠yuriev.ru 06 Oct '14

06 Oct '14

https://github.com/leo-yuriev/openldap-lmdb-challenge/pull/1 Best regards. Leonid Yuriev.

1 0

Re: (ITS#7961) [LMDB] remove logically dead code (2nd)
by hyc＠symas.com 05 Oct '14

05 Oct '14

jcd(a)tribudubois.net wrote: > Full_Name: Jean-Christophe Dubois > Version: 2.4.40 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (78.235.240.156) > > > In function mdb_txn_begin() at line 2672 there is a check for the parent > pointer. > > The same check is done few lines earlier (line 2665) and if the condition was > met the program would have skip the all section to ok: > > So code line 2673 can never be reached. It could be removed. Thanks. This was leftover from 4d02c741b120786df1b87ee9ed49c1d3f9bc7522. Fixed in mdb.master. > > Patch available at URL below: > > https://github.com/jcdubois/lmdb/commit/a3770a5fef56417ceea677efbbde7687551… > > JC > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#7962) [LMDB] remove logically dead code (2nd)
by jcd＠tribudubois.net 05 Oct '14

05 Oct '14

Full_Name: Jean-Christophe Dubois Version: 2.4.40 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.235.240.156) In function mdb_txn_begin() at line 2672 there is a check for the parent pointer. The same check is done few lines earlier (line 2665) and if the condition was met the program would have skip the all section to ok: So code line 2673 can never be reached. It could be removed. Patch available at URL below: https://github.com/jcdubois/lmdb/commit/a3770a5fef56417ceea677efbbde7687551… JC

1 0

(ITS#7961) [LMDB] remove logically dead code (2nd)
by jcd＠tribudubois.net 05 Oct '14

05 Oct '14

1 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs October 2014