openldap-bugs December 2010

openldap-bugs@openldap.org

32 participants
128 discussions

(ITS#6742) Patch - Mozilla NSS - centralize and improve certificate verification
by rmeggins＠redhat.com 09 Dec '10

09 Dec '10

Full_Name: Rich Megginson Version: 2.4.23 (current CVS HEAD) OS: RHEL6 URL: ftp://ftp.openldap.org/incoming/openldap-2.4.23-centralize-and-improve-cert… Submission from: (NULL) (76.113.111.209) The changes are to make Mozilla NSS certificate verification work like OpenSSL. The former is using Fedora 14 with Mozilla NSS 3.12.8, the latter, Fedora 13 with OpenLDAP 2.4.21 and OpenSSL 1.0.0b. I tested the following scenarios: * self signed server + CA cert as generated by openssl req -x509 * server cert generated by self signed CA (/etc/pki/tls/misc/CA) I tested various combinations of certs, with and with CA certs, on both the server and the client, and verified that the F-14 system worked the same as the F-13, excepting differences in error messages. I added a new function - tlsm_verify_cert() - that could handle different types of cert verification. I replaced other calls to CERT_Verify* with this function and consolidated exception and error handling there. In order to make error handling more flexible, I use the CERT_VerifyCertificate() function which takes a logging parameter. The log contains a list of the errors found along with each cert that caused a problem (a cert may be listed in the log multiple times if a cert had more than one problem). The use of logging also allows cert verification to continue to search for all problems, rather than just returning at the first problem. This allows fine grained error handling which is needed for the following problem: OpenSSL allows CA certs with the Basic Constraints extension set with the CA flag set to FALSE. NSS does not. If tlsm_verify_cert finds this case, it can just log a warning and allow it. I also added the ability to specify an error code to ignore in cert verification, which is needed when using a self signed CA cert for the server cert. I also changed the way trust is handled. In OpenSSL, certs specified by the user (e.g. in TLS_CACERT, TLS_CACERTDIR, TLS_CERT) are explicitly trusted. So, for example, you can specify a server or client cert without specifying the CA cert issuer, and OpenSSL will allow it. NSS will allow it if the cert is specified as trusted. I changed the add_cert code to accept an istrusted flag so that you can specify if a PEM cert is trusted. The PEM NSS code stores trusted certs in a special slot, so the code had to be changed to accommodate that. Finally, I added a default error message which has the error code if an error message was not already set by the library.

1 0

Re: (ITS#6714) Patch - Mozilla NSS - implement full non-blocking semantics
by rmeggins＠redhat.com 09 Dec '10

09 Dec '10

I "rebased" the patch on top of a recent change: revision 1.24 date: 2010/12/06 10:31:59; author: hallvard; state: Exp; lines: +5 -17 ITS#6625 Remove some LDAP_R_COMPILEs The new patch is here: ftp://ftp.openldap.org/incoming/openldap-2.4.23-use-non-blocking-semantics-… This patch file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Red Hat. Red Hat has not assigned rights and/or interest in this work to any party. I, Rich Megginson am authorized by Red Hat, my employer, to release this work under the following terms. Red Hat hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

1 0

Re: (ITS#6716) syncprov sessionlog 'sl_mincsn' not assigned a value.
by masarati＠aero.polimi.it 09 Dec '10

09 Dec '10

rein(a)OpenLDAP.org wrote: > On 09.12.10 09.09, masarati(a)aero.polimi.it wrote: >> I think the best (blind) fix consists in only performing that test if >> sl_mincsn is assigned a value; something like > > I'm looking at an extended fix. The problem with the current > implementation is that is assumes the entries arrives in CSN order, > which isn't necessarily true in a MMR configuration. > > My fix drops sl_mincsn, keeps the log queue in CSN order and compares > with the head entry. It also wipes the log if it receives any changes > without CSN (i.e during refresh). > > There might still be a theoretical problem there, if the sid of an entry > in the log is not in the set sent by the consumer. But since we know > they have the same number of CSNs this can only happen during initial > setup of a multi-master configuration. In which case the admins real > problem is that he didn't bring the servers online in a controlled order.. OK, I'm not looking at this any more. Thanks, p.

1 0

Re: (ITS#6716) syncprov sessionlog 'sl_mincsn' not assigned a value.
by rein＠OpenLDAP.org 09 Dec '10

09 Dec '10

On 09.12.10 09.09, masarati(a)aero.polimi.it wrote: > I think the best (blind) fix consists in only performing that test if > sl_mincsn is assigned a value; something like I'm looking at an extended fix. The problem with the current implementation is that is assumes the entries arrives in CSN order, which isn't necessarily true in a MMR configuration. My fix drops sl_mincsn, keeps the log queue in CSN order and compares with the head entry. It also wipes the log if it receives any changes without CSN (i.e during refresh). There might still be a theoretical problem there, if the sid of an entry in the log is not in the set sent by the consumer. But since we know they have the same number of CSNs this can only happen during initial setup of a multi-master configuration. In which case the admins real problem is that he didn't bring the servers online in a controlled order.. Rein

1 0

Re: (ITS#6716) syncprov sessionlog 'sl_mincsn' not assigned a value.
by cmikk＠qwest.net 09 Dec '10

09 Dec '10

On Thu, Dec 09, 2010 at 09:09:21AM +0100, Pierangelo Masarati wrote: > I think the best (blind) fix consists in only performing that test > if sl_mincsn is assigned a value; something like > > /* Are there any log entries, and is the consumer state > * present in the session log? > */ > - if ( sl->sl_num > 0 && ber_bvcmp( &mincsn, > &sl->sl_mincsn ) >= 0 ) { > + if ( !BER_BVISEMPTY( &sl->sl_mincsn ) && > + sl->sl_num > 0 && > + ber_bvcmp( &mincsn, &sl->sl_mincsn ) >= 0 ) > + { > do_present = 0; > /* mutex is unlocked in playlog */ > syncprov_playlog( op, rs, sl, srs, ctxcsn, numcsns, sids ); > > However I'd like to hear some other opinion. This fix would have the effect of treating the sessionlog as empty until it overflows, and will cause unnecessary refresh traffic. Other than the patch I suggested (using the list head's CSN value directly), I can think of two other approaches: 1) When adding an entry to the sessionlog, check if sl_mincsn is empty. If it is, update sl_mincsn to the new entry's CSN. 2) When initializing the sessionlog, set sl_mincsn to the maximum contextCSN value of the underlying database. #2 seems ideal from an efficiency standpoint, although it differs from the algorithm the current code appears to be intended to implement. -- Chris Mikkelson | Vampireware; n, a project capable of sucking the cmikk(a)qwest.net | lifeblood out of anyone unfortunate enough to be | assigned to it which never actually sees the light | of day, but nonetheless refuses to die. (tlode(a)nyx.net)

1 0

Re: (ITS#6716) syncprov sessionlog 'sl_mincsn' not assigned a value.
by masarati＠aero.polimi.it 09 Dec '10

09 Dec '10

I think the best (blind) fix consists in only performing that test if sl_mincsn is assigned a value; something like /* Are there any log entries, and is the consumer state * present in the session log? */ - if ( sl->sl_num > 0 && ber_bvcmp( &mincsn, &sl->sl_mincsn ) >= 0 ) { + if ( !BER_BVISEMPTY( &sl->sl_mincsn ) && + sl->sl_num > 0 && + ber_bvcmp( &mincsn, &sl->sl_mincsn ) >= 0 ) + { do_present = 0; /* mutex is unlocked in playlog */ syncprov_playlog( op, rs, sl, srs, ctxcsn, numcsns, sids ); However I'd like to hear some other opinion. p.

1 0

(ITS#6741) x500UniqueIdentifier handling
by jgcardoso＠seguridata.com 08 Dec '10

08 Dec '10

Full_Name: Juan González Cardoso Version: 2.4.23 OS: Red Hat 5.5 EL URL: ftp://ftp.openldap.org/incoming/juan-gonzalez-101208.cer Submission from: (NULL) (201.148.141.170) Inserting userCertificate values containing x500UniqueIdentifier attribute at issuerNames fails. Some values even makes server to crash.

1 0

Re: (ITS#6740) syncrepl/--disable-rewrite dependency
by masarati＠aero.polimi.it 08 Dec '10

08 Dec '10

> What's special about DN rewriting so it has a configure option > anyway? It doesn't disable building of libraries/librewrite. It used to, as far as I remember. I remember something about performing simple suffixmassage when librewrite is not built. In any case I agree that given the widespread usage of rewrite capabilities (authz regexp, for example) not building librewrite is somehow pointless. p.

1 0

Re: (ITS#6740) syncrepl/--disable-rewrite dependency
by h.b.furuseth＠usit.uio.no 08 Dec '10

08 Dec '10

What's special about DN rewriting so it has a configure option anyway? It doesn't disable building of libraries/librewrite. -- Hallvard

1 0

(ITS#6740) syncrepl/--disable-rewrite dependency
by h.b.furuseth＠usit.uio.no 08 Dec '10

08 Dec '10

Full_Name: Hallvard B Furuseth Version: HEAD OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (129.240.6.233) Submitted by: hallvard configure should mention syncrepl here: --enable-rewrite enable DN rewriting in back-ldap and rwm overlay test059-slave-config fails with --disable-rewrite. Testrun/test.out says parse_syncrepl_line: unable to parse "suffixmassage=cn=schema,cn=config,cn=slave"

1 0

← Newer
1
...
6
7
8
9
10
11
12
13
Older →

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs December 2010