openldap-bugs January 2008

openldap-bugs@openldap.org

36 participants
144 discussions

Re: (ITS#5304) bug in source code: libldap/extended.c ?
by ando＠sys-net.it 02 Jan '08

02 Jan '08

I've patched it differently in HEAD (rev. 1.44); please check. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it --------------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Email: pierangelo.masarati(a)sys-net.it ---------------------------------------

1 0

Re: (ITS#5304) bug in source code: libldap/extended.c ?
by mark.funkenhauser＠bluecoat.com 02 Jan '08

02 Jan '08

Correction to suggested fix: I think the code at line 374 should look like: if ( ber_scanf( ber, /*{*/ "}" ) == LBER_ERROR ) { ld->ld_errno = LDAP_DECODING_ERROR; ber_free( ber, 0 ); if( resoid != NULL ) LDAP_FREE( resoid ); if (resdata != NULL) ber_bvfree( resdata ); return ld->ld_errno; }

1 0

(ITS#5304) bug in source code: libldap/extended.c ?
by mark.funkenhauser＠bluecoat.com 02 Jan '08

02 Jan '08

Full_Name: Mark Funkenhauser Version: OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (216.16.247.2) Looking at libldap/extended.c, rev 1.43, function ldap_parse_intermediate(), at line 374, the code is written as: if ( ber_scanf( ber, /*{*/ "}" ) == LBER_ERROR ) { rc = LDAP_DECODING_ERROR; goto free_and_return; } I think there's a problem here. 1) rc is defined to be a ber_tag_t type, which is not suitable for assignment to an LDAP_*_ERROR error code. ber_tag_t is an unsigned type, and LDAP_DECODING_ERROR is a negative number. 2) The use of LDAP_DECODING_ERROR here implies there is an error. I would have thought this function should be returning this error code using "return ld->ld_errno". Jumping to "free_and_return" is not the way to return an error. 3) the "goto free_and_return" is a jump to code to handle a successful return from this function. Assigning any value to rc before this "goto" becomes a no-op because the code after "free_and_return" does not use rc. I think the code at line 374 should look like: if ( ber_scanf( ber, /*{*/ "}" ) == LBER_ERROR ) { ld->ld_errno = LDAP_DECODING_ERROR; ber_free( ber, 0 ); if( resoid != NULL ) LDAP_FREE( resoid ); return ld->ld_errno; }

1 0

Re: (ITS#5281) doc contribution - set examples - following references
by ghenry＠OpenLDAP.org 02 Jan '08

02 Jan '08

andreas(a)mandriva.com.br wrote: > Full_Name: Andreas Hasenack > Version: 2.4.6 > OS: Linux > URL: http://users.mandriva.com.br/~andreas/ldap-doc/doc-set-examples/set-followi… > Submission from: (NULL) (200.140.247.99) > > > http://users.mandriva.com.br/~andreas/ldap-doc/doc-set-examples/set-followi… > > Documentation contribution with further examples regarding the usage of sets in > ACLs. This time, using a user/manager/secretary/group example. > > These files are derived from OpenLDAP Software. All of the modifications to > OpenLDAP Software represented in the following patch(es) were developed by > Andreas Hasenack <andreas(a)mandriva.com.br>. These modifications are not subject > to any license of Mandriva. > I, Andreas Hasenack, hereby place the following modifications to OpenLDAP > Software (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose with or > without attribution and/or other notice. > > Thanks for this Andreas. I'll be working on a sets section in the ACL section shortly. It's up for discussion if the ACL discussion in the current config sections of the admin guide should stay there or be moved out into their own. More later. -- Kind Regards, Gavin Henry. OpenLDAP Engineering Team. E ghenry(a)OpenLDAP.org Community developed LDAP software. http://www.openldap.org/project/

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs January 2008