-----Original Message----- From: Pierangelo Masarati [mailto:ando@sys-net.it] Sent: Wednesday, September 26, 2007 2:54 PM To: mhardin@symas.com Cc: openldap-its@openldap.org Subject: Re: (ITS#5154) Sequential binds to back-meta cause assertion failiure

mhardin@symas.com wrote:

...

Full_Name: Matthew Hardin Version: 2.3.38 OS: N/A URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (12.168.121.2)

Multiple binds on the same connection where at least one bind ends up

being

[...]

...

                    /* FIXME: in some cases (e.g. unavailable)
                     * do not assume it's not candidate; rather
                     * mark this as an error to be eventually

I think the "real" fix should be different: binds should always receive a fresh connection from meta_back_getconn(), which shouldn't be put into the cache at all. meta_back_bind() should cache them only in case of success, otherwise they should be destroyed. This would allow to remove the need to set a BINDING flag to guarantee connections used for bind are not shared.

I agree that would be a better fix.

In the meanwhile, the solution you propose should be just fine, as it fills the hole occurring when a bind fails.

I'll work at that ASAP.

Thanks!

-Matt

Matthew Hardin Symas Corporation- The LDAP Guys

http://www.symas.com