--=-JaZE3OeFLXsBmyVf+gjk Content-Type: multipart/mixed; boundary="=-5geAzHYesMuCPweb8j5I"

--=-5geAzHYesMuCPweb8j5I Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Mon, 2010-04-19 at 02:15 +0200, masarati@aero.polimi.it wrote:

Refactored rdnval.c available at =20 ftp://ftp.openldap.org/incoming/pierangelo-masarati-2010-04-18-rdnval.c =20 attempts to repair the database at startup; useful when the overlay is configured for an existing database. Please test.

Sadly it segfaults on startup (we don't have the DB at startup - we expect the first operations to create them).=20

I produced the environment with Samba4 from master (538a07a80aae72b57e5c23133158c7f214d0c27a) with the attached additional patch

TEST_LDAP=3Dyes OPENLDAP_SLAPD=3D/usr/local/libexec/slapd make quicktest

This ran:=20 '/usr/local/libexec/slapd' '-F/scratch/samba-2/source4/st/dc/private/ldap/slapd.d' '-h' 'ldapi://% 2Fscratch%2Fsamba-2%2Fsource4%2Fst%2Fdc%2Fprivate%2Fldap%2Fldapi' '-d0'

and running that under gdb produced

Program received signal SIGSEGV, Segmentation fault. 0x000000000057ba54 in rdnval_repair (be=3D0x7fffffffdbe0) at rdnval.c:466 466 op->o_req_dn =3D op->o_bd->be_suffix[ 0 ]; Missing separate debuginfos, use: debuginfo-install glibc-2.11.90-17.x86_64 libgcc-4.4.3-12.fc13.x86_64 libicu-4.2.1-7.fc12.x86_64 libicu-4.2.1-8.fc13.x86_64 libstdc ++-4.4.3-12.fc13.x86_64 libtool-ltdl-2.2.6-18.fc12.x86_64 libtool-ltdl-2.2.6-18.fc13.x86_64 libuuid-2.17.2-1.fc13.x86_64 mysql-libs-5.1.45-2.fc13.x86_64 postgresql-libs-8.4.3-1.fc13.x86_64 (gdb) p op $1 =3D (Operation *) 0x7fffffffd4d0 (gdb) p op->o_bd $2 =3D (BackendDB *) 0x0 (gdb) p *op $3 =3D {o_hdr =3D 0x7fffffffd640, o_tag =3D 99, o_time =3D 1271737105, o_ti= ncr =3D 1, o_bd =3D 0x0, o_req_dn =3D {bv_len =3D 0, bv_val =3D 0x0}, o_req_ndn =3D {bv_len =3D 0, bv_val =3D 0x0}, o_request =3D {oq_add =3D {rs_modlist =3D 0= x0, rs_e =3D 0x0}, oq_bind =3D { rb_method =3D 0, rb_cred =3D {bv_len =3D 0, bv_val =3D 0x0}, rb_edn = =3D {bv_len =3D 0, bv_val =3D 0x0}, rb_ssf =3D 0, rb_mech =3D {bv_len =3D 0, bv= _val =3D 0x0}}, oq_compare =3D {rs_ava =3D 0x0}, oq_modify =3D {rs_mods =3D {rs_modl= ist =3D 0x0,=20 rs_no_opattrs =3D 0 '\000'}, rs_increment =3D 0}, oq_modrdn =3D {rs_mods =3D {rs_modlist =3D 0x0, rs_no_opattrs =3D 0 '\000'}, rs_deleteold= rdn =3D 0, rs_newrdn =3D {bv_len =3D 0, bv_val =3D 0x0}, rs_nnewrdn =3D {bv_len= =3D 0, bv_val =3D 0x0},=20 rs_newSup =3D 0x0, rs_nnewSup =3D 0x0}, oq_search =3D {rs_scope =3D 0= , rs_deref =3D 0, rs_slimit =3D 0, rs_tlimit =3D 0, rs_limit =3D 0x0, rs_attr= sonly =3D 0, rs_attrs =3D 0x0, rs_filter =3D 0x0, rs_filterstr =3D {bv_len =3D 0,= bv_val =3D 0x0}},=20 oq_abandon =3D {rs_msgid =3D 0}, oq_cancel =3D {rs_msgid =3D 0}, oq_ext= ended =3D {rs_reqoid =3D {bv_len =3D 0, bv_val =3D 0x0}, rs_flags =3D 0, rs_reqda= ta =3D 0x0}, oq_pwdexop =3D {rs_extended =3D {rs_reqoid =3D {bv_len =3D 0, bv_val = =3D 0x0}, rs_flags =3D 0,=20 rs_reqdata =3D 0x0}, rs_old =3D {bv_len =3D 0, bv_val =3D 0x0}, rs_= new =3D {bv_len =3D 0, bv_val =3D 0x0}, rs_mods =3D 0x0, rs_modtail =3D 0x0}}, o_ab= andon =3D 0, o_cancel =3D 0, o_groups =3D 0x0, o_do_not_cache =3D 0 '\000', o_is_auth_check =3D 0 '\000',=20 o_dont_replicate =3D 0 '\000', o_acl_priv =3D ACL_NONE, o_nocaching =3D 0 '\000', o_delete_glue_parent =3D 0 '\000', o_no_schema_check =3D 0 '\000', o_no_subordinate_glue =3D 0 '\000', o_ctrlflag =3D '\000' <repeats 31 times>,=20 o_controls =3D 0x7fffffffd788, o_authz =3D {sai_method =3D 0, sai_mech = =3D {bv_len =3D 0, bv_val =3D 0x0}, sai_dn =3D {bv_len =3D 0, bv_val =3D 0x0}, = sai_ndn =3D {bv_len =3D 0, bv_val =3D 0x0}, sai_ssf =3D 0, sai_transport_ssf =3D 0, sai_tls_ssf =3D 0,=20 sai_sasl_ssf =3D 0}, o_ber =3D 0x0, o_res_ber =3D 0x0, o_callback =3D 0= x0, o_ctrls =3D 0x0, o_csn =3D {bv_len =3D 0, bv_val =3D 0x0}, o_private =3D 0x= 0, o_extra =3D {slh_first =3D 0x0}, o_next =3D {stqe_next =3D 0x0}} (gdb)=20

--=20 Andrew Bartlett http://samba.org/~abartlet/ Authentication Developer, Samba Team http://samba.org Samba Developer, Cisco Inc.

--=-5geAzHYesMuCPweb8j5I Content-Disposition: attachment; filename="add-rdnval.patch" Content-Transfer-Encoding: base64 Content-Type: text/x-patch; name="add-rdnval.patch"; charset="UTF-8"

ZGlmZiAtLWdpdCBhL3NvdXJjZTQvc2V0dXAvc2xhcGQuY29uZiBiL3NvdXJjZTQvc2V0dXAvc2xh cGQuY29uZg0KaW5kZXggMDA3N2EyMi4uZTVmY2QwNiAxMDA2NDQNCi0tLSBhL3NvdXJjZTQvc2V0 dXAvc2xhcGQuY29uZg0KKysrIGIvc291cmNlNC9zZXR1cC9zbGFwZC5jb25mDQpAQCAtNDksNiAr NDksNyBAQCBkZWZhdWx0c2VhcmNoYmFzZSAke0RPTUFJTkROfQ0KIHJvb3RkbiBjbj1NYW5hZ2Vy DQogDQogb3ZlcmxheSBkZXJlZg0KK292ZXJsYXkgcmRudmFsDQogDQogJHtSRUZJTlRfQ09ORklH fQ0KIA0K

--=-5geAzHYesMuCPweb8j5I--

--=-JaZE3OeFLXsBmyVf+gjk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part

--=-JaZE3OeFLXsBmyVf+gjk--