Hi Ryan,

Thank you for your review.

On Thu, 3 Oct 2019 at 13:05, Ryan Tandy wrote:

Thanks for providing the patches. I have reviewed and tested them, everything I could think of works properly.

Excellent! :)

As a personal opinion I might prefer shorter descriptions, for example "OpenLDAP ASN.1 Basic Encoding Rules library for LDAP" and "OpenLDAP Lightweight Directory Access Protocol library (reentrant version)". Only an opinion, there's nothing wrong with what you wrote.

I'm happy for the descriptions to be whatever describes the libraries best. I particularly like your shortened ASN.1 description.

I'd like to see this included, however a more senior team member should approve it first. Good luck!

Thanks. Hopefully that will happen soon.

Kind regards, Hugh