On pe, 14 kesä 2019, Ondřej Kuzník wrote:

On Thu, Oct 19, 2017 at 03:39:24PM +0000, quanah@symas.com wrote:

...

--On Thursday, October 19, 2017 10:20 AM +0300 Alexander Bokovoy abokovoy@redhat.com wrote:

...

Hi Quanah,

On ti, 12 syys 2017, Quanah Gibson-Mount wrote:

...

Hi Alexander,

Your submission appears to be missing an IPR statement as noted at https://www.openldap.org/devel/contributing.html#notice. This is required for your submission to be evaluated. Please add an IPR at your earliest convenience.

Attached is a re-based patch set since there were changes in git master in last month or so that affected the same area.

There are two patches: one for git master, one for 2.4 branch. Since there is no functional change in the code, I'd like to see the 2.4 version in an upcoming release as that would greatly help Samba.

I'm also including an IPR notice below:

Red Hat, Inc. hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

Thanks very much! I'll get this into my scratch repo for review.

Hi Alexander, as of commit 6a5e30674b63b17587738ba9a3d1ea3633c33fb1, OpenLDAP master now ships and installs a new header <openldap.h> that should expose ldap_init_fd(). Could you check this will work for Samba before we apply this change in 2.4?

Thanks. I've compiled openldap git master and installed it, I can see $prefix/include/openldap.h with ldap_init_fd() and man pages have proper references to openldap.h.

Looks good to me. Once 2.4 becomes available, we can add support of this to Samba.