On 09/01/2017 02:38 PM, Howard Chu wrote:

vladimir.cunat@nic.cz wrote:

...

The documentation of txn_commit did confuse me (as well). https://github.com/LMDB/lmdb/blob/LMDB_0.9.21/libraries/liblmdb/lmdb.h#L994

Would you consider adding a line stressing that the txn gets released even in case any error is returned? (or something similar) I'm personally used to failing operations not "having externally observable effects" unless explicitly stated.

The very first words on the line you highlight are "The transaction handle is freed." I don't know how to state that any more explicitly.

Well, okay. (I knew the line stated it and still it somehow didn't make me sure, but it's perhaps just me.)