Re: (ITS#8928) Reproducibility: Remove user, hostname, pwd from version string

URL: ftp://ftp.openldap.org/incoming/douglas-royds-181120.patch

On 19/11/18 12:34 PM, Howard Chu wrote:

Thanks. According to this link, we shouldn't even need the date/time portion of this patch.

Under the section "Reading the Variable" we have

...

gcc (>= 7, Debian >= 5.3.1-17, Debian >= 6.1.1-1)

https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=e3e8c48c4a494d9da741c1c8ea...

I.e., gcc itself will set __DATE__ and __TIME__ accordingly if SOURCE_DATE_EPOCH is set.

I'm inclined to just tweak WHOWHERE and let gcc handle the rest.

Once again, good point. I have removed the date and time changes from the patch, and only kept the WHOWHERE change, still using the existence of a SOURCE_DATE_EPOCH to decide whether to fix the string or not.