On Tue, Sep 12, 2017 at 12:55:20PM +0000, okuznik@symas.com wrote:
The patch series in the linked archive changes the logging macros to be fully variadic:
There is a new archive at: ftp://ftp.openldap.org/incoming/debug_macro_refactor_v2.tgz
This addresses concerns that it should still be possible to build libldap (only) on compilers that might not support variadic macros. All patches are generated from the attached .cocci files against current master (commit 9069cbe543d079e9d7f55162decb8e732fc32338).
I would welcome some review of the patch 01-logging.patch, which consists of the actual implementation. Rest is just to bring OpenLDAP up to scratch.
At the end of the series, OpenLDAP seems to compile with CFLAGS containing -Werror=format-extra-args.