openldap-bugs

openldap-bugs@openldap.org

1 participants
20959 discussions

Re: (ITS#7885) [PATCH] wrong RPATH in contrib/passwd/Makefile
by hyc＠symas.com 30 Jun '14

30 Jun '14

ryan(a)nardis.ca wrote: > Full_Name: Ryan Tandy > Version: master > OS: Debian unstable > URL: > Submission from: (NULL) (24.68.121.206) > > > Similar to #7858, another easy patch. Thanks, committed to master. > > >>From 3047469eb717018e5b292352626cd084477faf12 Mon Sep 17 00:00:00 2001 > From: Ryan Tandy <ryan(a)nardis.ca> > Date: Fri, 27 Jun 2014 11:15:26 -0700 > Subject: [PATCH] fix contrib/passwd RPATH > > --- > contrib/slapd-modules/passwd/Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/contrib/slapd-modules/passwd/Makefile > b/contrib/slapd-modules/passwd/Makefile > index ba41304..c240366 100644 > --- a/contrib/slapd-modules/passwd/Makefile > +++ b/contrib/slapd-modules/passwd/Makefile > @@ -33,19 +33,19 @@ all: $(PROGRAMS) > > pw-kerberos.la: kerberos.lo > $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ > - -rpath $(PREFIX)/lib -module -o $@ $? -lkrb5 > + -rpath $(moduledir) -module -o $@ $? -lkrb5 > > pw-netscape.la: netscape.lo > $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ > - -rpath $(PREFIX)/lib -module -o $@ $? > + -rpath $(moduledir) -module -o $@ $? > > pw-radius.la: radius.lo > $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ > - -rpath $(PREFIX)/lib -module -o $@ $? -lradius > + -rpath $(moduledir) -module -o $@ $? -lradius > > pw-apr1.la: apr1.lo > $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ > - -rpath $(PREFIX)/lib -module -o $@ $? > + -rpath $(moduledir) -module -o $@ $? > > clean: > rm -rf *.o *.lo *.la .libs > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

ITS#7884 Not able to communicate with secure ldap
by hyc＠symas.com 30 Jun '14

30 Jun '14

The version of OpenLDAP you're using is 6 years old and no longer supported by the OpenLDAP Project. The configuration you're using is invalid, read the ldap.conf(5) manpage. There is no bug in OpenLDAP Software here, this ITS will be closed. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7886) mdb_ovpage_free() can break mdb_copy
by hyc＠symas.com 30 Jun '14

30 Jun '14

h.b.furuseth(a)usit.uio.no wrote: > Full_Name: Hallvard B Furuseth > Version: LMDB_0.9.13 > OS: Linux x86_64 > URL: > Submission from: (NULL) (81.191.45.35) > Submitted by: hallvard > > > Allocate an ovpage from mt_next_pgno, mdb_ovpage_free() it > and commit: The datafile may end before MDB_meta.mm_last_pg > since the ovpage was never written. mdb_env_copyfd() & co > break when they read the file to mm_last_pg. fixed in mdb.master > > Same with loose pages if mdb_page_flush() skipped them, > which it could: ecde3a4008f5080d8264926f49680db27804787f > in my branch mdb/loose3. > > Bug demo: > > rm data.mdb; ./a.out && ./mdb_copy . > copy.mdb > ./mdb_copy: copying failed, error 14 (Bad address) > > (Piping it to /dev/null succeeds on Linux, apparently > it doesn't read anything.) > > #include "lmdb.h" > #include <stdio.h> > #include <stdlib.h> > #define E(expr) CHECK((rc = (expr)) == MDB_SUCCESS, #expr) > #define CHECK(test, msg) ((test) ? (void)0 : ((void)fprintf(stderr, \ > "%s:%d: %s: %s\n", __FILE__, __LINE__, msg, mdb_strerror(rc)), abort())) > > int main(void) > { > int rc; > unsigned sz; > MDB_env *env; > MDB_txn *txn; > MDB_dbi dbi; > static char buf[20000]; > E(mdb_env_create(&env)); > E(mdb_env_open(env, ".", 0, 0664)); > for (sz = 0; sz<=sizeof(buf); sz = (sz==2 ? sizeof(buf) : sz+1)) { > E(mdb_txn_begin(env, NULL, 0, &txn)); > E(mdb_dbi_open(txn, NULL, 0, &dbi)); > E(mdb_put(txn, dbi, &(MDB_val){4,&sz}, &(MDB_val){sz,buf}, 0)); > if (sz) > E(mdb_del(txn, dbi, &(MDB_val){4,&sz}, NULL)); > E(mdb_txn_commit(txn)); > } > mdb_env_close(env); > return 0; > } > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7887) mkrelease breaks on building guide.html
by hyc＠symas.com 30 Jun '14

30 Jun '14

openldap(a)semyon.org wrote: > Full_Name: Semyon Chaichenets > Version: 2.4.39 > OS: Linux 3.2.0-64-generic #97-Ubuntu SMP Wed Jun 4 22:04:21 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux > URL: https://gist.githubusercontent.com/leveche/307be9cb9de55c4085d8/raw/9a1ce68… > Submission from: (NULL) (69.165.226.82) > > > Trivial typo in doc/guide/admin/install.sdf breaks mkrelease in current HEAD > (f6eacdb). Trivial fix included. > > Fixed now in master, thanks. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#7887) mkrelease breaks on building guide.html
by openldap＠semyon.org 30 Jun '14

30 Jun '14

Full_Name: Semyon Chaichenets Version: 2.4.39 OS: Linux 3.2.0-64-generic #97-Ubuntu SMP Wed Jun 4 22:04:21 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux URL: https://gist.githubusercontent.com/leveche/307be9cb9de55c4085d8/raw/9a1ce68… Submission from: (NULL) (69.165.226.82) Trivial typo in doc/guide/admin/install.sdf breaks mkrelease in current HEAD (f6eacdb). Trivial fix included.

1 0

(ITS#7886) mdb_ovpage_free() can break mdb_copy
by h.b.furuseth＠usit.uio.no 28 Jun '14

28 Jun '14

Full_Name: Hallvard B Furuseth Version: LMDB_0.9.13 OS: Linux x86_64 URL: Submission from: (NULL) (81.191.45.35) Submitted by: hallvard Allocate an ovpage from mt_next_pgno, mdb_ovpage_free() it and commit: The datafile may end before MDB_meta.mm_last_pg since the ovpage was never written. mdb_env_copyfd() & co break when they read the file to mm_last_pg. Same with loose pages if mdb_page_flush() skipped them, which it could: ecde3a4008f5080d8264926f49680db27804787f in my branch mdb/loose3. Bug demo: rm data.mdb; ./a.out && ./mdb_copy . > copy.mdb ./mdb_copy: copying failed, error 14 (Bad address) (Piping it to /dev/null succeeds on Linux, apparently it doesn't read anything.) #include "lmdb.h" #include <stdio.h> #include <stdlib.h> #define E(expr) CHECK((rc = (expr)) == MDB_SUCCESS, #expr) #define CHECK(test, msg) ((test) ? (void)0 : ((void)fprintf(stderr, \ "%s:%d: %s: %s\n", __FILE__, __LINE__, msg, mdb_strerror(rc)), abort())) int main(void) { int rc; unsigned sz; MDB_env *env; MDB_txn *txn; MDB_dbi dbi; static char buf[20000]; E(mdb_env_create(&env)); E(mdb_env_open(env, ".", 0, 0664)); for (sz = 0; sz<=sizeof(buf); sz = (sz==2 ? sizeof(buf) : sz+1)) { E(mdb_txn_begin(env, NULL, 0, &txn)); E(mdb_dbi_open(txn, NULL, 0, &dbi)); E(mdb_put(txn, dbi, &(MDB_val){4,&sz}, &(MDB_val){sz,buf}, 0)); if (sz) E(mdb_del(txn, dbi, &(MDB_val){4,&sz}, NULL)); E(mdb_txn_commit(txn)); } mdb_env_close(env); return 0; }

1 0

(ITS#7885) [PATCH] wrong RPATH in contrib/passwd/Makefile
by ryan＠nardis.ca 27 Jun '14

27 Jun '14

Full_Name: Ryan Tandy Version: master OS: Debian unstable URL: Submission from: (NULL) (24.68.121.206) Similar to #7858, another easy patch. >From 3047469eb717018e5b292352626cd084477faf12 Mon Sep 17 00:00:00 2001 From: Ryan Tandy <ryan(a)nardis.ca> Date: Fri, 27 Jun 2014 11:15:26 -0700 Subject: [PATCH] fix contrib/passwd RPATH --- contrib/slapd-modules/passwd/Makefile | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/slapd-modules/passwd/Makefile b/contrib/slapd-modules/passwd/Makefile index ba41304..c240366 100644 --- a/contrib/slapd-modules/passwd/Makefile +++ b/contrib/slapd-modules/passwd/Makefile @@ -33,19 +33,19 @@ all: $(PROGRAMS) pw-kerberos.la: kerberos.lo $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ - -rpath $(PREFIX)/lib -module -o $@ $? -lkrb5 + -rpath $(moduledir) -module -o $@ $? -lkrb5 pw-netscape.la: netscape.lo $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ - -rpath $(PREFIX)/lib -module -o $@ $? + -rpath $(moduledir) -module -o $@ $? pw-radius.la: radius.lo $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ - -rpath $(PREFIX)/lib -module -o $@ $? -lradius + -rpath $(moduledir) -module -o $@ $? -lradius pw-apr1.la: apr1.lo $(LIBTOOL) --mode=link $(CC) $(OPT) -version-info $(LTVER) \ - -rpath $(PREFIX)/lib -module -o $@ $? + -rpath $(moduledir) -module -o $@ $? clean: rm -rf *.o *.lo *.la .libs -- 2.0.0

1 0

Re: (ITS#7851) [PATCH] buffer overrun in password checkers with malformed hash
by ryan＠nardis.ca 27 Jun '14

27 Jun '14

This is a multi-part message in MIME format. --------------070104060109070008020807 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I checked the new pw-pbkdf2 module. It doesn't appear to be affected by this problem. On 11/05/14 07:56 PM, Ryan Tandy wrote: > ftp://ftp.openldap.org/incoming/rtandy_20140511_fix-passwd-b64-buffer_v2.pa… You probably know this, but just in case it helps: "git am --keep-cr" is the way to apply that patch, because of apr1.c's line endings. There's a second bug in slapd-sha2.c, a missing cast causing the return value of lutil_b64_pton to be ignored. The built-in checkers already have the appropriate cast. Patch attached. --------------070104060109070008020807 Content-Type: text/x-patch; name="0002-ITS-7851-contrib-pw-sha2-fix-int-size_t-comparison.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0002-ITS-7851-contrib-pw-sha2-fix-int-size_t-comparison.patc"; filename*1="h" >From 0683ded766e51e0521991fc1a5d2303cf95cc475 Mon Sep 17 00:00:00 2001 From: Ryan Tandy <ryan(a)nardis.ca> Date: Thu, 26 Jun 2014 18:33:29 -0700 Subject: [PATCH 2/2] ITS#7851 contrib pw-sha2 fix int/size_t comparison --- contrib/slapd-modules/passwd/sha2/slapd-sha2.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/slapd-modules/passwd/sha2/slapd-sha2.c b/contrib/slapd-modules/passwd/sha2/slapd-sha2.c index 1ec7989..2e4fcb0 100644 --- a/contrib/slapd-modules/passwd/sha2/slapd-sha2.c +++ b/contrib/slapd-modules/passwd/sha2/slapd-sha2.c @@ -244,7 +244,7 @@ static int chk_ssha256( rc = lutil_b64_pton(passwd->bv_val, orig_pass, decode_len); - if( rc <= sizeof(SHAdigest) ) { + if( rc <= (int)(sizeof(SHAdigest)) ) { ber_memfree(orig_pass); return LUTIL_PASSWD_ERR; } @@ -332,7 +332,7 @@ static int chk_ssha384( rc = lutil_b64_pton(passwd->bv_val, orig_pass, decode_len); - if( rc <= sizeof(SHAdigest) ) { + if( rc <= (int)(sizeof(SHAdigest)) ) { ber_memfree(orig_pass); return LUTIL_PASSWD_ERR; } @@ -420,7 +420,7 @@ static int chk_ssha512( rc = lutil_b64_pton(passwd->bv_val, orig_pass, decode_len); - if( rc <= sizeof(SHAdigest) ) { + if( rc <= (int)(sizeof(SHAdigest)) ) { ber_memfree(orig_pass); return LUTIL_PASSWD_ERR; } -- 2.0.0 --------------070104060109070008020807--

1 0

Re: (ITS#7878) OpenLDAP MinGW Build Problem
by ron＠zytrax.com 27 Jun '14

27 Jun '14

Additional Information re ITS#7878 omitted from original report: The build did not (correctly) auto-detect either Openssl or SASL which may make it a pretty unusual build case. On 20/06/2014 4:44 PM, openldap-its(a)OpenLDAP.org wrote: > *** THIS IS AN AUTOMATICALLY GENERATED REPLY *** > > Thanks for your report to the OpenLDAP Issue Tracking System. Your > report has been assigned the tracking number ITS#7878. > > One of our support engineers will look at your report in due course. > Note that this may take some time because our support engineers > are volunteers. They only work on OpenLDAP when they have spare > time. > > If you need to provide additional information in regards to your > issue report, you may do so by replying to this message. Note that > any mail sent to openldap-its(a)openldap.org with (ITS#7878) > in the subject will automatically be attached to the issue report. > > mailto:openldap-its@openldap.org?subject=(ITS#7878) > > You may follow the progress of this report by loading the following > URL in a web browser: > http://www.OpenLDAP.org/its/index.cgi?findid=7878 > > Please remember to retain your issue tracking number (ITS#7878) > on any further messages you send to us regarding this report. If > you don't then you'll just waste our time and yours because we > won't be able to properly track the report. > > Please note that the Issue Tracking System is not intended to > be used to seek help in the proper use of OpenLDAP Software. > Such requests will be closed. > > OpenLDAP Software is user supported. > http://www.OpenLDAP.org/support/ > > -------------- > Copyright 1998-2007 The OpenLDAP Foundation, All Rights Reserved. > > -- Ron Aitchison www.zytrax.com ZYTRAX ron(a)zytrax.com tel: 514-315-4296 Suite 22 6201 Chemin Cote St. Luc Hampstead QC H3X 2H2 Canada Author: Pro DNS and BIND (Apress) ISBN 1-59059-494-0

1 0

Re: (ITS#7877) please make gcrypt optional with newer gnutls
by ryan＠nardis.ca 23 Jun '14

23 Jun '14

On Fri, Jun 20, 2014 at 5:23 PM, Ryan Tandy <ryan(a)nardis.ca> wrote: > This might be a better patch, if the build system change is acceptable. As usual, I can't get anything right on the first try. That one was missing a line (but apparently not one that stopped it from building or working); and besides that I'm not supposed to be attaching these in the first place, right? Proper patch series against current master: ftp://ftp.openldap.org/incoming/20140623-rtandy-0001-ITS-7877-detect-whethe… ftp://ftp.openldap.org/incoming/20140623-rtandy-0002-ITS-7877-support-nettl… Sorry for the noise, administer cluehammer as necessary...

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs