openldap-bugs

openldap-bugs@openldap.org

1 participants
21065 discussions

Re: (ITS#7977) Supported PBKDF2-SHA256 and PBKDF2-SHA512
by luca.bruno＠rocket-internet.de 11 Dec '14

11 Dec '14

> with a corresponding IPR statement as outlined in > our Contributors guidelines. I was (wrongly) assuming that the explicit "Signed-off-by" line in each patch was enough to express this from my side. Just to be more explicit, here is the IPR statement for my part of the patch: """ The attached patch is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Luca Bruno, on behalf of "Rocket Internet AG". By virtue of my employment agreement with "Rocket Internet AG", I have assigned my rights and interest in this work to "Rocket Internet AG". "Rocket Internet AG" has not assigned rights and/or interest in this work to any party. I, Luca Bruno am authorized by "Rocket Internet AG", my employer, to release this work under the following terms. "Rocket Internet AG" hereby places the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. """ Cheers, Luca PS. I would suggest to explicitly CC third-parties when you are missing IPR info, as I was not aware that this ticket was waiting for input on my side. -- Luca Bruno (kaeso) Security Engineer Rocket Internet AG -> GPG Key ID: 0x4F3BBEBF

1 0

Re: (ITS#8001) Segmentation Fault in ldap_sync_*
by hyc＠symas.com 10 Dec '14

10 Dec '14

alexey(a)kireyev.name wrote: > Full_Name: Alexey Kireyev > Version: 2.4.40 > OS: Ubuntu 14.04 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (98.118.88.65) > > > If not all fields in ldap_sync_t manually set after ldap_sync_initialize, then > any following calls might (and most probably will) ends in segmentation fault. > > Reason: ldap_sync_initialize doesn't zeroed newly allocated structure (it does > it for pre-existing, though, which is wrong by itself in my view) Thanks, you're right. fixed in master. > > > > > -------------------------------------------------------------------------------------------------------- > > >>From 01149a2eba9f463261d88e5a1ce43e19c4a323cf Mon Sep 17 00:00:00 2001 > From: Alexey Kireyev <alexey(a)kireyev.name> > Date: Wed, 10 Dec 2014 14:37:16 -0500 > Subject: [PATCH] Newly allocated ldap_sync_t has to be zero out > > --- > libraries/libldap/ldap_sync.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libraries/libldap/ldap_sync.c b/libraries/libldap/ldap_sync.c > index e573c3b..e79153f 100644 > --- a/libraries/libldap/ldap_sync.c > +++ b/libraries/libldap/ldap_sync.c > @@ -64,11 +64,10 @@ ldap_sync_initialize( ldap_sync_t *ls_in )D%D > if ( ls == NULL ) { > return NULL; > } > - > - } else { > - memset( ls, 0, sizeof( ldap_sync_t ) ); > } > > + memset( ls, 0, sizeof( ldap_sync_t ) ); > + > ls->ls_scope = LDAP_SCOPE_SUBTREE; > ls->ls_timeout = -1; > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7998) no-return-in-nonvoid-function noopsrch.c:145
by michael＠stroeder.com 10 Dec '14

10 Dec '14

hyc(a)symas.com wrote: > michael(a)stroeder.com wrote: >> As I read noopsrch_response there's a else {} clause missing. >> But I'm not sure. > > Yes, but not important. Unfortunately the build is blocked on openSUSE build system because of this. There may be a way to work around it but I don't know how. Ciao, Michael.

1 0

Re: (ITS#8000) Warnings building contrib overlay passwd/sha2
by hyc＠symas.com 10 Dec '14

10 Dec '14

michael(a)stroeder.com wrote: > Full_Name: > Version: RE24 > OS: > URL: > Submission from: (NULL) (79.227.174.182) > > > HI! > > I'm trying to package passwd/sha2 for openSUSE. > The default compiler options in their build system results in these warnings: Fixed in master. The note about compilers breaking this code is spurious. Any compiler that failed to properly compile the previous code would itself be broken. > > [ 193s] + CFLAGS='-fomit-frame-pointer -fmessage-length=0 -grecord-gcc-switches > -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables > -fasynchronous-unwind-tables -g -Wno-format-extra-args -fno-strict-aliasing' > [ 193s] + make -j4 sysconfdir=/etc/openldap libdir=/usr/lib > libexecdir=/usr/lib > [ 193s] ../../../../libtool --mode=compile gcc -g -O2 -Wall > -I..%2.%./../../include -I../../../../include -I../../../../servers/slapd -c > slapd-sha2.c > [ 193s] ../../../../libtool --mode=compile gcc -g -O2 -Wall > -I../../../../include -I../../../../include -I../../../../servers/slapd -c > sha2.c > [ 193s] mkdir .libs > [ 193s] mkdir .libs > [ 193s] mkdir: cannot create directory '.libs': File exists > [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include > -I../../../../servers/slapd -c sha2.c -fPIC -DPIC -o .libs/sha2.o > [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include > -I../../../../servers/slapd -c slapd-sha2.c -fPIC -DPIC -o .libs/slapd-sha2.o > [ 193s] sha2.c: In function 'SHA256_Final': > [ 193s] sha2.c:608:3: warning: dereferencing type-punned pointer will break > strict-aliasing rules [-Wstrict-aliasing] > [ 193s] *(sha2_word64*)&context->buffer[SHA256_SHORT_BLOCK_LENGTH] = > context->bitcount; > [ 193s] ^ > [ 193s] sha2.c: In function 'SHA512_Last': > [ 193s] sha2.c:925:2: warning: dereferencing type-punned pointer will break > strict-aliasing rules [-Wstrict-aliasing] > [ 193s] *(sha2_word64*)&context->buffer[SHA512_SHORT_BLOCK_LENGTH] = > context->bitcount[1]; > [ 193s] ^ > [ 193s] sha2.c:926:2: warning: dereferencing type-punned pointer will break > strict-aliasing rules [-Wstrict-aliasing] > [ 193s] *(sha2_word64*)&context->buffer[SHA512_SHORT_BLOCK_LENGTH+8] = > context->bitcount[0]; > [ 193s] ^ > [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include > -I../../../../servers/slapd -c slapd-sha2.c -o slapd-sha2.o >/dev/null > 2>&1 > [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include > -I../../../../servers/slapd -c sha2.c -o sha2.o >/dev/null 2>&1 > [ 194s] ../../../../libtool --mode=link gcc -g -O2 -Wall -version-info 0:0:0 \ > [ 194s] -rpath /usr/lib/openldap -module -o pw-sha2.la slapd-sha2.lo sha2.lo > ../../../../libraries/libldap_r/libldap_r.la > ../../../../libraries/liblber/liblber.la > [ 194s] cc -shared .libs/slapd-sha2.o .libs/sha2.o -Wl,--rpath > -Wl,/home/abuild/rpmbuild/BUILD/openldap-2.4.40/libraries/libldap_r/.libs > -Wl,--rpath -Wl,/home/abuild/rpmbuild/BUILD/openldap-2.4.40/libraries/liblber/.libs > -L/home/abuild/rpmbuild/BUILD/openldap-2.4.40/libraries/liblber/.libs > ../../../../libraries/libldap_r/.libs/libldap_r.so > ../../../../libraries/liblber/.libs/liblber.so -Wl,-soname -Wl,pw-sha2.so.0 -o > .libs/pw-sha2.so.0.0.0 > [ 194s] (cd .libs && rm -f pw-sha2.so.0 && ln -s > pw-sha2.so.0.0.0 pw-sha2.so.0) > [ 194s] (cd .libs && rm -f pw-sha2.so && ln -s pw-sha2.so.0.0.0 > pw-sha2.so) > [ 194s] ar cru .libs/pw-sha2.a slapd-sha2.o sha2.o > [ 194s] ranlib .libs/pw-sha2.a > [ 194s] creating pw-sha2.la > > > Overall RPM build fails with: > > [ 262s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing. > [ 262s] W: openldap2 strict-aliasing-punning sha2.c:608, 925, 926 > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7998) no-return-in-nonvoid-function noopsrch.c:145
by hyc＠symas.com 10 Dec '14

10 Dec '14

michael(a)stroeder.com wrote: > As I read noopsrch_response there's a else {} clause missing. > But I'm not sure. Yes, but not important. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7998) no-return-in-nonvoid-function noopsrch.c:145
by hyc＠symas.com 10 Dec '14

10 Dec '14

michael(a)stroeder.com wrote: > Full_Name: > Version: RE24 > OS: > URL: > Submission from: (NULL) (79.227.174.182) > > > Building slapo- (contrib/) with strict warnings results in: > > no-return-in-nonvoid-function noopsrch.c:145 > > Fixed in master -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#7997) no-return-in-nonvoid-function dupent.c:367
by hyc＠symas.com 10 Dec '14

10 Dec '14

michael(a)stroeder.com wrote: > Full_Name: > Version: > OS: > URL: > Submission from: (NULL) (79.227.174.182) > > > Building slapo-dupent (contrib/) with strict warnings results in: > > no-return-in-nonvoid-function dupent.c:367 > > > Fixed in master -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8001) Segmentation Fault in ldap_sync_*
by alexey＠kireyev.name 10 Dec '14

10 Dec '14

Full_Name: Alexey Kireyev Version: 2.4.40 OS: Ubuntu 14.04 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (98.118.88.65) If not all fields in ldap_sync_t manually set after ldap_sync_initialize, then any following calls might (and most probably will) ends in segmentation fault. Reason: ldap_sync_initialize doesn't zeroed newly allocated structure (it does it for pre-existing, though, which is wrong by itself in my view) -------------------------------------------------------------------------------------------------------- >From 01149a2eba9f463261d88e5a1ce43e19c4a323cf Mon Sep 17 00:00:00 2001 From: Alexey Kireyev <alexey(a)kireyev.name> Date: Wed, 10 Dec 2014 14:37:16 -0500 Subject: [PATCH] Newly allocated ldap_sync_t has to be zero out --- libraries/libldap/ldap_sync.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libraries/libldap/ldap_sync.c b/libraries/libldap/ldap_sync.c index e573c3b..e79153f 100644 --- a/libraries/libldap/ldap_sync.c +++ b/libraries/libldap/ldap_sync.c @@ -64,11 +64,10 @@ ldap_sync_initialize( ldap_sync_t *ls_in )D%D if ( ls == NULL ) { return NULL; } - - } else { - memset( ls, 0, sizeof( ldap_sync_t ) ); } + memset( ls, 0, sizeof( ldap_sync_t ) ); + ls->ls_scope = LDAP_SCOPE_SUBTREE; ls->ls_timeout = -1; -- 1.9.1 The attached patch file is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Alexey Kireyev alexey(a)kireyev.name. I have not assigned rights and/or interest in this work to any party. I, Alexey Kireyev, hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

1 0

(ITS#8000) Warnings building contrib overlay passwd/sha2
by michael＠stroeder.com 10 Dec '14

10 Dec '14

Full_Name: Version: RE24 OS: URL: Submission from: (NULL) (79.227.174.182) HI! I'm trying to package passwd/sha2 for openSUSE. The default compiler options in their build system results in these warnings: [ 193s] + CFLAGS='-fomit-frame-pointer -fmessage-length=0 -grecord-gcc-switches -fstack-protector -O2 -Wall -D_FORTIFY_SOURCE=2 -funwind-tables -fasynchronous-unwind-tables -g -Wno-format-extra-args -fno-strict-aliasing' [ 193s] + make -j4 sysconfdir=/etc/openldap libdir=/usr/lib libexecdir=/usr/lib [ 193s] ../../../../libtool --mode=compile gcc -g -O2 -Wall -I..%2.%./../../include -I../../../../include -I../../../../servers/slapd -c slapd-sha2.c [ 193s] ../../../../libtool --mode=compile gcc -g -O2 -Wall -I../../../../include -I../../../../include -I../../../../servers/slapd -c sha2.c [ 193s] mkdir .libs [ 193s] mkdir .libs [ 193s] mkdir: cannot create directory '.libs': File exists [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include -I../../../../servers/slapd -c sha2.c -fPIC -DPIC -o .libs/sha2.o [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include -I../../../../servers/slapd -c slapd-sha2.c -fPIC -DPIC -o .libs/slapd-sha2.o [ 193s] sha2.c: In function 'SHA256_Final': [ 193s] sha2.c:608:3: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] [ 193s] *(sha2_word64*)&context->buffer[SHA256_SHORT_BLOCK_LENGTH] = context->bitcount; [ 193s] ^ [ 193s] sha2.c: In function 'SHA512_Last': [ 193s] sha2.c:925:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] [ 193s] *(sha2_word64*)&context->buffer[SHA512_SHORT_BLOCK_LENGTH] = context->bitcount[1]; [ 193s] ^ [ 193s] sha2.c:926:2: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] [ 193s] *(sha2_word64*)&context->buffer[SHA512_SHORT_BLOCK_LENGTH+8] = context->bitcount[0]; [ 193s] ^ [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include -I../../../../servers/slapd -c slapd-sha2.c -o slapd-sha2.o >/dev/null 2>&1 [ 193s] gcc -g -O2 -Wall -I../../../../include -I../../../../include -I../../../../servers/slapd -c sha2.c -o sha2.o >/dev/null 2>&1 [ 194s] ../../../../libtool --mode=link gcc -g -O2 -Wall -version-info 0:0:0 \ [ 194s] -rpath /usr/lib/openldap -module -o pw-sha2.la slapd-sha2.lo sha2.lo ../../../../libraries/libldap_r/libldap_r.la ../../../../libraries/liblber/liblber.la [ 194s] cc -shared .libs/slapd-sha2.o .libs/sha2.o -Wl,--rpath -Wl,/home/abuild/rpmbuild/BUILD/openldap-2.4.40/libraries/libldap_r/.libs -Wl,--rpath -Wl,/home/abuild/rpmbuild/BUILD/openldap-2.4.40/libraries/liblber/.libs -L/home/abuild/rpmbuild/BUILD/openldap-2.4.40/libraries/liblber/.libs ../../../../libraries/libldap_r/.libs/libldap_r.so ../../../../libraries/liblber/.libs/liblber.so -Wl,-soname -Wl,pw-sha2.so.0 -o .libs/pw-sha2.so.0.0.0 [ 194s] (cd .libs && rm -f pw-sha2.so.0 && ln -s pw-sha2.so.0.0.0 pw-sha2.so.0) [ 194s] (cd .libs && rm -f pw-sha2.so && ln -s pw-sha2.so.0.0.0 pw-sha2.so) [ 194s] ar cru .libs/pw-sha2.a slapd-sha2.o sha2.o [ 194s] ranlib .libs/pw-sha2.a [ 194s] creating pw-sha2.la Overall RPM build fails with: [ 262s] I: Program is likely to break with new gcc. Try -fno-strict-aliasing. [ 262s] W: openldap2 strict-aliasing-punning sha2.c:608, 925, 926

1 0

(ITS#7999) proxycache failed for bdb while testing
by yjd＠zjca.com.cn 10 Dec '14

10 Dec '14

Full_Name: edong Version: 2.4.40 OS: CentOS 6.6 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (60.190.254.10) BerkeleyDB version: 5.3.28 ./configure --enable-crypt --enable-lmpasswd --enable-spasswd --enable-modules --enable-backends=mod --enable-perl=no --enable-ndb=no --enable-overlays=mod --enable-dynamic The "make test" fails as follow3A3A ... Testing Bind caching Query 19: cn=James A Jones 1,ou=Alumni Association,ou=People,dc=example,dc=com Query 20: (Bind should be cached) Refresh failed >>>>> test020-proxycache failed for bdb (exit 1) make[2]: *** [bdb-mod] Error 1 make[2]: Leaving directory `/root/Downloads/openldap-2.4.40/tests' make[1]: *** [test] Error 2 make[1]: Leaving directory `/root/Downloads/openldap-2.4.40/tests' make: *** [test] Error 2

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs