--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Howard Chu <hyc(a)symas.com> writes:
> Jan Synacek wrote:
>> Howard Chu <hyc(a)symas.com> writes:
>>
>>> Jan Synacek wrote:
>>>> Howard Chu <hyc(a)symas.com> writes:
>>>>
>>>>> jsynacek(a)redhat.com wrote:
>>>>>> Full_Name: Jan Synacek
>>>>>> Version: master
>>>>>> OS: GNU/Linux
>>>>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150415-ba=
ck-perl-correctly-convert-perlModuleConfig.patch
>>>>>> Submission from: (NULL) (213.175.37.10)
>>>>>>
>>>>>>
>>>>>> When using the perl backend, slaptest doesn't convert perlModuleConf=
ig lines
>>>>>> from slapd.conf to slapd.d.
>>>>>>
>>>>>> A simple reproducer can be found at
>>>>>> https://jsynacek.fedorapeople.org/openldap/back-perl.sh
>>>>>>
>>>>>>
>>>>> Thanks, added to git master
>>>>
>>>> I misunderstood the semantics of perlModuleConfig when given multiple
>>>> arguments, so the patch isn't quite correct. I'm sorry for the
>>>> confusion. The fix can be found at:
>>>>
>>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150424-More=
-for-ITS-8105.patch
>>>>
>>>> Please note that I'm not aware of any internal functions that I can use
>>>> to flatten a list of strings. If there are some, or if there is a bett=
er
>>>> way to fix the issue, please advice, I'll simplify the patch.
>>>>
>>> Hi Jan, there's no need to muck with the list of strings, just use
>>> c->line instead of c->argv.
>>
>> Thank you for your advice! I've simplified the patch (url stays the same=
).
>
> Looks OK. One minor nit - we discourage using strlen() (or most of the=20
> libc str* functions, really). We particularly discourage runtime=20
> calculations on compile-time constants (including string constants) -=20
> use the STRLENOF() macro instead.
Done.
=2D-=20
Jan Synacek
Software Engineer, Red Hat
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJVPgvMAAoJEL3BmMJQOtjBC/cQAK3bicCb/k7Y47Jwt8hgIp7A
2+jHmMtIwVdA7sK7f26dPlwATUxtYXdXwewTJF8+t+wUg99cNEmgF0c/7clpEVJn
7lwOTdM5aJj5WDarXLYBpOnVoXNCP9aHTigAAe6wuRCHxeIclbqf5yd8wxEELDkl
piM6KkdWKqKlBY/hybD6+JI+hbXSFsHJfIdSudq+uVZwyDLjdjy3SPjoNiSZxSUi
S+h7CAt+d384KXX8aEGq9hUe5K2vvr3Yr83Gelm6w6xN4/aDFQZ75SHumsMPXrAe
j5mGNDb1Y8mMcrzJ0Qc/6JT8JCbhHJEaHKLUxLeYOH1NFylqNFUA2kgYI5jsjVUE
eMSXbb+pyKeWMbqUERNH6/tNS2t9rk/awJCj4o+xsRoK8DluUnP7tkSpTaDe4UqO
itgxNhKCV9NPm5Ar3MbBJOVK+dBIgOM9VM+t5ju+MdpiDTuytnUgIvvaixWfP7Bg
t8Q4t9U8u3gHoWyBdBnLVmwx7qq/BtPxqAt5uDv8mv9MyM9eeoDb4eaRhOe7sl2y
5s3bpBvOADks4dX5RpQ/SGUU5s/Fh/b2rAUrXqVxEkw5PipbTOBhx2LwKNVPnGhm
SoLjQzm7fDEODFS7/jAWbzYsxQ6m8engNUpSi1rMt1PJbLzVrW2vaU6+1UG5eiaS
IhBsZnx4E+WCfGoaUzxt
=23Ho
-----END PGP SIGNATURE-----
--=-=-=--
Jan Synacek wrote:
> Howard Chu <hyc(a)symas.com> writes:
>
>> Jan Synacek wrote:
>>> Howard Chu <hyc(a)symas.com> writes:
>>>
>>>> jsynacek(a)redhat.com wrote:
>>>>> Full_Name: Jan Synacek
>>>>> Version: master
>>>>> OS: GNU/Linux
>>>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150415-back-perl-corr…
>>>>> Submission from: (NULL) (213.175.37.10)
>>>>>
>>>>>
>>>>> When using the perl backend, slaptest doesn't convert perlModuleConfig lines
>>>>> from slapd.conf to slapd.d.
>>>>>
>>>>> A simple reproducer can be found at
>>>>> https://jsynacek.fedorapeople.org/openldap/back-perl.sh
>>>>>
>>>>>
>>>> Thanks, added to git master
>>>
>>> I misunderstood the semantics of perlModuleConfig when given multiple
>>> arguments, so the patch isn't quite correct. I'm sorry for the
>>> confusion. The fix can be found at:
>>>
>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150424-More-for-ITS-8…
>>>
>>> Please note that I'm not aware of any internal functions that I can use
>>> to flatten a list of strings. If there are some, or if there is a better
>>> way to fix the issue, please advice, I'll simplify the patch.
>>>
>> Hi Jan, there's no need to muck with the list of strings, just use
>> c->line instead of c->argv.
>
> Thank you for your advice! I've simplified the patch (url stays the same).
Looks OK. One minor nit - we discourage using strlen() (or most of the
libc str* functions, really). We particularly discourage runtime
calculations on compile-time constants (including string constants) -
use the STRLENOF() macro instead.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Howard Chu <hyc(a)symas.com> writes:
> Jan Synacek wrote:
>> Howard Chu <hyc(a)symas.com> writes:
>>
>>> jsynacek(a)redhat.com wrote:
>>>> Full_Name: Jan Synacek
>>>> Version: master
>>>> OS: GNU/Linux
>>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150415-back-perl-corr…
>>>> Submission from: (NULL) (213.175.37.10)
>>>>
>>>>
>>>> When using the perl backend, slaptest doesn't convert perlModuleConfig lines
>>>> from slapd.conf to slapd.d.
>>>>
>>>> A simple reproducer can be found at
>>>> https://jsynacek.fedorapeople.org/openldap/back-perl.sh
>>>>
>>>>
>>> Thanks, added to git master
>>
>> I misunderstood the semantics of perlModuleConfig when given multiple
>> arguments, so the patch isn't quite correct. I'm sorry for the
>> confusion. The fix can be found at:
>>
>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150424-More-for-ITS-8…
>>
>> Please note that I'm not aware of any internal functions that I can use
>> to flatten a list of strings. If there are some, or if there is a better
>> way to fix the issue, please advice, I'll simplify the patch.
>>
> Hi Jan, there's no need to muck with the list of strings, just use
> c->line instead of c->argv.
Thank you for your advice! I've simplified the patch (url stays the same).
Cheers,
--
Jan Synacek
Software Engineer, Red Hat
Full_Name: HAMANO Tsukasa
Version: master
OS: Linux
URL: https://www.osstech.co.jp/download/hamano/openldap/0001-OpenLDAP-WiredTiger…
Submission from: (NULL) (183.77.250.155)
The attached patch file is derived from OpenLDAP Software. All of the
modifications to OpenLDAP Software represented in the following
patch(es) were developed by HAMANO Tsukasa <hamano(a)osstech.co.jp>. I
have not assigned rights and/or interest in this work to any party.
Copyright 2015 HAMANO Tsukasa <hamano(a)osstech.co.jp>
Redistribution and use in source and binary forms, with or without
modification, are permitted only as authorized by the OpenLDAP Public
License.
Pavel Kraynyukhov wrote:
> Hello Howard,
> Please accept my apologies, the issue was not related to LMDB. There
> have been a data race in my code that was only triggered by fast writes.
> Sorry for late answer, - your e-mail landed into the spam-folder, and I
> just found it.
>
> With best regards,
> Pavel.
OK, thanks for the reply, closing this ITS.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
--90e6ba3fd5fbb4dffe05148bbe0e
Content-Type: text/plain; charset=UTF-8
Hello Howard,
Please accept my apologies, the issue was not related to LMDB. There have
been a data race in my code that was only triggered by fast writes.
Sorry for late answer, - your e-mail landed into the spam-folder, and I
just found it.
With best regards,
Pavel.
2015-04-16 8:04 GMT+06:00 Howard Chu <hyc(a)symas.com>:
> pk(a)dbic.pro wrote:
>
>> Full_Name: Pavel Kraynyukhov
>> Version: only LMDB from git and lmdb-0.9.14
>> OS: Gentoo Linux
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (37.99.47.171)
>>
>>
>> Hello there, I have ran into an issue with LMDB, which I can reproduce at
>> will,
>> but it seems a specific one. The git commit is
>> 3368d1f5e243225cba4d730fba19ff600798ebe3
>> And this commit and my issue seems to be related.
>>
>> 1. I use MDB_NOTLS flag on environment open.
>> 2. if I use MDB_NOSYNC flag for LMDB environment, the writer thread is
>> stuck
>> after several transactions (writer thread backtrace):
>>
>
> P.S. tested against system provided lmdb version 0.9.14 and result is the
>> same.
>> So this maybe not related to latest commit in git.
>>
>
> If you're having this problem in 0.9.14 then it is certainly not related
> to 3368d1f5e243225cba4d730fba19ff600798ebe3.
>
> You confirm that the issue does not occur in 0.9.13? Can you upload a test
> case demonstrating the problem?
>
> --
> -- Howard Chu
> CTO, Symas Corp. http://www.symas.com
> Director, Highland Sun http://highlandsun.com/hyc/
> Chief Architect, OpenLDAP http://www.openldap.org/project/
>
--90e6ba3fd5fbb4dffe05148bbe0e
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div><div><div><div>Hello Howard,<br></div>Please accept m=
y apologies, the issue was not related to LMDB. There have been a data race=
in my code that was only triggered by fast writes.<br></div>Sorry for late=
answer, - your e-mail landed into the spam-folder, and I just found it.<br=
><br></div>With best regards,<br></div>Pavel.<br><div><div><div><div><div c=
lass=3D"gmail_extra"><br><div class=3D"gmail_quote">2015-04-16 8:04 GMT+06:=
00 Howard Chu <span dir=3D"ltr"><<a href=3D"mailto:hyc@symas.com" target=
=3D"_blank">hyc(a)symas.com</a>></span>:<br><blockquote class=3D"gmail_quo=
te" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"=
><a href=3D"mailto:pk@dbic.pro" target=3D"_blank">pk(a)dbic.pro</a> wrote:<br=
>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
Full_Name: Pavel Kraynyukhov<br>
Version: only LMDB from git and lmdb-0.9.14<br>
OS: Gentoo Linux<br>
URL: <a href=3D"ftp://ftp.openldap.org/incoming/" target=3D"_blank">ftp://f=
tp.openldap.org/incoming/</a><br>
Submission from: (NULL) (37.99.47.171)<br>
<br>
<br>
Hello there, I have ran into an issue with LMDB, which I can reproduce at w=
ill,<br>
but it seems a specific one. The git commit is<br>
3368d1f5e243225cba4d730fba19ff600798ebe3<br>
And this commit and my issue seems to be related.<br>
<br>
1. I use MDB_NOTLS flag on environment open.<br>
2. if=C2=A0 I use MDB_NOSYNC flag for LMDB environment, the writer thread i=
s stuck<br>
after several transactions (writer thread backtrace):<br>
</blockquote>
<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
P.S. tested against system provided lmdb version 0.9.14 and result is the s=
ame.<br>
So this maybe not related to latest commit in git.<br>
</blockquote>
<br>
If you're having this problem in 0.9.14 then it is certainly not relate=
d to 3368d1f5e243225cba4d730fba19ff600798ebe3.<br>
<br>
You confirm that the issue does not occur in 0.9.13? Can you upload a test =
case demonstrating the problem?<span class=3D"HOEnZb"><font color=3D"#88888=
8"><br>
<br>
-- <br>
=C2=A0 -- Howard Chu<br>
=C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"=
http://www.symas.com" target=3D"_blank">http://www.symas.com</a><br>
=C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland=sun.com/hyc/" target=3D"_blank">http://highlandsun.com/hyc/</a><br>
=C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p=
roject/" target=3D"_blank">http://www.openldap.org/project/</a><br>
</font></span></blockquote></div><br><br></div></div></div></div></div></di=
v>
--90e6ba3fd5fbb4dffe05148bbe0e--
Jan Synacek wrote:
> Howard Chu <hyc(a)symas.com> writes:
>
>> jsynacek(a)redhat.com wrote:
>>> Full_Name: Jan Synacek
>>> Version: master
>>> OS: GNU/Linux
>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150415-back-perl-corr…
>>> Submission from: (NULL) (213.175.37.10)
>>>
>>>
>>> When using the perl backend, slaptest doesn't convert perlModuleConfig lines
>>> from slapd.conf to slapd.d.
>>>
>>> A simple reproducer can be found at
>>> https://jsynacek.fedorapeople.org/openldap/back-perl.sh
>>>
>>>
>> Thanks, added to git master
>
> I misunderstood the semantics of perlModuleConfig when given multiple
> arguments, so the patch isn't quite correct. I'm sorry for the
> confusion. The fix can be found at:
>
> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150424-More-for-ITS-8…
>
> Please note that I'm not aware of any internal functions that I can use
> to flatten a list of strings. If there are some, or if there is a better
> way to fix the issue, please advice, I'll simplify the patch.
>
Hi Jan, there's no need to muck with the list of strings, just use
c->line instead of c->argv.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
Howard Chu <hyc(a)symas.com> writes:
> jsynacek(a)redhat.com wrote:
>> Full_Name: Jan Synacek
>> Version: master
>> OS: GNU/Linux
>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150415-back-p=
erl-correctly-convert-perlModuleConfig.patch
>> Submission from: (NULL) (213.175.37.10)
>>
>>
>> When using the perl backend, slaptest doesn't convert perlModuleConfig l=
ines
>> from slapd.conf to slapd.d.
>>
>> A simple reproducer can be found at
>> https://jsynacek.fedorapeople.org/openldap/back-perl.sh
>>
>>
> Thanks, added to git master
I misunderstood the semantics of perlModuleConfig when given multiple
arguments, so the patch isn't quite correct. I'm sorry for the
confusion. The fix can be found at:
URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150424-More-for-=
ITS-8105.patch
Please note that I'm not aware of any internal functions that I can use
to flatten a list of strings. If there are some, or if there is a better
way to fix the issue, please advice, I'll simplify the patch.
=2D-=20
Jan Synacek
Software Engineer, Red Hat
--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJVOi7AAAoJEL3BmMJQOtjBv5cP/12AYektB3N6XsD2HzdBTE8V
A0Uc0GuyZ639D0SiqOOFLEIMipgK+O+Qk3viQWnfrlDWvnw1bgDtsKcUAQvgK17N
ZxxT5uEFeE+e9AHaWxURNXyFIU3BYY/jxy6evZAuhtOb88Ihigqef/dw3Pcn/4Mr
WISwVq82hCCUcz5VDt0Yg9ULsb2xf8GTPd8FD+HI3LwGxF9HNF/bpETAn2b3O/xL
hlSy963ZwHYZDsnsOMZdhcWsSQY72Z7vHtTJSauqy8o7iCWv86SB4CFf4Z7iDtDk
4jR/UZe2EwKfHalY1XsU8d0Ijx5HIuN+ffbxnalULfpN7BoqvHK3nph4vJ/JXkUe
R1hSk9i1PXrbYMJ8PjvAR/4/CP3rYw9oDdLPi2uhBFegjG9wugi/SVxMs6r/oD0Q
ylspwsQF2jiml04OkRy6RvzntB5Y70sekqgjHDQw2uDQwwyQ0sB6kS5IFjNxo5Yh
SRC4dTcVLHZ3KYmPcmsLlV8kaZUkiBaT4lipukVwvNXGSm6FjAamsCPCEO9ujutq
r0A1/PzA4wj81SCrCDfFmR8/xeQ+XFG2R9rTENFNgJRSJxQSxBIjUPRdugggrh0Z
SDELt6oln9OeOaHVKGpePh524zJ7AGMFnEY3C05sUfzFIJ83gBmOFcHDjKVly2/3
qWpOvoEUEJqKm4mO8Zvy
=kff0
-----END PGP SIGNATURE-----
--=-=-=--
--001a11c1e532dd12d70514602d88
Content-Type: text/plain; charset=UTF-8
Thank you, Howard. You are the best.
On Thursday, April 23, 2015, Howard Chu <hyc(a)symas.com> wrote:
> igor.shmukler(a)gmail.com wrote:
>
>> Full_Name: Igor Shmukler
>> Version: 2.4
>> OS: Linux
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (82.146.103.114)
>>
>>
>> I make a use of olcHidden. When set to true, olcHidden breaks slapcat.
>> $ sudo slapcat -n 0
>> 5530b282 olcRootPW: value #0: <olcRootPW> can only be set when rootdn
>> is under suffix
>> 5530b282 config error processing olcDatabase={2}hdb,cn=config:
>> <olcRootPW> can only be set when rootdn is under suffix
>> slapcat: bad configuration file!
>>
>>
>> Thanks for the report, fixed now in git master.
>
> --
> -- Howard Chu
> CTO, Symas Corp. http://www.symas.com
> Director, Highland Sun http://highlandsun.com/hyc/
> Chief Architect, OpenLDAP http://www.openldap.org/project/
>
--001a11c1e532dd12d70514602d88
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Thank you, Howard. You are the best.<div><br><br>On Thursday, April 23, 201=
5, Howard Chu <<a href=3D"mailto:hyc@symas.com">hyc(a)symas.com</a>> wr=
ote:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border=
-left:1px #ccc solid;padding-left:1ex"><a>igor.shmukler(a)gmail.com</a>=C2=A0=
wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
Full_Name: Igor Shmukler<br>
Version: 2.4<br>
OS: Linux<br>
URL: <a href=3D"ftp://ftp.openldap.org/incoming/" target=3D"_blank">ftp://f=
tp.openldap.org/incoming/</a><br>
Submission from: (NULL) (82.146.103.114)<br>
<br>
<br>
I make a use of olcHidden. When set to true, olcHidden breaks slapcat.<br>
$ sudo slapcat -n 0<br>
5530b282 olcRootPW: value #0: <olcRootPW> can only be set when rootdn=
<br>
is under suffix<br>
5530b282 config error processing olcDatabase=3D{2}hdb,cn=3Dconfig:<br>
<olcRootPW> can only be set when rootdn is under suffix<br>
slapcat: bad configuration file!<br>
<br>
<br>
</blockquote>
Thanks for the report, fixed now in git master.<br>
<br>
-- <br>
=C2=A0 -- Howard Chu<br>
=C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"=
http://www.symas.com" target=3D"_blank">http://www.symas.com</a><br>
=C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland=sun.com/hyc/" target=3D"_blank">http://highlandsun.com/hyc/</a><br>
=C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p=
roject/" target=3D"_blank">http://www.openldap.org/project/</a><br>
</blockquote></div>
--001a11c1e532dd12d70514602d88--
zach(a)puppetlabs.com wrote:
> Full_Name: Zach Leslie
> Version: 2.4.40-1
> OS: Debian Wheezy
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (192.69.65.15)
>
>
> I have a custom schema that contains a handful of attributeTypes and a few
> objectClasses. If I add a new attributeType to the existing schema, and then
> attempt to reorder that type, slapd crashes. Starting the service again, slapd
> seems to behave normally, and the schema looks intact as it did prior to the
> attempted order modification.
Did you get a stack trace from the crash?
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/