openldap-bugs

openldap-bugs@openldap.org

1 participants
20961 discussions

Re: (ITS#8202) openldap assumes printf has %z
by iand＠ekit-inc.com 22 Jul '15

22 Jul '15

Hi Howard, Yes I'm well aware of the state of Solaris 9 support and we support key components of the OS ourselves. However that doesn't mean that people don't still run it, like we do on some systems yet to be upgraded. (yes we have Sun systems purchased over 15 years ago that are still happily running; the hardware is very reliable; many are well overdue for upgrade though; its a resource/priority thing just look at how many people are running WinXP still) However this issue is a portability of openldap issue, not a OS support/patch thing (the C library in this case is not broken; its doing as the man page says, which doesn't mention %z), and the %z support is only a recent thing in the lifetime of unix (well last ~15 years it started to appear... C99 I think) There will be other legacy OS's that don't support %z too; no idea what ones though. Anyway I've got an (ugly) patch for me to use now and it passes 'make check' on Solaris 9; it was hard to find the cause of the problem though. Ian D On 07/22/15 04:01, Howard Chu wrote: > Howard Chu wrote: >> iand(a)ekit-inc.com wrote: >>> Full_Name: Ian Donaldson >>> Version: 2.4.41 >>> OS: Solaris 9 >>> URL: ftp://ftp.openldap.org/incoming/ >>> Submission from: (NULL) (60.241.85.68) >>> >>> >>> Built 2.4.41 on Solaris 9; ran 'make check' which failed to start slapd with >>> the following errors: >> >> Thanks for the report. Not sure that it's worth our taking any action though. >> The last release of Solaris 9 was 10 years ago, and it has been end-of-life'd >> by Oracle. > > For reference: Solaris 9 EOL > http://www.oracle.com/technetwork/server-storage/solaris10/overview/index-1… > > In short it means Solaris 9 is no longer eligible for any Oracle updates including security updates, fixes, patches or any other changes. Solaris 9 went into sustaining support in October 2014. > > Since Oracle is no longer providing any patches for this OS, I don't see much reason for us to either. Fortunately you are free to patch and build OpenLDAP for yourself for as long as you wish. >

1 0

Re: (ITS#8202) openldap assumes printf has %z
by h.b.furuseth＠usit.uio.no 21 Jul '15

21 Jul '15

If we require C99 library features like this, then I think we should add a configure test for them. Strange breakage at runtime is rather worse than a failed build. (That's not the same as testing for a C99 compiler, since one can have a C99 compiler like gcc with a C90 library.)

1 0

Re: (ITS#8202) openldap assumes printf has %z
by hyc＠symas.com 21 Jul '15

21 Jul '15

Howard Chu wrote: > iand(a)ekit-inc.com wrote: >> Full_Name: Ian Donaldson >> Version: 2.4.41 >> OS: Solaris 9 >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (60.241.85.68) >> >> >> Built 2.4.41 on Solaris 9; ran 'make check' which failed to start slapd with >> the following errors: > > Thanks for the report. Not sure that it's worth our taking any action though. > The last release of Solaris 9 was 10 years ago, and it has been end-of-life'd > by Oracle. For reference: Solaris 9 EOL http://www.oracle.com/technetwork/server-storage/solaris10/overview/index-1… In short it means Solaris 9 is no longer eligible for any Oracle updates including security updates, fixes, patches or any other changes. Solaris 9 went into sustaining support in October 2014. Since Oracle is no longer providing any patches for this OS, I don't see much reason for us to either. Fortunately you are free to patch and build OpenLDAP for yourself for as long as you wish. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8199) Crash when modifying the first olcAttributeTypes element in olcSchemaConfig objectClass
by luca.bruno＠rocket-internet.de 19 Jul '15

19 Jul '15

On Friday 17 July 2015 16:19:16 Ryan Tandy wrote: > On Tue, Jul 14, 2015 at 11:13:56AM +0000, luca.bruno(a)rocket-internet.de wrote: > >slapd 2.4.40 realiably crashes when modifying the 0th olcAttributeTypes > >element in a olcSchemaConfig object. > > This doesn't match my experience exactly, but if you were editing the > config with some tool, it might reflect how that tool implements > modifications. For a more specific background, this was Apache Directory Studio (pre-)2 doing schema changes on the debian backports 2.4.40 on wheezy (amd64). IIRC it does in fact synthesize a batch-modify of schema entries. > This was already fixed for olcObjectClasses in ITS#5388. I've pushed a > patch doing the same for at_next, can you please verify it? > > http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=patch;h=b48d0169d0 > 4824f83c0e0855eea4d6429740cf08 I'll try to apply that patch on top of my current setup and see if it stops crashing without any other regression. Thanks, Luca -- Luca Bruno (kaeso) Security Engineer Rocket Internet SE -> GPG: 0xBB1A3A854F3BBEBF

1 0

Re: (ITS#8202) openldap assumes printf has %z
by hyc＠symas.com 19 Jul '15

19 Jul '15

iand(a)ekit-inc.com wrote: > Full_Name: Ian Donaldson > Version: 2.4.41 > OS: Solaris 9 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (60.241.85.68) > > > Built 2.4.41 on Solaris 9; ran 'make check' which failed to start slapd with > the following errors: Thanks for the report. Not sure that it's worth our taking any action though. The last release of Solaris 9 was 10 years ago, and it has been end-of-life'd by Oracle. > 55ab70f0 config_build_entry: "olcDatabase={-1}frontend" > 55ab70f0 config_build_entry: "olcDatabase={0}config" > 55ab70f0 config_build_entry: "olcDatabase={1}bdb" > 55ab70f0 config_build_attrs: error 21 on olcDbCacheSize value #0 > 55ab70f0 config_build_entry: build "zu" failed: "" > > Eventually found this to be due to the assumption that %z format > works in printf; this is not the case on Solaris 9. (Solaris 10 has %z) > > Found the following code that makes this assumption (there may be others): > > ./libraries/liblmdb/mdb_load.c > ./libraries/liblmdb/mdb_dump.c > ./libraries/liblmdb/mdb_stat.c > ./libraries/liblmdb/mdb.c > ./servers/slapd/overlays/constraint.c > ./servers/slapd/config.c > > My workaround was to use %l instead of %z which works for me; may not > be 100% fix though. > > See http://stackoverflow.com/questions/2524611/how-to-print-size-t-variable-por… > > > I previously built 2.4.33 which has some %z'isms too but not in places > that cause 'make check' to fail. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8202) openldap assumes printf has %z
by iand＠ekit-inc.com 19 Jul '15

19 Jul '15

Full_Name: Ian Donaldson Version: 2.4.41 OS: Solaris 9 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (60.241.85.68) Built 2.4.41 on Solaris 9; ran 'make check' which failed to start slapd with the following errors: 55ab70f0 config_build_entry: "olcDatabase={-1}frontend" 55ab70f0 config_build_entry: "olcDatabase={0}config" 55ab70f0 config_build_entry: "olcDatabase={1}bdb" 55ab70f0 config_build_attrs: error 21 on olcDbCacheSize value #0 55ab70f0 config_build_entry: build "zu" failed: "" Eventually found this to be due to the assumption that %z format works in printf; this is not the case on Solaris 9. (Solaris 10 has %z) Found the following code that makes this assumption (there may be others): ./libraries/liblmdb/mdb_load.c ./libraries/liblmdb/mdb_dump.c ./libraries/liblmdb/mdb_stat.c ./libraries/liblmdb/mdb.c ./servers/slapd/overlays/constraint.c ./servers/slapd/config.c My workaround was to use %l instead of %z which works for me; may not be 100% fix though. See http://stackoverflow.com/questions/2524611/how-to-print-size-t-variable-por… I previously built 2.4.33 which has some %z'isms too but not in places that cause 'make check' to fail.

1 0

Re: (ITS#8111) Re-ordering schema attributeTypes crashes slapd
by ryan＠nardis.ca 18 Jul '15

18 Jul '15

Hi Zach, I just pushed a patch for another ITS that reminded me of this one. Assuming you can still reproduce this, would you please try the patch mentioned at the end of http://www.openldap.org/its/?findid=8199 and let us know whether it resolves your crash?

1 0

Re: (ITS#8199) Crash when modifying the first olcAttributeTypes element in olcSchemaConfig objectClass
by ryan＠nardis.ca 18 Jul '15

18 Jul '15

On Tue, Jul 14, 2015 at 11:13:56AM +0000, luca.bruno(a)rocket-internet.de wrote: >slapd 2.4.40 realiably crashes when modifying the 0th olcAttributeTypes element >in a olcSchemaConfig object. This doesn't match my experience exactly, but if you were editing the config with some tool, it might reflect how that tool implements modifications. I reproduced the crash with the following changeset: dn: cn={2}nis,cn=schema,cn=config changetype: modify replace: olcAttributeTypes olcAttributeTypes: {1}( 1.3.6.1.1.1.1.3 NAME 'homeDirectory' DESC 'The absolute path to the home directory' EQUALITY caseExactIA5Match SYNTAX 1.3.6.1.4.1.1466.115.121.1.26 SINGLE-VALUE ) Deleting all values clears c_at_head and c_at_tail (bconfig.c:1541). Adding a specific non-zero index assumes the head is already valid. This was already fixed for olcObjectClasses in ITS#5388. I've pushed a patch doing the same for at_next, can you please verify it? http://www.openldap.org/devel/gitweb.cgi?p=openldap.git;a=patch;h=b48d0169d…

1 0

(ITS#8173)
by Adrian.Raemy＠vtg.admin.ch 17 Jul '15

17 Jul '15

Dear Howard, We didn't use back-ldap as proxy backend in the past, we had a very old ope= nldap and did use syncrepl.=20 Then we changed our IT Infrastructures and had to use ldap proxy. That was = around 3 months ago. So we tried with 2.4.26 coming from sles and there we had the problem..so w= e tried then with the latest release and with both it was the same. Thanks a lot for your FIX. Actually it looks like working fine, the slapd of the ldap proxy didn't cra= sh anymore since 24 hours. No segfaults at the moment. We will monitor it next few days and weeks and if you like we can give you = again a feedback. ITS#8173 fix SEGV after failed retry [openldap.git] / servers / slapd / back-ldap / bind.c diff --git a/servers/slapd/back-ldap/bind.c b/servers/slapd/back-ldap/bind.= c index 598dae3..20197f3 100644 (file) --- a/servers/slapd/back-ldap/bind.c +++ b/servers/slapd/back-ldap/bind.c @@ -271,6 +271,8 @@ retry:; =20 if ( ldap_back_retry( &lc, op, rs, LDAP_BACK_BIND_SERR ) ) { = =20 goto retry; } + if ( !lc ) + return( rc ); =20 } ldap_pvt_thread_mutex_lock( &li->li_counter_mutex );

1 0

(ITS#8201) Enhancement: thread stack overrun detection
by hyc＠openldap.org 16 Jul '15

16 Jul '15

Full_Name: Howard Chu Version: HEAD OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.155.231.135) Submitted by: hyc Have been looking at some puzzling SEGVs where none of the addresses in the core dump backtrace appear to be invalid. Suspecting a thread stack overrun. Normally pthreads allocates a 1-page guard at the end of the requested thread stack. (This is a page of memory mprotect'd to deny any access, so spilling into it should cause a SEGV.) It's possible for some overruns to skip over this guard page, e.g. if they occur in a function that has a local variable larger than 1 page in size. Adding a feature to set the guard region size to be equal to the original thread stack size. (E.g., 8MB on 64 bit builds.) This should help catch the more elusive overrun cases. The feature will be enabled by setting the LDAPSTACKGUARD environment variable (to anything, the value is ignored).

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs