openldap-bugs

openldap-bugs@openldap.org

1 participants
20963 discussions

Re: (ITS#8270) win32: fix conversion error
by nacho.resa＠gmail.com 20 Oct '15

20 Oct '15

--047d7bb03a5ac118d20522842ead Content-Type: text/plain; charset=UTF-8 So I took another closer look at this issue and I went for this possible solution: https://github.com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5ad5… Basically it errors out because MSVC needs stdcall on that method. Cheers. On Mon, Oct 19, 2015 at 2:55 PM, Ignacio Casal Quinteiro < nacho.resa(a)gmail.com> wrote: > Sorry! I did indeed meant to change just the windows part, for some reason > I thought it was already ifdeffed that part. > > https://github.com/nice-software/lmdb/commit/42577fe173923c1166f8382a53523a… > > This is the right patch. > > On Mon, Oct 19, 2015 at 1:43 PM, Hallvard Breien Furuseth < > h.b.furuseth(a)usit.uio.no> wrote: > >> On 19. okt. 2015 08:57, nacho.resa(a)gmail.com wrote: >> >>> I do not understand, I tested also with mingw64 (...) >>> >> >> There's no LPTHREAD_START_ROUTINE type on non-Windows machines. >> You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)' >> in the _WIN32 variant of '#define THREAD_CREATE...'. >> >> However, it's still wrong to call a function via another prototype. >> Maybe that'd fall on 32-bit Windows or something, I don't know >> how LPTHREAD_START_ROUTINE is defined. The safe way would be to >> give mdb_env_copythr() a prototype which does not need a cast. >> There is some code for that already. Maybe it can be improved. >> >> -- >> Hallvard >> > > > > -- > Ignacio Casal Quinteiro > -- Ignacio Casal Quinteiro --047d7bb03a5ac118d20522842ead Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><div>So I took another closer look at this issue and = I went for this possible solution:<br><a href=3D"https://github.com/nice-so= ftware/lmdb/commit/03987789735141dc68ae8b2d0e5ad52d82cc80d0">https://github= .com/nice-software/lmdb/commit/03987789735141dc68ae8b2d0e5ad52d82cc80d0</a>= <br><br></div>Basically it errors out because MSVC needs stdcall on that me= thod.<br><br></div>Cheers.<br></div><div class=3D"gmail_extra"><br><div cla= ss=3D"gmail_quote">On Mon, Oct 19, 2015 at 2:55 PM, Ignacio Casal Quinteiro= <span dir=3D"ltr"><<a href=3D"mailto:nacho.resa@gmail.com" target=3D"_b= lank">nacho.resa(a)gmail.com</a>></span> wrote:<br><blockquote class=3D"gm= ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le= ft:1ex"><div dir=3D"ltr"><div>Sorry! I did indeed meant to change just the = windows part, for some reason I thought it was already ifdeffed that part.<= br><a href=3D"https://github.com/nice-software/lmdb/commit/42577fe173923c11= 66f8382a53523a31479f9d43" target=3D"_blank">https://github.com/nice-softwar= e/lmdb/commit/42577fe173923c1166f8382a53523a31479f9d43</a><br><br></div>Thi= s is the right patch.<br></div><div class=3D"gmail_extra"><div><div class= =3D"h5"><br><div class=3D"gmail_quote">On Mon, Oct 19, 2015 at 1:43 PM, Hal= lvard Breien Furuseth <span dir=3D"ltr"><<a href=3D"mailto:h.b.furuseth@= usit.uio.no" target=3D"_blank">h.b.furuseth(a)usit.uio.no</a>></span> wrot= e:<br><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-l= eft:1px #ccc solid;padding-left:1ex">On 19. okt. 2015 08:57, <a href=3D"mai= lto:nacho.resa@gmail.com" target=3D"_blank">nacho.resa(a)gmail.com</a> wrote:= <br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I do not understand, I tested also with mingw64 (...)<br> </blockquote> <br> There's no LPTHREAD_START_ROUTINE type on non-Windows machines.<br> You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)= '<br> in the _WIN32 variant of '#define THREAD_CREATE...'.<br> <br> However, it's still wrong to call a function via another prototype.<br> Maybe that'd fall on 32-bit Windows or something, I don't know<br> how LPTHREAD_START_ROUTINE is defined.=C2=A0 The safe way would be to<br> give mdb_env_copythr() a prototype which does not need a cast.<br> There is some code for that already. Maybe it can be improved.<span><font c= olor=3D"#888888"><br> <br> -- <br> Hallvard<br> </font></span></blockquote></div><br><br clear=3D"all"><br></div></div><spa= n class=3D"HOEnZb"><font color=3D"#888888">-- <br><div>Ignacio Casal Quinte= iro</div> </font></span></div> </blockquote></div><br><br clear=3D"all"><br>-- <br><div class=3D"gmail_sig= nature">Ignacio Casal Quinteiro</div> </div> --047d7bb03a5ac118d20522842ead--

1 0

(ITS#8278) slapd fails to start when built with --enable-slp on freebsd
by quanah＠openldap.org 19 Oct '15

19 Oct '15

Full_Name: Quanah Gibson-Mount Version: 2.4.42 OS: FreeBSD 10.1 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (75.111.52.177) slapd will not start, exits with "slap_schema_init: Error registering matching rule ( 2.5.13.28 NAME 'generalizedTimeOrderingMatch' SYNTAX 1.3.6.1.4.1.1466.115.121.1.24 )"

1 0

(ITS#8277) test049 crashes
by hyc＠openldap.org 19 Oct '15

19 Oct '15

Full_Name: Howard Chu Version: 2.4 OS: Win32 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.155.231.14) Submitted by: hyc After "replacing syncrepl on provider" the consumer crashes. Stack trace shows a do_syncrepl thread trying to lock a syncinfo mutex that is no longer valid, i.e., the syncinfo has been freed. This happens when the consumer receives the syncrepl config change - it deletes the existing config (thus freeing it) and creates a new one. Something funny is going on here since the config change itself is being processed in the consumer, and no other thread should have been started for this syncrepl instance.

1 0

(ITS#8276) [PATCH 2/2] Add an application context pointer into user-defined key compare and dupsort functions
by pmedvedev＠gmail.com 19 Oct '15

19 Oct '15

Full_Name: Pavel Medvedev Version: OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (217.25.225.40) This allows to use application context in user-defined compare functions. --- libraries/liblmdb/lmdb.h | 14 ++++++++++---- libraries/liblmdb/mdb.c | 40 ++++++++++++++++"B2B+++++----------------- 2 files changed, 33 insertions(+), 21 deletions(-) diff --git a/libraries/liblmdb/lmdb.h b/libraries/liblmdb/lmdb.h index 933a862..debdf43 100644 --- a/libraries/liblmdb/lmdb.h +++ b/libraries/liblmdb/lmdb.h @@ -251,8 +251,12 @@ typedef struct MDB_val { void *mv_data; /**< address of the data item */ } MDB_val; -/** @brief A callback function used to compare two keys in a database */ -typedef int (MDB_cmp_func)(const MDB_val *a, const MDB_val *b); +/** @brief A callback function used to compare two keys in a database +* @param[in] a The first value to compare. +* @param[in] b The second value to compare. +* @param[in] cmpctx An application-provided context, set by #mdb_set_compare() or #mdb_set_dupsort(). +*/ +typedef int (MDB_cmp_func)(const MDB_val *a, const MDB_val *b, void *cmpctx); /** @brief A callback function used to relocate a position-dependent data item * in a fixed-address database. @@ -1193,13 +1197,14 @@ int mdb_drop(MDB_txn *txn, MDB_dbi dbi, int del); * @param[in] txn A transaction handle returned by #mdb_txn_begin() * @param[in] dbi A database handle returned by #mdb_dbi_open() * @param[in] cmp A #MDB_cmp_func function + * @param[in] cmpctx An arbitrary pointer for whatever the application needs. * @return A non-zero error value on failure and 0 on success. Some possible * errors are: * <ul> * <li>EINVAL - an invalid parameter was specified. * </ul> */ -int mdb_set_compare(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp); +int mdb_set_compare(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp, void *cmpctx); /** @brief Set a custom data comparison function for a #MDB_DUPSORT database. * @@ -1216,13 +1221,14 @@ int mdb_set_compare(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp); * @param[in] txn A transaction handle returned by #mdb_txn_begin() * @param[in] dbi A database handle returned by #mdb_dbi_open() * @param[in] cmp A #MDB_cmp_func function + * @param[in] cmpctx An arbitrary pointer forhahatever the application needs. * @return A non-zero error value on failure and 0 on success. Some possible * errors are: * <ul> * <li>EINVAL - an invalid parameter was specified. * </ul> */ -int mdb_set_dupsort(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp); +int mdb_set_dupsort(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp, void *cmpctx); /** @brief Set a relocation function for a #MDB_FIXEDMAP database. * diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb-bdb.c index a2763f8..f816a44 100644 --- a/libraries/liblmdb/mdb.c +++ b/libraries/liblmdb/mdb.c @@ -1057,7 +1057,9 @@ typedef union MDB_metabuf { typedef struct MDB_dbx { MDB_val md_name; /**< name of the database */ MDB_cmp_func9*9*md_cmp; /**< function for comparing keys */ + void *md_cmpctx; /**< user-provided context for md_cmp*/ MDB_cmp_func *md_dcmp; /**< function for comparing data items */ + void *md_dcmpctx; /**< user-provided context for md_dcmp */A A MDB_rel_func *md_rel; /**< user relocate function */ void *md_relctx; /**< user-provided context for md_rel */ } MDB_dbx; @@ -1709,7 +1711,7 @@ static void mdb_audit(MDB_txn *txn) int mdb_cmp(MDB_txn *txn, MDB_dbi dbi, const MDB_val *a, const MDB_val *b) { - return txn->mt_dbxs[dbi].md_cmp(a, b); + return txn->mt_dbxs[dbi].md_cmp(a, b, txn->mt_dbxs[dbi].md_cmpctx); } int @@ -1720,7 +1722,7 @@ mdb_dcmp(MDB_txn *txn, MDB_dbi dbi, const MDB_val *a, const MDB_val *b) if (dcmp == mdb_cmp_int && a->mv_size == sizeof(size_t)) dcmp = mdb_cmp_clong; #endif - return dcmp(a, b); + return dcmp(a, b, txn->mt_dbxs[dbi].md_dcmpctx); } /** Allocate memory for a page. @@ -5003,7 +5005,7 @@ mdb_env_close(MDB_env *env) /** Compare two items pointing at aligned size_t's */ static int -mdb_cmp_long(const MDB_val *a, const MDB_val *b) +mdb_cmp_long(const MDB_val *a, const MDB_val *b, void *cmpctx) { return (*(size_t *)a->mv_data < *(size_t *)b->mv_data) ? -1 : *(size_t *)a->mv_data > *(size_t *)b->mv_data; @@ -5015,7 +5017,7 @@ mdb_cmp_long(const MDB_val *a, const MDB_val *b) * but #mdb_cmp_clong() is called instead if the data type is size_t. */ static int -mdb_cmp_int(const MDB_val *a, const MDB_val *b) +mdb_cmp_int(const MDB_val *a, const MDB_v *b%b, void *cmpctx) { return (*(unsigned int *)a->mv_data < *(unsigned int *)b->mv_data) ? -1 : *(unsigned int *)a->mv_data > *(unsigned int *)b->mv_data; @@ -5025,7 +5027,7 @@ mdb_cmp_int(const MDB_val *a, const MDB_val *b) * Nodes and keys are guaranteed to be 2-byte aligned. */ static int -mdb_cmp_cint(const MDB_val *a, const MDB_val *b) +mdb_cmp_cint(const MDB_val *a, const MDB_val *b, void *cmpctx) { #if BYTE_ORDER == LITTLE_ENDIAN unsigned short *u, *c; @@ -5053,7 +5055,7 @@ mdb_cmp_cint(const MDB_val *a, const MDB_val *b) /** Compare two items lexically */ static int -mdb_cmp_memn(const MDB_val *a, const MDB_val *b) +mdb_cmp_memn(const MDB_val *a, const MDB_val *b, void *cmpctx) { int diff; ssize_t len_diff; @@ -5072,7 +5074,7 @@ mdb_cmp_memn(const MDB_val *a, const MDB_val *b) /** Compare two items in reverse byte order */ static int -mdb_cmp_memnr(const MDB_val *a, const MDB_val *b) +mdb_cmp_memnr(const MDB_val *a, const MDB_val *b, void *cmpctx) { const unsigned char *p1, *p2, *p1_lim; ssize_t len_diff; @@ -5113,6 +5115,7 @@ mdb_node_search(MDB_cursor *mc, MDB_val *key, int *exactp) MDB_node *node = NULL; MDB_val nodekey; MDB_cmp_func *cmp; + void *cmpctx; DKBUF; nkeys = NUMKEYS(mp); @@ -5124,6 +5127,7 @@ mdb_node_search(MDB_cursor *mc, MDB_val *key, int *exactp) low = IS_LEAF(mp) ? 0 : 1; high = nkeys - 1; cmp = mc->mc_dbx->md_cmp; + cmpctx = mc->mc_dbx->md_cmpctx; /* Branch pages have no data% so o if using integer keys, * alignment is guaranteed. Use faster mdb_cmp_int. @@ -5141,7 +5145,7 @@ mdb_node_search(MDB_cursor *mc, MDB_val *key, int *exactp) while (low <= high) { i = (low + high) >> 1; nodey.m.mv_data = LEAF2KEY(mp, i, nodekey.mv_size); - rc = cmp(key, &nodekey); + rc = cmp(key, &nodekey, cmpctx); DPRINTF(("found leaf index %u [%s], rc = %i", i, DKEY(&nodekey), rc)); if (rc == 0) @@ -5159,7 +5163,7 @@ mdb_node_search(MDB_cursor *mc, MDB_val *key, int *exactp) nodekey.mv_size = NODEKSZ(node); nodekey.mv_data = NODEKEY(node); - rc = cmp(key, &nodekey); + rc = cmp(key, &nodekey, cmpctx); #if MDB_DEBUG if (IS_LEAF(mp)) DPRINTF(("found leaf index %u [%s], rc = %i", @@ -5855,7 +5859,7 @@ mdb_cursor_set(MDB_cursor *mc, MDB_val *key, MDB_val *data, leaf = NODEPTR(mp, 0); MDB_GET_KEY2(leaf, nodekey); } - rc = mc->mc_dbx->md_cmp(key, &nodekey); + rc = mc->mc_dbx->md_cmp(key, &nodekey, mc->mc_dbx->md_cmpctx); if (rc == 0) { /* Probably happens rarely, but first node on the page * was the one we wanted. @@ -5876,7 +5880,7 @@ mdb_cursor_set(MDB_cursor *mc, MDB_val *key, MDB_val *data, leaf = NODEPTR(%2, nkeys-1); MDB_GET_KEY2(leaf, nodekey); } - rc = mc->mc_dbx->md_cmp(key, &nodekey); + rc = mc->mc_dbx->md_cmp(key, &nodekey, mc->mc_dbx->md_cmpctx); if (rc == 0) { /* last node was the one we wanted */ mc->mc_ki[mc->mc_top] D D nkeys-1; @@ -5894,7 +5898,7 @@ mdb_cursor_set(MDB_cursor *mc, MDB_val *key, MDB_val *data, leaf = NODEPTR(mp, mc->mc_ki[mc->mc_top]); MDB_GET_KEY2(leaf, nodekey); } - rc = mc->mc_dbx->md_cmp(key, &nodekey);A%A+ rc = mc->mc_dbx->md_cmp(key, &nodekey, mc->mc_dbx->md_cmpctx); if (rc == 0) { /* current node was the one we wanted */ if (exactp) @@ -5996,7 +6000,7 @@ set1: if (dcmp == mdb_cmp_int && olddata.mv_size == sizeof(size_t)) dcmp = mdb_cmp_clong; #endif - rc = dcmp(data, &olddata); + rc = dcmp(data, &olddata, mc->mc_dbx->md_dcmpctx); if (rc) { if (op == MDB_GET_BOTH || rc > 0) return MDB_NOTFOUND; @@ -6387,7 +6391,7 @@ mdb_cursor_put(MDB_cursor *mc, MDB_val *key, MDB_val *data, MDB_val k2; rc = mdb_cursor_last(mc, &k2, &d2); if (rc == 0) { - rc = mc->mc_dbx->md_cmp(key, &k2); + rc = mc->mc_dbx->md_cmp(key, &k2, mc->mc_dbx->md_cmpctx); if (rc > 0) { rc = MDB_NOTFOUND; mc->mc_k5B5Bmc->mc_top]++; @@ -6520,7 +6524,7 @@ more: dcmp = mdb_cmp_clong; #endif /* does data match? */ - if (!dcmp(data, &olddata)) { + if (!dcmp(data, &olddata, mc->mc_dbx->md_dcmpctx)) { if (flags &DMDB_NODUPDATA) return MDB_KEYEXIST; /* overwrite it */ @@ -9690,21 +9694,23 @@ leave: return rc; } -int mdb_set_compare(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp) +int mdb_set_compare(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp, void *cmpctx) { if (!TXN_DBI_EXIST(txn, dbi, DB_USRVALID)) return EINVAL; txn->mt_dbxs[dbi].md_cmp = cmp; + txn->mt_dbxs[dbi].md_cmpctx = cmpctx; return MDB_SUCCESS; } -int mdb_set_dupsort(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp) +int mdb_set_dupsort(MDB_txn *txn, MDB_dbi dbi, MDB_cmp_func *cmp, void *cmpctx) { if (!TXN_DBI_EXIST(txn, dbi, DB_USRVALID)) return EINVAL; txn->mt_dbxs[dbi].md_dcmp = cmp; + txn->mt_dbxs[dbi].md_dcmpctx = cmpctx; return MDB_SUCCESS; }

1 0

(ITS#8275) [PATCH 1/2] Add mdb_dbi_name() function to get database name from a handle
by pmedvedev＠gmail.com 19 Oct '15

19 Oct '15

Full_Name: Pavel Medvedev Version: OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (217.25.225.40) --- libraries/liblmdb/lmdb.h | 15 +++++++++++++++ libraries/liblmdb/mdb.c | 9 +++++++++ 2 files changed, 24 insertions(+) diff --git a/libraries/liblmdb/lmdb.h b/libraries/liblmdb/lmdb.h index e080e76..933a862 100644 - - a/libraries/liblmdb/lmdb.h +++ b/libraries/liblmdb/lmdb.h @@ -1136,6 +1136,21 @@ int mdb_stat(MDB_txn *txn, MDB_dbi dbi, MDB_stat *stat); */ int mdb_dbi_flags(MDB_txn *txn, MDB_dbi dbi, unsigned int *flags); + /** @brief Return the DB name that was used in #mdb_dbi_open(). + * + * @param[in] txn A transaction handle returned by #mdb_txn_begin() + * @param[in] dbi A database handle returned by #mdb_dbi_open() + * @param[out] path Address of a string pointer to contain the path. This + * is the actual string in the database, not a copy. It should not be + * altered in any way. + * @return A non-zero error value on failure and 0 on success. Some possible + * errors are: + * <ul> + * <li>EINVAL - an invalid parameter was specified. + * </ul> + */ +int mdb_dbi_name(MDB_txn *txn, MDB_dbi dbi, const char **name); + /** @brief Close a database handle. Normally unnecessary. Use with care: * * This call is not mutex protected. Handles should only be closed by diff --git a/libraries/liblmdb/mdb.c b/libraries/liblmdb/mdb.c index 8f7f3b3..a2763f8 100644 --- a/libraries/liblmdb/mdb.c +++ b/libraries/liblmdb/mdb.c @@ -9541,6 +9541,15 @@ int mdb_dbi_flags(MDB_txn *txn, MDB_dbi dbi, unsigned int *flags) return MDB_SUCCESS; } +int mdb_dbi_name(MDB_txn *txn, MDB_dbi dbi, const char **name) +{ + if (!TXN_DBI_EXIST(txn, dbi, DB_USRVALID) || !name) + return EINVAL; + /* safe since md_name is 0-terminated with strdup in mdb_dbi_open */ + *name = txn->mtbxbxs[dbi].md_name.mv_data; + return MDB_SUCCESS; +} + /** Add all the DB's pages to the free list. * @param[in] mc Cursor on the DB to free. * @param[in] subs non-Zero to check for sub-DBs in this DB.

1 0

Re: (ITS#8270) win32: fix conversion error
by nacho.resa＠gmail.com 19 Oct '15

19 Oct '15

--f46d0444813d6e6086052274a949 Content-Type: text/plain; charset=UTF-8 Sorry! I did indeed meant to change just the windows part, for some reason I thought it was already ifdeffed that part. https://github.com/nice-software/lmdb/commit/42577fe173923c1166f8382a53523a… This is the right patch. On Mon, Oct 19, 2015 at 1:43 PM, Hallvard Breien Furuseth < h.b.furuseth(a)usit.uio.no> wrote: > On 19. okt. 2015 08:57, nacho.resa(a)gmail.com wrote: > >> I do not understand, I tested also with mingw64 (...) >> > > There's no LPTHREAD_START_ROUTINE type on non-Windows machines. > You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)' > in the _WIN32 variant of '#define THREAD_CREATE...'. > > However, it's still wrong to call a function via another prototype. > Maybe that'd fall on 32-bit Windows or something, I don't know > how LPTHREAD_START_ROUTINE is defined. The safe way would be to > give mdb_env_copythr() a prototype which does not need a cast. > There is some code for that already. Maybe it can be improved. > > -- > Hallvard > -- Ignacio Casal Quinteiro --f46d0444813d6e6086052274a949 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div>Sorry! I did indeed meant to change just the windows = part, for some reason I thought it was already ifdeffed that part.<br><a hr= ef=3D"https://github.com/nice-software/lmdb/commit/42577fe173923c1166f8382a= 53523a31479f9d43">https://github.com/nice-software/lmdb/commit/42577fe17392= 3c1166f8382a53523a31479f9d43</a><br><br></div>This is the right patch.<br><= /div><div class=3D"gmail_extra"><br><div class=3D"gmail_quote">On Mon, Oct = 19, 2015 at 1:43 PM, Hallvard Breien Furuseth <span dir=3D"ltr"><<a href= =3D"mailto:h.b.furuseth@usit.uio.no" target=3D"_blank">h.b.furuseth(a)usit.ui= o.no</a>></span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"ma= rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 19. okt. 20= 15 08:57, <a href=3D"mailto:nacho.resa@gmail.com" target=3D"_blank">nacho.r= esa(a)gmail.com</a> wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I do not understand, I tested also with mingw64 (...)<br> </blockquote> <br> There's no LPTHREAD_START_ROUTINE type on non-Windows machines.<br> You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)= '<br> in the _WIN32 variant of '#define THREAD_CREATE...'.<br> <br> However, it's still wrong to call a function via another prototype.<br> Maybe that'd fall on 32-bit Windows or something, I don't know<br> how LPTHREAD_START_ROUTINE is defined.=C2=A0 The safe way would be to<br> give mdb_env_copythr() a prototype which does not need a cast.<br> There is some code for that already. Maybe it can be improved.<span class= =3D"HOEnZb"><font color=3D"#888888"><br> <br> -- <br> Hallvard<br> </font></span></blockquote></div><br><br clear=3D"all"><br>-- <br><div clas= s=3D"gmail_signature">Ignacio Casal Quinteiro</div> </div> --f46d0444813d6e6086052274a949--

1 0

Re: (ITS#8270) win32: fix conversion error
by h.b.furuseth＠usit.uio.no 19 Oct '15

19 Oct '15

On 19. okt. 2015 08:57, nacho.resa(a)gmail.com wrote: > I do not understand, I tested also with mingw64 (...) There's no LPTHREAD_START_ROUTINE type on non-Windows machines. You could replace 'start' with '(LPTHREAD_START_ROUTINE)(start)' in the _WIN32 variant of '#define THREAD_CREATE...'. However, it's still wrong to call a function via another prototype. Maybe that'd fall on 32-bit Windows or something, I don't know how LPTHREAD_START_ROUTINE is defined. The safe way would be to give mdb_env_copythr() a prototype which does not need a cast. There is some code for that already. Maybe it can be improved. -- Hallvard

1 0

(ITS#8274) Review lmdb cyrus-sasl backend changes
by nacho.resa＠gmail.com 19 Oct '15

19 Oct '15

Full_Name: Ignacio Casal Quinteiro Version: OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (89.202.223.30) Hi Howard Chu, since you made the backend for cyrus-sasl, any chance you could review the patches here: https://github.com/nice-software/cyrus-sasl/commits/wip/lmdb before they get upstream? Cheers.

1 0

(ITS#8273) file:// URLs broken on Windows
by hyc＠openldap.org 19 Oct '15

19 Oct '15

Full_Name: Howard Chu Version: 2.4 OS: Win32 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.155.231.14) Submitted by: hyc file URLs with absolute paths are parsed incorrectly on Windows. The current code expects an absolute path in Unix form: file:///etc/ldap.conf In our test suites we just concatenate "file://" with an absolute path. On Windowsn ababsolute path starts with a drive letter and a colon, so our test suite doing simple concatenation uses file://C:/some/thing This is actually invalid; the proper form would be file:///C:/some/thing but the current parser won't do the right thing for either form. It MUST be fixed to accept the latter form with 3 slashes. I'm inclined to also accept the form with 2 slashes, to avoid hacking up our test suite to handle this case.

1 0

Re: (ITS#8270) win32: fix conversion error
by nacho.resa＠gmail.com 18 Oct '15

18 Oct '15

--f46d044289f661da1905226fa6a2 Content-Type: text/plain; charset=UTF-8 I do not understand, I tested also with mingw64 and here is the result I get with my patches applied: $ make gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb.c mdb.c: In function 'mdb_strerror': cc1.exe: warning: function may return address of local variable [-Wreturn-local-addr] mdb.c:1453:7: note: declared here char buf[1024], *ptr = buf; ^ gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c midl.c ar rs liblmdb.a mdb.o midl.o C:\msys64\mingw64\bin\ar.exe: creating liblmdb.a gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -fPIC -c mdb.c -o mdb.lo mdb.c:1:0: warning: -fPIC ignored for target (all code is position independent) /** @file mdb.c ^ mdb.c: In function 'mdb_strerror': cc1.exe: warning: function may return address of local variable [-Wreturn-local-addr] mdb.c:1453:7: note: declared here char buf[1024], *ptr = buf; ^ gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -fPIC -c midl.c -o midl.lo midl.c:1:0: warning: -fPIC ignored for target (all code is position independent) /** @file midl.c ^ gcc -pthread -shared -o liblmdb.so mdb.lo midl.lo gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_stat.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_stat.o liblmdb.a -o mdb_stat gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_copy.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_copy.o liblmdb.a -o mdb_copy gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_dump.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_dump.o liblmdb.a -o mdb_dump gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_load.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_load.o liblmdb.a -o mdb_load gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest.o liblmdb.a -o mtest gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest2.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest2.o liblmdb.a -o mtest2 gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest3.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest3.o liblmdb.a -o mtest3 gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest4.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest4.o liblmdb.a -o mtest4 gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mtest5.c gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mtest5.o liblmdb.a -o mtest5 On Mon, Oct 19, 2015 at 8:35 AM, Howard Chu <hyc(a)symas.com> wrote: > Ignacio Casal Quinteiro wrote: > >> I am ok not fixing the MSVC warnings because it is picky even though some >> of >> them might make sense even for mingw, but in this case it is an error and >> this >> really small change enable msvc to build without errors. Can't you >> reconsider >> the change? Specially since it will build fine with mingw as well. >> > > No, since it will break Unix builds. > >> >> On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <hyc(a)symas.com >> <mailto:hyc@symas.com>> wrote: >> >> nacho.resa(a)gmail.com <mailto:nacho.resa@gmail.com> wrote: >> >> Full_Name: Ignacio Casal Quinteiro >> Version: >> OS: Windows 7 >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (2a01:111f:9fa:7f00:864b:f5ff:fe34:ddaa) >> >> >> >> https://github.com/nice-software/lmdb/commit/076281a2c03356667fca7cce1a898a… >> >> >> I see no error when compiling with gcc -Wall. Closing this ITS. >> >> -- >> -- Howard Chu >> CTO, Symas Corp. http://www.symas.com >> Director, Highland Sun http://highlandsun.com/hyc/ >> Chief Architect, OpenLDAP http://www.openldap.org/project/ >> >> >> >> >> -- >> Ignacio Casal Quinteiro >> > > > -- > -- Howard Chu > CTO, Symas Corp. http://www.symas.com > Director, Highland Sun http://highlandsun.com/hyc/ > Chief Architect, OpenLDAP http://www.openldap.org/project/ > -- Ignacio Casal Quinteiro --f46d044289f661da1905226fa6a2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr">I do not understand, I tested also with mingw64 and here i= s the result I get with my patches applied:<br><br>$ make<br>gcc -pthread -= O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2= =A0=C2=A0 -c mdb.c<br>mdb.c: In function 'mdb_strerror':<br>cc1.exe= : warning: function may return address of local variable [-Wreturn-local-ad= dr]<br>mdb.c:1453:7: note: declared here<br>=C2=A0 char buf[1024], *ptr =3D= buf;<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^<br>gcc -pthread -O2 -g -W -= Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 = -c midl.c<br>ar rs liblmdb.a mdb.o midl.o<br>C:\msys64\mingw64\bin\ar.exe: = creating liblmdb.a<br>gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -W= bad-function-cast -Wuninitialized=C2=A0 -fPIC=C2=A0 -c mdb.c -o mdb.lo<br>m= db.c:1:0: warning: -fPIC ignored for target (all code is position independe= nt)<br>=C2=A0/** @file mdb.c<br>=C2=A0^<br>mdb.c: In function 'mdb_stre= rror':<br>cc1.exe: warning: function may return address of local variab= le [-Wreturn-local-addr]<br>mdb.c:1453:7: note: declared here<br>=C2=A0 cha= r buf[1024], *ptr =3D buf;<br>=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^<br>gcc= -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wunini= tialized=C2=A0 -fPIC=C2=A0 -c midl.c -o midl.lo<br>midl.c:1:0: warning: -fP= IC ignored for target (all code is position independent)<br>=C2=A0/** @file= midl.c<br>=C2=A0^<br>gcc=C2=A0 -pthread -shared -o liblmdb.so mdb.lo midl.= lo<br>gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cas= t -Wuninitialized=C2=A0=C2=A0 -c mdb_stat.c<br>gcc -pthread -O2 -g -W -Wall= -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mdb_= stat.o liblmdb.a=C2=A0 -o mdb_stat<br>gcc -pthread -O2 -g -W -Wall -Wno-unu= sed-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 -c mdb_copy.c= <br>gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast = -Wuninitialized=C2=A0=C2=A0 mdb_copy.o liblmdb.a=C2=A0 -o mdb_copy<br>gcc -= pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuniniti= alized=C2=A0=C2=A0 -c mdb_dump.c<br>gcc -pthread -O2 -g -W -Wall -Wno-unuse= d-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mdb_dump.o libl= mdb.a=C2=A0 -o mdb_dump<br>gcc -pthread -O2 -g -W -Wall -Wno-unused-paramet= er -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 -c mdb_load.c<br>gcc -pt= hread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitial= ized=C2=A0=C2=A0 mdb_load.o liblmdb.a=C2=A0 -o mdb_load<br>gcc -pthread -O2= -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2= =A0=C2=A0 -c mtest.c<br>gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter = -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mtest.o liblmdb.a=C2=A0 -o = mtest<br>gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-= cast -Wuninitialized=C2=A0=C2=A0 -c mtest2.c<br>gcc -pthread -O2 -g -W -Wal= l -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mte= st2.o liblmdb.a=C2=A0 -o mtest2<br>gcc -pthread -O2 -g -W -Wall -Wno-unused= -parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 -c mtest3.c<br>g= cc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuni= nitialized=C2=A0=C2=A0 mtest3.o liblmdb.a=C2=A0 -o mtest3<br>gcc -pthread -= O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2= =A0=C2=A0 -c mtest4.c<br>gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter= -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 mtest4.o liblmdb.a=C2=A0 -= o mtest4<br>gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-functi= on-cast -Wuninitialized=C2=A0=C2=A0 -c mtest5.c<br>gcc -pthread -O2 -g -W -= Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized=C2=A0=C2=A0 = mtest5.o liblmdb.a=C2=A0 -o mtest5<br><br></div><div class=3D"gmail_extra">= <br><div class=3D"gmail_quote">On Mon, Oct 19, 2015 at 8:35 AM, Howard Chu = <span dir=3D"ltr"><<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hy= c(a)symas.com</a>></span> wrote:<br><blockquote class=3D"gmail_quote" styl= e=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span c= lass=3D"">Ignacio Casal Quinteiro wrote:<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"> I am ok not fixing the MSVC warnings because it is picky even though some o= f<br> them might make sense even for mingw, but in this case it is an error and t= his<br> really small change enable msvc to build without errors. Can't you reco= nsider<br> the change? Specially since it will build fine with mingw as well.<br> </blockquote> <br></span> No, since it will break Unix builds.<br> <blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p= x #ccc solid;padding-left:1ex"><span class=3D""> <br> On Sat, Oct 17, 2015 at 7:54 PM, Howard Chu <<a href=3D"mailto:hyc@symas= .com" target=3D"_blank">hyc(a)symas.com</a><br></span> <mailto:<a href=3D"mailto:hyc@symas.com" target=3D"_blank">hyc(a)symas.com= </a>>> wrote:<span class=3D""><br> <br> =C2=A0 =C2=A0 <a href=3D"mailto:nacho.resa@gmail.com" target=3D"_blank">nac= ho.resa(a)gmail.com</a> <mailto:<a href=3D"mailto:nacho.resa@gmail.com" ta= rget=3D"_blank">nacho.resa(a)gmail.com</a>> wrote:<br> <br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Full_Name: Ignacio Casal Quinteiro<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Version:<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 OS: Windows 7<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 URL: <a href=3D"ftp://ftp.openldap.org/incoming= /" rel=3D"noreferrer" target=3D"_blank">ftp://ftp.openldap.org/incoming/</a= ><br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 Submission from: (NULL) (2a01:111f:9fa:7f00:864= b:f5ff:fe34:ddaa)<br> <br> <br> =C2=A0 =C2=A0 =C2=A0 =C2=A0 <a href=3D"https://github.com/nice-software/lmd= b/commit/076281a2c03356667fca7cce1a898a4f155e3dce" rel=3D"noreferrer" targe= t=3D"_blank">https://github.com/nice-software/lmdb/commit/076281a2c03356667= fca7cce1a898a4f155e3dce</a><br> <br> <br> =C2=A0 =C2=A0 I see no error when compiling with gcc -Wall. Closing this IT= S.<br> <br> =C2=A0 =C2=A0 --<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0-- Howard Chu<br> =C2=A0 =C2=A0 =C2=A0 =C2=A0CTO, Symas Corp. <a href=3D"http://www.symas.com= " rel=3D"noreferrer" target=3D"_blank">http://www.symas.com</a><br> =C2=A0 =C2=A0 =C2=A0 =C2=A0Director, Highland Sun <a href=3D"http://highlan= dsun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/= hyc/</a><br> =C2=A0 =C2=A0 =C2=A0 =C2=A0Chief Architect, OpenLDAP <a href=3D"http://www.= openldap.org/project/" rel=3D"noreferrer" target=3D"_blank">http://www.open= ldap.org/project/</a><br> <br> <br> <br> <br> --<br> Ignacio Casal Quinteiro<br> </span></blockquote><div class=3D"HOEnZb"><div class=3D"h5"> <br> <br> -- <br> =C2=A0 -- Howard Chu<br> =C2=A0 CTO, Symas Corp.=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0<a href=3D"= http://www.symas.com" rel=3D"noreferrer" target=3D"_blank">http://www.symas= .com</a><br> =C2=A0 Director, Highland Sun=C2=A0 =C2=A0 =C2=A0<a href=3D"http://highland= sun.com/hyc/" rel=3D"noreferrer" target=3D"_blank">http://highlandsun.com/h= yc/</a><br> =C2=A0 Chief Architect, OpenLDAP=C2=A0 <a href=3D"http://www.openldap.org/p= roject/" rel=3D"noreferrer" target=3D"_blank">http://www.openldap.org/proje= ct/</a><br> </div></div></blockquote></div><br><br clear=3D"all"><br>-- <br><div class= =3D"gmail_signature">Ignacio Casal Quinteiro</div> </div> --f46d044289f661da1905226fa6a2--

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs