gnoe(a)symas.com wrote:
> Full_Name: Gregory Noe
> Version:
> OS:
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (63.142.209.94)
>
>
> Update mdb_load to safely load back-mdb databases. Currently back-mdb's custom
> sort functions don't order database items in the correct order.
Actually no, this ITS is about tweaking back-mdb to give mdb_load a better
hint about what ordering to use. In particular, the id2v table in master/RE25
isn't being reloaded in proper order at the moment.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
--On Wednesday, May 24, 2017 3:14 PM +0000 nespor(a)id.ethz.ch wrote:
> I am not quite sure, if it is really the same problem. I do not use the
> Red Hat openldap package.
> I have downloaded openldap-2.4.44.tgz on January 5, 2017, and compiled
> myself.
Yes, it was fixed in May of 2016 (2.4.44 was released February of 2016).
So it is already fixed for the next release (2.4.45).
Hope that helps.
--Quanah
--
Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
I am not quite sure, if it is really the same problem. I do not use the
Red Hat openldap package.
I have downloaded openldap-2.4.44.tgz on January 5, 2017, and compiled
myself.
On 05/24/17 15:48, Howard Chu wrote:
> Howard Chu wrote:
>> nespor(a)id.ethz.ch wrote:
>>> Full_Name: Vlado Nespor
>>> Version: 2.4.44
>>> OS: Red Hat el7
>>> URL: ftp://ftp.openldap.org/incoming/
>>> Submission from: (NULL) (2001:67c:10ec:32d0::222)
>>>
>>>
>>> We have experienced random slapd segmentation faults, when the relay
>>> backend and rwm overlay were used in the configuration. After some
>>> time I could reproduce the segmentation fault on a slow client and
>>> with test queries, which were supposed to return a larger set of
>>> entries.
>>>
>>> I could trace the problem to a wrong pointer in the slap_writewait_play
>>> function in the openldap-2.4.44/servers/slapd/result.c file, and then
>>> further to the openldap-2.4.44/servers/slapd/back-relay/op.c file.
>>> After
>>> the addition of the sc_writewait pointer initialisation (see the patch
>>> below), the test queries returned correct results and random slapd
>>> segmentation faults disappeared.
>>
>> Thanks for the report, but this was already fixed in ITS#8218
>> released in
>> 2.4.43. Sounds like Red Hat has botched their source code since the
>> official
>> fix has been out for nearly 2 years already.
>
> Sorry, a typo on my part. It was ITS#8428.
>
Howard Chu wrote:
> nespor(a)id.ethz.ch wrote:
>> Full_Name: Vlado Nespor
>> Version: 2.4.44
>> OS: Red Hat el7
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (2001:67c:10ec:32d0::222)
>>
>>
>> We have experienced random slapd segmentation faults, when the relay
>> backend and rwm overlay were used in the configuration. After some
>> time I could reproduce the segmentation fault on a slow client and
>> with test queries, which were supposed to return a larger set of entries.
>>
>> I could trace the problem to a wrong pointer in the slap_writewait_play
>> function in the openldap-2.4.44/servers/slapd/result.c file, and then
>> further to the openldap-2.4.44/servers/slapd/back-relay/op.c file. After
>> the addition of the sc_writewait pointer initialisation (see the patch
>> below), the test queries returned correct results and random slapd
>> segmentation faults disappeared.
>
> Thanks for the report, but this was already fixed in ITS#8218 released in
> 2.4.43. Sounds like Red Hat has botched their source code since the official
> fix has been out for nearly 2 years already.
Sorry, a typo on my part. It was ITS#8428.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
nespor(a)id.ethz.ch wrote:
> Full_Name: Vlado Nespor
> Version: 2.4.44
> OS: Red Hat el7
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (2001:67c:10ec:32d0::222)
>
>
> We have experienced random slapd segmentation faults, when the relay
> backend and rwm overlay were used in the configuration. After some
> time I could reproduce the segmentation fault on a slow client and
> with test queries, which were supposed to return a larger set of entries.
>
> I could trace the problem to a wrong pointer in the slap_writewait_play
> function in the openldap-2.4.44/servers/slapd/result.c file, and then
> further to the openldap-2.4.44/servers/slapd/back-relay/op.c file. After
> the addition of the sc_writewait pointer initialisation (see the patch
> below), the test queries returned correct results and random slapd
> segmentation faults disappeared.
Thanks for the report, but this was already fixed in ITS#8218 released in
2.4.43. Sounds like Red Hat has botched their source code since the official
fix has been out for nearly 2 years already.
>
> With best regards,
>
> Vlado Nespor
>
>
> diff -rupN openldap-2.4.44/servers/slapd/back-relay/op.c
> openldap-2.4.44_back-relay/servers/slapd/back-relay/op.c
> --- openldap-2.4.44/servers/slapd/back-relay/op.c 2016-02-06 00:57:45.000000000
> +0100
> +++ openldap-2.4.44_back-relay/servers/slapd/back-relay/op.c 2017-02-07
> 15:09:55.046188340 +0100
> @@ -97,6 +97,7 @@ relay_back_response_cb( Operation *op, S
> (rcb)->rcb_sc.sc_next = (op)->o_callback; \
> (rcb)->rcb_sc.sc_response = relay_back_response_cb; \
> (rcb)->rcb_sc.sc_cleanup = 0; \
> + (rcb)->rcb_sc.sc_writewait = 0; \
> (rcb)->rcb_sc.sc_private = (op)->o_bd; \
> (op)->o_callback = (slap_callback *) (rcb); \
> }
>
>
>
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Full_Name: Vlado Nespor
Version: 2.4.44
OS: Red Hat el7
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (2001:67c:10ec:32d0::222)
We have experienced random slapd segmentation faults, when the relay
backend and rwm overlay were used in the configuration. After some
time I could reproduce the segmentation fault on a slow client and
with test queries, which were supposed to return a larger set of entries.
I could trace the problem to a wrong pointer in the slap_writewait_play
function in the openldap-2.4.44/servers/slapd/result.c file, and then
further to the openldap-2.4.44/servers/slapd/back-relay/op.c file. After
the addition of the sc_writewait pointer initialisation (see the patch
below), the test queries returned correct results and random slapd
segmentation faults disappeared.
With best regards,
Vlado Nespor
diff -rupN openldap-2.4.44/servers/slapd/back-relay/op.c
openldap-2.4.44_back-relay/servers/slapd/back-relay/op.c
--- openldap-2.4.44/servers/slapd/back-relay/op.c 2016-02-06 00:57:45.000000000
+0100
+++ openldap-2.4.44_back-relay/servers/slapd/back-relay/op.c 2017-02-07
15:09:55.046188340 +0100
@@ -97,6 +97,7 @@ relay_back_response_cb( Operation *op, S
(rcb)->rcb_sc.sc_next = (op)->o_callback; \
(rcb)->rcb_sc.sc_response = relay_back_response_cb; \
(rcb)->rcb_sc.sc_cleanup = 0; \
+ (rcb)->rcb_sc.sc_writewait = 0; \
(rcb)->rcb_sc.sc_private = (op)->o_bd; \
(op)->o_callback = (slap_callback *) (rcb); \
}
quanah(a)symas.com wrote:
> Seems like it would have been better to leave audit* attrs with slapo-auditlog
I was not aware of a specific schema for slapo-auditlog
(except attribute type 'olcAuditlogFile' for back-config).
Ciao, Michael.