Full_Name: Muthamma
Version: 2.4 and 2.3
OS:
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (2620:160:e708:6::a)
Hi team,
Could you confirm if the product OpenLDAP is a stand-alone product or embedded?
Full_Name: Andreas Schulze
Version: 2.4.45
OS: Linux
URL: ftp://ftp.openldap.org/incoming/andreas-schulze-180224.patch
Submission from: (NULL) (2001:470:77b3:50::65)
Debian Lintian found a typo in libraries/libldap/os-local.c: "errror" should be
"error"
Patch attached
Andreas
--On Friday, February 23, 2018 5:07 PM +0000 Howard Chu <hyc(a)symas.com>
wrote:
> quanah(a)openldap.org wrote:
>> Full_Name: Quanah Gibson-Mount
>> Version: HEAD
>> OS: N/A
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (47.208.148.239)
>>
>>
>> When attempting to link OpenLDAP to OpenSSL 1.0.2 series, where OpenSSL
>> has been built with deprecated API's disabled, the build will fail.
>> This is because RSA_F4 is deprecated in 1.0.2. In master, this is
>> around line 1367:
>>
>> # if OPENSSL_VERSION_NUMBER < 0x10100000
>> static RSA *
>> tlso_tmp_rsa_cb( SSL *ssl, int is_export, int key_length )
>
>> This function needs to check < 1.0.2 rather than < 1.1
>
> That would only be true if the RSA callback is not needed at all in
> 1.0.2. Is that true?
Not sure. Exact error is in RE24 is:
tls_o.c:1184:25: error: 'RSA_F4' undeclared (first use in this function)
if ( BN_set_word( bn, RSA_F4 )) {
so it dies before we get to the RSA_generate_key_ex function itself.
--Quanah
--
Quanah Gibson-Mount
Product Architect
Symas Corporation
Packaged, certified, and supported LDAP solutions powered by OpenLDAP:
<http://www.symas.com>
quanah(a)openldap.org wrote:
> Full_Name: Quanah Gibson-Mount
> Version: HEAD
> OS: N/A
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (47.208.148.239)
>
>
> When attempting to link OpenLDAP to OpenSSL 1.0.2 series, where OpenSSL has been
> built with deprecated API's disabled, the build will fail. This is because
> RSA_F4 is deprecated in 1.0.2. In master, this is around line 1367:
>
> #if OPENSSL_VERSION_NUMBER < 0x10100000
> static RSA *
> tlso_tmp_rsa_cb( SSL *ssl, int is_export, int key_length )
> This function needs to check < 1.0.2 rather than < 1.1
That would only be true if the RSA callback is not needed at all in 1.0.2. Is
that true?
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
Full_Name: Quanah Gibson-Mount
Version: HEAD
OS: N/A
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (47.208.148.239)
When attempting to link OpenLDAP to OpenSSL 1.0.2 series, where OpenSSL has been
built with deprecated API's disabled, the build will fail. This is because
RSA_F4 is deprecated in 1.0.2. In master, this is around line 1367:
#if OPENSSL_VERSION_NUMBER < 0x10100000
static RSA *
tlso_tmp_rsa_cb( SSL *ssl, int is_export, int key_length )
{
RSA *tmp_rsa;
/* FIXME: Pregenerate the key on startup */
/* FIXME: Who frees the key? */
#if OPENSSL_VERSION_NUMBER >= 0x00908000
BIGNUM *bn = BN_new();
tmp_rsa = NULL;
if ( bn ) {
if ( BN_set_word( bn, RSA_F4 )) {
tmp_rsa = RSA_new();
if ( tmp_rsa && !RSA_generate_key_ex( tmp_rsa, key_length, bn, NULL
)) {
RSA_free( tmp_rsa );
tmp_rsa = NULL;
}
}
BN_free( bn );
}
#else
tmp_rsa = RSA_generate_key( key_length, RSA_F4, NULL, NULL );
#endif
if ( !tmp_rsa ) {
Debug( LDAP_DEBUG_ANY,
"TLS: Failed to generate temporary %d-bit %s RSA key\n",
key_length, is_export ? "export" : "domestic", 0 );
}
return tmp_rsa;
}
#endif /* OPENSSL_VERSION_NUMBER < 1.1 */
This function needs to check < 1.0.2 rather than < 1.1
cheimes(a)redhat.com wrote:
> This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
> --xtLU7S4g0jUK8GMHh0QtLLEN50A6OirhP
> Content-Type: multipart/mixed; boundary="ImAEehvUF6AyAI2LgcI3vl7LvbpVlLmbd";
> protected-headers="v1"
> From: Christian Heimes <cheimes(a)redhat.com>
> To: Howard Chu <hyc(a)symas.com>, openldap-its(a)OpenLDAP.org
> Message-ID: <1ad5d71c-c2c2-701e-1550-5296c850a51e(a)redhat.com>
> Subject: Re: (ITS#8805) Documentation for LDAP_OPT_X_TLS_NEWCTX is wrong
> References: <E1emLjU-0005uv-8G(a)gauss.openldap.net>
> <9e35c40f-d567-5dec-dd5d-085dcd356483(a)symas.com>
> In-Reply-To: <9e35c40f-d567-5dec-dd5d-085dcd356483(a)symas.com>
>
> --ImAEehvUF6AyAI2LgcI3vl7LvbpVlLmbd
> Content-Type: text/plain; charset=utf-8
> Content-Language: en-US
> Content-Transfer-Encoding: quoted-printable
>
> On 2018-02-15 17:04, Howard Chu wrote:
>> I see no disagreement between the code and the documentation. Please
>> elaborate, otherwise this ITS will be closed.
>
> For a non-native speaker, the documentation sounds a bit like
> ldap_set_option(l, LDAP_OPT_X_TLS_NEWCTX, 0) does not create a new
> context at all because the input value is zero. Could you please mention
> that a zero value creates a client context?
"This option creates a context.
If you specify a 1, it will create a context for a server."
Nothing in these statements implies that it will *not* create a context.
Closing this ITS.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--xtLU7S4g0jUK8GMHh0QtLLEN50A6OirhP
Content-Type: multipart/mixed; boundary="ImAEehvUF6AyAI2LgcI3vl7LvbpVlLmbd";
protected-headers="v1"
From: Christian Heimes <cheimes(a)redhat.com>
To: Howard Chu <hyc(a)symas.com>, openldap-its(a)OpenLDAP.org
Message-ID: <1ad5d71c-c2c2-701e-1550-5296c850a51e(a)redhat.com>
Subject: Re: (ITS#8805) Documentation for LDAP_OPT_X_TLS_NEWCTX is wrong
References: <E1emLjU-0005uv-8G(a)gauss.openldap.net>
<9e35c40f-d567-5dec-dd5d-085dcd356483(a)symas.com>
In-Reply-To: <9e35c40f-d567-5dec-dd5d-085dcd356483(a)symas.com>
--ImAEehvUF6AyAI2LgcI3vl7LvbpVlLmbd
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
On 2018-02-15 17:04, Howard Chu wrote:
> I see no disagreement between the code and the documentation. Please
> elaborate, otherwise this ITS will be closed.
For a non-native speaker, the documentation sounds a bit like
ldap_set_option(l, LDAP_OPT_X_TLS_NEWCTX, 0) does not create a new
context at all because the input value is zero. Could you please mention
that a zero value creates a client context?
--=20
Christian Heimes
Senior Software Engineer, Identity Management and Platform Security
Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,
Commercial register: Amtsgericht Muenchen, HRB 153243,
Managing Directors: Charles Cachera, Michael Cunningham, Michael
O'Neill, Eric Shander
--ImAEehvUF6AyAI2LgcI3vl7LvbpVlLmbd--
--xtLU7S4g0jUK8GMHh0QtLLEN50A6OirhP
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQEzBAEBCgAdFiEEL7+ElqIWjf0BBClLhmhSSSEttokFAlqFtLAACgkQhmhSSSEt
ton6FggAqOSMIaWDSrVLYVQPxhqAQh+HDbinIaxgLPZarYxr0ijth8wPbpdt0f1s
Bgq21a71Qkrrr9joDhb6T3I7ZOs85wsq8mFlHAqciVV2qJGCOFDYd7SOveAyyY6/
PgETKxQ9/S/ei+8NKiRhc0UP2wAvUF8pus7TyJDMao8/EumButO8R8MJWydBOdkh
/5kUuROlo1B9owujmNY9V7tIKUU5to6zj1r05gJXrznP+ex+ZkoJz6Us+PedueRe
uF5/jAibFnLIpk0WRN+DdTl1PqZnXVGHfBaHsVbpH5Wff+yzxgUNwo4zmQB6sCuA
w+82yYr0Lbh243efKYPC+ivRjfs4kg==
=A94C
-----END PGP SIGNATURE-----
--xtLU7S4g0jUK8GMHh0QtLLEN50A6OirhP--
cheimes(a)redhat.com wrote:
> Full_Name: Christian Heimes
> Version: 2.4.45
> OS: Fedora
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (2001:16b8:607e:f300:6312:6da:8e63:dfa2)
>
>
> The documentation for ldap_set_option LDAP_OPT_X_TLS_NEWCTX is wrong or at least
> misleading. The man page https://linux.die.net/man/3/ldap_set_option describes
> the option as:
>
>> Instructs the library to create a new TLS library context. invalue must be
> const int *. A non-zero value pointed to by invalue tells the library to create
> a context for a server.
>
> However tls2 creates a new context for any non-NULL argument, even for
> ldap_set_option(l, LDAP_OPT_X_TLS_NEWCTX, 0). See
> https://github.com/openldap/openldap/blob/OPENLDAP_REL_ENG_2_4_45/libraries…
I see no disagreement between the code and the documentation. Please
elaborate, otherwise this ITS will be closed.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/