openldap-bugs

openldap-bugs@openldap.org

1 participants
20967 discussions

Re: (ITS#8831) Database flags reset in mdb_load
by hyc＠symas.com 02 Apr '18

02 Apr '18

gnoe(a)symas.com wrote: > Full_Name: Gregory Noe > Version: 2.4.46 > OS: All > URL: ftp://ftp.openldap.org/incoming/mdb_load-dbflag-patch.c > Submission from: (NULL) (63.142.209.94) > > > The flags variable set by the readhdr function in mdb_load is getting set to 0 > before the mdb database is opened for writing. The submitted patch fixes the > issue. > > > --- > Symas Corporation hereby place the following modifications to OpenLDAP Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose with or > without attribution and/or other notice. > --- Thanks for the report. A slightly different patch was used. Fixed now in mdb.master. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8831) Database flags reset in mdb_load
by gnoe＠symas.com 02 Apr '18

02 Apr '18

Full_Name: Gregory Noe Version: 2.4.46 OS: All URL: ftp://ftp.openldap.org/incoming/mdb_load-dbflag-patch.c Submission from: (NULL) (63.142.209.94) The flags variable set by the readhdr function in mdb_load is getting set to 0 before the mdb database is opened for writing. The submitted patch fixes the issue. --- Symas Corporation hereby place the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. ---

1 0

Re: (ITS#8830) build hardcodes gcc
by hyc＠symas.com 02 Apr '18

02 Apr '18

vcunat(a)gmail.com wrote: > On 04/01/2018 12:37 PM, Howard Chu wrote: >> vcunat(a)gmail.com wrote: >>> On 04/01/2018 12:12 PM, Howard Chu wrote: >>>> The rules you patched are only for generating gcov-compatible binari= es. >>>> They aren't even invoked by "make test" so I don't see why this has = any >>>> impact on your build at all. >>>> >>> >>> The build looks like this: >>> ... >>> running tests >>> ar rs liblmdb.a mdb.o midl.o >>> gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cas= t >>> -Wuninitialized=C3=82 =C3=82 mdb_stat.o liblmdb.a=C3=82 -o mdb_stat >>> make: gcc: Command not found >> >> What's the actual command line you used to invoke this? >=20 > It should be basically `make` before that part and `make test` in the > "running tests" part. Some build flags were passed, too. >=20 > Hmm, weird, I can't see why make decided to do this, and it doesn't > happen with Linux+clang locally (I have no direct access to osx now). > Maybe I'm just tired ATM. Possibly the full failed build log will shed > light on this? > https://logs.nix.ci/?key=3Dnixos/nixpkgs.38289&attempt_id=3De3767f8e-8c= 1e-4404-93b1-d23d9fe429ee >=20 > If you can't see why, I'll try to revisit this weirdness to avoid > potential surprises in future. The log doesn't show the actual command invocations. Most likely your "ma= ke=20 test" isn't setting CC=3Dgcc. It's probably also doing something else wei= rd=20 since it's building liblmdb.a twice. Regardless, there is no bug in the L= MDB=20 Makefile, your build invocations are broken. Closing this ITS. --=20 -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8830) build hardcodes gcc
by vcunat＠gmail.com 01 Apr '18

01 Apr '18

On 04/01/2018 12:37 PM, Howard Chu wrote: > vcunat(a)gmail.com wrote: >> On 04/01/2018 12:12 PM, Howard Chu wrote: >>> The rules you patched are only for generating gcov-compatible binaries. >>> They aren't even invoked by "make test" so I don't see why this has any >>> impact on your build at all. >>> >> >> The build looks like this: >> ... >> running tests >> ar rs liblmdb.a mdb.o midl.o >> gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast >> -Wuninitialized mdb_stat.o liblmdb.a -o mdb_stat >> make: gcc: Command not found > > What's the actual command line you used to invoke this? It should be basically `make` before that part and `make test` in the "running tests" part. Some build flags were passed, too. Hmm, weird, I can't see why make decided to do this, and it doesn't happen with Linux+clang locally (I have no direct access to osx now). Maybe I'm just tired ATM. Possibly the full failed build log will shed light on this? https://logs.nix.ci/?key=nixos/nixpkgs.38289&attempt_id=e3767f8e-8c1e-4404-… If you can't see why, I'll try to revisit this weirdness to avoid potential surprises in future.

1 0

Re: (ITS#8830) build hardcodes gcc
by hyc＠symas.com 01 Apr '18

01 Apr '18

vcunat(a)gmail.com wrote: > On 04/01/2018 12:12 PM, Howard Chu wrote: >> The rules you patched are only for generating gcov-compatible binaries. >> They aren't even invoked by "make test" so I don't see why this has any >> impact on your build at all. >> > > The build looks like this: > ... > running tests > ar rs liblmdb.a mdb.o midl.o > gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast > -Wuninitialized mdb_stat.o liblmdb.a -o mdb_stat > make: gcc: Command not found What's the actual command line you used to invoke this? -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8830) build hardcodes gcc
by vcunat＠gmail.com 01 Apr '18

01 Apr '18

On 04/01/2018 12:12 PM, Howard Chu wrote: > The rules you patched are only for generating gcov-compatible binaries. > They aren't even invoked by "make test" so I don't see why this has any > impact on your build at all. > The build looks like this: ... running tests ar rs liblmdb.a mdb.o midl.o gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized mdb_stat.o liblmdb.a -o mdb_stat make: gcc: Command not found

1 0

Re: (ITS#8830) build hardcodes gcc
by hyc＠symas.com 01 Apr '18

01 Apr '18

vcunat(a)gmail.com wrote: > On 04/01/2018 11:53 AM, Howard Chu wrote: >> The coverage flags have only been tested with gcc. What compiler are you >> using that also provides code coverage with these flags? > > This is clang on osx, kind of. > > NixOS.org is packaging lmdb for various "platforms", including osx. And > we run `make test` to be more confident about the result. That's what > now broke when we attempt lmdb: 0.9.21 -> 0.9.22 - and this patch fixed > the build (though I didn't really check anything; I don't really have > any osx machine myself). > > My experience in general is that clang tries to be compatible with gcc. The rules you patched are only for generating gcov-compatible binaries. They aren't even invoked by "make test" so I don't see why this has any impact on your build at all. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8830) build hardcodes gcc
by vcunat＠gmail.com 01 Apr '18

01 Apr '18

On 04/01/2018 11:53 AM, Howard Chu wrote: > The coverage flags have only been tested with gcc. What compiler are you > using that also provides code coverage with these flags? This is clang on osx, kind of. NixOS.org is packaging lmdb for various "platforms", including osx. And we run `make test` to be more confident about the result. That's what now broke when we attempt lmdb: 0.9.21 -> 0.9.22 - and this patch fixed the build (though I didn't really check anything; I don't really have any osx machine myself). My experience in general is that clang tries to be compatible with gcc.

1 0

Re: (ITS#8830) build hardcodes gcc
by hyc＠symas.com 01 Apr '18

01 Apr '18

vcunat(a)gmail.com wrote: > Full_Name: Vladim.r &#268;un.t > Version: 0.9.22 (lmdb) > OS: Linux (NixOS) > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (178.255.168.34) >=20 >=20 > Some parts of the LMDB Makefile hardcode gcc, seemingly unnecessarily. = Please > apply the following patch or some similar fix. The coverage flags have only been tested with gcc. What compiler are you = using=20 that also provides code coverage with these flags? >=20 > commit 029031a68873bc3784a8561bd8e049efbd34f9d0 (HEAD) > Author: Vladim=C3=ADr Čun=C3=A1t <vcunat(a)gmail.com> > Date: Sun Apr 1 11:05:31 2018 +0200 >=20 > make: gcc -> $(CC) >=20 > diff --git a/libraries/liblmdb/Makefile b/libraries/liblmdb/Makefile > index f254511..612484e 100644 > --- a/libraries/liblmdb/Makefile > +++ b/libraries/liblmdb/Makefile > @@ -102,13 +102,13 @@ COV_OBJS=3Dxmdb.o xmidl.o > =20 > coverage: xmtest > for i in mtest*.c [0-9]*.c; do j=3D`basename \$$i .c`; $(MAKE) $$j.o= ; \ > - gcc -o x$$j $$j.o $(COV_OBJS) -pthread $(COV_FLAGS); \ > + $(CC) -o x$$j $$j.o $(COV_OBJS) -pthread $(COV_FLAGS); \ > rm -rf testdb; mkdir testdb; ./x$$j; done > gcov xmdb.c > gcov xmidl.c > =20 > xmtest: mtest.o xmdb.o xmidl.o > - gcc -o xmtest mtest.o xmdb.o xmidl.o -pthread $(COV_FLAGS) > + $(CC) -o xmtest mtest.o xmdb.o xmidl.o -pthread $(COV_FLAGS) > =20 > xmdb.o: mdb.c lmdb.h midl.h > $(CC) $(CFLAGS) -fPIC $(CPPFLAGS) -O0 $(COV_FLAGS) -c mdb.c -o $@ >=20 >=20 --=20 -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8829) Right shift build warning VS2017 mdb.c
by hyc＠symas.com 01 Apr '18

01 Apr '18

robin.rowe(a)cinepaint.org wrote: > Full_Name: Robin Rowe > Version: git > OS: Windows 10 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (23.242.20.216) > > > Warning from VS2017: > > mdb.c(7455): warning C4333: '>>': right shift by too large amount, data loss > > 7455: SETDSZ(node, nsize); > > 960: #define SETDSZ(node,size) do { \ > 961: (node)->mn_lo = (size) & 0xffff; (node)->mn_hi = (size) >> 16;} while(0) > > Intentional and irrelevant. Closing this ITS. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs