https://bugs.openldap.org/show_bug.cgi?id=8650
Howard Chu <hyc(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |RESOLVED
Resolution|--- |TEST
--- Comment #18 from Howard Chu <hyc(a)openldap.org> ---
Commits:
• 735e1ab
by Howard Chu at 2020-04-12T22:18:51+00:00
ITS#8650 loop on incomplete TLS handshake
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8650
--- Comment #17 from Ryan Tandy <ryan(a)openldap.org> ---
Created attachment 708
--> https://bugs.openldap.org/attachment.cgi?id=708&action=edit
test program with non-blocking socket
Here's a test program that exercises the scenario with a non-blocking socket,
similar to the case described in bug 9210. Currently it fails on 2.4 with
LDAP_SERVER_DOWN and on 2.5 with LDAP_TIMEOUT, but succeeds if you comment out
the fcntl(). Any patch needs to correct that as well as the scenario described
here with a blocking socket.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8650
--- Comment #16 from Ryan Tandy <ryan(a)openldap.org> ---
*** Bug 9210 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8650
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--- Comment #15 from Ryan Tandy <ryan(a)openldap.org> ---
The other way we can get a non-blocking socket is if the client set one up
itself and gave it to us via ldap_init_fd(). sssd does this, or used to: bug
9210.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8650
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |lukas.juhrich(a)agdsn.de
--- Comment #14 from Ryan Tandy <ryan(a)openldap.org> ---
*** Bug 9210 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8650
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.openldap.org/s
| |how_bug.cgi?id=9210
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8847
--- Comment #31 from Ryan Tandy <ryan(a)openldap.org> ---
Hello, I have been reviewing and testing this patch and I think that there are
a number of issues, some less severe and some more, that should still be
addressed.
In general the patch does not seem well adapted to the surrounding code. For
example things have been added at random positions in lists that previously
were sorted, and the whitespace style (and code style generally) are quite
different from the existing code. Also, the new code does not seem to respect
the configure option (and #ifdefs etc) for disabling IPv6 support.
doc/man/man3/ldap_get_option.3:
- LDAP_OPT_SOCKET_BIND_ADDRESSES added at the wrong place
doc/man/man5/ldap.conf.5:
- SOCKET_BIND_ADDRESSES added at the wrong place
- typo (seperated -> separated)
libraries/libldap/ldap-int.h:
- /* pull in netinet/in */ is a useless comment
- fails to compile under MinGW (there is no netinet/in.h header)
-> I could be wrong but 'struct in_addr' feels rather low-level for this
file?
but I'm not sure what a better design would look like...
- should not include IPv6 bits if IPv6 disabled
- LDAP_LDO_NULLARG has not been updated (gcc generates a warning)
- if ITS#6567 is finished before this one, MAX_LDAP_ADDR_LEN will probably need
an update ("GSSAPI_ALLOW_REMOTE_PRINCIPAL" is longer than
"SOCKET_BIND_ADDRESSES" is longer than "TLS_CIPHER_SUITE")
libraries/libldap/options.c:
- in ldap_set_option: other options reset to default when invalue == NULL, it
would be nice if this would do the same
- ldap_validate_and_fill_sourceip feels a bit weird again, there are no other
similar functions in this file... maybe os-ip.c or util-int.c?
- in the existing code, inet_pton is only used if LDAP_PF_INET6; should
probably
follow that pattern (there is also HAVE_INET_NTOP...)
libraries/libldap/os-ip.c:
- possibly the new code should be in ldap_int_prepare_socket()? not sure...
- address family mismatch (only one bind address specified and socket uses the
other family) ignored; should we try to catch it?
-> MS implementation returns LDAP_SERVER_DOWN when this happens
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=6567
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |IN_PROGRESS
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=6567
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|TEST |---
Status|RESOLVED |CONFIRMED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=6567
--- Comment #15 from Ryan Tandy <ryan(a)openldap.org> ---
I think there are some bits that can still be cleaned up:
.gitignore:96:libraries/libldap_r/gssapi.c
^- gssapi.c itself was deleted
include/ldap.h:205:/* OpenLDAP GSSAPI options */
include/ldap.h:206:#define LDAP_OPT_X_GSSAPI_DO_NOT_FREE_CONTEXT 0x6200
include/ldap.h:207:#define LDAP_OPT_X_GSSAPI_ALLOW_REMOTE_PRINCIPAL 0x6201
^- all uses of these have been removed
libraries/libldap/init.c:141:#define MAX_LDAP_ATTR_LEN
sizeof("GSSAPI_ALLOW_REMOTE_PRINCIPAL")
^- previously MAX_LDAP_ATTR_LEN used "TLS_CIPHER_SUITE", probably switch it
back to that (double check nothing else is longer)
(note to self actually, MAX_LDAP_ATTR_LEN is almost certainly relevant for
ITS#8847 too...)
libraries/libldap/init.c:44: LDAP_LDO_GSSAPI_NULLARG
libraries/libldap/init.c:60:#define ATTR_GSSAPI 10
libraries/libldap/ldap-int.h:308:#define LDAP_LDO_GSSAPI_NULLARG
^- I think these are just cruft as well...
--
You are receiving this mail because:
You are on the CC list for the bug.