--BI5RvnYi6R4T2M87
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On Sun, Jun 29, 2008 at 11:49:37AM -0700, Howard Chu wrote:
> vorlon(a)debian.org wrote:
>> This bug is marked as fixed in 2.4.8, but I still see the same problem in
>> the test suite in 2.4.10. Trying to start slapd with back-meta gives:
>> /home/devel/openldap/build-area/openldap2.3-2.4.10/debian/build/servers/slapd/.libs/lt-slapd: symbol lookup error: ../servers/slapd/back-meta/.libs/back_meta-2.4.so.2: undefined symbol: slap_idassert_parse_cf
>> Is this a regression since 2.4.8?
> Looks more like an incomplete fix. The functions in question haven't
> changed since 2006. Since we're not using a hacked libltdl the problem
> you're seeing doesn't show up here. I guess you should have tested this
> sooner...
Well, given that back_meta has been broken for an indeterminate period of
time on systems whose libltdl doesn't use the insane RTLD_GLOBAL option :),
the Debian userbase for that backend is roughly nonexistent which means
verifying the fix was not a high priority (except that I would like to be
able to turn on 'make test' during our builds). Is the correct fix to add
this function to the ldap_extra_t struct, as in the attached patch?
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slangasek(a)ubuntu.com vorlon(a)debian.org
--BI5RvnYi6R4T2M87
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=no_backend_inter-linking
Index: trunk/servers/slapd/back-ldap/back-ldap.h
===================================================================
--- trunk.orig/servers/slapd/back-ldap/back-ldap.h
+++ trunk/servers/slapd/back-ldap/back-ldap.h
@@ -428,6 +428,8 @@
int (*proxy_authz_ctrl)( Operation *op, SlapReply *rs, struct berval *bound_ndn,
int version, slap_idassert_t *si, LDAPControl *ctrl );
int (*controls_free)( Operation *op, SlapReply *rs, LDAPControl ***pctrls );
+ int (*idassert_parse_cf)( const char *fname, int lineno, int argc,
+ char *argv[], slap_idassert_t *si );
} ldap_extra_t;
LDAP_END_DECL
Index: trunk/servers/slapd/back-meta/config.c
===================================================================
--- trunk.orig/servers/slapd/back-meta/config.c
+++ trunk/servers/slapd/back-meta/config.c
@@ -1089,7 +1089,7 @@
}
cargv[ 2 ] = binddn;
- rc = slap_idassert_parse_cf( fname, lineno, cargc, cargv, &mi->mi_targets[ mi->mi_ntargets - 1 ]->mt_idassert );
+ rc = mi->mi_ldap_extra->idassert_parse_cf( fname, lineno, cargc, cargv, &mi->mi_targets[ mi->mi_ntargets - 1 ]->mt_idassert );
if ( rc == 0 ) {
struct berval bv;
@@ -1159,7 +1159,7 @@
return 1;
}
- return slap_idassert_parse_cf( fname, lineno, argc, argv, &mi->mi_targets[ mi->mi_ntargets - 1 ]->mt_idassert );
+ return mi->mi_ldap_extra->idassert_parse_cf( fname, lineno, argc, argv, &mi->mi_targets[ mi->mi_ntargets - 1 ]->mt_idassert );
/* idassert-authzFrom */
} else if ( strcasecmp( argv[ 0 ], "idassert-authzFrom" ) == 0 ) {
Index: trunk/servers/slapd/back-ldap/init.c
===================================================================
--- trunk.orig/servers/slapd/back-ldap/init.c
+++ trunk/servers/slapd/back-ldap/init.c
@@ -34,7 +34,8 @@
static const ldap_extra_t ldap_extra = {
ldap_back_proxy_authz_ctrl,
- ldap_back_controls_free
+ ldap_back_controls_free,
+ slap_idassert_parse_cf
};
int
--BI5RvnYi6R4T2M87--
Pierangelo Masarati <ando(a)sys-net.it> writes:
> Dieter Kluenter wrote:
>> Pierangelo Masarati <ando(a)sys-net.it> writes:
>>
>>> dieter(a)dkluenter.de wrote:
>>>
>>>> Sorry, forgot it,
>>> Should be fixed in HEAD, please test. I infer you're using multiple
>>> instances of slapo-dynlist(5) in your slapd.conf, aren't you?
>> No, just one instance.
>
> Sounds odd, because the error was related to executing slapo-dynlist's
> db_open() function while the static vars holding the dgIdentity (and
> the dgAuthz) attrs being already initialized. Can you test the fix to
> overlays/dynlist.c 1.51->1.52? It is for HEAD, but should apply
> straightforwardly to 2.4.
I just compiled HEAD and slapadd added the ldif file as expected. But
a second error occured, test failed with test001, but I will check
this tomorrow, same as the dynlist patch.
-Dieter
--
Dieter Klünter | Systemberatung
http://www.dkluenter.de
GPG Key ID:8EF7B6C6
michael(a)stroeder.com wrote:
> Full_Name: Michael Ströder
> Version: RE24
> OS: OpenSUSE Linux 10.2
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (84.163.82.89)
>
>
> Please add attribute type 'auditContext' to subschema.
It is registered by slapo-accesslog(5). I can see it when
slapo-accesslog(5) is built.
p.
Ing. Pierangelo Masarati
OpenLDAP Core Team
SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office: +39 02 23998309
Mobile: +39 333 4963172
Email: ando(a)sys-net.it
-----------------------------------
Dieter Kluenter wrote:
> Pierangelo Masarati <ando(a)sys-net.it> writes:
>
>> dieter(a)dkluenter.de wrote:
>>
>>> Sorry, forgot it,
>> Should be fixed in HEAD, please test. I infer you're using multiple
>> instances of slapo-dynlist(5) in your slapd.conf, aren't you?
>
> No, just one instance.
Sounds odd, because the error was related to executing slapo-dynlist's
db_open() function while the static vars holding the dgIdentity (and the
dgAuthz) attrs being already initialized. Can you test the fix to
overlays/dynlist.c 1.51->1.52? It is for HEAD, but should apply
straightforwardly to 2.4.
p.
Ing. Pierangelo Masarati
OpenLDAP Core Team
SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office: +39 02 23998309
Mobile: +39 333 4963172
Email: ando(a)sys-net.it
-----------------------------------
Pierangelo Masarati <ando(a)sys-net.it> writes:
> dieter(a)dkluenter.de wrote:
>
>> Sorry, forgot it,
>
> Should be fixed in HEAD, please test. I infer you're using multiple
> instances of slapo-dynlist(5) in your slapd.conf, aren't you?
No, just one instance.
-Dieter
--
Dieter Klünter | Systemberatung
http://www.dkluenter.de
GPG Key ID:8EF7B6C6
amg1127(a)cefetrs.tche.br wrote:
> I submitted a bug report in Ubuntu's Launchpad. The address is:
>
> https://bugs.launchpad.net/ubuntu/+source/openldap2.3/+bug/243337
>
> The bug refers to 2.4.9, but it is reproducible in OpenLDAP 2.4.10 (I could
> reproduce it, at least).
Your logs show something relatively odd: apparently, slapo-unique(5) is
trying to perform an internal search with a really malformed filter:
==> unique_search ,
str2filter "(&objectClass=posixGroup(|(gidNumber=1000)))"
put_filter: "(&objectClass=posixGroup(|(gidNumber=1000)))"
put_filter: AND
put_filter_list "objectClass=posixGroup(|(gidNumber=1000))"
Can you please try using "(objectClass=posixGroup)" instead of
"objectClass=posixGroup" as the unique_uri filter in your test slapd.conf?
p.
Ing. Pierangelo Masarati
OpenLDAP Core Team
SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office: +39 02 23998309
Mobile: +39 333 4963172
Email: ando(a)sys-net.it
-----------------------------------
dieter(a)dkluenter.de wrote:
> Sorry, forgot it,
Should be fixed in HEAD, please test. I infer you're using multiple
instances of slapo-dynlist(5) in your slapd.conf, aren't you?
p.
Ing. Pierangelo Masarati
OpenLDAP Core Team
SysNet s.r.l.
via Dossi, 8 - 27100 Pavia - ITALIA
http://www.sys-net.it
-----------------------------------
Office: +39 02 23998309
Mobile: +39 333 4963172
Email: ando(a)sys-net.it
-----------------------------------
Howard Chu <hyc(a)symas.com> writes:
> dieter(a)dkluenter.de wrote:
>> Full_Name: Dieter Kluenter
>> Version: 2.4.10
>> OS: openSUSE
>> URL: ftp://ftp.openldap.org/incoming/
>> Submission from: (NULL) (84.142.217.87)
[...]
>
> Where is the backtrace?
Sorry, forgot it,
#0 0x00007f07d3c6a5c5 in raise () from /lib64/libc.so.6
(gdb) bt
#0 0x00007f07d3c6a5c5 in raise () from /lib64/libc.so.6
#1 0x00007f07d3c6bbb3 in abort () from /lib64/libc.so.6
#2 0x00007f07d3c631e9 in __assert_fail () from /lib64/libc.so.6
#3 0x00000000004894a1 in slap_bv2ad (bv=0x7fffddbd3c30, ad=0x7f07d2bbc4f0,
text=0x7fffddbd3c70) at ad.c:164
#4 0x00000000004893a3 in slap_str2ad (str=0x7f07d29bad62 "dgIdentity",
ad=0x7f07d2bbc4f0, text=0x7fffddbd3c70) at ad.c:123
#5 0x00007f07d29ba0bc in dynlist_db_open (be=0x7fffddbd3ce0,
cr=0x7fffddbd3f20) at dynlist.c:1560
#6 0x00000000004bae67 in over_db_open (be=0x8b9a90, cr=0x7fffddbd3f20)
at backover.c:153
#7 0x0000000000449819 in backend_startup_one (be=0x8b9a90, cr=0x7fffddbd3f20)
at backend.c:224
#8 0x0000000000449ad2 in backend_startup (be=0x8b9a90) at backend.c:267
#9 0x000000000047366f in slap_startup (be=0x8b9a90) at init.c:225
#10 0x00000000004c1853 in slap_tool_init (progname=0x55a728 "slapadd", tool=1,
argc=10, argv=0x7fffddbe4a08) at slapcommon.c:725
#11 0x00000000004beff0 in slapadd (argc=10, argv=0x7fffddbe4a08)
at slapadd.c:73
#12 0x00000000004190ef in main (argc=10, argv=0x7fffddbe4a08) at main.c:636
(gdb)
-Dieter
--
Dieter Klünter | Systemberatung
http://www.dkluenter.de
GPG Key ID:8EF7B6C6
hyc(a)symas.com wrote:
> vorlon(a)debian.org wrote:
>> This bug is marked as fixed in 2.4.8, but I still see the same problem in
>> the test suite in 2.4.10. Trying to start slapd with back-meta gives:
>>
>> /home/devel/openldap/build-area/openldap2.3-2.4.10/debian/build/servers/slapd/.libs/lt-slapd: symbol lookup error: ../servers/slapd/back-meta/.libs/back_meta-2.4.so.2: undefined symbol: slap_idassert_parse_cf
>>
>> Is this a regression since 2.4.8?
>
> Looks more like an incomplete fix. The functions in question haven't changed
> since 2006. Since we're not using a hacked libltdl the problem you're seeing
> doesn't show up here. I guess you should have tested this sooner...
Additional patches for back-ldap/back-meta are now in HEAD; please test.
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/
vorlon(a)debian.org wrote:
> This bug is marked as fixed in 2.4.8, but I still see the same problem in
> the test suite in 2.4.10. Trying to start slapd with back-meta gives:
>
> /home/devel/openldap/build-area/openldap2.3-2.4.10/debian/build/servers/slapd/.libs/lt-slapd: symbol lookup error: ../servers/slapd/back-meta/.libs/back_meta-2.4.so.2: undefined symbol: slap_idassert_parse_cf
>
> Is this a regression since 2.4.8?
Looks more like an incomplete fix. The functions in question haven't changed
since 2006. Since we're not using a hacked libltdl the problem you're seeing
doesn't show up here. I guess you should have tested this sooner...
--
-- Howard Chu
CTO, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc/
Chief Architect, OpenLDAP http://www.openldap.org/project/