https://bugs.openldap.org/show_bug.cgi?id=9059
--- Comment #4 from Ondřej Kuzník <ondra(a)mistotebe.net> ---
The response is triggered by
https://git.openldap.org/openldap/openldap/-/blob/fd23680a447b9efe1a481dd64…
but it looks like the sessionlog has already been replayed correctly.
In that case, we are either finished or have a persistent search set up and all
remaining responses are queued up to be sent, so we shouldn't even care if we
can still find the CSN in the DB... Moving that whole `if` under `do_present ==
1` should then be enough and it might not be related to bug 8125 at all.
But then I might be missing something.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9240
Bug ID: 9240
Summary: Can't log to stdout/stderr
Product: OpenLDAP
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: slapd
Assignee: bugs(a)openldap.org
Reporter: hadmut(a)danisch.de
Target Milestone: ---
Hi,
slapd can send its logs and messages to syslog, which is nice and good in
common Unix/Linux environments, but I didn't see any way to have the logs sent
to stdout/stderr instead of syslog.
When run in a docker/kubernetes container, which is a typical use nowadays, it
should be run as a single process, and not require a separate syslog process
just to write some logs to a file. There are dirty workarounds, but if run
cleanly, it should be a standalone process.
Therefore, it would be nice if slap had a container mode, where
- it doesn't fork (currently available only through debugging mode)
- sends logging to stdout/stderr instead of syslog
regards
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9202
--- Comment #9 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
(In reply to Michael Ströder from comment #8)
> Please add the CVE-Id to CHANGES so downstream packagers take note of it.
That's currently not a tracked item in the format of the CHANGES file.
I have been thinking of adding a customized field to bugzilla to track CVEs (we
did that at a prior job I worked at).
We may want to consider a format change for RE25 to allow for CVEs in the
CHANGES file as well.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9202
--- Comment #8 from Michael Ströder <michael(a)stroeder.com> ---
Please add the CVE-Id to CHANGES so downstream packagers take note of it.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9202
--- Comment #7 from carnil(a)debian.org ---
(In reply to Quanah Gibson-Mount from comment #3)
> CVE-2020-10704
FWIW: Note that there is a dedicated CVE id for this issue in OpenLDAP, which
is CVE-2020-12243.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9233
Bug ID: 9233
Summary: Add argon2 module to contrib
Product: OpenLDAP
Version: 2.4.50
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: contrib
Assignee: bugs(a)openldap.org
Reporter: quanah(a)openldap.org
Target Milestone: ---
Now that the argon2 module is complete, add it to contrib for 2.4.50
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9230
Bug ID: 9230
Summary: slapindex man page states that truncate option (-t)
only works with Quick Mode (-q)
Product: OpenLDAP
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: documentation
Assignee: bugs(a)openldap.org
Reporter: requate(a)univention.de
Target Milestone: ---
Created attachment 712
--> https://bugs.openldap.org/attachment.cgi?id=712&action=edit
Patch proposal for doc/man/man8/slapindex.8
The slapindex man page states that truncate option (-t) only works with Quick
Mode (-q), but from the source code I cannot see a reason for this restriction.
Git blame shows that the statement predates back-mdb.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9214
Bug ID: 9214
Summary: back-mdb: memory leak in dnSuperiorMatch search filter
Product: OpenLDAP
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: backends
Assignee: bugs(a)openldap.org
Reporter: grapvar(a)gmail.com
Target Milestone: ---
Created attachment 709
--> https://bugs.openldap.org/attachment.cgi?id=709&action=edit
Fix for cursor leak
This is a MDB backend issue. Each time when a dnSuperiorMatch rule of a search
filter matches DN that exists in the DIT, the matching operation leaks one MDB
cursor.
Leak happens in servers/slapd/back-mdb/dn2id.c`mdb_dn2sups(). Leak exists since
MDB backend inception, i.e. commit
2011-09-01 0ba4206 Import back-mdb
Fix attached.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9206
Bug ID: 9206
Summary: contrib/passwd/argon2: consolidate libsodium
implementation
Product: OpenLDAP
Version: 2.5
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: contrib
Assignee: bugs(a)openldap.org
Reporter: peter(a)adpm.de
Target Milestone: ---
Created attachment 702
--> https://bugs.openldap.org/attachment.cgi?id=702&action=edit
patch to consolidate pw-argon2 implementation based on libsodium
Hi,
current libsodium implementation of pw-argon2 has 2 issues:
- it uses crypto_pwhash_str(), which only guarantees a "memory-hard,
CPU-intensive hash function", but not necessarily Argon2.
- it uses a different unit for the 'memory' parameter than the
libargon2 implementation: bytes instead of KiB.
The attached patch aims to fix both issues.
(The patch is is git format, you can merge it using 'git am')
I'd appreciate if you include them into OpenLDAP.
The referenced files are derived from OpenLDAP Software.
All of the modifications to OpenLDAP Software represented in the following
patch(es) were developed by Peter Marschall <peter(a)adpm.de>.
I have not assigned rights and/or interest in this work to any party.
The referenced modifications to OpenLDAP Software are subject to the following
notice:
Copyright 2020 Peter Marschall
Redistribution and use in source and binary forms, with or without
modification, are permitted only as authorized by the OpenLDAP Public License.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9203
Bug ID: 9203
Summary: No manual page for module 'pw-argon2'
Product: OpenLDAP
Version: 2.5
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: contrib
Assignee: bugs(a)openldap.org
Reporter: peter(a)adpm.de
Target Milestone: ---
Created attachment 698
--> https://bugs.openldap.org/attachment.cgi?id=698&action=edit
add manual page to pw-argon2 contrib module
Hi,
the pw-argon2 password module lacks a manual page.
Please find attached patches to upstream to fix the issue.
I'd appreciate if you include them into OpenLDAP.
The referenced files are derived from OpenLDAP Software.
All of the modifications to OpenLDAP Software represented in the following
patch(es) were developed by Peter Marschall <peter(a)adpm.de>.
I have not assigned rights and/or interest in this work to any party.
The referenced modifications to OpenLDAP Software are subject to the following
notice:
Copyright 2015 Peter Marschall
Redistribution and use in source and binary forms, with or without
modification,
are permitted only as authorizedy y the OpenLDAP Public License.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9202
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9198
Bug ID: 9198
Summary: libraries: memory leak in UTF8bvnormalize()
Product: OpenLDAP
Version: 2.4.49
Hardware: All
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: libraries
Assignee: bugs(a)openldap.org
Reporter: 1259039012(a)qq.com
Target Milestone: ---
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9182
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9181
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9175
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9171
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9003
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8683
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8650
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8575
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8383
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=7878
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=7384
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=7074
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9202
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|OpenLDAP-devs |
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8758
--- Comment #2 from mirror(a)koddos.net <mirror(a)koddos.net> ---
Hello,
Yes we still are interested. We run mirrors in Hong Kong and the
Netherlands. We can setup both locations if you wish.
Regards,
Martin
> https://bugs.openldap.org/show_bug.cgi?id=8758
>
> Quanah Gibson-Mount <quanah(a)openldap.org> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> Resolution|--- |FEEDBACK
> Status|UNCONFIRMED |RESOLVED
>
> --- Comment #1 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
> Hi Martin,
>
> rsync is available for use. Are you still interested in doing this?
>
> Sorry that this fell through the cracks.
>
> Regards,
> Quanah
>
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9083
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |FIXED
--- Comment #1 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Fixed. This will go live later today.
Regards,
Quanah
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8758
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FEEDBACK
Status|UNCONFIRMED |RESOLVED
--- Comment #1 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Hi Martin,
rsync is available for use. Are you still interested in doing this?
Sorry that this fell through the cracks.
Regards,
Quanah
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=6035
--- Comment #12 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
• df46c07a
by Ryan Tandy at 2020-04-26T01:46:43+00:00
ITS#6035 Skip test076 if chosen SASL mech not supported
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9176
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|OL_2_5_REQ |
Status|IN_PROGRESS |RESOLVED
Resolution|--- |TEST
--- Comment #3 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Commits:
• 5c0efb9c
by Howard Chu at 2020-04-27T03:41:12+01:00
ITS#9176 Add TLS SNI support to libldap
• b8f34888
by Howard Chu at 2020-04-27T18:25:49+01:00
ITS#9176 check for numeric addrs before passing SNI
• 4265849b
by Howard Chu at 2020-04-27T18:54:02+01:00
ITS#9176 check for failure setting SNI
• e96f90e2
by Ryan Tandy at 2020-04-27T11:01:01-07:00
ITS#9176 Implement SNI for GnuTLS
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=7573
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |TEST
Status|IN_PROGRESS |RESOLVED
Target Milestone|--- |2.5.0
--- Comment #7 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
commit 8f174209e112d6937d871de7eb410105e076d3d4
Author: Ryan Tandy <ryan(a)nardis.ca>
Date: Sun Apr 26 10:46:22 2020 -0700
ITS#7573 Fix back-perl dynamic config with threaded slapd
commit 10cc52ca4cbaa2d3ac365c6223969b42725c9854
Author: Ryan Tandy <ryan(a)nardis.ca>
Date: Sun Apr 26 17:38:29 2020 +0000
ITS#7573 Create regression test
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9176
--- Comment #2 from Ryan Tandy <ryan(a)openldap.org> ---
Commits:
b8f34888 by Howard Chu at 2020-04-27T18:25:49+01:00
ITS#9176 check for numeric addrs before passing SNI
- - - - -
4265849b by Howard Chu at 2020-04-27T18:54:02+01:00
ITS#9176 check for failure setting SNI
- - - - -
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9112
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2.5.0
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9091
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2.5.0
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=6844
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |2.5.0
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9176
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|ldap.google.com requires |libldap support for TLS SNI
|TLS SNI |
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9176
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|bugs(a)openldap.org |ryan(a)openldap.org
Ever confirmed|0 |1
Status|UNCONFIRMED |IN_PROGRESS
--- Comment #1 from Ryan Tandy <ryan(a)openldap.org> ---
Commits:
5c0efb9c by Howard Chu at 2020-04-27T03:41:12+01:00
ITS#9176 Add TLS SNI support to libldap
Implemented for OpenSSL, GnuTLS just stubbed
Assigning to myself to fill in the GnuTLS side.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9176
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|libldap support for TLSv1.3 |ldap.google.com requires
|Encrypted SNI |TLS SNI
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=7573
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CONFIRMED
Resolution|SUSPENDED |---
Assignee|bugs(a)openldap.org |ryan(a)openldap.org
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8591
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|CONFIRMED |RESOLVED
--- Comment #3 from Ryan Tandy <ryan(a)openldap.org> ---
*** This bug has been marked as a duplicate of bug 7573 ***
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=7573
Ryan Tandy <ryan(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hark(a)puscii.nl
--- Comment #5 from Ryan Tandy <ryan(a)openldap.org> ---
*** Bug 8591 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9017
--- Comment #22 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Commits:
• 8d0cbbc9
by Howard Chu at 2020-04-25T00:46:58+01:00
ITS#9017 cleanup Windows off_t
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9017
--- Comment #21 from Howard Chu <hyc(a)openldap.org> ---
(In reply to kriszyp(a)gmail.com from comment #20)
> > You ought to be able to use int64_t instead, or any other explicitly
> > 64-bit signed integer type.
>
> Yes, that (#define MDB_OFF_T int64_t) compiles and works fine in all
> my tests (including with >2GB dbs). I assume you can commit/fix this
> (or do we want me to make a patch)?
> Thanks,
> Kris
Committed with int64_t. Thanks for testing/verifying.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9017
Howard Chu <hyc(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |TEST
Status|IN_PROGRESS |RESOLVED
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9017
--- Comment #20 from kriszyp(a)gmail.com <kriszyp(a)gmail.com> ---
> You ought to be able to use int64_t instead, or any other explicitly
> 64-bit signed integer type.
Yes, that (#define MDB_OFF_T int64_t) compiles and works fine in all
my tests (including with >2GB dbs). I assume you can commit/fix this
(or do we want me to make a patch)?
Thanks,
Kris
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8125
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |CONFIRMED
Ever confirmed|0 |1
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9017
--- Comment #19 from Howard Chu <hyc(a)openldap.org> ---
openldap-its(a)openldap.org wrote:
> https://bugs.openldap.org/show_bug.cgi?id=9017
>
> --- Comment #18 from kriszyp(a)gmail.com <kriszyp(a)gmail.com> ---
>> I've committed your first two patches as-is,
> Thank you so much, appreciate the review and including this code. I
> hope it helps other Windows users leverage the awesome LMDB
> performance and integrity!
>
>> and taken a different approach for the off_t issue.
> Unfortunately, this commit didn't work for me. LMDB no longer compiles
> when using LARGE_INTEGER for offsets. Perhaps ULONG would work better?
> I get the following compilation errors (or is there possibly something
> I need to define to address this?):
>
> \dependencies\lmdb\libraries\liblmdb\mdb.c(3739): error C2440: '=':
> cannot convert from 'pgno_t' to 'LA
> RGE_INTEGER' [\build\node-lmdb.vcxproj]
> \dependencies\lmdb\libraries\liblmdb\mdb.c(3744): error C2088: '!=':
> illegal for union [C:\dev\node-lmd
> b\build\node-lmdb.vcxproj]
> \dependencies\lmdb\libraries\liblmdb\mdb.c(3767): error C2088: '&':
> illegal for union [
> \build\node-lmdb.vcxproj]
Apparently LARGE_INTEGER isn't an integer at all, it appears to be a
structure.
You ought to be able to use int64_t instead, or any other explicitly
64-bit signed integer type.
Since offsets can be forward or backward from a designated reference
point, off_t and MDB_OFF_T must be a signed type. size_t is explicitly
unsigned, so it is an error to use that for this purpose. It's also only
32 bits wide on a 32bit machine, so it'd be unsuitable for larger DBs.
The use of MDB_OFF_T/off_t for env->me_size is a bit bogus, since a
file size should be unsigned. But we don't have address spaces large
enough yet for the difference between 2^63 and 2^64 to matter. (And
also, the me_size field has actually never been used. Probably should
just be deleted...)
>> Do you still want the corresponding patch in 0.9? And can you please remind
>> me where the 0.9 patch is? Thanks.
> I could if you want, but you convinced me that using mdb.master and
> focusing 1.0 was the way to go, so that's what we have been using for
> the last few months (with my patches applied locally), and it has been
> working great on our servers. I don't need an 0.9 patch, but I could
> work on creating one if you think it is important.
No, that's fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=9017
--- Comment #18 from kriszyp(a)gmail.com <kriszyp(a)gmail.com> ---
> I've committed your first two patches as-is,
Thank you so much, appreciate the review and including this code. I
hope it helps other Windows users leverage the awesome LMDB
performance and integrity!
> and taken a different approach for the off_t issue.
Unfortunately, this commit didn't work for me. LMDB no longer compiles
when using LARGE_INTEGER for offsets. Perhaps ULONG would work better?
I get the following compilation errors (or is there possibly something
I need to define to address this?):
\dependencies\lmdb\libraries\liblmdb\mdb.c(3739): error C2440: '=':
cannot convert from 'pgno_t' to 'LA
RGE_INTEGER' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(3744): error C2088: '!=':
illegal for union [C:\dev\node-lmd
b\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(3767): error C2088: '&':
illegal for union [
\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(3768): error C2088: '>>':
illegal for union [C:\dev\node-lmd
b\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(3832): error C2088: '+':
illegal for union [
\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(3667): error C2440:
'initializing': cannot convert from 'int
' to 'LARGE_INTEGER' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(3680): error C2440:
'initializing': cannot convert from 'int
' to 'LARGE_INTEGER' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(4333): error C2440: '=':
cannot convert from 'size_t' to 'LA
RGE_INTEGER' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(4334): error C2088: '+':
illegal for union [
\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(4335): error C2088: '-':
illegal for union [
\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(4336): error C2088: '+=':
illegal for union [C:\dev\node-lmd
b\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(4346): error C2440: '=':
cannot convert from 'LARGE_INTEGER'
to 'DWORD' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(4369): error C2440: '=':
cannot convert from 'LARGE_INTEGER'
to 'DWORD' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5319): error C2440: '=':
cannot convert from 'DWORD' to 'LAR
GE_INTEGER' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5324): error C2440: '=':
cannot convert from 'size_t' to 'LA
RGE_INTEGER' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5325): error C2088: '<':
illegal for union [
\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5327): error C2440:
'function': cannot convert from 'LARGE_I
NTEGER' to 'LONG' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5327): warning C4024:
'SetFilePointer': different types for
formal and actual parameter 2 [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5328): error C2440: 'type
cast': cannot convert from 'LARGE_
INTEGER' to 'DWORD' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5335): error C2088: '-':
illegal for union [
\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5336): error C2088: '/':
illegal for union [
\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5344): error C2440:
'function': cannot convert from 'LARGE_I
NTEGER' to 'SIZE_T' [\build\node-lmdb.vcxproj]
\dependencies\lmdb\libraries\liblmdb\mdb.c(5344): warning C4024:
'MapViewOfFileEx': different types for
formal and actual parameter 5 [\build\node-lmdb.vcxproj]
(and it all compiles fine when I use size_t
> Do you still want the corresponding patch in 0.9? And can you please remind
> me where the 0.9 patch is? Thanks.
I could if you want, but you convinced me that using mdb.master and
focusing 1.0 was the way to go, so that's what we have been using for
the last few months (with my patches applied locally), and it has been
working great on our servers. I don't need an 0.9 patch, but I could
work on creating one if you think it is important.
> And please don't send HTML emails, plaintext only.
My apologies. Missed some settings, I despise that HTML cruft as well.
Thanks,
Kris
--
You are receiving this mail because:
You are on the CC list for the bug.
https://bugs.openldap.org/show_bug.cgi?id=8847
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|IN_PROGRESS |CONFIRMED
--
You are receiving this mail because:
You are on the CC list for the bug.