- openldap-bugs - openldap.org

Re: (ITS#5943) back-relay does not recognize when would call self
by ando＠sys-net.it 12 Feb '09

12 Feb '09

ando(a)sys-net.it wrote: > Simply comparing the BackendDB pointers of the operation and of the operation's > DN does not detect when back-relay would call self, possibly resulting in > endless loop. should be fixed in HEAD. Please test. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

(ITS#5943) back-relay does not recognize when would call self
by ando＠sys-net.it 12 Feb '09

12 Feb '09

Full_Name: Pierangelo Masarati Version: HEAD/re24 OS: irrelevant URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (81.72.89.40) Submitted by: ando Simply comparing the BackendDB pointers of the operation and of the operation's DN does not detect when back-relay would call self, possibly resulting in endless loop. p.

1 0

Re: (ITS#5942) URI matching of "self" in add_syncrepl is incomplete
by jclarke＠linagora.com 12 Feb '09

12 Feb '09

Le Jeu 12 février 2009 20:41, Howard Chu a écrit : > jclarke(a)linagora.com wrote: >> Full_Name: Jonathan Clarke >> Version: RE24 >> OS: irrelevant >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (213.41.243.192) >> >> >> Hi, >> >> When adding a syncrepl config, the function add_syncrepl performs a >> "check if >> URL points to current server". This check is based on an exact match >> between the >> provider parameter from the syncrepl config line, and the URIs given to >> slapd on >> startup. >> >> If this doesn't match when it should, the database is marked as a >> shadow, and >> all following updates fail with "shadow context; no update refs". This >> is quite >> a pain when it happens on cn=config :) >> >> There are multiple cases when this happens: >> 1) If no specific URI was specified on launch (no -h option) >> 2) Port numbers are explicitly specified or not (":389") >> 3) Trailing slash (for example "ldap://1.2.3.4" != "ldap://1.2.3.4/") >> 4) IP is specified rather than DNS name ("ldap://localhost" != >> "ldap://127.0.0.1") >> >> I saw the comment in the code that clarifies this behaviour. However, >> it's a >> surprising behaviour, and I think there is code to parse this kind of >> thing in >> the serverID detection now. Maybe it could be reused? >> >> Otherwise, we should probably document this behaviour, to avoid >> headaches :) > > The manpage says the serverID URL must use an FQDN. We already do a number > of > guesses in the code, I don't see any reason to extend this further. I'm sorry, but I was not referring to the serverID URI matching. I'm referring to syncrepl provider matching to listeners. I mentioned the serverID matching since it seems to work like syncrepl provider matching should. Regards, Jonathan

1 0

Re: (ITS#5941) Problem when stacking rwm and translucent overlays together
by ando＠sys-net.it 12 Feb '09

12 Feb '09

The problem can be easily reproduced, no need for further testing. However, I don't see an easy and clear fix right now. In the meanwhile, you should stack something in between to obtain the desired result. Having another proxy in between that deals with rwm could help. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5942) URI matching of "self" in add_syncrepl is incomplete
by hyc＠symas.com 12 Feb '09

12 Feb '09

Howard Chu wrote: > hyc(a)symas.com wrote: >> jclarke(a)linagora.com wrote: >>> I saw the comment in the code that clarifies this behaviour. However, it's a >>> surprising behaviour, and I think there is code to parse this kind of thing in >>> the serverID detection now. Maybe it could be reused? > > Oops, never mind. I was thinking of the serverID code, and you're talking > about the syncrepl code. > > I'll have to think a bit about why the two aren't behaving identically; > probably they should both use the same code. > Ah right. For the serverID code, we're doing a liberal match because anything that matches the current name:port is obviously the current server, and we want it to be identified as such. For syncrepl, we know full well that it may be the current server, but for whatever reason you may want to replicate against yourself anyway (e.g., against a different baseDN, etc...). -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5942) URI matching of "self" in add_syncrepl is incomplete
by hyc＠symas.com 12 Feb '09

12 Feb '09

hyc(a)symas.com wrote: > jclarke(a)linagora.com wrote: >> Full_Name: Jonathan Clarke >> Version: RE24 >> OS: irrelevant >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (213.41.243.192) >> >> >> Hi, >> >> When adding a syncrepl config, the function add_syncrepl performs a "check if >> URL points to current server". This check is based on an exact match between the >> provider parameter from the syncrepl config line, and the URIs given to slapd on >> startup. >> >> If this doesn't match when it should, the database is marked as a shadow, and >> all following updates fail with "shadow context; no update refs". This is quite >> a pain when it happens on cn=config :) >> >> There are multiple cases when this happens: >> 1) If no specific URI was specified on launch (no -h option) >> 2) Port numbers are explicitly specified or not (":389") >> 3) Trailing slash (for example "ldap://1.2.3.4" != "ldap://1.2.3.4/") >> 4) IP is specified rather than DNS name ("ldap://localhost" != >> "ldap://127.0.0.1") >> >> I saw the comment in the code that clarifies this behaviour. However, it's a >> surprising behaviour, and I think there is code to parse this kind of thing in >> the serverID detection now. Maybe it could be reused? Oops, never mind. I was thinking of the serverID code, and you're talking about the syncrepl code. I'll have to think a bit about why the two aren't behaving identically; probably they should both use the same code. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5942) URI matching of "self" in add_syncrepl is incomplete
by hyc＠symas.com 12 Feb '09

12 Feb '09

jclarke(a)linagora.com wrote: > Full_Name: Jonathan Clarke > Version: RE24 > OS: irrelevant > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (213.41.243.192) > > > Hi, > > When adding a syncrepl config, the function add_syncrepl performs a "check if > URL points to current server". This check is based on an exact match between the > provider parameter from the syncrepl config line, and the URIs given to slapd on > startup. > > If this doesn't match when it should, the database is marked as a shadow, and > all following updates fail with "shadow context; no update refs". This is quite > a pain when it happens on cn=config :) > > There are multiple cases when this happens: > 1) If no specific URI was specified on launch (no -h option) > 2) Port numbers are explicitly specified or not (":389") > 3) Trailing slash (for example "ldap://1.2.3.4" != "ldap://1.2.3.4/") > 4) IP is specified rather than DNS name ("ldap://localhost" != > "ldap://127.0.0.1") > > I saw the comment in the code that clarifies this behaviour. However, it's a > surprising behaviour, and I think there is code to parse this kind of thing in > the serverID detection now. Maybe it could be reused? > > Otherwise, we should probably document this behaviour, to avoid headaches :) The manpage says the serverID URL must use an FQDN. We already do a number of guesses in the code, I don't see any reason to extend this further. 1) with no URI the listener will default to localhost. The serverID URL should therefore refer to localhost, or omit the hostname. 2) Port numbers shouldn't be an issue, since they're always matched in the parsed URLs. 3) Trailing slashes don't matter in the parsed URLs. 4) The doc is quite explicit about using FQDN. I have no sympathy for people who trip over this. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

RE: (ITS#5919) URI syntaxe (ldap:///dc=my%2cdc=domaine)
by philippe.eychart＠informatique.gov.pf 12 Feb '09

12 Feb '09

In fact, none of the LDAP clients need (can) write the directory servers. They (remote servers) only read informations needed to make (or upgrade) their own config files and to authenticate their own users. Client interfaces (web/php) allow the users to upgrade (or, according their profile, simply consult) the informations needed. Some of them (authorized "administrators" on remote sites) can to upgrade some more sensible informations (create/delete new users in their department, change them from groups, affect profile application softwares, create new emails/alias or proxy acces, upgrade departement informations or sometime, why not, administrate some new samba shares, ...) On central site, technicians of the hot-line or system administrators make the rest ... (of course, everything is not totally ended and work remains to be done ... What, as matter of fact, remains a good think concerning my remuneration ;-) --- PE -----Message d'origine----- De : Michael Ströder [mailto:michael@stroeder.com] Envoyé : jeudi 12 février 2009 00:29 À : Philippe EYCHART Cc : openldap-its(a)openldap.org Objet : Re: (ITS#5919) URI syntaxe (ldap:///dc=my%2cdc=domaine) Philippe EYCHART wrote: > philippe.eychart(a)informatique.gov.pf wrote: >> Used of SRV rr is a good reponse, (in particular in case of large Intranet >> with many >> remote sites -islands in pacific- and poor communication ressources - >> satellite) but require >> to be performed in all client applications : nssldap, samba, ldap client >> tools >> for rsync/mail/DNS/proxy/supervision definitions, ... or openldap. > > We are in this case : I work in Tahiti, for the french polynesian > gouvernment, IT departement. > Our intranet take in a big geographic area recovering several islands. > I'm in charge to transfer of the totality of our management systems (and > network config) in a centralized base (of course: openldap). > But, in one hand, distant servers (and users) can't be submit to > communication links quality, in particular concerning local services > (authentifications, local messaging, samba service, etc ...) and in other > hand, we can't multipy the number of ldap servers assuming redundence (quite > services merged, we already manage more than 100 servers - and about 4000 > pc). > So, one local server in every remote site must assume ldap service for the > other local servers (which assume different services for different > administrative departements) to guarantee acceptable performances (and also > to insure a certain insensitivity in break of communication links, at least > for local provided services) ; so, in case of an ldap server failure, the > redundance must be assumed by the central servers group, with the help of > SRV resolutions that (will) allow the ... excellent openldap library ;) > It seems to me that SRV RRs definition is actually a quite good answer (easy > to deploy and, why not, standardized) to this problematic. IMHO DNS RRs are not a good failover mechanism. The LDAP clients would have to be quite smart to do the right thing. Especially if LDAP clients are writing to the directory servers. Ciao, Michael.

1 0

(ITS#5942) URI matching of "self" in add_syncrepl is incomplete
by jclarke＠linagora.com 12 Feb '09

12 Feb '09

Full_Name: Jonathan Clarke Version: RE24 OS: irrelevant URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (213.41.243.192) Hi, When adding a syncrepl config, the function add_syncrepl performs a "check if URL points to current server". This check is based on an exact match between the provider parameter from the syncrepl config line, and the URIs given to slapd on startup. If this doesn't match when it should, the database is marked as a shadow, and all following updates fail with "shadow context; no update refs". This is quite a pain when it happens on cn=config :) There are multiple cases when this happens: 1) If no specific URI was specified on launch (no -h option) 2) Port numbers are explicitly specified or not (":389") 3) Trailing slash (for example "ldap://1.2.3.4" != "ldap://1.2.3.4/") 4) IP is specified rather than DNS name ("ldap://localhost" != "ldap://127.0.0.1") I saw the comment in the code that clarifies this behaviour. However, it's a surprising behaviour, and I think there is code to parse this kind of thing in the serverID detection now. Maybe it could be reused? Otherwise, we should probably document this behaviour, to avoid headaches :)

1 0

(ITS#5941) Problem when stacking rwm and translucent overlays together
by bryan.mesich＠ndsu.edu 12 Feb '09

12 Feb '09

Full_Name: Bryan Mesich Version: 2.4.13 OS: RHEL 5.3 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (2001:4930:106:0:212:3fff:fefb:2891) When a rwm overlay is used in conjunction with the translucent overlay, slapd dies with the following error and backtrace: *** glibc detected *** ./libexec/slapd: double free or corruption (fasttop): 0x0860ca38 *** ======= Backtrace: ========= /lib/libc.so.6[0x5ceac1] /lib/libc.so.6(cfree+0x90)[0x5d20f0] ./libexec/slapd(do_search+0x10e)[0x807bbfe] ./libexec/slapd[0x8079845] ./libexec/slapd[0x8079c12] ./libexec/slapd[0x816d504] /lib/libpthread.so.0[0x6f750b] /lib/libc.so.6(clone+0x5e)[0x638b2e] I have been able to reproduce this error in 2.4.11, 2.4.13 and the CVS HEAD as of Mon Feb 9 11:13:04 CST 2009. Here is portion of my configuration file: ############################################### # database backend modules to load moduleload back_ldap.la # overlay modules to load moduleload translucent.la moduleload rwm.la # local database database bdb suffix "dc=nodak,dc=edu" rootdn "cn=root,dc=nodak,dc=edu" rootpw secret directory /var/lib/ldap2.4 overlay translucent uri "ldap://ldap.nodak.edu/"; overlay rwm #rwm-rewriteEngine on #rwm-rewriteContext searchFilter #rwm-rewriteRule "^(.*objectClass=)posixAccount(.*)" "$1inetOrgPerson$2" ":@" #rwm-map attribute uidNumber NID ############################################### Simply declaring the rwm overlay (as shown in my configuration) is enough to produce the error when used with a translucent overlay. Slapd will usually answer one request after being started before tipping over. I'm open to testing if needed. Thanks in advance, Bryan

1 0

RE: (ITS#5919) URI syntaxe (ldap:///dc=my%2cdc=domaine)
by philippe.eychart＠informatique.gov.pf 11 Feb '09

11 Feb '09

philippe.eychart(a)informatique.gov.pf wrote: > Used of SRV rr is a good reponse, (in particular in case of large Intranet > with many > remote sites -islands in pacific- and poor communication ressources - > satellite) but require > to be performed in all client applications : nssldap, samba, ldap client > tools > for rsync/mail/DNS/proxy/supervision definitions, ... or openldap. We are in this case : I work in Tahiti, for the french polynesian gouvernment, IT departement. Our intranet take in a big geographic area recovering several islands. I'm in charge to transfer of the totality of our management systems (and network config) in a centralized base (of course: openldap). But, in one hand, distant servers (and users) can't be submit to communication links quality, in particular concerning local services (authentifications, local messaging, samba service, etc ...) and in other hand, we can't multipy the number of ldap servers assuming redundence (quite services merged, we already manage more than 100 servers - and about 4000 pc). So, one local server in every remote site must assume ldap service for the other local servers (which assume different services for different administrative departements) to guarantee acceptable performances (and also to insure a certain insensitivity in break of communication links, at least for local provided services) ; so, in case of an ldap server failure, the redundance must be assumed by the central servers group, with the help of SRV resolutions that (will) allow the ... excellent openldap library ;) It seems to me that SRV RRs definition is actually a quite good answer (easy to deploy and, why not, standardized) to this problematic. -----Message d'origine----- De : Michael Ströder [mailto:michael@stroeder.com] Envoyé : mercredi 11 février 2009 06:44 À : philippe.eychart(a)informatique.gov.pf Cc : openldap-its(a)openldap.org Objet : Re: (ITS#5919) URI syntaxe (ldap:///dc=my%2cdc=domaine) philippe.eychart(a)informatique.gov.pf wrote: > Michael Ströder wrote: >> Frankly I'd vote against stuffing this into standard function >> ldap_initialize(). Using this without further pre-caution (like >> user-interaction) is broken in a similar way like chasing LDAPv3 >> referrals at the client side. > > I also think myself that security aspects are important ; but in other hand, > IMHO : it is of the responsibility of the DNS administrator to configure > cleanly and to protect its systems of any corruption (and maybe also to the > project BIND to improve tools allowing it). DNSSEC would be a solution. But my question is which problem to solve at first with SRV RRs? Ciao, Michael.

1 0

Re: (ITS#5940) crash in slapo-rwm when modifying olcRwmRewrite
by ando＠sys-net.it 11 Feb '09

11 Feb '09

At a very quick glance of your backtrace, info == 0; you didn´t olcRwmRewiteEngine TRUE? If it´s the case, the code needs to be reworked in this area. I can´t look at this now, in the meanwhile try to set it to TRUE as your first slapo-rmw statement. p. ----- jclarke(a)linagora.com wrote: > Full_Name: Jonathan Clarke > Version: RE24 > OS: CentOS > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (213.41.243.192) > > > Hi, > > Given a simple setup involving back-ldap with slapo-rwm on top, modifying the > attribute "olcRwmRewrite" causes a crash. This seems to happen both while > modifying an existing value, or when deleting one. > > The config: > 8<---------------------------- > # {1}ldap, config > dn: olcDatabase={1}ldap,cn=config > objectClass: olcDatabaseConfig > objectClass: olcLDAPConfig > olcDatabase: {1}ldap > olcSuffix: o=proxy > olcAddContentAcl: FALSE > olcLastMod: FALSE > olcMaxDerefDepth: 15 > olcReadOnly: FALSE > olcMonitoring: FALSE > olcDbURI: "ldap://server.lan" > olcDbStartTLS: none > olcDbIDAssertBind: mode=none flags=prescriptive bindmethod=simple timeout=0 ne > twork-timeout=0 binddn="cn=administrateur,cn=users,dc=otherdemo,dc=lan" creden > tials="secret" > olcDbRebindAsUser: FALSE > olcDbChaseReferrals: TRUE > olcDbTFSupport: no > olcDbProxyWhoAmI: FALSE > olcDbSingleConn: FALSE > olcDbCancel: abandon > olcDbUseTemporaryConn: FALSE > olcDbConnectionPoolMax: 16 > olcDbNoRefs: FALSE > olcDbNoUndefFilter: FALSE > > # {0}rwm, {1}ldap, config > dn: olcOverlay={0}rwm,olcDatabase={1}ldap,cn=config > objectClass: olcOverlayConfig > objectClass: olcRwmConfig > olcOverlay: {0}rwm > olcRwmRewrite: {0}rwm-suffixmassage "o=proxy" "dc=otherdemo,dc=lan" > olcRwmTFSupport: false > olcRwmNormalizeMapped: FALSE > 8<---------------------------- > > The operation: > 8<---------------------------- > dn: olcOverlay={0}rwm,olcDatabase={1}ldap,cn=config > changeType: modify > replace: olcRwmRewrite > olcRwmRewrite: {0}rwm-suffixmassage "o=proxy" "dc=demo,dc=lan" > > 8<---------------------------- > > > GDB output: > 8<---------------------------- > conn=4 fd=12 ACCEPT from IP=127.0.0.1:45843 (IP=0.0.0.0:389) > conn=4 op=0 BIND dn="cn=config" method=128 > conn=4 op=0 BIND dn="cn=config" mech=SIMPLE ssf=0 > conn=4 op=0 RESULT tag=97 err=0 text= > conn=4 op=1 MOD dn="olcOverlay={0}rwm,olcDatabase={1}ldap,cn=config" > conn=4 op=1 MOD attr=olcRwmRewrite > slapd: config.c:59: rewrite_parse: Assertion `info != ((void *)0)' failed. > > Program received signal SIGABRT, Aborted. > [Switching to Thread 1106893120 (LWP 31852)] > 0x0000003411a30155 in raise () from /lib64/libc.so.6 > (gdb) bt > #0 0x0000003411a30155 in raise () from /lib64/libc.so.6 > #1 0x0000003411a31bf0 in abort () from /lib64/libc.so.6 > #2 0x0000003411a295d6 in __assert_fail () from /lib64/libc.so.6 > #3 0x00000000004ea899 in rewrite_parse (info=0x0, fname=0x555ec5 "<suffix > massage>", lineno=1, argc=2, argv=0x41f9a180) at config.c:59 > #4 0x00000000004df8fe in rwm_suffix_massage_config (info=0x7c6a, > pvnc=0x41f9a220, nvnc=<value optimized out>, prnc=0x41f9a1f0, nrnc=<value > optimized out>) > at rwmconf.c:326 > #5 0x00000000004dc1bd in rwm_suffixmassage_config (be=<value optimized out>, > fname=0x523789 "slapd", lineno=0, argc=<value optimized out>, > argv=<value optimized out>) at rwm.c:1662 > #6 0x00000000004dc632 in rwm_cf_gen (c=0x41f9a620) at rwm.c:2076 > #7 0x0000000000414b7b in config_set_vals (Conf=0x7abc00, c=0x7c6c) at > config.c:314 > #8 0x000000000041835d in config_parse_add (ct=0x7abc00, c=0x41f9a620, > valx=<value optimized out>) at config.c:642 > #9 0x000000000040e63f in config_modify_add (ct=0x7abc00, ca=0x41f9a620, > ad=<value optimized out>, i=0) at bconfig.c:4806 > #10 0x0000000000410b03 in config_back_modify (op=0x1c8bf360, rs=0x41f9cc20) at > bconfig.c:5039 > #11 0x0000000000434317 in fe_op_modify (op=0x1c8bf360, rs=0x41f9cc20) at > modify.c:301 > #12 0x0000000000434a72 in do_modify (op=0x1c8bf360, rs=0x41f9cc20) at > modify.c:175 > #13 0x000000000041dd2b in connection_operation (ctx=0x41f9cd70, arg_v=<value > optimized out>) at connection.c:1097 > #14 0x000000000041e207 in connection_read_thread (ctx=0x41f9cd70, argv=<value > optimized out>) at connection.c:1223 > #15 0x00000000004f906a in ldap_int_thread_pool_wrapper (xpool=0x1c83c2d0) at > tpool.c:663 > #16 0x00002b6a8d3532f7 in start_thread () from /lib64/libpthread.so.0 > #17 0x0000003411ad1e3d in clone () from /lib64/libc.so.6 > 8<---------------------------- > > Let me know if you need any more details, or output from GDB. > > Regards, > Jonathan > > Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

(ITS#5940) crash in slapo-rwm when modifying olcRwmRewrite
by jclarke＠linagora.com 11 Feb '09

11 Feb '09

Full_Name: Jonathan Clarke Version: RE24 OS: CentOS URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (213.41.243.192) Hi, Given a simple setup involving back-ldap with slapo-rwm on top, modifying the attribute "olcRwmRewrite" causes a crash. This seems to happen both while modifying an existing value, or when deleting one. The config: 8<---------------------------- # {1}ldap, config dn: olcDatabase={1}ldap,cn=config objectClass: olcDatabaseConfig objectClass: olcLDAPConfig olcDatabase: {1}ldap olcSuffix: o=proxy olcAddContentAcl: FALSE olcLastMod: FALSE olcMaxDerefDepth: 15 olcReadOnly: FALSE olcMonitoring: FALSE olcDbURI: "ldap://server.lan" olcDbStartTLS: none olcDbIDAssertBind: mode=none flags=prescriptive bindmethod=simple timeout=0 ne twork-timeout=0 binddn="cn=administrateur,cn=users,dc=otherdemo,dc=lan" creden tials="secret" olcDbRebindAsUser: FALSE olcDbChaseReferrals: TRUE olcDbTFSupport: no olcDbProxyWhoAmI: FALSE olcDbSingleConn: FALSE olcDbCancel: abandon olcDbUseTemporaryConn: FALSE olcDbConnectionPoolMax: 16 olcDbNoRefs: FALSE olcDbNoUndefFilter: FALSE # {0}rwm, {1}ldap, config dn: olcOverlay={0}rwm,olcDatabase={1}ldap,cn=config objectClass: olcOverlayConfig objectClass: olcRwmConfig olcOverlay: {0}rwm olcRwmRewrite: {0}rwm-suffixmassage "o=proxy" "dc=otherdemo,dc=lan" olcRwmTFSupport: false olcRwmNormalizeMapped: FALSE 8<---------------------------- The operation: 8<---------------------------- dn: olcOverlay={0}rwm,olcDatabase={1}ldap,cn=config changeType: modify replace: olcRwmRewrite olcRwmRewrite: {0}rwm-suffixmassage "o=proxy" "dc=demo,dc=lan" 8<---------------------------- GDB output: 8<---------------------------- conn=4 fd=12 ACCEPT from IP=127.0.0.1:45843 (IP=0.0.0.0:389) conn=4 op=0 BIND dn="cn=config" method=128 conn=4 op=0 BIND dn="cn=config" mech=SIMPLE ssf=0 conn=4 op=0 RESULT tag=97 err=0 text= conn=4 op=1 MOD dn="olcOverlay={0}rwm,olcDatabase={1}ldap,cn=config" conn=4 op=1 MOD attr=olcRwmRewrite slapd: config.c:59: rewrite_parse: Assertion `info != ((void *)0)' failed. Program received signal SIGABRT, Aborted. [Switching to Thread 1106893120 (LWP 31852)] 0x0000003411a30155 in raise () from /lib64/libc.so.6 (gdb) bt #0 0x0000003411a30155 in raise () from /lib64/libc.so.6 #1 0x0000003411a31bf0 in abort () from /lib64/libc.so.6 #2 0x0000003411a295d6 in __assert_fail () from /lib64/libc.so.6 #3 0x00000000004ea899 in rewrite_parse (info=0x0, fname=0x555ec5 "<suffix massage>", lineno=1, argc=2, argv=0x41f9a180) at config.c:59 #4 0x00000000004df8fe in rwm_suffix_massage_config (info=0x7c6a, pvnc=0x41f9a220, nvnc=<value optimized out>, prnc=0x41f9a1f0, nrnc=<value optimized out>) at rwmconf.c:326 #5 0x00000000004dc1bd in rwm_suffixmassage_config (be=<value optimized out>, fname=0x523789 "slapd", lineno=0, argc=<value optimized out>, argv=<value optimized out>) at rwm.c:1662 #6 0x00000000004dc632 in rwm_cf_gen (c=0x41f9a620) at rwm.c:2076 #7 0x0000000000414b7b in config_set_vals (Conf=0x7abc00, c=0x7c6c) at config.c:314 #8 0x000000000041835d in config_parse_add (ct=0x7abc00, c=0x41f9a620, valx=<value optimized out>) at config.c:642 #9 0x000000000040e63f in config_modify_add (ct=0x7abc00, ca=0x41f9a620, ad=<value optimized out>, i=0) at bconfig.c:4806 #10 0x0000000000410b03 in config_back_modify (op=0x1c8bf360, rs=0x41f9cc20) at bconfig.c:5039 #11 0x0000000000434317 in fe_op_modify (op=0x1c8bf360, rs=0x41f9cc20) at modify.c:301 #12 0x0000000000434a72 in do_modify (op=0x1c8bf360, rs=0x41f9cc20) at modify.c:175 #13 0x000000000041dd2b in connection_operation (ctx=0x41f9cd70, arg_v=<value optimized out>) at connection.c:1097 #14 0x000000000041e207 in connection_read_thread (ctx=0x41f9cd70, argv=<value optimized out>) at connection.c:1223 #15 0x00000000004f906a in ldap_int_thread_pool_wrapper (xpool=0x1c83c2d0) at tpool.c:663 #16 0x00002b6a8d3532f7 in start_thread () from /lib64/libpthread.so.0 #17 0x0000003411ad1e3d in clone () from /lib64/libc.so.6 8<---------------------------- Let me know if you need any more details, or output from GDB. Regards, Jonathan

1 0

Re: (ITS#5756) 2.4 slapo-pcache only caches first lookup for certain templates
by toby＠inf.ed.ac.uk 11 Feb '09

11 Feb '09

Brilliant, many thanks for this. A simple test seems to confirm that it fixes the problem. I'll test in more detail and with more complex filters to confirm. Cheers Toby -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336.

1 0

Re: (ITS#5938) tls.c does not conform to RFC 4513
by hyc＠symas.com 11 Feb '09

11 Feb '09

nick.hudson(a)isode.com wrote: > Full_Name: nick hudson > Version: 2.3.38 > OS: linux > URL: > Submission from: (NULL) (62.3.217.250) > > > I am looking at the code in tls.c, function ldap_pvt_tls_check_hostname > (although the code has been refactored in recent versions, into e.g. tls_o.c, > but the same is true of the new code) > > I think the code is doing something that RFC 4513 says that it should not do. > Specifically, ref RFC 4513 section 3.1.3 says: > > The server's identity may also be verified by comparing the reference > identity to the Common Name (CN) [RFC4519] value in the leaf Relative > Distinguished Name (RDN) of the subjectName field of the server's > certificate. This comparison is performed using the rules for > comparison of DNS names in Section 3.1.3.1, below, with the exception > that no wildcard matching is allowed. > > In tls.c (and the refactored code), you can see it's first attempting an exact > comparison on subjectAltName, and if that fails it tries a wildcard match (which > is ok, as per section 3.1.3.1) > > But if no subjectAltName match is found, there's another section which looks at > the certificate's subjectname, in which it also does a wildcard match, although > the RFC says this shouldn't be done. I recall having a long argument against adding this, but we went with it in the end. The original patch was in ITS#3134. Some of the discussion surfaced here http://www.openldap.org/lists/openldap-software/200404/msg00434.html It carried on here http://www.openldap.org/lists/openldap-devel/200405/msg00002.html I'll also note ITS#5789, we allow matching an IP address against the CN too, and according to the spec that's only allowed for subjectAltName. But obviously there are lots of people out there misusing X.509, and we're tired of telling them to go do it right. It's a losing battle, we just get blamed for being broken... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

RE: (ITS#5919) URI syntaxe (ldap:///dc=my%2cdc=domaine)
by philippe.eychart＠informatique.gov.pf 11 Feb '09

11 Feb '09

Pierangelo Masarati [mailto:ando@sys-net.it] wrote: > OpenLDAP clients do the following: > empty hostport, empty DN: localhost, default port > empty hostport, non-empty DN: SRV > what might be missing IMHO is: > use domain to specify SRV > however, I don't see any special need for it, as domain can always be > put in DN form. > I don't know if there's need for a form that asks to use SRV to discover > the server for the default SUFFIX. > In order to avoid issues, I recommend using something like > x-dnssrv={<domain>|<DN>} > where <DN> is restricted to the domain component sequence form. Ok, I start on this agreement ... So, is it a Good Thing (IYHO ;) to introduce this patch according the "followup 9" ?... One other possible solution could be (for example) to patch the ldap_connect_to_host() function in os-ip.c (around getaddrinfo() and ldap_pvt_gethostbyname_a() calls). However, samba (as an example) seems not to use it ... I think that the first solution remains the one who will have a minimal impact on the existing sources ... Michael Str.der wrote: > Frankly I'd vote against stuffing this into standard function > ldap_initialize(). Using this without further pre-caution (like > user-interaction) is broken in a similar way like chasing LDAPv3 > referrals at the client side. I also think myself that security aspects are important ; but in other hand, IMHO : it is of the responsibility of the DNS administrator to configure cleanly and to protect its systems of any corruption (and maybe also to the project BIND to improve tools allowing it). Although it is there, the advantage of the suggested solution ("followup 9") is as well as this patch can be located as well within the function ldap_initialize() as within another frontal function (according to what will be finally decided ;). --- PE

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by ando＠sys-net.it 10 Feb '09

10 Feb '09

> Right, I did the same first with test017. I've now repeated with > test018, > which works fine since the intermediate message carries the sync > cookie. Ah, I never checked refreshOnly, as it's not an option I use often. Well, the issue about response controls needs to be solved at some point. In any case, proxying syncrepl this way should not be regular usage. I'm happy it helped sorting out some issues in the proxies. Fine for the liblber patch to be backed out, then. I can't test right now, but I don't see any reason to have a different behavior than yours. What puzzles me now is that I had to rework entry parsing in back-meta to prevent it eating entry controls while parsing attributes, but back-ldap didn't need anything like that... p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by hyc＠symas.com 10 Feb '09

10 Feb '09

Pierangelo Masarati wrote: > ----- hyc(a)symas.com ha scritto: > >> hyc(a)symas.com wrote: >>> I'll play with this code some with the decode change backed out. >>> >> Heh, in my current build I hadn't updated liblber yet so I didn't have >> the >> change. Fwiw, test036 etc. worked fine without it. Will try some >> syncrepl >> configs now. > > I ran test018, then I put a back-meta between the consumer and the > producer, I wiped the consumer's database and restarted it. Then I performed some further modifications to the producer and checked that they appeared in the consumer. Right, I did the same first with test017. I've now repeated with test018, which works fine since the intermediate message carries the sync cookie. > Please pay attention to the proxy's logs: what you could (should) get is a series of messages complaining about the impossibility to decode attribute types. I didn't see any such errors in the proxy's logs, and the consumer was fine. > I might well have screwed something up while trying to fix intermediate responses and other stuff related to this ITS. That's why I'm asking for critical review before merging my fix into re24. With the change in liblber I could perform syncrepl with back-meta in between. refreshAndPersist seems to work fine without the liblber patch. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by hyc＠symas.com 10 Feb '09

10 Feb '09

hyc(a)symas.com wrote: > hyc(a)symas.com wrote: >> I'll play with this code some with the decode change backed out. >> > Heh, in my current build I hadn't updated liblber yet so I didn't have the > change. Fwiw, test036 etc. worked fine without it. Will try some syncrepl > configs now. > back-meta passes search entry controls fine without the liblber patch. But since back-meta doesn't pass result controls, (ITS#4591) it never propagates the final cookie in refreshonly mode, so the consumer always gets a full refresh every time it reconnects. I'm going to revert the liblber patch. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by ando＠sys-net.it 10 Feb '09

10 Feb '09

----- hyc(a)symas.com ha scritto: > hyc(a)symas.com wrote: > > I'll play with this code some with the decode change backed out. > > > Heh, in my current build I hadn't updated liblber yet so I didn't have > the > change. Fwiw, test036 etc. worked fine without it. Will try some > syncrepl > configs now. I ran test018, then I put a back-meta between the consumer and the producer, I wiped the consumer's database and restarted it. Then I performed some further modifications to the producer and checked that they appeared in the consumer. Please pay attention to the proxy's logs: what you could (should) get is a series of messages complaining about the impossibility to decode attribute types. I might well have screwed something up while trying to fix intermediate responses and other stuff related to this ITS. That's why I'm asking for critical review before merging my fix into re24. With the change in liblber I could perform syncrepl with back-meta in between. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by hyc＠symas.com 10 Feb '09

10 Feb '09

hyc(a)symas.com wrote: > I'll play with this code some with the decode change backed out. > Heh, in my current build I hadn't updated liblber yet so I didn't have the change. Fwiw, test036 etc. worked fine without it. Will try some syncrepl configs now. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by hyc＠symas.com 10 Feb '09

10 Feb '09

Pierangelo Masarati wrote: > ----- "Howard Chu"<hyc(a)symas.com> ha scritto: > >> ando(a)sys-net.it wrote: >>> I'm trying to modify the code in order to compute the size of the >>> SearchResultEntry portion of the message, but again, in some cases, >> the >>> size is computed incorrectly: the computed length is 4 octets >> shorter >>> than what's actually in the packet. >>> >>> One issue seems to be related to the fact that when ber_skip_tag() >>> checks if the length it's computed fits in the ber by calling >>> ber_pvt_ber_remaining(), it doesn't count that earlier calls to >>> ber_read() moved the ber_ptr forward. The original ber_ptr should >> be saved. >> >> This sounds wrong; the bytes that ber_read() advanced comprise the >> length >> bytes, but they're not included in the total that the length is >> counting. >> Therefore they should not be accounted for here. > > But without this fix ber_scanf("l") LBER_ERROR was failing because > ber_pvt_ber_remaining(), which is actually ber_end - ber_ptr, is shorter > than *len by the bytes that the ber_reads are advancing. Feel free to back > this out, if you're sure it's incorrect. I'll recheck the syncrepl over > back-meta. Pretty sure. Notice ber_first_element: *last = ber->ber_ptr + *len; All of this has been working for quite a long time... I'll play with this code some with the decode change backed out. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by ando＠sys-net.it 10 Feb '09

10 Feb '09

----- "Howard Chu" <hyc(a)symas.com> ha scritto: > ando(a)sys-net.it wrote: > > I'm trying to modify the code in order to compute the size of the > > SearchResultEntry portion of the message, but again, in some cases, > the > > size is computed incorrectly: the computed length is 4 octets > shorter > > than what's actually in the packet. > > > > One issue seems to be related to the fact that when ber_skip_tag() > > checks if the length it's computed fits in the ber by calling > > ber_pvt_ber_remaining(), it doesn't count that earlier calls to > > ber_read() moved the ber_ptr forward. The original ber_ptr should > be saved. > > This sounds wrong; the bytes that ber_read() advanced comprise the > length > bytes, but they're not included in the total that the length is > counting. > Therefore they should not be accounted for here. But without this fix ber_scanf("l") LBER_ERROR was failing because ber_pvt_ber_remaining(), which is actually ber_end - ber_ptr, is shorter than *len by the bytes that the ber_reads are advancing. Feel free to back this out, if you're sure it's incorrect. I'll recheck the syncrepl over back-meta. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by hyc＠symas.com 10 Feb '09

10 Feb '09

ando(a)sys-net.it wrote: > I'm trying to modify the code in order to compute the size of the > SearchResultEntry portion of the message, but again, in some cases, the > size is computed incorrectly: the computed length is 4 octets shorter > than what's actually in the packet. > > One issue seems to be related to the fact that when ber_skip_tag() > checks if the length it's computed fits in the ber by calling > ber_pvt_ber_remaining(), it doesn't count that earlier calls to > ber_read() moved the ber_ptr forward. The original ber_ptr should be saved. This sounds wrong; the bytes that ber_read() advanced comprise the length bytes, but they're not included in the total that the length is counting. Therefore they should not be accounted for here. > I don't believe messages are encoded incorrectly, so I must be doing > something wrong in decoding them... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5939) Missing close of file descriptor
by hyc＠symas.com 10 Feb '09

10 Feb '09

joakim.bentholm(a)birdstep.com wrote: > Full_Name: Joakim Bentholm > Version: OpenLDAP 2.4.13 > OS: FreeBSD 7.0 Release > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (217.13.255.38) > > > The running setup: > An ldap server with a socket back-end communicating with server process > listening on incoming requests from the socket back-end and replying in an > orderly fashing. > > The failure: > If the server process shuts down, the socket back-end will continue to try to > connect and allocating new file descriptors which will never be released. If the > server process is restarted everything will work, unless the file descriptor > limit have been reached, in case the ldap server have to be restart. Thanks for the report and patch, fixed now in HEAD. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5938) tls.c does not conform to RFC 4513
by quanah＠zimbra.com 10 Feb '09

10 Feb '09

--On February 10, 2009 5:28:24 PM +0100 Hallvard B Furuseth <h.b.furuseth(a)usit.uio.no> wrote: > quanah(a)zimbra.com writes: >> This is because the Cert vendors themselves don't honor the RFC's when >> issuing wildcard certs, and was added so that their broken wildcard >> certs could still be used. > > In that case, maybe there should be a config option to turn this > behavior on/off, and documentation which explains that it breaks TLS > the standard and why it does so. > > If nothing else, it may get more people to complain to the cert vendors. I spent something like 4 hours on the phone discussing the issue with one of the cert vendors. They still didn't understand what was wrong with their cert, and to this day they still issue the same style of certs. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

Re: (ITS#5938) tls.c does not conform to RFC 4513
by Kurt＠OpenLDAP.org 10 Feb '09

10 Feb '09

On Feb 10, 2009, at 8:29 AM, h.b.furuseth(a)usit.uio.no wrote: > quanah(a)zimbra.com writes: >> This is because the Cert vendors themselves don't honor the RFC's >> when >> issuing wildcard certs, and was added so that their broken wildcard >> certs could still be used. > > In that case, maybe there should be a config option to turn this > behavior on/off, and documentation which explains that it breaks TLS > the standard and why it does so. I think it reasonable to be liberal in what we accept in this particular case. It's not like someone is actually going to name a host '*'. If they do, their certificate matching more hosts than they expect will be just one of many problems they face. > > > If nothing else, it may get more people to complain to the cert > vendors. Far more persons would complain to the OpenLDAP Project.

1 0

Re: (ITS#5938) tls.c does not conform to RFC 4513
by h.b.furuseth＠usit.uio.no 10 Feb '09

10 Feb '09

quanah(a)zimbra.com writes: > This is because the Cert vendors themselves don't honor the RFC's when > issuing wildcard certs, and was added so that their broken wildcard > certs could still be used. In that case, maybe there should be a config option to turn this behavior on/off, and documentation which explains that it breaks TLS the standard and why it does so. If nothing else, it may get more people to complain to the cert vendors. -- Hallvard

1 0

Re: (ITS#5938) tls.c does not conform to RFC 4513
by Kurt＠OpenLDAP.org 10 Feb '09

10 Feb '09

On Feb 10, 2009, at 7:56 AM, nick.hudson(a)isode.com wrote: > Full_Name: nick hudson > Version: 2.3.38 > OS: linux > URL: > Submission from: (NULL) (62.3.217.250) > > > I am looking at the code in tls.c, function > ldap_pvt_tls_check_hostname > (although the code has been refactored in recent versions, into e.g. > tls_o.c, > but the same is true of the new code) > > I think the code is doing something that RFC 4513 says that it > should not do. > Specifically, ref RFC 4513 section 3.1.3 says: > > The server's identity may also be verified by comparing the > reference > identity to the Common Name (CN) [RFC4519] value in the leaf > Relative > Distinguished Name (RDN) of the subjectName field of the server's > certificate. This comparison is performed using the rules for > comparison of DNS names in Section 3.1.3.1, below, with the > exception > that no wildcard matching is allowed. > > In tls.c (and the refactored code), you can see it's first > attempting an exact > comparison on subjectAltName, and if that fails it tries a wildcard > match (which > is ok, as per section 3.1.3.1) > > But if no subjectAltName match is found, there's another section > which looks at > the certificate's subjectname, in which it also does a wildcard > match, although > the RFC says this shouldn't be done. This is a case where OpenLDAP library is purposely being 'liberal in what it accepts'. -- Kurt

1 0

Re: (ITS#5938) tls.c does not conform to RFC 4513
by quanah＠zimbra.com 10 Feb '09

10 Feb '09

--On February 10, 2009 3:56:37 PM +0000 nick.hudson(a)isode.com wrote: > Full_Name: nick hudson > Version: 2.3.38 > OS: linux > URL: > Submission from: (NULL) (62.3.217.250) > > > I am looking at the code in tls.c, function ldap_pvt_tls_check_hostname > (although the code has been refactored in recent versions, into e.g. > tls_o.c, but the same is true of the new code) > > I think the code is doing something that RFC 4513 says that it should not > do. Specifically, ref RFC 4513 section 3.1.3 says: > > The server's identity may also be verified by comparing the reference > identity to the Common Name (CN) [RFC4519] value in the leaf Relative > Distinguished Name (RDN) of the subjectName field of the server's > certificate. This comparison is performed using the rules for > comparison of DNS names in Section 3.1.3.1, below, with the exception > that no wildcard matching is allowed. > > In tls.c (and the refactored code), you can see it's first attempting an > exact comparison on subjectAltName, and if that fails it tries a wildcard > match (which is ok, as per section 3.1.3.1) > > But if no subjectAltName match is found, there's another section which > looks at the certificate's subjectname, in which it also does a wildcard > match, although the RFC says this shouldn't be done. This is because the Cert vendors themselves don't honor the RFC's when issuing wildcard certs, and was added so that their broken wildcard certs could still be used. --Quanah -- Quanah Gibson-Mount Principal Software Engineer Zimbra, Inc -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

(ITS#5939) Missing close of file descriptor
by joakim.bentholm＠birdstep.com 10 Feb '09

10 Feb '09

Full_Name: Joakim Bentholm Version: OpenLDAP 2.4.13 OS: FreeBSD 7.0 Release URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (217.13.255.38) The running setup: An ldap server with a socket back-end communicating with server process listening on incoming requests from the socket back-end and replying in an orderly fashing. The failure: If the server process shuts down, the socket back-end will continue to try to connect and allocating new file descriptors which will never be released. If the server process is restarted everything will work, unless the file descriptor limit have been reached, in case the ldap server have to be restart. Solution: close the file descripton The following patch solves the problem --- --- servers/slapd/back-sock/opensock.c.orig 2008-02-09 01:46:09.000000000 +0100 +++ servers/slapd/back-sock/opensock.c 2009-02-02 16:09:24.000000000 +0100 @@ -57,6 +57,7 @@ if ( connect( fd, (struct sockaddr *)&sockun, sizeof(sockun) ) < 0 ) { Debug( LDAP_DEBUG_ANY, "socket connect(%s) failed\n", sockpath ? sockpath : "<null>", 0, 0 ); + close( fd ); return( NULL ); } ---

1 0

(ITS#5938) tls.c does not conform to RFC 4513
by nick.hudson＠isode.com 10 Feb '09

10 Feb '09

Full_Name: nick hudson Version: 2.3.38 OS: linux URL: Submission from: (NULL) (62.3.217.250) I am looking at the code in tls.c, function ldap_pvt_tls_check_hostname (although the code has been refactored in recent versions, into e.g. tls_o.c, but the same is true of the new code) I think the code is doing something that RFC 4513 says that it should not do. Specifically, ref RFC 4513 section 3.1.3 says: The server's identity may also be verified by comparing the reference identity to the Common Name (CN) [RFC4519] value in the leaf Relative Distinguished Name (RDN) of the subjectName field of the server's certificate. This comparison is performed using the rules for comparison of DNS names in Section 3.1.3.1, below, with the exception that no wildcard matching is allowed. In tls.c (and the refactored code), you can see it's first attempting an exact comparison on subjectAltName, and if that fails it tries a wildcard match (which is ok, as per section 3.1.3.1) But if no subjectAltName match is found, there's another section which looks at the certificate's subjectname, in which it also does a wildcard match, although the RFC says this shouldn't be done.

1 0

Re: (ITS#5937) Apparent mistake in ipv6 address handling in tls.c
by hyc＠symas.com 10 Feb '09

10 Feb '09

Kurt Zeilenga wrote: > On Feb 10, 2009, at 4:27 AM, hyc(a)symas.com wrote: >> Nice catch, that's been in there since 2002. Fixed in HEAD. > > I counted 5 occurs in HEAD tls*.c... 2 of those are in tls.c, which is no longer being compiled. I just haven't got around to cvs rm'ing it yet after splitting to tls2.c and the other modules. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5937) Apparent mistake in ipv6 address handling in tls.c
by Kurt＠OpenLDAP.org 10 Feb '09

10 Feb '09

On Feb 10, 2009, at 4:27 AM, hyc(a)symas.com wrote: > nick.hudson(a)isode.com wrote: >> Full_Name: nick hudson >> Version: 2.3.38 >> OS: linux >> URL: >> Submission from: (NULL) (62.3.217.250) >> >> >> I think there is a bug in libraries/libldap/tls.c - specifically in >> this >> section: >> >> #ifdef LDAP_PF_INET6 >> if (name[0] == '['&& strchr(name, ']')) { >> char *n2 = ldap_strdup(name+1); >> *strchr(n2, ']') = 2; >> if (inet_pton(AF_INET6, n2,&addr)) >> ntype = IS_IP6; >> LDAP_FREE(n2); >> } else >> #endif >> >> the code is attempting to detect whether part of an LDAP URL >> represents an IPv6 >> address; it passes the string to inet_pton(), after removing square >> brackets. >> But I think this line: >> >> *strchr(n2, ']') = 2; >> >> is wrong: shouldn't it be using 0 instead of 2? >> >> When testing on my local system, using the code above always >> results in >> inet_pton returning 0 (not an IPv6 address) - if I modify the >> strchr line to use >> zero instead, then inet_pton returns 1 for valid IPv6 addresses. >> >> I may be missing something - "2" seems a peculiar value to use so >> perhaps it >> does have some special significance - but I think the code as it >> stands is >> incorrect. > > Nice catch, that's been in there since 2002. Fixed in HEAD. I counted 5 occurs in HEAD tls*.c... -- Kurt

1 0

Re: (ITS#5936) test049 uses nonexistant variable SLEEP1
by hyc＠symas.com 10 Feb '09

10 Feb '09

jclarke(a)linagora.com wrote: > Full_Name: Jonathan Clarke > Version: RE24 > OS: irrelevant > URL: http://milopita.phillipoux.net/jonathan-clarke-20090210-test049.patch > Submission from: (NULL) (213.41.243.192) > > > test049 complains with: > Waiting seconds for syncrepl to receive changes... > sleep: missing operator > > The patch below corrects this. Using 10 seconds as default value, as is done > above in the test script for cn=config replication. > > > Thanks, fixed. I guess we probably should just sync up the rest of the test scripts between HEAD and RE24 after all, since we've tripped over this a few times already. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5937) Apparent mistake in ipv6 address handling in tls.c
by hyc＠symas.com 10 Feb '09

10 Feb '09

nick.hudson(a)isode.com wrote: > Full_Name: nick hudson > Version: 2.3.38 > OS: linux > URL: > Submission from: (NULL) (62.3.217.250) > > > I think there is a bug in libraries/libldap/tls.c - specifically in this > section: > > #ifdef LDAP_PF_INET6 > if (name[0] == '['&& strchr(name, ']')) { > char *n2 = ldap_strdup(name+1); > *strchr(n2, ']') = 2; > if (inet_pton(AF_INET6, n2,&addr)) > ntype = IS_IP6; > LDAP_FREE(n2); > } else > #endif > > the code is attempting to detect whether part of an LDAP URL represents an IPv6 > address; it passes the string to inet_pton(), after removing square brackets. > But I think this line: > > *strchr(n2, ']') = 2; > > is wrong: shouldn't it be using 0 instead of 2? > > When testing on my local system, using the code above always results in > inet_pton returning 0 (not an IPv6 address) - if I modify the strchr line to use > zero instead, then inet_pton returns 1 for valid IPv6 addresses. > > I may be missing something - "2" seems a peculiar value to use so perhaps it > does have some special significance - but I think the code as it stands is > incorrect. Nice catch, that's been in there since 2002. Fixed in HEAD. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#5937) Apparent mistake in ipv6 address handling in tls.c
by nick.hudson＠isode.com 10 Feb '09

10 Feb '09

Full_Name: nick hudson Version: 2.3.38 OS: linux URL: Submission from: (NULL) (62.3.217.250) I think there is a bug in libraries/libldap/tls.c - specifically in this section: #ifdef LDAP_PF_INET6 if (name[0] == '[' && strchr(name, ']')) { char *n2 = ldap_strdup(name+1); *strchr(n2, ']') = 2; if (inet_pton(AF_INET6, n2, &addr)) ntype = IS_IP6; LDAP_FREE(n2); } else #endif the code is attempting to detect whether part of an LDAP URL represents an IPv6 address; it passes the string to inet_pton(), after removing square brackets. But I think this line: *strchr(n2, ']') = 2; is wrong: shouldn't it be using 0 instead of 2? When testing on my local system, using the code above always results in inet_pton returning 0 (not an IPv6 address) - if I modify the strchr line to use zero instead, then inet_pton returns 1 for valid IPv6 addresses. I may be missing something - "2" seems a peculiar value to use so perhaps it does have some special significance - but I think the code as it stands is incorrect.

1 0

(ITS#5936) test049 uses nonexistant variable SLEEP1
by jclarke＠linagora.com 10 Feb '09

10 Feb '09

Full_Name: Jonathan Clarke Version: RE24 OS: irrelevant URL: http://milopita.phillipoux.net/jonathan-clarke-20090210-test049.patch Submission from: (NULL) (213.41.243.192) test049 complains with: Waiting seconds for syncrepl to receive changes... sleep: missing operator The patch below corrects this. Using 10 seconds as default value, as is done above in the test script for cn=config replication.

1 0

Re: (ITS#5929) 'make test' uses installed libldap_r/liblber
by hyc＠symas.com 10 Feb '09

10 Feb '09

h.b.furuseth(a)usit.uio.no wrote: > Thanks for checking this out. > >> If you want this to work you'll have to provide both the build >> directory and your installed directory in your -rpath. > > Doesn't sound good either. Then I presume the installed binaries may > later use libraries from a test build. Probably. You can of course edit the relink commands in the wrapper to eliminate the build runpath, but it's a lot of manual intervention no matter how you slice it. > >> The symlinks would then help a little, because you only need to set >> one build rpath instead of 3. Go ahead and restore the build rules in >> your source tree to set the symlinks if you want them. At the moment >> it looks like they're not generally useful, and I'm tired of >> committing/reverting, so I'm not touching those files any more today. > > I don't have time for this now either, but I'll hopefully get to it > soon. I wonder if a fix will be to revert the recent libtool upgrade:-( > > Of course it may be that this situation has existed for ages but I only > noticed because of the missing ldap_pvt_search symbol. > The build rules were changed in OL 2.1, it's been like this for ages... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5929) 'make test' uses installed libldap_r/liblber
by h.b.furuseth＠usit.uio.no 10 Feb '09

10 Feb '09

Thanks for checking this out. > If you want this to work you'll have to provide both the build > directory and your installed directory in your -rpath. Doesn't sound good either. Then I presume the installed binaries may later use libraries from a test build. > The symlinks would then help a little, because you only need to set > one build rpath instead of 3. Go ahead and restore the build rules in > your source tree to set the symlinks if you want them. At the moment > it looks like they're not generally useful, and I'm tired of > committing/reverting, so I'm not touching those files any more today. I don't have time for this now either, but I'll hopefully get to it soon. I wonder if a fix will be to revert the recent libtool upgrade:-( Of course it may be that this situation has existed for ages but I only noticed because of the missing ldap_pvt_search symbol. -- Hallvard

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by ando＠sys-net.it 10 Feb '09

10 Feb '09

Howard Chu wrote: > Pierangelo Masarati wrote: >> hyc(a)symas.com wrote: >> >>> I saw that, but it seems that multiple -i options work. >>> -i !xx -i yy >> >> Yes, it works. The test becomes waaaaaay too verbose, though. It'd be >> nicer to have the possibility to limit the error message to the first >> occurrence, when it is intended. > > Yes, I also patched slapd-bind.c in my tree, forgot to mention that: > @@ -344,7 +348,7 @@ > /* if ignore.. */ > if ( first ) { > /* only log if first occurrence */ > - if ( force < 2 || first == 1 ) { > + if ( first == 1 ) { > tester_ldap_error( ld, "ldap_sasl_bind_s", NULL ); > } > rc = LDAP_SUCCESS; I've added another modifier, "*", that makes testers ignore errors and only log the first occurrence. I'm about to commit it. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by hyc＠symas.com 10 Feb '09

10 Feb '09

Pierangelo Masarati wrote: > hyc(a)symas.com wrote: > >> I saw that, but it seems that multiple -i options work. >> -i !xx -i yy > > Yes, it works. The test becomes waaaaaay too verbose, though. It'd be > nicer to have the possibility to limit the error message to the first > occurrence, when it is intended. Yes, I also patched slapd-bind.c in my tree, forgot to mention that: @@ -344,7 +348,7 @@ /* if ignore.. */ if ( first ) { /* only log if first occurrence */ - if ( force < 2 || first == 1 ) { + if ( first == 1 ) { tester_ldap_error( ld, "ldap_sasl_bind_s", NULL ); } rc = LDAP_SUCCESS; -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by ando＠sys-net.it 10 Feb '09

10 Feb '09

hyc(a)symas.com wrote: > I saw that, but it seems that multiple -i options work. > -i !xx -i yy Yes, it works. The test becomes waaaaaay too verbose, though. It'd be nicer to have the possibility to limit the error message to the first occurrence, when it is intended. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5931) back-meta crashes with syncrepl data
by ando＠sys-net.it 10 Feb '09

10 Feb '09

ando(a)sys-net.it wrote: > This won't probably be as easy as I expected: back-meta does not check, > parse or return entry controls. This needs to be fixed as well. My fault: back-meta does. However, something strange is happening: - in some cases, while looping for attribute values, back-meta incorrectly treates entry controls (right after the SearchResultEntry message) as yet another attribute name/values set - in other cases things just go fine I'm trying to modify the code in order to compute the size of the SearchResultEntry portion of the message, but again, in some cases, the size is computed incorrectly: the computed length is 4 octets shorter than what's actually in the packet. One issue seems to be related to the fact that when ber_skip_tag() checks if the length it's computed fits in the ber by calling ber_pvt_ber_remaining(), it doesn't count that earlier calls to ber_read() moved the ber_ptr forward. The original ber_ptr should be saved. I don't believe messages are encoded incorrectly, so I must be doing something wrong in decoding them... p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5613) slapd determines hostname by PTR even if host url defined, breaking ServerID
by hyc＠symas.com 10 Feb '09

10 Feb '09

joe(a)julianfamily.org wrote: > Full_Name: Joe Julian > Version: 2.4.10 > OS: Linux (Fedora 7 distribution) > URL: > Submission from: (NULL) (68.178.24.202) > > > Description of problem: > slapd is called with "-h ldap://ldap1.domain.dom" where ldap1 is a CNAME for > the > actual server name "moe.domain.dom" and "-h ldap://ldap2.domain.dom" for > "curly.domain.dom". > > The cn=config entries for olcServerID are "1 ldap://ldap1.domain.dom" and "2 > ldap://ldap2.domain.dom" > > In config_generic (bconfig.c) case CFG_SERVERID lud->lud_host is compared with > global_host. As the PTR record for moe is moe.domain.dom and not > ldap1.domain.dom, moe does not get assigned a serverID. The same is true for > curly. > Expected results: > the serverID should be selected (in part) based on the "-h" url configuration > matching an olcServerID entry The listener URLs specified with -h are now being compared. The fix is in HEAD, please test. Thanks. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5853) LDAP search crashes when chasing multiple referrals
by hyc＠symas.com 10 Feb '09

10 Feb '09

hyc(a)symas.com wrote: > And yet another approach is simply to bump up each lconn's refcnt, the same > way request.c:ldap_new_connection() does, to prevent them from getting freed > prematurely. This latter approach would be simplest, except it requires > calling ldap_free_connection() to actually decrement the refcnt, and that > requires more mutex manipulation for the libldap_r version. (I haven't looked > too deeply into the lock dependencies yet, it may actually be simpler.) I opted for this approach, now checked into HEAD. Please test. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by hyc＠symas.com 10 Feb '09

10 Feb '09

Pierangelo Masarati wrote: > hyc(a)symas.com wrote: >> michael(a)stroeder.com wrote: >>> Full_Name: karlsruhe >>> Version: HEAD >>> OS: Linux >>> URL: ftp://ftp.openldap.org/incoming/ >>> Submission from: (NULL) (84.163.100.169) >>> >>> >>> Currently test039-glue-ldap-concurrency fails with a lot of these messages (see >>> below). Maybe the test scripts could be modified to detect this situation and >>> stop immediately. >> Normally the tester programs will stop immediately on any error. test036 and >> test039 invoke slapd-tester with -FF which causes slapd-bind to ignore errors. >> (Note that test008 doesn't use -FF.) >> >> Seems to me that test036/039 would both work fine if they just added -i >> INVALID_CREDENTIALS to the TESTER invocation, instead of using -FF. >> >> Ando, what do you think? > > Not right now: -i is already used with negation ("!"). Negation needs > to move on a per-value basis, or something like that (if I0m reading > that code fine). I'll look at it, maybe later. I saw that, but it seems that multiple -i options work. -i !xx -i yy -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5893) test scripts should stop immediately if slapd crashed
by ando＠sys-net.it 10 Feb '09

10 Feb '09

hyc(a)symas.com wrote: > michael(a)stroeder.com wrote: >> Full_Name: karlsruhe >> Version: HEAD >> OS: Linux >> URL: ftp://ftp.openldap.org/incoming/ >> Submission from: (NULL) (84.163.100.169) >> >> >> Currently test039-glue-ldap-concurrency fails with a lot of these messages (see >> below). Maybe the test scripts could be modified to detect this situation and >> stop immediately. > > Normally the tester programs will stop immediately on any error. test036 and > test039 invoke slapd-tester with -FF which causes slapd-bind to ignore errors. > (Note that test008 doesn't use -FF.) > > Seems to me that test036/039 would both work fine if they just added -i > INVALID_CREDENTIALS to the TESTER invocation, instead of using -FF. > > Ando, what do you think? Not right now: -i is already used with negation ("!"). Negation needs to move on a per-value basis, or something like that (if I0m reading that code fine). I'll look at it, maybe later. p. Ing. Pierangelo Masarati OpenLDAP Core Team SysNet s.r.l. via Dossi, 8 - 27100 Pavia - ITALIA http://www.sys-net.it ----------------------------------- Office: +39 02 23998309 Mobile: +39 333 4963172 Fax: +39 0382 476497 Email: ando(a)sys-net.it -----------------------------------

1 0

Re: (ITS#5853) LDAP search crashes when chasing multiple referrals
by hyc＠symas.com 10 Feb '09

10 Feb '09

This is some extremely ugly code. My first instinct is to rewrite it to eliminate the recursion but I have a feeling that may be too drastic a change. Another thought is to alter wait4msg/try_read1msg's parameter list to specify which lconn to start from, and order the list such that the recursive calls can only iterate over the newest lconn structures. That would prevent them from freeing lconns that are currently being referenced by a prior caller. (That would also prevent them from parsing any received data that's ready on other connections, until the Bind on the new referral connection completes. So this may needlessly serialize some work and decrease overall throughput when references are interleaved in a larger result set.) And yet another approach is simply to bump up each lconn's refcnt, the same way request.c:ldap_new_connection() does, to prevent them from getting freed prematurely. This latter approach would be simplest, except it requires calling ldap_free_connection() to actually decrement the refcnt, and that requires more mutex manipulation for the libldap_r version. (I haven't looked too deeply into the lock dependencies yet, it may actually be simpler.) -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5853) LDAP search crashes when chasing multiple referrals
by hyc＠symas.com 10 Feb '09

10 Feb '09

Judging from the stack trace, this appears to be the same as #5743. Since there's more info here, I'll close the older one as a dup of this one. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs