https://bugs.openldap.org/show_bug.cgi?id=9079
--- Comment #4 from gray(a)nxg.name <gray(a)nxg.name> ---
> > * Each URI defines a set of object attributes
> > * One can have multiple olcUniqueURI attributes, _each of which_ creates a
> > 'domain'
> > * This doesn't say what a 'domain' is
>
>
> The concept of a "domain" is a key part of the mathematical concept of "sets". As this is clearly talking about sets, the definition of domain follows.
We may be thinking of different set theories, but in the mathematical set
theory I'm familiar with, there is no notion of 'domain'. Functions have
domains, codomains and ranges which are each sets, but that is part of the
theory of functions, not of sets.
Not that it matters, because 'domain' has a variety of meanings in computing
contexts, so it does no harm to be precise here. Since the text just above
this in the manpage talks of 'scope', in a sense which appears to at least
overlap with 'domain' here, I merely suggest that the text explain what it
means by 'domain'.
For concreteness, can I suggest:
Each `unique_uri` option defines a 'uniqueness domain' consisting of the set of
attributes which would be returned by the specified (RFC 4516) LDAP URI, or the
union of the sets of attributes returned by the URIs, if there is more than
one. The overlay ensures that no two attributes in this set have the same
value. In a 'strict' uniqueness domain (when the keyword 'strict' is present),
at most one attribute in the domain may have a null value; in a non-strict
domain more than one attribute may have a null value.
This uniqueness constraint is imposed independently for the attributes in each
uniqueness domain.
...and delete the paragraph 'It is possible...'
[If 'scope' is a different notion from 'domain', then the text might benefit
from some clarification about what the difference is; if they are the same
notion, then it might be useful to use the same term for both, or else the
careful reader will worry that there is a distinction being made that they
don't understand.]
> > * It's not clear where the quotes go, when combining with 'strict' or
> > 'ignore'
> > (I guess "strict ldap://...").
> > * Can 'strict' or 'ignore' be combined with the second or subsequent URIs?
>
>
> This is already explicitly answered in the man page:
>
> "Strictness applies to all URIs within a uniqueness domain" thus it must be combined with the full set of URIs in a given statement.
True. As implied above, it might be useful to relocate the remark about what
'strict' means, but the answer to my question was indeed implicit in the text
as it stands.
To be clear, I reiterate that I'm not suggesting the text is inaccurate, simply
that it is not as clear as it could be, and I wouldn't bother suggesting
documentation edits if the OpenLDAP documentation were not already unusually
high quality. Also, when I first read the manpage I largely got the point
pretty quickly (it's not a complicated notion), and it's only when I re-read
carefully that I started to have doubts.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8415
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|UNCONFIRMED |RESOLVED
Keywords|OL_2_5_REQ |
--- Comment #5 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Commits:
• 59a21512
by Quanah Gibson-Mount at 2021-03-06T00:39:22+00:00
ITS#8415 - Fix copyright update for all known cases
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8682
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |needs_review
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9079
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |IN_PROGRESS
Keywords|OL_2_5_REQ |
--- Comment #3 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
https://git.openldap.org/openldap/openldap/-/merge_requests/277
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9079
--- Comment #2 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
(In reply to gray(a)nxg.name from comment #0)
> I understand from this text the following:
>
> * One can specify multiple URIs in the value of a olcUniqueURI attribute.
> I
> _guess_ these can be space-separated, even though that isn't shown in this
> syntax.
This is a typo, which will be fixed.
> * Each URI defines a set of object attributes
> * One can have multiple olcUniqueURI attributes, _each of which_ creates a
> 'domain'
> * This doesn't say what a 'domain' is
The concept of a "domain" is a key part of the mathematical concept of "sets".
As this is clearly talking about sets, the definition of domain follows.
> * If multiple URIs are specified in a 'domain'
Again, this goes back to the mathematical concept of sets.
> * It's not clear where the quotes go, when combining with 'strict' or
> 'ignore'
> (I guess "strict ldap://...").
> * Can 'strict' or 'ignore' be combined with the second or subsequent URIs?
This is already explicitly answered in the man page:
"Strictness applies to all URIs within a uniqueness domain" thus it must be
combined with the full set of URIs in a given statement.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9051
--- Comment #5 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
These 3 searches should all have been logged:
6042bb16 conn=1001 op=1 SRCH base="dc=example,dc=com" scope=0 deref=0
filter="(objectClass=*)"
6042bb16 send_ldap_result: conn=1001 op=1 p=3
6042bb16 conn=1001 op=1 SEARCH RESULT tag=101 err=0 qtime=0.000016
etime=0.000202 nentries=1 text=
6042bb16 conn=1003 op=1 SRCH base="dc=example,dc=com" scope=0 deref=0
filter="(objectClass=*)"
6042bb16 send_ldap_result: conn=1003 op=1 p=3
6042bb16 conn=1003 op=1 SEARCH RESULT tag=101 err=0 qtime=0.000016
etime=0.000183 nentries=1 text=
6042bb16 conn=1005 op=1 SRCH base="dc=example,dc=com" scope=0 deref=0
filter="(objectClass=*)"
6042bb16 send_ldap_result: conn=1005 op=1 p=3
6042bb16 conn=1005 op=1 SEARCH RESULT tag=101 err=0 qtime=0.000008
etime=0.000093 nentries=1 text=
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9051
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Status|UNCONFIRMED |CONFIRMED
--- Comment #4 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
This regression test that was trivial to set up shows only bind ops in the
resulting accesslog database:
https://git.openldap.org/quanah/openldap/-/commit/d22d10ebd7cb216496fd8c3e6…
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9051
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|quanah(a)openldap.org |ondra(a)mistotebe.net
Keywords|OL_2_5_REQ, reviewed |
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9051
--- Comment #3 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Trivial to reproduce. Only logs bind ops.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8773
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |IN_PROGRESS
Keywords|OL_2_5_REQ |
Ever confirmed|0 |1
--- Comment #1 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
https://git.openldap.org/openldap/openldap/-/merge_requests/275
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8773
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.openldap.org/s
| |how_bug.cgi?id=5768
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5768
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.openldap.org/s
| |how_bug.cgi?id=8773
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8440
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.5.3 |---
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8440
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8440
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |WORKSFORME
Keywords|OL_2_5_REQ, replication, |
|reviewed |
--- Comment #3 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
No longer appears to occur. "CSN too old" messages are limited to reqStart=XXX
entries as they should be.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8742
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|OL_2_5_REQ |
Ever confirmed|0 |1
Status|UNCONFIRMED |IN_PROGRESS
--- Comment #1 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
https://git.openldap.org/openldap/openldap/-/merge_requests/274
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8847
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|has_patch, IPR_OK, |needs_review
|OL_2_5_REQ |
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8871
--- Comment #4 from OndÅ™ej KuznÃk <ondra(a)mistotebe.net> ---
On Thu, Mar 04, 2021 at 06:24:28PM +0000, openldap-its(a)openldap.org wrote:
> --- Comment #2 from hsuenju_ko(a)stratus.com <hsuenju_ko(a)stratus.com> ---
> This used to work before #6672. The code used to unlock the ld_conn_mutex
> before the select call.
>
> what if one thread is doing ldap_result with indefinite wait while other thread
> is doing something, not necessary cancel, which also requires holding the
> ld_conn_mutex lock? Are you saying no other thread is allowed to do anything
> requiring the same ld_conn_mutex?
You can't use the connection while another thread is waiting there (and
holding the mutex), this is not how libldap works. What you can do is
retrieve the fd with LDAP_OPT_DESC, wait until there's activity and then
call ldap_result with a timeout set to 0 to see if you got what you were
interested in. Then you're able to send more requests while waiting,
from any thread you want as long as they're not stuck waiting on network.
> If I can not use the same connection, how do I do multiple connections? Can I
> cancel operations from different connection?
Cancel and unbind operations can only stop the processing of a request
sent over the same connection.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8847
--- Comment #33 from HoweverAT <laeufer4321(a)gmx.at> ---
Hi,
I would like to take over this task.
@Ryan Tandy
thank you for your great feedback, I have tried to work everything into the new
patch.
-whitespace style
-sorted lists and typos
-IPv6 ifdefs
-useless comments
-add initial NULLARG for new struct
-ldap_set_option reset to default if invalue==NULL
-ldap_validate_and_fill_sourceip moved to new position
-inet_pton is only used if LDAP_PF_INET6 like in existing code
-os-ip.c i didn't changed the position of the code. For me it was cleaner if we
set address (local or remote) in one place
Im not sure about the MinGW Compile Fix - part
Is there an instruction how the mingw environment should be set up to retest
it?
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8847
HoweverAT <laeufer4321(a)gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #803|Client Address Binding |client_address_binding_2021
description| |-03-05
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8724
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|IN_PROGRESS |RESOLVED
--- Comment #13 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Commits:
• 932d18fd
by Quanah Gibson-Mount at 2021-03-04T21:44:38+00:00
ITS#8724 - Note that paged results is stripped
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8871
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|WONTFIX |INVALID
--- Comment #3 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
The use case here is invalid, and the code prior to ITS#6672 was broken. There
is nothing here to be fixed.
--
You are receiving this mail because:
You are on the CC list for the issue.