- openldap-bugs - openldap.org

(ITS#5554) slapd.conf man page missing TLSCipherSuite
by ghenry＠OpenLDAP.org 12 Jun '08

12 Jun '08

Full_Name: Gavin Henry Version: HEAD OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (212.159.59.85) http://www.openldap.org/software/man.cgi?query=slapd.conf&sektion=5&apropos… missing TLSCipherSuite

1 0

Re: (ITS#5551) assertion causes application failure
by ghenry＠OpenLDAP.org 12 Jun '08

12 Jun '08

> Is there debug output you would like from me? See http://www.openldap.org/faq/data/cache/59.html -- Kind Regards, Gavin Henry. OpenLDAP Engineering Team. E ghenry(a)OpenLDAP.org Community developed LDAP software. http://www.openldap.org/project/

1 0

Re: (ITS#5540) Normalization assertion in attr.c
by h.b.furuseth＠usit.uio.no 12 Jun '08

12 Jun '08

hyc(a)symas.com writes: >>> monitorContext, readOnly and the olc* attributes are defined by OpenLDAP >>> (their OIDs start with 1.3.6.1.4.1.4203) and can be modified if we feel >>> like it. Personally I prefer attrs to have the matching rules they can >>> have unless there is a reason not to, but I didn't write these modules >>> so I don't know if there _is_ a reason not to. > > For the config attributes, I just assumed no one needs to search on > them (so no filter capability needed) and for single-valued > attributes, there's no need to consider modifies... Oh, good. No reason not to add matching rules then:-) I search for one config attrs or another once in a while. Mostly for olcSuffix and with presence filters, but it'd be nice if e.g. (olcAccess:caseIgnoreSubstringsMatch:=*userPassword*) worked. Also some day I'll want to use assertion controls as a check on modify operations someday. Still, I'm not proposing to add more work than necessary to this ITS. Get it right first, then think of "nice to have"-features if/when anyone bothers. -- Hallvard

1 0

Re: (ITS#5553) Inconsistent sasl.c logging format
by h.b.furuseth＠usit.uio.no 12 Jun '08

12 Jun '08

hyc(a)symas.com writes: >> Would it be reasonable to change the 6 debug statements in sasl.c to >> use the first format? > > I don't see any reason not to. I do: Currently that format is more or less reserved for loglevel stats/stats2, and is useful when grepping a more chatty log for stats. Though it could certainly be useful to normalize log formats a little. -- Hallvard

1 0

Re: (ITS#5540) Normalization assertion in attr.c
by hyc＠symas.com 12 Jun '08

12 Jun '08

unix.gurus(a)gmail.com wrote: >>> namingContexts >>> configContext >>> dynamicSubtrees >>> >>> These attributes do not have equality matching rules, but probably >>> should. I add 'EQUALITY distinguishedNameMatch' to them in >>> schema_prep.c. >> No, that breaks the definitions in the RFCs they come from. (See their >> DESC strings.) I don't know why they lack EQUALITY rules, maybe we just >> forgot when we defined them, but that's the way it is. Same with >> supportedControl. configContext is OpenLDAP-specific. It is also single-valued, so it seemed to me it did not need an EQ rule. > Ok, so we should not define nvals for them? No normalizer, therefore, cannot provide nval... >> monitorContext, readOnly and the olc* attributes are defined by OpenLDAP >> (their OIDs start with 1.3.6.1.4.1.4203) and can be modified if we feel >> like it. Personally I prefer attrs to have the matching rules they can >> have unless there is a reason not to, but I didn't write these modules >> so I don't know if there _is_ a reason not to. For the config attributes, I just assumed no one needs to search on them (so no filter capability needed) and for single-valued attributes, there's no need to consider modifies... -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5553) Inconsistent sasl.c logging format
by hyc＠symas.com 12 Jun '08

12 Jun '08

unix.gurus(a)gmail.com wrote: > Full_Name: Sean Burford > Version: 2.4.8 > OS: Linux > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (72.14.227.1) > > > Most connection logs are of the format: > conn=\d+ fd=\d+ MSG > > sasl.c Debug logs are of the format: > SASL .*[conn=\d+]: MSG > > Would it be reasonable to change the 6 debug statements in sasl.c to use the > first format? I don't see any reason not to. > > This is not an important issue, just a small inconsistency. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#5553) Inconsistent sasl.c logging format
by unix.gurus＠gmail.com 12 Jun '08

12 Jun '08

Full_Name: Sean Burford Version: 2.4.8 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (72.14.227.1) Most connection logs are of the format: conn=\d+ fd=\d+ MSG sasl.c Debug logs are of the format: SASL .*[conn=\d+]: MSG Would it be reasonable to change the 6 debug statements in sasl.c to use the first format? This is not an important issue, just a small inconsistency.

1 0

(ITS#5552) Ppolicy overlay doesn't accept unquoted DN for "olcPpolicyDefault"
by ralf＠OpenLDAP.org 12 Jun '08

12 Jun '08

Full_Name: Ralf Haferkamp Version: HEAD, RE24 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (89.166.189.171) Submitted by: ralf Adding an unquoted DN (containing white spaces) to olcPpolicyDefault results in the following error: ldap_modify: Constraint violation (19) additional info: <olcPPolicyDefault> extra cruft after <policyDN> Fix is on the way to CVS.

1 0

Re: (ITS#5550) Unable to do scp from and to server ldap
by hyc＠symas.com 12 Jun '08

12 Jun '08

karim.bourenane(a)orange-ftgroup.com wrote: > Full_Name: Bourenane > Version: Openldap-server-2.3.41 / and clien > OS: FreeBSD 7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (57.250.229.136) > > > Hi All > > My server running fine, with ldap and ldaps. > Is i do a command SCP from any server to user i have : > > server# scp kbourena@ldap-rain:/home/kbourena/toto.txt . > Password: > unknown user 1206 > server# > > On ldap-rain scp is not OpenLDAP software. Since you already said your server is running fine, this is clearly not an OpenLDAP software issue, and therefore does not belong in the OpenLDAP ITS. This ITS will be closed. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5462) Allow setting of RANDOM_FILE for gnutls
by pogma＠thewrittenword.com 12 Jun '08

12 Jun '08

On Tue, Jun 10, 2008 at 12:50:22PM -0700, Howard Chu wrote: > pogma(a)thewrittenword.com wrote: >> Full_Name: Peter O'Gorman >> Version: 2.4.8 >> OS: multiple >> URL: ftp://ftp.openldap.org/incoming/the-written-word-080410.patch >> Submission from: (NULL) (24.76.165.223) >> >> >> gcrypt-1.4.x and later allow the egd socket path to be set. This patch allows >> the conf file option to work when building openldap with gnutls on systems that >> do not have a /dev/random. > > Hm, this patch is a silent no-op if the gcrypt function is missing. > Currently the randfile option is already documented as being ignored by > GNUtls. I would prefer that the behavior is absolutely consistent - either > the feature always works or is always ignored. Perhaps we should require > gcrypt 1.4 or newer? Requiring gcrypt-1.4.x or newer is ok with us. Peter -- Peter O'Gorman pogma(a)thewrittenword.com

1 0

Re: (ITS#5551) assertion causes application failure
by aej＠WPI.EDU 12 Jun '08

12 Jun '08

I ran the thing again to get a trace back, and went to attach the code and found a free() which was at the wrong location. I think I caused the problem. I still don't know what's happening with ldap on the mail server, but my application bug was not related after all.

1 0

(ITS#5551) assertion causes application failure
by aej＠wpi.edu 12 Jun '08

12 Jun '08

Full_Name: Allan E. Johannesen Version: 2.4.10 OS: Linux EL 4 URL: Submission from: (NULL) (130.215.24.208) Recently, incorrect "User unknown" have been appearing in the mail logs with some frequency, accompanied by nss ldap error messages. I can't see into that application, so I'm not sure what's going on. At another place, I've had an application failing where it sees an assertion fail, so this may be the cause of the other problem. Did some debug code remain in the 2.4.10 release? [New Thread 1367456096 (LWP 14151)] [New Thread 1388435808 (LWP 14165)] [Thread 1514314080 (LWP 14129) exited] [New Thread 1514314080 (LWP 14178)] [Thread 1252067680 (LWP 13877) exited] [Thread 1241577824 wpi closed] [Thread 1241577824 (LWP 13824) exited] [New Thread 1241577824 (LWP 14188)] [Thread 1199618400 (LWP 13994) exited] [Thread 1231087968 wpi closed] [Thread 1231087968 (LWP 13888) exited] [New Thread 1231087968 (LWP 14199)] [Thread 1115699552 wpi closed] [Thread 1115699552 (LWP 13946) exited] [Thread 1126189408 alum_connect ldap://alum.wpi.edu] [New Thread 1115699552 (LWP 14212)] [Thread 1136679264 wpi_connect ldap://ldapv2back.wpi.edu] [New Thread 1199618400 (LWP 14223)] [Thread 1105209696 (LWP 14011) exited] [New Thread 1105209696 (LWP 14234)] [Thread 1294027104 (LWP 13865) exited] [Thread 1335986528 (LWP 13839) exited] [Thread 1094719840 (LWP 14057) exited] [New Thread 1094719840 (LWP 14251)] [Thread 1346476384 alum_connect ldap://alum.wpi.edu] [New Thread 1335986528 (LWP 14271)] [New Thread 1294027104 (LWP 14285)] [Thread 1126189408 alum closed] [New Thread 1252067680 (LWP 14286)] [Thread 1126189408 (LWP 14022) exited] [New Thread 1398925664 (LWP 14297)] [New Thread 1126189408 (LWP 14308)] [Thread 1294027104 (LWP 14285) exited] [New Thread 1409415520 (LWP 14318)] [Thread 1157658976 wpi closed] [Thread 1157658976 (LWP 13960) exited] [New Thread 1157658976 (LWP 14329)] [New Thread 1294027104 (LWP 14342)] [Thread 1377945952 (LWP 13928) exited] [New Thread 1377945952 (LWP 14353)] [New Thread 1419905376 (LWP 14363)] [Thread 1325496672 (LWP 14100) exited] [Thread 1294027104 (LWP 14342) exited] [Thread 1136679264 wpi closed] [Thread 1136679264 (LWP 14033) exited] [New Thread 1136679264 (LWP 14380)] [Thread 1262557536 (LWP 13971) exited] [Thread 1220598112 (LWP 14111) exited] [Thread 1283537248 (LWP 14140) exited] [Thread 1346476384 alum closed] [Thread 1346476384 (LWP 14069) exited] [Thread 1367456096 wpi_connect ldap://ldapv2back.wpi.edu] phish+: decode.c:779: ber_scanf: Assertion `((ber)->ber_opts.lbo_valid==0x2)' failed. Program received signal SIGABRT, Aborted. [Switching to Thread 1367456096 (LWP 14151)] 0x000000382342e25d in raise () from /lib64/tls/libc.so.6 (gdb) quit The program is running. Exit anyway? (y or n) y Is there debug output you would like from me?

1 0

(ITS#5550) Unable to do scp from and to server ldap
by karim.bourenane＠orange-ftgroup.com 12 Jun '08

12 Jun '08

Full_Name: Bourenane Version: Openldap-server-2.3.41 / and clien OS: FreeBSD 7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (57.250.229.136) Hi All My server running fine, with ldap and ldaps. Is i do a command SCP from any server to user i have : server# scp kbourena@ldap-rain:/home/kbourena/toto.txt . Password: unknown user 1206 server# On ldap-rain

1 0

(ITS#5549) slapd SEGV faults in entry_partsize when monitoring
by andreas.mueller＠othello.ch 11 Jun '08

11 Jun '08

Full_Name: Andreas Mueller Version: 2.4.9 OS: Solaris 10 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (193.134.170.35) We have four slapd servers in a mirrormode configuration. This generally works well. We monitor these servers using ldapsearches to cn=Monitor every minute, and collect performance data to construct load/performance graphs with rrdtool. Unfortunately, it sometimes happens that slapd crashes during the monitoring query. Using gdb, we were able to get a stack backtrace: Core was generated by `/usr/local/libexec/slapd'. Program terminated with signal 11, Segmentation fault. #0 0x0005fd48 in entry_partsize () (gdb) bt #0 0x0005fd48 in entry_partsize () #1 0x000603b4 in entry_flatsize () #2 0x0006a5c8 in slap_send_search_entry () #3 0x00134330 in monitor_send_children () #4 0x001348e0 in monitor_back_search () #5 0x000523ac in fe_op_search () #6 0x00051b64 in do_search () #7 0x0004dd8c in connection_operation () #8 0x0004e4c4 in connection_read_thread () #9 0x001a22a8 in ldap_int_thread_pool_wrapper () #10 0xfe3c5800 in __tbl_10_huge_digits () from /lib/libc.so.1 All cores obtained so far show that the segmentation fault occured at the same location inside entry_partsize. Unfortunately we cannot systematically reproduce this behaviour, and we also cannot get the line number (binaries are stripped). We have not tried other versions or other platforms. For production, we use the versions available in package form from www.sunfreeware.com, but the error also happens on servers we have compiled ourselves from the sources.

1 0

(ITS#5548) syncprov evaluates ACL rules with wrong connection info
by rein＠OpenLDAP.org 11 Jun '08

11 Jun '08

Full_Name: Rein Tollevik Version: 2.4.10 (CVS head) OS: linux, solaris URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (84.215.2.34) Submitted by: rein Access control rules that uses connection data are evaluated using the wrong connection structure. The problem is in syncprov_matchop() where it around line 1233 assigns: op2.o_hdr = op->o_hdr; This causes ACL rules to be tested against the connection that made the change, not the syncrepl connection. It should retain the value from ss->s_op. Rein Tollevik Basefarm AS

1 0

(ITS#5547) JLDAP: unauthenticated bind silently converted to anonymous bind
by johannes.geiger＠vkb.de 11 Jun '08

11 Jun '08

Full_Name: Johannes Geiger Version: n/a OS: Windows, Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (62.245.172.60) While the documentation of JLDAP states that only authenticated and anonymous bind are supported, JLDAP silently converts an unauthenticated bind to an anonymous one. >From LDAPconnection.java boolean anonymous = false; if( passwd.length == 0) { anonymous = true; // anonymous, passwd length zero with simple bind dn = ""; // set to null if anonymous } (I even think there is a bug in this, as the flag "anonymous" stays on false, if there is a password given but no dn.) This is in fact a security issue, as - while unauthenticated bind usually is forbidden by the server, anonymous bind is allowed - the client using bind for authentication reasons might be led to believe in successful authentication whereas the server only accepted an anonymous bind and did not do any credential verification.

1 0

(ITS#5546) slapd aborts using slapo-pcache when caching negative searches
by toby＠inf.ed.ac.uk 11 Jun '08

11 Jun '08

Full_Name: Toby Blake Version: 2.4.10 OS: Scientific Linux 5.1 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (129.215.218.33) Hi there, If I specify a negative ttl when using slapo-pcache, e.g... overlay pcache proxycache bdb 5000 1 500 300 proxycachequeries 10000 proxyattrset 0 uid # proxytemplate using ttl and negative ttl of 1800 proxytemplate (uid=) 0 1800 1800 ... slapd aborts whenever there is a negative search to cache. The cause of this seems to be the assert(0) in pcache.c:pcache_op_cleanup, code fragment starting line 2010... switch ( si->caching_reason ) { case PC_POSITIVE: cache_entries( op, rs, &qc->q_uuid ); break; case PC_SIZELIMIT: qc->q_sizelimit = rs->sr_nentries; break; default: assert( 0 ); break; } The value of si>caching_reason when slapd SIGABRTs is PC_NEGATIVE (which isn't handled by the switch statement). Let me know if you need any more info... Cheers Toby Blake School of Informatics University of Edinburgh

1 0

(ITS#5545) Inconsistency in multi-master setup
by st＠itsc.cuhk.edu.hk 11 Jun '08

11 Jun '08

Full_Name: SiuTo Wong Version: 2.4.10 OS: CentOS 5 (Final) URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (137.189.29.184) Have setup 2-node multi-master configuration. Found that when operating on same set of users at high loading, there will be consistency between the masters. The problem can be simulated by running copies of perl script to add/delete the same set of users simultaneously, e.g. add user a001 - a100 & delete user a001 - a100 & or add user a001 - a100 & add user a001 - a100 & There is no problem if multiple threads of add/delete are running, when operating on different sets of users. Attached please find snap of syncrepl setting of one of the servers. All attributes are the same on both masters, except serverId, rid, and provider. Thanks a lot. ====================== cut here ====================== index entryCSN,entryUUID eq lastmod on serverId 2 syncrepl rid=002 provider=ldap://192.168.28.70 starttls=yes tls_reqcert=never tls_cacert=/etc/CA/cacert.pem type=refreshAndPersist retry="5 + 5 +" searchbase="dc=mydomain,dc=hk" schemachecking=off bindmethod=simple binddn="cn=srAdmin,ou=People,dc=mydomain,dc=hk" credentials=youguess interval=00:00:00:05 mirrormode true overlay syncprov syncprov-checkpoint 100 10 syncprov-sessionlog 100 limits dn.exact="cn=srAdmin,ou=People,dc=cuhk,dc=edu,dc=hk" time.soft=unlimited time.hard=unlimited size.soft=unlimited size.hard=unlimited ====================== cut here ======================

1 0

Re: (ITS#5462) Allow setting of RANDOM_FILE for gnutls
by hyc＠symas.com 10 Jun '08

10 Jun '08

pogma(a)thewrittenword.com wrote: > Full_Name: Peter O'Gorman > Version: 2.4.8 > OS: multiple > URL: ftp://ftp.openldap.org/incoming/the-written-word-080410.patch > Submission from: (NULL) (24.76.165.223) > > > gcrypt-1.4.x and later allow the egd socket path to be set. This patch allows > the conf file option to work when building openldap with gnutls on systems that > do not have a /dev/random. Hm, this patch is a silent no-op if the gcrypt function is missing. Currently the randfile option is already documented as being ignored by GNUtls. I would prefer that the behavior is absolutely consistent - either the feature always works or is always ignored. Perhaps we should require gcrypt 1.4 or newer? -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5464) ucred guarded by __USE_GNU in glibc 2.8
by hyc＠symas.com 06 Jun '08

06 Jun '08

rhafer(a)suse.de wrote: > Full_Name: Ralf Haferkamp > Version: Any > OS: Linux (glibc 2.8) > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (85.8.71.17) > > > Newer glibc Version guards the definition of struct ucred (e.g. used in > liblutil/getpeereid.c) by __USE_GNU, hence it is only available when _GNU_SOURCE > is defined. > > The matching glibc changelog only say "Cleanup namespace.". Here's the diff: > > http://sourceware.org/cgi-bin/cvsweb.cgi/libc/sysdeps/unix/sysv/linux/bits/… This is a bug in glibc. Luca Scamoni reported it upstream here http://sources.redhat.com/bugzilla/show_bug.cgi?id=6545 -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#5517) add superclass of existing class fails
by Kurt＠OpenLDAP.org 05 Jun '08

05 Jun '08

On Jun 5, 2008, at 6:31 AM, h.b.furuseth(a)usit.uio.no wrote: > And when they add the absent A and that fails, but we can fix that. I think the best is option is disallow addition of an unlisted subject and disallow the removal of a unlisted subclass (except by replace). This will provide more a more consistent and symmetric behavior. In your initial report, it was this inconsistent and non-symmetric behavior that was your most significant concern. As far as RFC conformance goes, I argue that with this change, the behavior would be fully conformant. No where in the RFCs does it require servers to return implicitly added values, no where in the RFCs does it preclude servers from removing implicitly added values upon removal of values which caused there addition. The concern I have is impact on clients which add a class and then delete that class, expecting it just to work. But if that class is subclass, and the add causes the insertion of some other class, then the delete will either leave that other class there or lead to an error, both undesirable and unexpected behaviors. I think the mistake that LDAP designers made (long ago) was not to require LDAP CLIENTS to provide all (non-top) classes, as is required of DAP clients. Regarding objectClass being special (especially with regard to its equality matching rule): consider (objectClass=top) and X.500 "top may be omitted" statement. -- Kurt

1 0

Re: (ITS#5517) add superclass of existing class fails
by h.b.furuseth＠usit.uio.no 05 Jun '08

05 Jun '08

(I seem to be arguing myself into two different corners here, but anyway...) Kurt(a)OpenLDAP.org writes: >On May 24, 2008, at 2:37 PM, h.b.furuseth(a)usit.uio.no wrote: >> ando(a)sys-net.it writes: >>> The issue right now is caused by the fact that comparing present >>> values with the asserted one causes objectSubClassMatch() to check >>> for match including superiors. >> >> This looks like a bug to me. > > Maybe in the RFCs. Yes, to my eyes it cleary says what you say was not intended. >> objectClass has EQUALITY matching rule >> objectIdentifierMatch, which does not follow the object class >> inheritance chain. > > Yes, but objectClass is quite special (despite being a > userApplications attribute). Hpmh. Not very, according to RFCs 4511-12. Maybe we all "knew" it so well that we never noticed, during several IETF WGs. > For instance, (objectClass=*) is to match DSEs which don't have an > objectClass attribute. That's explicitly mentioned in RFC 4512 for the root DSE, as is the (objectClass=subschema) special case. Section RFC 4512 section 3.3 says each entry in the DIT has an 'objectClass' attribute. Are other DSEs not in the DIT? There is RFC 4511 section 4.5.1 (Search Request)'s statement that List and Read operations can be emulated with a search for (objectClass=*). Nowhere else can I find that (objectClass=*) is special. > Likewise, objectClass=foo can match objectClass attributes which > don't explicitly contain foo. Not according what the RFCs say to my eyes, (below): >> See RFC 4517 section 4.2.26. RFC 4512 section 3.3 >> (the 'objectClass' attribute) does not special-case this. >> >> What makes slapd work is that it also disobeys RFC 4512 section 3.3: >> "When creating an entry or adding an 'objectClass' value to an >> entry, >> all superclasses of the named classes SHALL be implicitly added as >> well if not already present." > >> This doesn't say the classes shall be considered to be implicitly >> present, like slapd does. > > You are reading 3.3 as if it said "SHALL be added (by the server)". > It doesn't say "SHALL be added (by the server). It says "SHALL be > implicitly added" (presumedly by the server). I don't see how that changes anything, but then I'm not a native English speaker. > This was discussed during LDAPbis discussions. As the Editor of RFC > 4512, I can say that it was my intent to allow servers to merely treat > superclasses as being present. Hard do argue with that. I couldn't find these discussions though. Do you remember where/when? All I found was this, which seems to imply the opposite: http://www.openldap.org/lists/ietf-ldapbis/200403/msg00023.html >> Instead slapd should add the missing classes to the actual object, > > Doing so is problematic. A client which adds B then deletes B would > be surprised by non-net-zero result of the operation(s). Clients will be surprised anyway. Currently clients are being surprised when (objectClass=A) matches even though A is absent. And when they add the absent A and that fails, but we can fix that. >> just like it adds some other attribute/values >> implicitly (createTimestamp, subschemaSubentry, etc). > > These are operational attributes. ObjectClass is an userApplications > attribute. Servers should not muck with the values of userApplication > attributes. Well, it does when it adds missing naming attributes (since RFC4511, ITS#5412). I guess that is a better example. And it "mucks with" objectClass in a different way anyway, as you've just pointed out. -- Hallvard

1 0

Re: (ITS#5540) Normalization assertion in attr.c
by unix.gurus＠gmail.com 04 Jun '08

04 Jun '08

Hi, On Wed, Jun 4, 2008 at 2:20 PM, Hallvard B Furuseth <h.b.furuseth(a)usit.uio.no> wrote: > I haven't follwed this ITS, but a few notes anyway: > > unix.gurus(a)gmail.com writes: >> monitorCounter >> monitorCounter does not have an equality matching rule, > > Yes it does. back-monitor/init.c line 1710. What are you looking at? > (Hmm, I too had the impression it had no EQUALITY rule...) I'm working with OpenLDAP 2.4.9. You're right. integerMatch has an equality rule but no normalizing function. The logic that determines whether a normalized value should exist says: have_norm = a->a_desc->ad_type->sat_equality != NULL && a->a_desc->ad_type->sat_equality->smr_normalize != NULL; ... new_nval = nvals != NULL; ... if ( have_norm != new_nval ) { assert() So we don't need nvals for integers. For this reason I was right to remove the nval for monitorCounter, monitorOpInitiated, monitorOpCompleted, but my reasoning was wrong. >> monitorOpCompleted >> monitorOpInitiated >> These attributes do not have equality matching rules, > > These do too, inherited from monitorCounter. See above. > it doesn't work right in 2.3 however: > > ldapsearch -LLL -bcn=monitor -s one '(monitorCounter=0)' monitorCounter > dn: cn=Operations,cn=Monitor > monitorOpInitiated: 231542983 > monitorOpCompleted: 231542982 I wonder if val is being maintained and nval is being left at 0. The code at the end of monitor_subsys_ops_update() maintains a_vals but not a_nvals, so that is probably the problem: /* NOTE: no minus sign is allowed in the counters... */ UI2BV( &a->a_vals[ 0 ], nInitiated ); ldap_pvt_mp_clear( nInitiated ); ... /* NOTE: no minus sign is allowed in the counters... */ UI2BV( &a->a_vals[ 0 ], nCompleted ); ldap_pvt_mp_clear( nCompleted ); >> namingContexts >> configContext >> dynamicSubtrees >> >> These attributes do not have equality matching rules, but probably >> should. I add 'EQUALITY distinguishedNameMatch' to them in >> schema_prep.c. > > No, that breaks the definitions in the RFCs they come from. (See their > DESC strings.) I don't know why they lack EQUALITY rules, maybe we just > forgot when we defined them, but that's the way it is. Same with > supportedControl. Ok, so we should not define nvals for them? > monitorContext, readOnly and the olc* attributes are defined by OpenLDAP > (their OIDs start with 1.3.6.1.4.1.4203) and can be modified if we feel > like it. Personally I prefer attrs to have the matching rules they can > have unless there is a reason not to, but I didn't write these modules > so I don't know if there _is_ a reason not to. -- Thanks, Sean Burford

1 0

Re: (ITS#5540) Normalization assertion in attr.c
by h.b.furuseth＠usit.uio.no 04 Jun '08

04 Jun '08

I haven't follwed this ITS, but a few notes anyway: unix.gurus(a)gmail.com writes: > monitorCounter > monitorCounter does not have an equality matching rule, Yes it does. back-monitor/init.c line 1710. What are you looking at? (Hmm, I too had the impression it had no EQUALITY rule...) > monitorOpCompleted > monitorOpInitiated > These attributes do not have equality matching rules, These do too, inherited from monitorCounter. it doesn't work right in 2.3 however: ldapsearch -LLL -bcn=monitor -s one '(monitorCounter=0)' monitorCounter dn: cn=Operations,cn=Monitor monitorOpInitiated: 231542983 monitorOpCompleted: 231542982 > namingContexts > configContext > dynamicSubtrees > > These attributes do not have equality matching rules, but probably > should. I add 'EQUALITY distinguishedNameMatch' to them in > schema_prep.c. No, that breaks the definitions in the RFCs they come from. (See their DESC strings.) I don't know why they lack EQUALITY rules, maybe we just forgot when we defined them, but that's the way it is. Same with supportedControl. monitorContext, readOnly and the olc* attributes are defined by OpenLDAP (their OIDs start with 1.3.6.1.4.1.4203) and can be modified if we feel like it. Personally I prefer attrs to have the matching rules they can have unless there is a reason not to, but I didn't write these modules so I don't know if there _is_ a reason not to. -- Hallvard

1 0

Re: (ITS#5540) Normalization assertion in attr.c
by unix.gurus＠gmail.com 04 Jun '08

04 Jun '08

HI, On Fri, May 30, 2008 at 2:40 AM, <hyc(a)symas.com> wrote: > hyc(a)symas.com wrote: >> We'll probably need to discuss on the -devel list what steps to take from here. >> > I wrote the attached patch for the original issue. Unfortunately it asserted > right away: > ... > > It was adding the createTimestamp attribute, without providing normalized > values. slap_add_opattrs was written before the generalizedTimeNormalize > function was written... I suspect there will be a fair number of cases that > need to be cleaned up. I've identified these attributes as having differences between their nval population and their schema. I've been using Google coredumper instead of assertions to mark places where normalization looks bad. In this way, I get a bunch of core files to look through after a run instead of a single assertion. Once all of the attributes that have bad normalization have been identified in this way, I'll go back over the source and look for other places where they are used. I haven't found all of the normalization differences yet, but I wanted to check in to ensure I'm on the right path. I would like your comments on whether these look like the right changes to make. You can refer to ftp://ftp.openldap.org/incoming/sburford-initial-normalization-20080604.pat… for the details. createTimestamp createTimestamp does have an equality matching rule, as I think it should. The buffer timestamp is populated with a generalized time by slap_timestamp(), so I add &timestamp as the nval for the calls to attr_merge_one in add.c slap_add_opattrs() and schema.c schema_info(). I also use a slight variation of this for createTimestamp in slapadd.c slapadd(). modifyTimestamp Same arguments and modifications as createTimestamp. modifyTimestamp is also used in modify.c slap_mods_opattrs(), where I ch_malloc a new BerVarray for the mod->sml_nvalues. I dont use the same BerVarray for vals and nvals in case whatever frees mod entries frees them as separate pointers (double free). Does something free all of the vals and nvals in the modify list? entryCSN entryCSN does have an equality matching rule, as I think it should. In add.c slap_add_opattrs() I change the attr_merge_one into an attr_merge_normalize_one with op->o_tmpmemctx as the memory context. I haven't looked into the memory context argument, but assume it contains a list of things to free when the context is finished with? In slapadd I also change the attr_merge_one into an attr_merge_normalize_one but I pass a NULL memory context, since slapadd is short lived and there are other examples like this in the nearby source code. In modify.c slap_mods_opattrs() I ch_malloc a new BerVarray for the entryCSN nval and use attr_normalize_one to populate it. Again I assume something frees the components of the modify list later. contextCSN contextCSN does have an equality matching rule, as I think it should. In ctxcsn.c slap_create_context_csn_entr() I change attr_merge_one into attr_merge_normalize_one with a NULL memory context. In overlays/syncprov.c syncprov_checkpoint() and syncrepl.c syncrepl_updateCookie() it is a bit more difficult because a local modlist is created without any attr_merge calls, so I ch_malloc an array for the nvals, and populate it with attr_normalize and use ber_array_bvfree to free it. monitorCounter monitorCounter does not have an equality matching rule, so I remove the nval argument from attr_merge_one() in back-monitor/conn.c monitor_subsys_conn_init() (affects counters for max FD, total conns and current conns). monitorOpCompleted monitorOpInitiated These attributes do not have equality matching rules, so I remove the nval argument from attr_merge_one() in back-monitor/operation.c monitor_subsys_ops_init(). monitorContext namingContexts configContext dynamicSubtrees These attributes do not have equality matching rules, but probably should. I add 'EQUALITY distinguishedNameMatch' to them in schema_prep.c. olcRootDN olcSchemaDN These attributes do not have equality matching rules, but probably should. I add 'EQUALITY distinguishedNameMatch' to them in bconfig.c. supportedControl This attribute does not have an equality matching rule, but probably should. I add 'EQUALITY objectIdentifierMatch' to it in schema_prep.c. readOnly This attribute does not have an equality matching rule, I don't know if it should. I NULLed the nval passed to attr_merge_one in back-monitor/database.c. default_referral: In rootdse.c root_dse_info() I change attr_merge to attr_merge_normalize for default_referral, since it has an equality matching rule. There doesn't seem to be a memory context in use here. I suspect this normalization might result in memory leakage unless followed by a free in root_dse_info()? Also, bconfig.c config_build_attrs() contains this logic which calls attr_merge_normalize() for values that don't need normalization. attr_merge_normalize won't normalize them though, so it should be fine: if ( c->rvalue_nvals ) attr_merge(e, ct[i].ad, c->rvalue_vals, c->rvalue_nvals); else attr_merge_normalize(e, ct[i].ad, c->rvalue_vals, NULL); > I don't have time at the moment to chase them all down. > Anyone else want to jump in here? If not, we may have to push this back a bit. > Note that this patch will probably require a fair number of databases to be > reloaded. The attributes listed above tend to agree with that, but if they really were not being normalized before storage I'm surprised that the original assertion wasn't hit more often? -- Thanks, Sean Burford

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs