- openldap-bugs - openldap.org

Re: (ITS#8021) Wrong mdb_env_sync() with at least MDB_RDONLY
by h.b.furuseth＠usit.uio.no 08 Jan '15

08 Jan '15

On 08/01/15 20:59, Howard Chu wrote: > mdb_env_sync() shouldn't even be doing any work at all if the env was > opened RDONLY. We should return nop in that case. RDONLY means RDONLY! Currently it syncs changes written by another process.

1 0

Re: (ITS#8021) Wrong mdb_env_sync() with at least MDB_RDONLY
by hyc＠symas.com 08 Jan '15

08 Jan '15

h.b.furuseth(a)usit.uio.no wrote: > Full_Name: Hallvard B Furuseth > Version: lmdb 0.9.14 > OS: > URL: > Submission from: (NULL) (81.191.45.22) > Submitted by: hallvard > > > mdb_env_sync() works with MDB_RDONLY at least on Unix, but > it syncs MDB_WRITEMAP changes incorrectly: fdatasync instead > of msync because mdb_env_open() cleared MDB_WRITEMAP. > > Users are likely doing the same thing anyway: Using MDB_RDONLY > instead of MDB_RDONLY|MDB_WRITEMAP on WRITEMAP-written DBs. mdb_env_sync() shouldn't even be doing any work at all if the env was opened RDONLY. We should return nop in that case. RDONLY means RDONLY! No writes, no calls that will alter the storage layer. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8021) Wrong mdb_env_sync() with at least MDB_RDONLY
by h.b.furuseth＠usit.uio.no 08 Jan '15

08 Jan '15

Full_Name: Hallvard B Furuseth Version: lmdb 0.9.14 OS: URL: Submission from: (NULL) (81.191.45.22) Submitted by: hallvard mdb_env_sync() works with MDB_RDONLY at least on Unix, but it syncs MDB_WRITEMAP changes incorrectly: fdatasync instead of msync because mdb_env_open() cleared MDB_WRITEMAP. Users are likely doing the same thing anyway: Using MDB_RDONLY instead of MDB_RDONLY|MDB_WRITEMAP on WRITEMAP-written DBs. Finally, writers committing with and without WRITEMAP will sync each others' commits incorrectly. lmdb.h does warn they will "not cooperate well", but it should warn it breaks ACID. LMDBv2 can instead fix all this with 2 bits in MDB_meta: "Changed with/without WRITEMAP since last sync". In LMDBv1, I think the smallest-impact fix is for env_sync to both msync and fdatasync when RDONLY is set and WRITEMAP is clear. A greedier fix would be to always sync both ways when the user calls env_sync. Either way, it may be best to keep WRITEMAP when RDONLY. Only env_map() needs to deal with that. Pushing suggestions except doc to "mdb/wmap-fix" in my repo.

1 0

(ITS#8020) 64bit indexer broken
by hyc＠openldap.org 07 Jan '15

07 Jan '15

Full_Name: Howard Chu Version: 2.4 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.155.233.73) Submitted by: hyc Only 32 bits of the hash were being used. patch coming shortly

1 0

Re: (ITS#8019) LDAP Replication By attribute
by quanah＠zimbra.com 07 Jan '15

07 Jan '15

--On Wednesday, January 07, 2015 4:19 PM +0000 sofiene.blouza(a)etiam.com wrote: > Full_Name: SOFIENE BLOUZA > Version: 2.4.23-34.el6_5.1 > OS: Centos 6.6 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (217.109.110.145) The ITS system is for reporting bugs, not for usage questions. Usage questions belong on the openldap-technical(a)openldap.org list. I would note that the version you reference is extremely old, and it would be advised as your first step to upgrade to a current OpenLDAP release. --Quanah -- Quanah Gibson-Mount Platform Architect Zimbra, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

(ITS#8019) LDAP Replication By attribute
by sofiene.blouza＠etiam.com 07 Jan '15

07 Jan '15

Full_Name: SOFIENE BLOUZA Version: 2.4.23-34.el6_5.1 OS: Centos 6.6 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (217.109.110.145) Hello, I want to make replication betweend two ldap servers using Delta-syncrepl. I use the tuto http://www.openldap.org/doc/admin24/replication.html#Delta-syncrepl on section 18.3.2. I make the configuration but it doesnt work correctly. How can I fix the problem! Thunks a lot

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by hyc＠symas.com 06 Jan '15

06 Jan '15

Leonid Yuriev wrote: > Yes of course, all warnings could be hushed by compiler options, but > this also hides the real mistakes. > So, I prefer fix the warnings, instead of disable gcc/clang features. > > Please review attached patchset and merge. Your patch assumes CPP features that are not guaranteed to be present. Rejecting this patchset. Learn more about how OpenLDAP software is built and why. > > Leonid. > > --- > > The attached files is derived from OpenLDAP Software. All of the > modifications > to OpenLDAP Software represented in the following patch(es) were > developed by > Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned > rights > and/or interest in this work to any party. I, Leonid Yuriev am > authorized by > Peter-Service LLC, my employer, to release this work under the following > terms. > > Peter-Service LLC hereby places the following modifications to OpenLDAP > Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose > with or without attribution and/or other notice > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by leo＠yuriev.ru 06 Jan '15

06 Jan '15

--e89a8f8389d152e760050bfd4ba8 Content-Type: text/plain; charset=UTF-8 Fast-forward 'pull' is also available https://github.com/leo-yuriev/openldap-lmdb-challenge.git Leonid. 2015-01-06 18:10 GMT+03:00 Leonid Yuriev <leo(a)yuriev.ru>: > Yes of course, all warnings could be hushed by compiler options, but this > also hides the real mistakes. > So, I prefer fix the warnings, instead of disable gcc/clang features. > > Please review attached patchset and merge. > > Leonid. > > --- > > The attached files is derived from OpenLDAP Software. All of the > modifications > to OpenLDAP Software represented in the following patch(es) were developed > by > Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned > rights > and/or interest in this work to any party. I, Leonid Yuriev am authorized > by > Peter-Service LLC, my employer, to release this work under the following > terms. > > Peter-Service LLC hereby places the following modifications to OpenLDAP > Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose > with or without attribution and/or other notice > > > --e89a8f8389d152e760050bfd4ba8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><div>Fast-forward 'pull' is also available</d= iv><div><a href=3D"https://github.com/leo-yuriev/openldap-lmdb-challenge.gi= t">https://github.com/leo-yuriev/openldap-lmdb-challenge.git</a><br><br>Leo= nid.</div></div></div><div class=3D"gmail_extra"><br><div class=3D"gmail_qu= ote">2015-01-06 18:10 GMT+03:00 Leonid Yuriev <span dir=3D"ltr"><<a href= =3D"mailto:leo@yuriev.ru" target=3D"_blank">leo(a)yuriev.ru</a>></span>:<b= r><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:= 1px #ccc solid;padding-left:1ex">Yes of course, all warnings could be hushe= d by compiler options, but this also hides the real mistakes.<br> So, I prefer fix the warnings, instead of disable gcc/clang features.<br> <br> Please review attached patchset and merge.<br> <br> Leonid.<br> <br> ---<br> <br> The attached files is derived from OpenLDAP Software. All of the modificati= ons<br> to OpenLDAP Software represented in the following patch(es) were developed = by<br> Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned right= s<br> and/or interest in this work to any party. I, Leonid Yuriev am authorized b= y<br> Peter-Service LLC, my employer, to release this work under the following te= rms.<br> <br> Peter-Service LLC hereby places the following modifications to OpenLDAP Sof= tware<br> (and only these modifications) into the public domain. Hence, these<br> modifications may be freely used and/or redistributed for any purpose<br> with or without attribution and/or other notice<br> <br> <br> </blockquote></div><br></div> --e89a8f8389d152e760050bfd4ba8--

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by hyc＠symas.com 06 Jan '15

06 Jan '15

leo(a)yuriev.ru wrote: > Full_Name: Leonid Yuriev > Version: git-master > OS: RHEL7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (31.130.36.33) > > > It is about 5K warnings reported by gcc/clang if building OpenLDAP with -Wall. > > CFLAGS="-Wall" ./configure ... No need for that. Learn how to use make. > make depend && make make AC_CFLAGS="-Wall -Wno-format-extra-args" -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by hyc＠symas.com 06 Jan '15

06 Jan '15

leo(a)yuriev.ru wrote: > Full_Name: Leonid Yuriev > Version: git-master > OS: RHEL7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (31.130.36.33) > > > It is about 5K warnings reported by gcc/clang if building OpenLDAP with -Wall. > > CFLAGS="-Wall" ./configure ... > make depend && make > > The vast majority of warnings about harmless things: unnecessary arguments to > printf through Debug macro, Ignore those. Use -Wno-format-extra-args > unused variables and functions, etc. > But such amount of warnings makes impossible to use -Wall to find a potential > problems. > > I have prepared the patchset which fixes most of these warnings. > It will be submited shortly. > > Leonid. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by pierangelo.masarati＠polimi.it 06 Jan '15

06 Jan '15

On 06/01/2015 15:47, leo(a)yuriev.ru wrote: > Full_Name: Leonid Yuriev > Version: git-master > OS: RHEL7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (31.130.36.33) > > > It is about 5K warnings reported by gcc/clang if building OpenLDAP with -Wall. > > CFLAGS="-Wall" ./configure ... > make depend && make > > The vast majority of warnings about harmless things: unnecessary arguments to > printf through Debug macro, unused variables and functions, etc. > But such amount of warnings makes impossible to use -Wall to find a potential > problems. > > I have prepared the patchset which fixes most of these warnings. > It will be submited shortly. My 2c: - normal users do not need to build with -Wall; only developers might need to - in addition to -Wall, if you add -Wno-[specific harmless warnings you want to disable], then only relevant ones do surface. p. -- Pierangelo Masarati Associate Professor Dipartimento di Scienze e Tecnologie Aerospaziali Politecnico di Milano

1 0

(ITS#8018) a lot of warnings building with -Wall
by leo＠yuriev.ru 06 Jan '15

06 Jan '15

Full_Name: Leonid Yuriev Version: git-master OS: RHEL7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (31.130.36.33) It is about 5K warnings reported by gcc/clang if building OpenLDAP with -Wall. CFLAGS="-Wall" ./configure ... make depend && make The vast majority of warnings about harmless things: unnecessary arguments to printf through Debug macro, unused variables and functions, etc. But such amount of warnings makes impossible to use -Wall to find a potential problems. I have prepared the patchset which fixes most of these warnings. It will be submited shortly. Leonid.

1 0

Re: (ITS#8017) Enhancement: Limit core dump size
by quanah＠zimbra.com 06 Jan '15

06 Jan '15

--On Tuesday, January 06, 2015 1:31 AM +0000 gnoe(a)symas.com wrote: > Full_Name: Greg Noe > Version: NA > OS: NA > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (63.142.209.94) > > > Request: If possible, add an option to limit the size of a core dump > when slapd crashes. > > Reason for request: In cases where very large caches are used and slapd > crashes, the size of the core dump files can exceed the available disk > space. Core dump size is controlled by the kernel already, via sysctl. Why does one need an option to slapd for this? -- Quanah Gibson-Mount Platform Architect Zimbra, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

(ITS#8017) Enhancement: Limit core dump size
by gnoe＠symas.com 06 Jan '15

06 Jan '15

Full_Name: Greg Noe Version: NA OS: NA URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (63.142.209.94) Request: If possible, add an option to limit the size of a core dump when slapd crashes. Reason for request: In cases where very large caches are used and slapd crashes, the size of the core dump files can exceed the available disk space.

1 0

Re: (ITS#8016) silence on wrong envflags for lmdb-backend
by hyc＠symas.com 05 Jan '15

05 Jan '15

leo(a)yuriev.ru wrote: > Full_Name: Leonid Yuriev > Version: 2.4-HEAD > OS: RHEL7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (31.130.36.33) > > > No any error reported by lmdb-backend when wrong options was specified in > envflags. > > For example slapd.conf: > envflags This is a rebus codestyle and the technical debt > > Patch will be available shortly. fixed in master -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8016) silence on wrong envflags for lmdb-backend
by hyc＠symas.com 05 Jan '15

05 Jan '15

leo(a)yuriev.ru wrote: > This is a multi-part message in MIME format. > --------------080401010006020303000400 > Content-Type: text/plain; charset=windows-1251; format=flowed > Content-Transfer-Encoding: 7bit > > Please review and merge. > > Leonid. > > --- > > The attached files is derived from OpenLDAP Software. All of the > modifications > to OpenLDAP Software represented in the following patch(es) were > developed by > Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned > rights > and/or interest in this work to any party. I, Leonid Yuriev am > authorized by > Peter-Service LLC, my employer, to release this work under the following > terms. > > Peter-Service LLC hereby places the following modifications to OpenLDAP > Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose > with or without attribution and/or other notice. > > > > --------------080401010006020303000400 > Content-Type: text/x-patch; > name="its8016.patch" > Content-Transfer-Encoding: 7bit > Content-Disposition: attachment; > filename="its8016.patch" > > commit 36ecfd44559d3b89a7dd5bcbfb6a22d8aeb8142b > Author: Leo Yuriev <leo(a)yuriev.ru> > Date: 2015-01-04 09:05:36 +0300 > > fix: report about wrong envflags in lmdb-backend instead of silently ignore them. > > diff --git a/servers/slapd/back-mdb/config.c b/servers/slapd/back-mdb/config.c > index bb9be73..68009b6 100644 > --- a/servers/slapd/back-mdb/config.c > +++ b/servers/slapd/back-mdb/config.c > @@ -620,8 +620,10 @@ mdb_cf_gen( ConfigArgs *c ) > } > mdb->mi_dbenv_flags |= mdb_envflags[j].mask; > } else { > - /* unknown keyword */ > - rc = 1; > + fprintf( stderr, "%s: " > + "unknown keyword \"%s\" in \"envflags\".\n", > + c->log, c->argv[i] ); > + return 1; > } > } > } > > --------------080401010006020303000400-- Use of fprintf(stderr) for config errors is deprecated. New code should only be using c->cr_msg. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8016) silence on wrong envflags for lmdb-backend
by leo＠yuriev.ru 04 Jan '15

04 Jan '15

This is a multi-part message in MIME format. --------------080401010006020303000400 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit Please review and merge. Leonid. --- The attached files is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned rights and/or interest in this work to any party. I, Leonid Yuriev am authorized by Peter-Service LLC, my employer, to release this work under the following terms. Peter-Service LLC hereby places the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. --------------080401010006020303000400 Content-Type: text/x-patch; name="its8016.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="its8016.patch" commit 36ecfd44559d3b89a7dd5bcbfb6a22d8aeb8142b Author: Leo Yuriev <leo(a)yuriev.ru> Date: 2015-01-04 09:05:36 +0300 fix: report about wrong envflags in lmdb-backend instead of silently ignore them. diff --git a/servers/slapd/back-mdb/config.c b/servers/slapd/back-mdb/config.c index bb9be73..68009b6 100644 --- a/servers/slapd/back-mdb/config.c +++ b/servers/slapd/back-mdb/config.c @@ -620,8 +620,10 @@ mdb_cf_gen( ConfigArgs *c ) } mdb->mi_dbenv_flags |= mdb_envflags[j].mask; } else { - /* unknown keyword */ - rc = 1; + fprintf( stderr, "%s: " + "unknown keyword \"%s\" in \"envflags\".\n", + c->log, c->argv[i] ); + return 1; } } } --------------080401010006020303000400--

1 0

(ITS#8016) silence on wrong envflags for lmdb-backend
by leo＠yuriev.ru 04 Jan '15

04 Jan '15

Full_Name: Leonid Yuriev Version: 2.4-HEAD OS: RHEL7 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (31.130.36.33) No any error reported by lmdb-backend when wrong options was specified in envflags. For example slapd.conf: envflags This is a rebus codestyle and the technical debt Patch will be available shortly.

1 0

Re: (ITS#8011) few mistakes in lmdb-backend
by hyc＠symas.com 04 Jan '15

04 Jan '15

Леонид Юрьев wrote: > Updated. > Please pickup. > diff --git a/servers/slapd/back-mdb/dn2id.c b/servers/slapd/back-mdb/dn2id.c > index 41c4758..0890bce 100644 > --- a/servers/slapd/back-mdb/dn2id.c > +++ b/servers/slapd/back-mdb/dn2id.c > @@ -746,7 +746,8 @@ mdb_idscopes( > /* remember our chain of parents */ > id2.mid = id; > id2.mval = data; > - mdb_id2l_insert( isc->sctmp, &id2 ); > + rc = mdb_id2l_insert( isc->sctmp, &id2 ); > + assert(rc == 0); > } > ptr = data.mv_data; > ptr += data.mv_size - sizeof(ID); Unnecessary, the total number of parents is constrained by the max length of a DN which is 8192 bytes. A maximum depth DN (max number of shortest possible RDNs) will always fit in sctmp. I will commit the remainder of the patch. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8012) SIGSEGV while disconnect/abandon
by hyc＠symas.com 04 Jan '15

04 Jan '15

Leonid Yuriev wrote: > Patch update: > > Detaching a syncops record from op-list CONDITIONALLY, only when it > was freed by syncprov_free_syncop. > The syncprov_drop_psearch() and syncprov_drop_psearch() now returns > a flag, which is nonzero if the given syncops was freed. Thanks, applied to master. > > Leonid. > > 29.12.2014 13:50, Leonid Yuriev ïèøåò: >> Please review attached patch and merge-in. >> >> Leonid. >> >> --- >> >> The attached files is derived from OpenLDAP Software. All of the >> modifications >> to OpenLDAP Software represented in the following patch(es) were >> developed by >> Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned >> rights >> and/or interest in this work to any party. I, Leonid Yuriev am >> authorized by >> Peter-Service LLC, my employer, to release this work under the >> following terms. >> >> Peter-Service LLC hereby places the following modifications to >> OpenLDAP Software >> (and only these modifications) into the public domain. Hence, these >> modifications may be freely used and/or redistributed for any purpose >> with or without attribution and/or other notice. >> > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8013) SIGSEGV in test_filter()
by hyc＠symas.com 04 Jan '15

04 Jan '15

hyc(a)symas.com wrote: > Leonid Yuriev wrote: >> >> 04.01.2015 02:47, Howard Chu wrote: >>> The patch is wrong. syncprov_matchops can be called twice for the same >>> operation; toggling the flag where you've placed it means the filter >>> will be incorrect on the 2nd invocation as well as on all subsequent >>> invocations. >> >> Ok, but found another case. >> The ss->s_op->ors_filter may be updated immediately after the s_mutex >> released. > > Seems like the simpler fix then is to keep the mutex held until after > test_filter finishes. Fixed in master. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8013) SIGSEGV in test_filter()
by hyc＠symas.com 04 Jan '15

04 Jan '15

Leonid Yuriev wrote: > > 04.01.2015 02:47, Howard Chu wrote: >> The patch is wrong. syncprov_matchops can be called twice for the same >> operation; toggling the flag where you've placed it means the filter >> will be incorrect on the 2nd invocation as well as on all subsequent >> invocations. > > Ok, but found another case. > The ss->s_op->ors_filter may be updated immediately after the s_mutex > released. Seems like the simpler fix then is to keep the mutex held until after test_filter finishes. > > This is a simple change for reproducing the bug. > > diff --git a/servers/slapd/overlays/syncprov.c > b/servers/slapd/overlays/syncprov.c > index 5ef2eaa..f579faa 100644 > --- a/servers/slapd/overlays/syncprov.c > +++ b/servers/slapd/overlays/syncprov.c > @@ -1295,6 +1295,7 @@ syncprov_matchops( Operation *op, opcookie *opc, > int saveit ) > } > > if ( fc.fscope ) { > + Filter *paranoia; > ldap_pvt_thread_mutex_lock( &ss->s_mutex ); > op2 = *ss->s_op; > oh = *op->o_hdr; > @@ -1304,6 +1305,7 @@ syncprov_matchops( Operation *op, opcookie *opc, > int saveit ) > op2.o_hdr = &oh; > op2.o_extra = op->o_extra; > op2.o_callback = NULL; > + paranoia = ss->s_op->ors_filter; > if (ss->s_flags & PS_FIX_FILTER) { > /* Skip the AND/GE clause that we stuck on in front. We > would lose deletes/mods that happen during the refresh > @@ -1311,7 +1313,11 @@ syncprov_matchops( Operation *op, opcookie *opc, > int saveit ) > op2.ors_filter = ss->s_op->ors_filter->f_and->f_next; > } > ldap_pvt_thread_mutex_unlock( &ss->s_mutex ); > + assert (paranoia == ss->s_op->ors_filter || paranoia == > ss->s_op->ors_filter->f_and->f_next); > + usleep(1000); > + assert (paranoia == ss->s_op->ors_filter || paranoia == > ss->s_op->ors_filter->f_and->f_next); > rc = test_filter( &op2, e, op2.ors_filter ); > + assert (paranoia == ss->s_op->ors_filter || paranoia == > ss->s_op->ors_filter->f_and->f_next); > } > > Debug( LDAP_DEBUG_TRACE, "syncprov_matchops: sid %03x fscope > %d rc %d\n", > > Updated patch attached. > Please review and merge. > > Leonid. > > --- > > The attached files is derived from OpenLDAP Software. All of the > modifications > to OpenLDAP Software represented in the following patch(es) were > developed by > Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned > rights > and/or interest in this work to any party. I, Leonid Yuriev am > authorized by > Peter-Service LLC, my employer, to release this work under the following > terms. > > Peter-Service LLC hereby places the following modifications to OpenLDAP > Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose > with or without attribution and/or other notice. > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8014) minor memleak in slapadd
by hyc＠symas.com 04 Jan '15

04 Jan '15

leo(a)yuriev.ru wrote: > Full_Name: Leonid Yuriev > Version: 2.4-HEAD > OS: RHEL7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (31.130.36.33) > > > Minor memleak was found by valgrind tool. > Patch will be available shortly. Thanks for the report. Fixed in master. > > Leonid. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8013) SIGSEGV in test_filter()
by leo＠yuriev.ru 04 Jan '15

04 Jan '15

This is a multi-part message in MIME format. --------------070009030106040804000907 Content-Type: text/plain; charset=windows-1251; format=flowed Content-Transfer-Encoding: 7bit 04.01.2015 02:47, Howard Chu wrote: > The patch is wrong. syncprov_matchops can be called twice for the same > operation; toggling the flag where you've placed it means the filter > will be incorrect on the 2nd invocation as well as on all subsequent > invocations. Ok, but found another case. The ss->s_op->ors_filter may be updated immediately after the s_mutex released. This is a simple change for reproducing the bug. diff --git a/servers/slapd/overlays/syncprov.c b/servers/slapd/overlays/syncprov.c index 5ef2eaa..f579faa 100644 --- a/servers/slapd/overlays/syncprov.c +++ b/servers/slapd/overlays/syncprov.c @@ -1295,6 +1295,7 @@ syncprov_matchops( Operation *op, opcookie *opc, int saveit ) } if ( fc.fscope ) { + Filter *paranoia; ldap_pvt_thread_mutex_lock( &ss->s_mutex ); op2 = *ss->s_op; oh = *op->o_hdr; @@ -1304,6 +1305,7 @@ syncprov_matchops( Operation *op, opcookie *opc, int saveit ) op2.o_hdr = &oh; op2.o_extra = op->o_extra; op2.o_callback = NULL; + paranoia = ss->s_op->ors_filter; if (ss->s_flags & PS_FIX_FILTER) { /* Skip the AND/GE clause that we stuck on in front. We would lose deletes/mods that happen during the refresh @@ -1311,7 +1313,11 @@ syncprov_matchops( Operation *op, opcookie *opc, int saveit ) op2.ors_filter = ss->s_op->ors_filter->f_and->f_next; } ldap_pvt_thread_mutex_unlock( &ss->s_mutex ); + assert (paranoia == ss->s_op->ors_filter || paranoia == ss->s_op->ors_filter->f_and->f_next); + usleep(1000); + assert (paranoia == ss->s_op->ors_filter || paranoia == ss->s_op->ors_filter->f_and->f_next); rc = test_filter( &op2, e, op2.ors_filter ); + assert (paranoia == ss->s_op->ors_filter || paranoia == ss->s_op->ors_filter->f_and->f_next); } Debug( LDAP_DEBUG_TRACE, "syncprov_matchops: sid %03x fscope %d rc %d\n", Updated patch attached. Please review and merge. Leonid. --- The attached files is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the following patch(es) were developed by Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned rights and/or interest in this work to any party. I, Leonid Yuriev am authorized by Peter-Service LLC, my employer, to release this work under the following terms. Peter-Service LLC hereby places the following modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice. --------------070009030106040804000907 Content-Type: text/x-patch; name="its8013.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="its8013.patch" commit 5014e0b526e68c21bcfd9a9dd43d154d621f7476 Author: Leo Yuriev <leo(a)yuriev.ru> Date: 2015-01-01 16:44:50 +0300 ITS#8013 fix rare SIGSEGV in test_filter(). Filter may be updated/fixed and freed in other thread immediately after release the s_mutex, while the test_filter() running. Also now specifically damaged filter fields when it freed. This will enable faster detection of such errors (fail-fast by SIGSEGV). diff --git a/servers/slapd/filter.c b/servers/slapd/filter.c index b859f73..f440336 100644 --- a/servers/slapd/filter.c +++ b/servers/slapd/filter.c @@ -566,6 +566,8 @@ filter_free_x( Operation *op, Filter *f, int freeme ) break; } + f->f_next = (void*) -1l; + f->f_un.f_un_complex = (void*) -1l; if ( freeme ) { op->o_tmpfree( f, op->o_tmpmemctx ); } diff --git a/servers/slapd/overlays/syncprov.c b/servers/slapd/overlays/syncprov.c index 5ef2eaa..2369edb 100644 --- a/servers/slapd/overlays/syncprov.c +++ b/servers/slapd/overlays/syncprov.c @@ -1304,14 +1304,17 @@ syncprov_matchops( Operation *op, opcookie *opc, int saveit ) op2.o_hdr = &oh; op2.o_extra = op->o_extra; op2.o_callback = NULL; - if (ss->s_flags & PS_FIX_FILTER) { + if ( ss->s_flags & PS_FIX_FILTER ) { /* Skip the AND/GE clause that we stuck on in front. We would lose deletes/mods that happen during the refresh phase otherwise (ITS#6555) */ - op2.ors_filter = ss->s_op->ors_filter->f_and->f_next; + op2.ors_filter = filter_dup( op2.ors_filter->f_and->f_next, NULL ); + } else { + op2.ors_filter = filter_dup( op2.ors_filter, NULL ); } ldap_pvt_thread_mutex_unlock( &ss->s_mutex ); rc = test_filter( &op2, e, op2.ors_filter ); + filter_free( op2.ors_filter ); } Debug( LDAP_DEBUG_TRACE, "syncprov_matchops: sid %03x fscope %d rc %d\n", @@ -2237,6 +2240,7 @@ syncprov_detach_op( Operation *op, syncops *so, slap_overinst *on ) /* Skip the AND/GE clause that we stuck on in front */ if ( so->s_flags & PS_FIX_FILTER ) { + assert(op2->ors_filter->f_choice == LDAP_FILTER_AND); op2->ors_filter = op->ors_filter->f_and->f_next; so->s_flags ^= PS_FIX_FILTER; } else { @@ -2390,7 +2394,6 @@ syncprov_search_response( Operation *op, SlapReply *rs ) ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex ); /* syncprov_ab_cleanup will free this syncop */ return SLAPD_ABANDON; - } else { ldap_pvt_thread_mutex_lock( &ss->ss_so->s_mutex ); /* Turn off the refreshing flag */ --------------070009030106040804000907--

1 0

Re: (ITS#8013) SIGSEGV in test_filter()
by hyc＠symas.com 04 Jan '15

04 Jan '15

Leonid Yuriev wrote: > Please review attached patch and merge. The patch is wrong. syncprov_matchops can be called twice for the same operation; toggling the flag where you've placed it means the filter will be incorrect on the 2nd invocation as well as on all subsequent invocations. > > Leonid. > > --- > > The attached files is derived from OpenLDAP Software. All of the > modifications > to OpenLDAP Software represented in the following patch(es) were > developed by > Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned > rights > and/or interest in this work to any party. I, Leonid Yuriev am > authorized by > Peter-Service LLC, my employer, to release this work under the following > terms. > > Peter-Service LLC hereby places the following modifications to OpenLDAP > Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose > with or without attribution and/or other notice. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs