https://bugs.openldap.org/show_bug.cgi?id=9045
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|bugs(a)openldap.org |hyc(a)openldap.org
Target Milestone|2.5.1 |2.5.3
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8900
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|bugs(a)openldap.org |quanah(a)openldap.org
Target Milestone|2.5.1 |2.5.3
--- Comment #2 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
Quanah to see if this still occurs with current 2.5 tree. If so, create
reproduction case.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8852
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.5.1 |2.6.0
Keywords|OL_2_5_REQ |
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8757
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |enhancement
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8736
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.5.1 |2.5.3
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8673
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.5.1 |2.5.3
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8649
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|2.5.1 |2.6.0
Keywords|OL_2_5_REQ |
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7766
--- Comment #10 from OndÅ™ej KuznÃk <ondra(a)mistotebe.net> ---
syncrepl_diff_entry() doesn't work if either entry has extra attributes at the
end, which are ignored when we stop once the "while ( old && new )" check
fails. Those do not make it into the diff.
In the above case, some operational attributes are modified (at least entryCSN
will) so they're moved to the end so the ppolicy parameters are picked up the
second time.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7468
Howard Chu <hyc(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |TEST
Status|UNCONFIRMED |RESOLVED
--- Comment #3 from Howard Chu <hyc(a)openldap.org> ---
fixed in master
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7468
Howard Chu <hyc(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.openldap.org/s
| |how_bug.cgi?id=9220
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7439
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Keywords|OL_2_5_REQ, replication |
Status|UNCONFIRMED |RESOLVED
--- Comment #6 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
trunk/RE25:
• 58dfef01
by OndÅ™ej KuznÃk at 2021-01-20T11:39:17+00:00
ITS#7439 Do not free parts of original filter
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=5941
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Keywords|OL_2_5_REQ |
Resolution|--- |FIXED
--- Comment #13 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
trunk/RE25:
• fc1bcaf9
by OndÅ™ej KuznÃk at 2021-01-18T14:36:16+00:00
ITS#5941 manage callbacks to coexist with other overlays
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=8307
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|OL_2_5_REQ |
Resolution|TEST |FIXED
--- Comment #11 from Quanah Gibson-Mount <quanah(a)openldap.org> ---
RE25:
commit eefe12366c5c6de25a9a7067000b443d76043725
Author: Howard Chu <hyc(a)openldap.org>
Date: Wed Jan 13 16:35:43 2021 +0000
ITS#8307 fix slapo-accesslog: noop if logDB isn't open yet
Add be_flag for DB OPEN status
commit 85b68aa5e221397081249fe5efe7330a6d738ecf
Author: Howard Chu <hyc(a)openldap.org>
Date: Wed Jan 13 16:39:24 2021 +0000
ITS#8307 slapo-dds: mark internal searches as do_not_cache
commit 9d440e3d2829258b803a2e663343c05341945446
Author: Howard Chu <hyc(a)openldap.org>
Date: Wed Jan 13 16:58:42 2021 +0000
ITS#8307 slapo-accesslog additional check
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9435
Issue ID: 9435
Summary: LDAP Servers locked up and unresponsive
Product: OpenLDAP
Version: 2.4.56
Hardware: x86_64
OS: Linux
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: slapd
Assignee: bugs(a)openldap.org
Reporter: tsujik(a)sekisui.com
Target Milestone: ---
Setup:
I have six OpenLDAP servers running, replicating in mirrormode and using
slapd-perl.
Problem:
On rare occasions servers will lock up and be unresponsive.
Workaround:
Restart the slapd process will resolve this problem.
Observations:
- Checking with gdb, lock occurs when binding.
- I don't know how to reproduce this reliably and how to fix.
slapd.conf setting (excerpt):
...
database perl
suffix "secret"
perlModulePath secret
perlModule secret
perlModuleConfig logfile secret
...
overlay syncprov
serverID 1
syncrepl rid=001
...
mirrormode on
GDB:
(gdb) bt
#0 0x00007f6a3ed9370a in pthread_join () from /lib64/libpthread.so.0
#1 0x00000000005c7ce2 in ldap_pvt_thread_join ()
#2 0x000000000045f7aa in slapd_daemon ()
#3 0x000000000043cc45 in main ()
(gdb) thread apply all bt
Thread 17 (Thread 0x7f69fb7eb700 (LWP 945)):
#0 0x00007f6a3ed9b2ad in __lll_lock_wait () from /lib64/libpthread.so.0
#1 0x00007f6a3ed94bfd in pthread_mutex_lock () from /lib64/libpthread.so.0
#2 0x00000000005c7df4 in ldap_pvt_thread_mutex_lock ()
#3 0x00000000005a1ef5 in perl_back_bind ()
#4 0x000000000048b367 in fe_op_bind ()
#5 0x000000000048aa25 in do_bind ()
#6 0x000000000046295b in ?? ()
#7 0x0000000000462ef7 in ?? ()
#8 0x00000000005c684d in ?? ()
#9 0x00007f6a3ed9240b in start_thread () from /lib64/libpthread.so.0
#10 0x00007f6a3d443e7f in clone () from /lib64/libc.so.6
Please let me know if you have any other information you need.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9441
Issue ID: 9441
Summary: make error on centos8
Product: OpenLDAP
Version: 2.4.57
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: build
Assignee: bugs(a)openldap.org
Reporter: tchatz(a)arx.gr
Target Milestone: ---
I tried to compile openldap on centos8
using ./configure --with-cyrus-sasl --enable-crypt --enable-slapd
--enable-perl
and I got a an error in make which I dont understand. I present when the funny
messages start appearing and a couple of lines before(just in case they help)
cc -g -O2 -o slapd main.o globals.o bconfig.o config.o daemon.o connection.o
search.o filter.o add.o cr.o attr.o entry.o backend.o backends.o result.o
operation.o dn.o compare.o modify.o delete.o modrdn.o ch_malloc.o value.o ava.o
bind.o unbind.o abandon.o filterentry.o phonetic.o acl.o str2filter.o
aclparse.o init.o user.o lock.o controls.o extended.o passwd.o schema.o
schema_check.o schema_init.o schema_prep.o schemaparse.o ad.o at.o mr.o
syntax.o oc.o saslauthz.o oidm.o starttls.o index.o sets.o referral.o
root_dse.o sasl.o module.o mra.o mods.o sl_malloc.o zn_malloc.o limits.o
operational.o matchedValues.o cancel.o syncrepl.o backglue.o backover.o
ctxcsn.o ldapsync.o frontend.o slapadd.o slapcat.o slapcommon.o slapdn.o
slapindex.o slappasswd.o slaptest.o slapauth.o slapacl.o component.o aci.o
alock.o txn.o slapschema.o version.o -Wl,--enable-new-dtags -Wl,-z -Wl,relro
-Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-z -Wl,relro
-Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
-fstack-protector-strong -pthread libbackends.a liboverlays.a
../../libraries/liblunicode/liblunicode.a
../../libraries/librewrite/librewrite.a ../../libraries/liblutil/liblutil.a
../../libraries/libldap_r/.libs/libldap_r.a
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a
../../libraries/liblber/.libs/liblber.a -ldb-5.3 -L/usr/local/lib
-L/usr/lib64/perl5/CORE -lperl -lpthread -ldl -lm -lutil -lsasl2 -lcrypt
-lresolv -pthread
daemon.o: In function `slap_listener':
/usr/local/src/openldap-2.4.57/servers/slapd/daemon.c:1934: warning:
`sys_errlist' is deprecated; use `strerror' or `strerror_r' instead
/usr/local/src/openldap-2.4.57/servers/slapd/daemon.c:1934: warning: `sys_nerr'
is deprecated; use `strerror' or `strerror_r' instead
/usr/bin/ld: main.o: relocation R_X86_64_32 against `.rodata.str1.8' can not be
used when making a PIE object; recompile with -fPIC
/usr/bin/ld: bconfig.o: relocation R_X86_64_32 against `.rodata' can not be
used when making a PIE object; recompile with -fPIC
lots of same messages for various *.o and *.a files
.......................................
........................................
......................................
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(decode.o):
relocation R_X86_64_32 against `.rodata' can not be used when making a PIE
object; recompile with -fPIC
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(encode.o):
relocation R_X86_64_32 against `.rodata' can not be used when making a PIE
object; recompile with -fPIC
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(io.o):
relocation R_X86_64_32 against `.rodata' can not be used when making a PIE
object; recompile with -fPIC
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(bprint.o):
relocation R_X86_64_32 against `.rodata' can not be used when making a PIE
object; recompile with -fPIC
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(debug.o):
relocation R_X86_64_32 against `.rodata.str1.1' can not be used when making a
PIE object; recompile with -fPIC
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(memory.o):
relocation R_X86_64_32 against `.rodata' can not be used when making a PIE
object; recompile with -fPIC
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(options.o):
relocation R_X86_64_32S against `.rodata' can not be used when making a PIE
object; recompile with -fPIC
/usr/bin/ld:
/usr/local/src/openldap-2.4.57/libraries/liblber/.libs/liblber.a(sockbuf.o):
relocation R_X86_64_32 against `.rodata.str1.8' can not be used when making a
PIE object; recompile with -fPIC
/usr/bin/ld: final link failed: Nonrepresentable section on output
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:518: slapd] Error 1
make[2]: Leaving directory '/usr/local/src/openldap-2.4.57/servers/slapd'
make[1]: *** [Makefile:291: all-common] Error 1
make[1]: Leaving directory '/usr/local/src/openldap-2.4.57/servers'
make: *** [Makefile:312: all-common] Error 1
O dont understand what "ld: final link failed: Nonrepresentable section on
output" means and if this is the error at all to be honest.
Any help would be much appreciated as I dont have any idea how to continue
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7468
--- Comment #2 from OndÅ™ej KuznÃk <ondra(a)mistotebe.net> ---
I have been able to reproduce this in master with the following config (no rwm
involved):
database relay
suffix "ou=People,dc=example,dc=com"
relay "dc=example,dc=com"
database mdb
suffix "dc=example,dc=com"
rootdn "dc=example,dc=com"
rootpw OBFUSCATED
directory ./db3
overlay ppolicy
ppolicy_default "cn=default,dc=example,dc=com"
ppolicy_use_lockout
ppolicy_hash_cleartext
back-mdb hits a null pointer:
0x0000000000535161 in mdb_env_pick_meta (env=0x78f420) at
./../../../libraries/liblmdb/mdb.c:3944
3944 return metas[ metas[0]->mm_txnid < metas[1]->mm_txnid ];
(gdb) bt
#0 0x0000000000535161 in mdb_env_pick_meta (env=0x78f420) at
./../../../libraries/liblmdb/mdb.c:3944
#1 0x000000000052feae in mdb_txn_renew0 (txn=0x7fffb6cef010) at
./../../../libraries/liblmdb/mdb.c:2688
#2 0x0000000000530914 in mdb_txn_begin (env=0x78f420, parent=0x0,
flags=131072, ret=0x7fffe8004290) at ./../../../libraries/liblmdb/mdb.c:2910
#3 0x00000000005afe53 in mdb_opinfo_get (op=Bind request = {...},
mdb=0x78f1b0, rdonly=1, moip=0x7ffff61cad68) at id2entry.c:778
#4 0x00000000005af5d6 in mdb_entry_get (op=Bind request = {...},
ndn=0x7fffe8002bf8, oc=NULL, at=NULL, rw=0, ent=0x7ffff61cb388) at
id2entry.c:607
#5 0x00000000004fd377 in overlay_entry_get_ov (op=Bind request = {...},
dn=0x7fffe8002bf8, oc=NULL, ad=NULL, rw=0, e=0x7ffff61cb388, on=0x0)
at backover.c:378
#6 0x00000000004ffd36 in over_entry_get_rw (op=Bind request = {...},
dn=0x7fffe8002bf8, oc=NULL, ad=NULL, rw=0, e=0x7ffff61cb388) at backover.c:412
#7 0x0000000000466d6b in be_entry_get_rw (op=Bind request = {...},
ndn=0x7fffe8002bf8, oc=NULL, at=NULL, rw=0, e=0x7ffff61cb388) at backend.c:1443
#8 0x00007ffff791d0e3 in ppolicy_bind_response (op=Bind request = {...},
rs=0x7ffff61cb9f8) at ppolicy.c:1424
#9 0x000000000046d8d6 in slap_response_play (op=Bind request = {...},
rs=0x7ffff61cb9f8) at result.c:567
#10 0x000000000046948d in send_ldap_response (op=Bind request = {...},
rs=0x7ffff61cb9f8) at result.c:642
#11 0x000000000046a33e in slap_send_ldap_result (op=Bind request = {...},
rs=0x7ffff61cb9f8) at result.c:918
#12 0x000000000047f666 in fe_op_bind_success (op=Bind request = {...},
rs=0x7ffff61cb9f8) at bind.c:552
#13 0x000000000047f26c in fe_op_bind (op=Bind request = {...},
rs=0x7ffff61cb9f8) at bind.c:386
#14 0x000000000047e8ab in do_bind (op=Bind request = {...}, rs=0x7ffff61cb9f8)
at bind.c:206
#15 0x00000000004528b7 in connection_operation (ctx=0x7ffff61cbb78,
arg_v=0x7fffe8002bb0) at connection.c:1163
#16 0x0000000000450a90 in connection_read_thread (ctx=0x7ffff61cbb78, argv=0xc)
at connection.c:1314
#17 0x00007ffff7fb01fe in ldap_int_thread_pool_wrapper (xpool=0x7266c0) at
tpool.c:1051
(gdb) p metas[0]
$1 = (MDB_meta * const) 0x0
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7439
--- Comment #5 from OndÅ™ej KuznÃk <ondra(a)mistotebe.net> ---
(In reply to Howard Chu from comment #4)
> Right, rwm should probably stash the incoming filter and restore it on
> return.
The overlay seems quite confused in what it wants to do, parts of it want to
maintain the original filter as is (rwm_callback_get, rwm_op_rollback) while
parts are very intrusive (rwm_int_filter_map_rewrite).
I'll see if I can change how rwm_int_filter_map_rewrite mangles the op/its
filter.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7439
--- Comment #4 from Howard Chu <hyc(a)openldap.org> ---
(In reply to OndÅ™ej KuznÃk from comment #3)
> Managed to repro with -DSLAP_NO_SL_MALLOC:
> Don't know if rwm should stop freeing parts of provided filters or syncrepl
> should allocate the avas. Probably the former...
Right, rwm should probably stash the incoming filter and restore it on return.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=7439
--- Comment #3 from OndÅ™ej KuznÃk <ondra(a)mistotebe.net> ---
Managed to repro with -DSLAP_NO_SL_MALLOC:
==317060== Thread 3:
==317060== Invalid free() / delete / delete[] / realloc()
==317060== at 0x48399AB: free (vg_replace_malloc.c:538)
==317060== by 0x48CAC24: ber_memfree_x (memory.c:152)
==317060== by 0x4E0CFC: slap_sl_free (sl_malloc.c:499)
==317060== by 0x4830D6: ava_free (ava.c:50)
==317060== by 0x459DB4: filter_free_x (filter.c:554)
==317060== by 0x52F9F92: rwm_int_filter_map_rewrite (rwmmap.c:772)
==317060== by 0x52F8AAF: rwm_filter_map_rewrite (rwmmap.c:824)
==317060== by 0x52EF17D: rwm_op_search (rwm.c:976)
==317060== by 0x508D20: overlay_op_walk (backover.c:691)
==317060== by 0x50BE40: over_op_func (backover.c:766)
==317060== by 0x50B031: over_op_search (backover.c:796)
==317060== by 0x5085B3: glue_sub_search (backglue.c:377)
==317060== by 0x505407: glue_op_search (backglue.c:534)
==317060== by 0x508D20: overlay_op_walk (backover.c:691)
==317060== by 0x50BE40: over_op_func (backover.c:766)
==317060== by 0x50B031: over_op_search (backover.c:796)
==317060== by 0x4FD3D9: syncrepl_entry (syncrepl.c:4007)
==317060== by 0x4F79C6: do_syncrep2 (syncrepl.c:1475)
==317060== by 0x4EF8D4: do_syncrepl (syncrepl.c:2067)
==317060== by 0x48A51FD: ldap_int_thread_pool_wrapper (tpool.c:1051)
==317060== Address 0x5bef807 is 7 bytes inside a block of size 24 alloc'd
==317060== at 0x483877F: malloc (vg_replace_malloc.c:307)
==317060== by 0x48CAD9C: ber_memalloc_x (memory.c:228)
==317060== by 0x48C4205: ber_get_stringbv (decode.c:519)
==317060== by 0x48C53FB: ber_scanf (decode.c:827)
==317060== by 0x4861B97: ldap_pvt_get_controls (controls.c:238)
==317060== by 0x4877E4F: ldap_get_entry_controls (getentry.c:106)
==317060== by 0x4F6A4A: do_syncrep2 (syncrepl.c:1284)
==317060== by 0x4EF8D4: do_syncrepl (syncrepl.c:2067)
==317060== by 0x48A51FD: ldap_int_thread_pool_wrapper (tpool.c:1051)
==317060== by 0x4CCEEA6: start_thread (pthread_create.c:477)
==317060== by 0x4DE5DEE: clone (clone.S:95)
Don't know if rwm should stop freeing parts of provided filters or syncrepl
should allocate the avas. Probably the former...
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9427
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
Group|OpenLDAP-devs |
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9425
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|OpenLDAP-devs |
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9424
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Group|OpenLDAP-devs |
Status|RESOLVED |VERIFIED
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9423
Quanah Gibson-Mount <quanah(a)openldap.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
Group|OpenLDAP-devs |
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9420
Issue ID: 9420
Summary: memory leak & ub in
servers/slapd/modrdn.c`slap_modrdn2mods()
Product: OpenLDAP
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: slapd
Assignee: bugs(a)openldap.org
Reporter: grapvar(a)gmail.com
Target Milestone: ---
Created attachment 781
--> https://bugs.openldap.org/attachment.cgi?id=781&action=edit
fix
Hi. I have noticed
1) a memory leak in failure cleanup section of slap_modrdn2mods():
| for ( ; op->orr_modlist != NULL; op->orr_modlist = tmp ) {
| tmp = op->orr_modlist->sml_next;
| ch_free( op->orr_modlist );
| }
this code leaks (n)values of mods. And
2) undefined behavior while scheduling delete:
| (void) (*desc->ad_type->sat_equality->smr_normalize)(...,
&mod_tmp->sml_nvalues[0], ...)
this code doesn't respect normalization failures, and may leave garbage in
nvalues[0].
I guess this is because somebody assumed normalization can't fail here, because
the value has already been normalized during dnPrettyNormal. But ...
normalization can fail at least because some normalizators do not abort() on
memory allocation failures.
Here is a patch that fixes these defects. Please, consider.
--
You are receiving this mail because:
You are on the CC list for the issue.
https://bugs.openldap.org/show_bug.cgi?id=9417
Issue ID: 9417
Summary: ldapexop: exit with indeterminate status
Product: OpenLDAP
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: ---
Component: client tools
Assignee: bugs(a)openldap.org
Reporter: danix800(a)gmail.com
Target Milestone: ---
In clients/tools/ldapexop.c:354 'main' calls 'tool_exit' with testing result of
'code' to 'LDAP_SUCCESS' as argument, but clang static analyzer finds that at
line 103 if 'ldap_whoami' fails then 'main' should exit, leaving 'code'
uninitialized, the test result is indeterminate. After further inspection I can
conclude that 'rc' is set all the way down so I think 'tool_exit' should be
called with 'rc' directly.
See MR!207 for potential fix for this.
--
You are receiving this mail because:
You are on the CC list for the issue.