openldap-bugs

openldap-bugs@openldap.org

1 participants
21001 discussions

Re: (ITS#8021) Wrong mdb_env_sync() with at least MDB_RDONLY
by hyc＠symas.com 08 Jan '15

08 Jan '15

h.b.furuseth(a)usit.uio.no wrote: > Full_Name: Hallvard B Furuseth > Version: lmdb 0.9.14 > OS: > URL: > Submission from: (NULL) (81.191.45.22) > Submitted by: hallvard > > > mdb_env_sync() works with MDB_RDONLY at least on Unix, but > it syncs MDB_WRITEMAP changes incorrectly: fdatasync instead > of msync because mdb_env_open() cleared MDB_WRITEMAP. > > Users are likely doing the same thing anyway: Using MDB_RDONLY > instead of MDB_RDONLY|MDB_WRITEMAP on WRITEMAP-written DBs. mdb_env_sync() shouldn't even be doing any work at all if the env was opened RDONLY. We should return nop in that case. RDONLY means RDONLY! No writes, no calls that will alter the storage layer. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8021) Wrong mdb_env_sync() with at least MDB_RDONLY
by h.b.furuseth＠usit.uio.no 08 Jan '15

08 Jan '15

Full_Name: Hallvard B Furuseth Version: lmdb 0.9.14 OS: URL: Submission from: (NULL) (81.191.45.22) Submitted by: hallvard mdb_env_sync() works with MDB_RDONLY at least on Unix, but it syncs MDB_WRITEMAP changes incorrectly: fdatasync instead of msync because mdb_env_open() cleared MDB_WRITEMAP. Users are likely doing the same thing anyway: Using MDB_RDONLY instead of MDB_RDONLY|MDB_WRITEMAP on WRITEMAP-written DBs. Finally, writers committing with and without WRITEMAP will sync each others' commits incorrectly. lmdb.h does warn they will "not cooperate well", but it should warn it breaks ACID. LMDBv2 can instead fix all this with 2 bits in MDB_meta: "Changed with/without WRITEMAP since last sync". In LMDBv1, I think the smallest-impact fix is for env_sync to both msync and fdatasync when RDONLY is set and WRITEMAP is clear. A greedier fix would be to always sync both ways when the user calls env_sync. Either way, it may be best to keep WRITEMAP when RDONLY. Only env_map() needs to deal with that. Pushing suggestions except doc to "mdb/wmap-fix" in my repo.

1 0

(ITS#8020) 64bit indexer broken
by hyc＠openldap.org 07 Jan '15

07 Jan '15

Full_Name: Howard Chu Version: 2.4 OS: URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (78.155.233.73) Submitted by: hyc Only 32 bits of the hash were being used. patch coming shortly

1 0

Re: (ITS#8019) LDAP Replication By attribute
by quanah＠zimbra.com 07 Jan '15

07 Jan '15

--On Wednesday, January 07, 2015 4:19 PM +0000 sofiene.blouza(a)etiam.com wrote: > Full_Name: SOFIENE BLOUZA > Version: 2.4.23-34.el6_5.1 > OS: Centos 6.6 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (217.109.110.145) The ITS system is for reporting bugs, not for usage questions. Usage questions belong on the openldap-technical(a)openldap.org list. I would note that the version you reference is extremely old, and it would be advised as your first step to upgrade to a current OpenLDAP release. --Quanah -- Quanah Gibson-Mount Platform Architect Zimbra, Inc. -------------------- Zimbra :: the leader in open source messaging and collaboration

1 0

(ITS#8019) LDAP Replication By attribute
by sofiene.blouza＠etiam.com 07 Jan '15

07 Jan '15

Full_Name: SOFIENE BLOUZA Version: 2.4.23-34.el6_5.1 OS: Centos 6.6 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (217.109.110.145) Hello, I want to make replication betweend two ldap servers using Delta-syncrepl. I use the tuto http://www.openldap.org/doc/admin24/replication.html#Delta-syncrepl on section 18.3.2. I make the configuration but it doesnt work correctly. How can I fix the problem! Thunks a lot

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by hyc＠symas.com 06 Jan '15

06 Jan '15

Leonid Yuriev wrote: > Yes of course, all warnings could be hushed by compiler options, but > this also hides the real mistakes. > So, I prefer fix the warnings, instead of disable gcc/clang features. > > Please review attached patchset and merge. Your patch assumes CPP features that are not guaranteed to be present. Rejecting this patchset. Learn more about how OpenLDAP software is built and why. > > Leonid. > > --- > > The attached files is derived from OpenLDAP Software. All of the > modifications > to OpenLDAP Software represented in the following patch(es) were > developed by > Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned > rights > and/or interest in this work to any party. I, Leonid Yuriev am > authorized by > Peter-Service LLC, my employer, to release this work under the following > terms. > > Peter-Service LLC hereby places the following modifications to OpenLDAP > Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose > with or without attribution and/or other notice > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by leo＠yuriev.ru 06 Jan '15

06 Jan '15

--e89a8f8389d152e760050bfd4ba8 Content-Type: text/plain; charset=UTF-8 Fast-forward 'pull' is also available https://github.com/leo-yuriev/openldap-lmdb-challenge.git Leonid. 2015-01-06 18:10 GMT+03:00 Leonid Yuriev <leo(a)yuriev.ru>: > Yes of course, all warnings could be hushed by compiler options, but this > also hides the real mistakes. > So, I prefer fix the warnings, instead of disable gcc/clang features. > > Please review attached patchset and merge. > > Leonid. > > --- > > The attached files is derived from OpenLDAP Software. All of the > modifications > to OpenLDAP Software represented in the following patch(es) were developed > by > Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned > rights > and/or interest in this work to any party. I, Leonid Yuriev am authorized > by > Peter-Service LLC, my employer, to release this work under the following > terms. > > Peter-Service LLC hereby places the following modifications to OpenLDAP > Software > (and only these modifications) into the public domain. Hence, these > modifications may be freely used and/or redistributed for any purpose > with or without attribution and/or other notice > > > --e89a8f8389d152e760050bfd4ba8 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div><div>Fast-forward 'pull' is also available</d= iv><div><a href=3D"https://github.com/leo-yuriev/openldap-lmdb-challenge.gi= t">https://github.com/leo-yuriev/openldap-lmdb-challenge.git</a><br><br>Leo= nid.</div></div></div><div class=3D"gmail_extra"><br><div class=3D"gmail_qu= ote">2015-01-06 18:10 GMT+03:00 Leonid Yuriev <span dir=3D"ltr"><<a href= =3D"mailto:leo@yuriev.ru" target=3D"_blank">leo(a)yuriev.ru</a>></span>:<b= r><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:= 1px #ccc solid;padding-left:1ex">Yes of course, all warnings could be hushe= d by compiler options, but this also hides the real mistakes.<br> So, I prefer fix the warnings, instead of disable gcc/clang features.<br> <br> Please review attached patchset and merge.<br> <br> Leonid.<br> <br> ---<br> <br> The attached files is derived from OpenLDAP Software. All of the modificati= ons<br> to OpenLDAP Software represented in the following patch(es) were developed = by<br> Peter-Service LLC, Moscow, Russia. Peter-Service LLC has not assigned right= s<br> and/or interest in this work to any party. I, Leonid Yuriev am authorized b= y<br> Peter-Service LLC, my employer, to release this work under the following te= rms.<br> <br> Peter-Service LLC hereby places the following modifications to OpenLDAP Sof= tware<br> (and only these modifications) into the public domain. Hence, these<br> modifications may be freely used and/or redistributed for any purpose<br> with or without attribution and/or other notice<br> <br> <br> </blockquote></div><br></div> --e89a8f8389d152e760050bfd4ba8--

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by hyc＠symas.com 06 Jan '15

06 Jan '15

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by hyc＠symas.com 06 Jan '15

06 Jan '15

leo(a)yuriev.ru wrote: > Full_Name: Leonid Yuriev > Version: git-master > OS: RHEL7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (31.130.36.33) > > > It is about 5K warnings reported by gcc/clang if building OpenLDAP with -Wall. > > CFLAGS="-Wall" ./configure ... > make depend && make > > The vast majority of warnings about harmless things: unnecessary arguments to > printf through Debug macro, Ignore those. Use -Wno-format-extra-args > unused variables and functions, etc. > But such amount of warnings makes impossible to use -Wall to find a potential > problems. > > I have prepared the patchset which fixes most of these warnings. > It will be submited shortly. > > Leonid. > > -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8018) a lot of warnings building with -Wall
by pierangelo.masarati＠polimi.it 06 Jan '15

06 Jan '15

On 06/01/2015 15:47, leo(a)yuriev.ru wrote: > Full_Name: Leonid Yuriev > Version: git-master > OS: RHEL7 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (31.130.36.33) > > > It is about 5K warnings reported by gcc/clang if building OpenLDAP with -Wall. > > CFLAGS="-Wall" ./configure ... > make depend && make > > The vast majority of warnings about harmless things: unnecessary arguments to > printf through Debug macro, unused variables and functions, etc. > But such amount of warnings makes impossible to use -Wall to find a potential > problems. > > I have prepared the patchset which fixes most of these warnings. > It will be submited shortly. My 2c: - normal users do not need to build with -Wall; only developers might need to - in addition to -Wall, if you add -Wno-[specific harmless warnings you want to disable], then only relevant ones do surface. p. -- Pierangelo Masarati Associate Professor Dipartimento di Scienze e Tecnologie Aerospaziali Politecnico di Milano

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs