openldap-bugs

openldap-bugs@openldap.org

1 participants
20967 discussions

(ITS#8059) In client code, set option LDAP_OPT_DEBUG_LEVEL LDAP_DEBUG_ANY does not set option.
by peter.driscoll＠dionglobal.com 16 Feb '15

16 Feb '15

Full_Name: Peter John Driscoll Version: openldap-2.4.40 OS: Linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (203.3.133.17) Set this option does not turn on debugging. #define LDAP_DEBUG_ANY 0xffff const int optionValue = LDAP_DEBUG_ANY; CHECK_RESULT(ldap_set_option(m_ld, LDAP_OPT_DEBUG_LEVEL, &optionValue), "ldap_set_option debug level"); Calling ldap_get_option confirms the change. But in libraries/libldap/sbind.c int ldap_simple_bind_s( LDAP *ld, LDAP_CONST char *dn, LDAP_CONST char *passwd ) The call, Debug( LDAP_DEBUG_TRACE, "ldap_simple_bind_s\n", 0, 0, 0 ); Does not log any debug information, because ldap_debug does not returns 0 instead of 0xFFFF. Debug is defined, #define Debug( level, fmt, arg1, arg2, arg3 ) \ Log3( (level), 0, (fmt), (arg1), (arg2), (arg3) ) #define Log3( level, severity, fmt, arg1, arg2, arg3 ) \ do { \ if ( ldap_debug & (level) ) \ lutil_debug( ldap_debug, (level), (fmt), (arg1), (arg2), (arg3) ); \ } while ( 0 ) #define ldap_debug ((LDAP_INT_GLOBAL_OPT())->ldo_debug) The option is set in, libraries/libldap/options.c int ldap_set_option( LDAP *ld, int option, LDAP_CONST void *invalue) starts with lo = LDAP_INT_GLOBAL_OPT(); but a few lines down, if(ld != NULL) { assert( LDAP_VALID( ld ) ); if( !LDAP_VALID( ld ) ) { return LDAP_OPT_ERROR; } lo = &ld->ld_options; } This code breaks the logic so that the option is not set in the right place. So later in the method, case LDAP_OPT_DEBUG_LEVEL: lo->ldo_debug = * (const int *) invalue; rc = LDAP_OPT_SUCCESS; break; is writing to the wrong place, because lo != LDAP_INT_GLOBAL_OPT() FYI my methods, doing the calling is, void NovaLdap::Connect() { NovaString ldaps = "ldap://"; if (m_SSL) { ldaps = "ldaps://"; } NovaString server = ldaps + m_IpAddress + ":" + ToNovaString(m_IpPort); JOURNAL(SECURITYSERVER,DTL) << "Security Server : Connect " << server << endl; #ifdef _WIN32 m_ld = ldap_sslinit((LDAP_PCHAR) m_IpAddress.data(), m_IpPort, m_SSL); #else CHECK_RESULT(ldap_initialize(&m_ld, server), "ldap_initialize(\2"22 + server + "\")"); #endif JOURNAL(SECURITYSERVER,DTL) << "Security Server : Connected - OK " << endl; if (!m_ld) { JOURNAL(SECURITYSERVER,DTL) << "Security Server : Connect - NULL LD " << endl;D0D throw NovaError(ISSFactory::Error_LDAP_INIT_NULL); } JOURNAL(SECURITYSERVER,DTL) << "Security Server : Connect - set option" << endl; int myVersion =LDAP_VERSION3; CHECK_RESULT(ldap_set_option(m_ld, LDAP_OPT_PROTOCOL_VERSION, &myVersion), "ldap_set_option version"); //CHECK_RESULT(ldap_set_option(m_ld, LDAP_OPT_TLS, &reqcert), "ldap_set_option TLS requires certificate"); #ifdef LDAP_OPT_DEBUG_LEVEL const int optionValue = LDAP_DEBUG_ANY; CHECK_RESULT(ldap_set_option(m_ld, LDAP_OPT_DEBUG_LEVEL, &optionValue), "ldap_set_option debug level"); int optionValueReturned = 0; CHECK_RESULT(ldap_get_option(m_ld, LDAP_OPT_DEBUG_LEVEL, &optionValueReturned), "ldap_set_option debug level"); JOURNAL(SECURITYSERVER,DTL) << "Security Server : Set debug level: " << optionValueReturned << endl; #endif #ifdef LDAP_OPT_CONNECT_ASYNC ldap_set_option( m_ld, LDAP_OPT_CONNECT_ASYNC, LDAP_OPT_OFF ); #endif ldap_set_option(m_ld, LDAP_OPT_REFERRALS, LDAP_OPT_OFF ); ldap_set_option(m_ld, LDAP_OPT_RESTART, LDAP_OPT_ON ); JOURNAL(SECURITYSERVER,DTL) << "Security Server : Connect - OK " << endl; #ifdef _WIN32 CHECK_RESULT(ldap_connect(m_ld, NULL), "ldap_connect"); #endif if (m_StartTLS) { JOURNAL(SECURITYSERVER,DTL) << "Security Server : Connect - Start TLS" << endl; #ifdef _WIN32 CHECK_RESULT(ldap_start_tls_s(m_ld, NULL, NULL, NULL, NULL), "ldap_start_tls_s"); // WINLDAPAPI ULONG LDAPAPI ldap_start_tls_sA ( // IN PLDAP ExternalHandle, // OUT PULONG ServerReturnValue, // OUT LDAPMessage **result, // IN PLDAPControlA *ServerControls, // IN PLDAPControlA *ClientControls // ); #else CHECK_RESULT(ldap_start_tls(m_ld, NULL, NULL, NULL), "ldap_start_tls_s"); #endif } } void NovaLdap::CheckConnection() { JOURNAL(SECURITYSERVER,DTL) << "NovaLdap::CheckConnection: Checking connection" << endl; Connect(); // See if can bind to the DN. if (!m_ServiceAccountUsername.isNull()) { JOURNAL(SECURITYSERVER,DTL) << "Security Server : GetDistinguishedNameForUserName Service service login " << m_ServiceAccountUsername << endl; puts("Security Server : GetDistinguishedNameForUserName Service service login\n"); LDAP_RESULT result = ldap_simple_bind_s(m_ld, (LDAP_PCHAR) m_ServiceAccountUsername.data(), (LDAP_PCHAR) m_ServiceAccountPassword.data()); if (result != (LDAP_RESULT) LDAP_SUCCESS) { NovaString errorMessage(ldap_err2string(result)); throw NovaError(ISSFactory::Error_LDAP_FAILURE, "bind as service user: ", errorMessage); char sevLevel; } ldap_unbind(m_ld); } JOURNAL(SECURITYSERVER,DTL) << "NovaLdap::ececkConnection: Success" << endl; }

1 0

Re: (ITS#8058) OpenLDAP: module autogroup (memberof)
by michael＠stroeder.com 15 Feb '15

15 Feb '15

tobias.helfenstein(a)wald-rlp.de wrote: > Version: 2.4.39 > > we have problems when activating the module autogroup (memberof). There were several fixes after 2.4.39. Could you please try RE24 branch from git repo? Ciao, Michael.

1 0

(ITS#8058) OpenLDAP: module autogroup (memberof)
by tobias.helfenstein＠wald-rlp.de 15 Feb '15

15 Feb '15

Full_Name: Tobias Helfenstein Version: 2.4.39 OS: CentOS 7.0 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (87.165.195.65) Hello, we have problems when activating the module autogroup (memberof). We configured the module like the described way in the README file. If we add a new entry to the LDAP tree, the entry is added to the desired group automatically. This is the expected behavior. We can add entries as much as possible and there is no problem. Now, if we delete one of the entries the slapd is very slow and hangs. The action have to be aborted to continue, there is no debug output. Because of that we have to restart the slapd daemon. But the restart takes a long time (3+ minutes). After the restart we can delete only one entry, then the described problem occurs again. We think it is a bug an hope you can help us. Thank you

1 0

(ITS#8057) slapo-unique can be bypassed by anyone
by ondra＠mistotebe.net 14 Feb '15

14 Feb '15

Full_Name: Ondrej Kuznik Version: master OS: URL: ftp://ftp.openldap.org/pub/Ondrej-Kuznik-20150214-ITS-8057-uniqueness-ACL.p… Submission from: (NULL) (86.177.93.243) This is caused by my fix for #6641. Since anyone can specify the manageDSAit control on an operation it is trivial to bypass the uniqueness check as it stands. The above patch is derived from OpenLDAP Software. All of the modifications to OpenLDAP Software represented in the above patches were developed by Ondrej Kuznik <ondra(a)mistotebe.net>. I have not assigned rights and/or interest in this work to any party. I, Ondrej Kuznik, hereby place the above modifications to OpenLDAP Software (and only these modifications) into the public domain. Hence, these modifications may be freely used and/or redistributed for any purpose with or without attribution and/or other notice.

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by jsynacek＠redhat.com 12 Feb '15

12 Feb '15

--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Howard Chu <hyc(a)symas.com> writes: > Jan Synacek wrote: >> Howard Chu <hyc(a)symas.com> writes: >>> jsynacek(a)redhat.com wrote: >>>> Full_Name: Jan Synacek >>>> Version: 2.4.40 >>>> OS: GNU/Linux >>>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-= libdb-detection-with-gcc-5.patch >>>> Submission from: (NULL) (94.112.188.81) >>>> >>>> >>>> The old cpp version generated: >>>> __db_version 5 >>>> >>>> Configure then correctly picked up the version, since it greps for >>>> "__db_version". >>>> >>>> The new output: >>>> __db_version >>>> 5 >>>> >>>> Grepping no longer works and configure fails. >>>> >>>> Running cpp with -P (inhibit linemarkers generation) fixes this when u= sing gcc >>>> 5. >>>> Behavior with older versions of gcc is not changed. >>> >>> Your patch is simple enough but frankly this sounds like a bug in gcc >>> 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle >>> of lines, or inserting line breaks arbitrarily. >> >> Yes, probably. But in the meantime, I needed the package to build, so I >> wrote this patch. > > Please file a bug with the gcc project and followup here with a link to=20 > that bug, for future reference. Thanks. Filed as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D65037. > Adding this patch to git master. Thank you, =2D-=20 Jan Synacek Software Engineer, Red Hat --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU3GWXAAoJEL3BmMJQOtjB6HQQAKF6PH2e6OACvDZCAmCRj4qG OT/izonRts5+ZEN645TB6oPjTN1hU43/Z/+W7eZQBQoTfQrngTzBwfAC3deFfFXU vhwf+oZR3vTsPjGev5EwM+vl7OCXN5AYhU1JNkeXM65cVQsZHWHLTIjkVImodXSs Gl258ydoURg29F1DNNfs4IA4ImpTuVZ9SZBLg7XCyJBN7Refgrbie7xpevkUh/5o ctvN4AQpUese60GE+OKiYhnyViG/pzxamMdKyOtbf5AwN+4u0HdndUqPU6iJHEQ6 66D8iJsrQgBH0dl8ggX8uQKAoq+8Pkf3hs339NUrEOAk6O91lixSWTV4UQsAJK9q 0aGMDc1f0JcNDFq1ycCcHnnJ+TbEJRi/s/RmD1Ku87vGXpYTzXUbYZE8S5pRlkLl Y5Nz0vfp76j9GvfFwrsKtvYBQAStWmV/HVeW5DbVXzRWE71StVeGfHOLRxViPoBp 3u2jaArPUMpA+ZgYfBZ7HMMvchBhgTW+f/nnZCudCVukWdd/VIK/JSe/r3q5SWv5 9QVnUy9er0t4yMsH+waSRCgRZ0BR14e7YNzPfzaqEIeFb/k5bbVtdAEhkjIREMHT 8oSF2/K+tCORx0lqpxoXZfjVEGAQUkobw/a9ABNnoUYeuy+/9nIkp970PK48AsCC wEULvjRGsq9wvJorGDJI =k/xN -----END PGP SIGNATURE----- --=-=-=--

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by h.b.furuseth＠usit.uio.no 11 Feb '15

11 Feb '15

On 11/02/15 14:25, hyc(a)symas.com wrote: > Your patch is simple enough but frankly this sounds like a bug in gcc > 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle > of lines, or inserting line breaks arbitrarily. Not a gcc bug, the ITS report proved incomplete. gcc-5 inserts "# <file information>" lines (indicating where the macro expansion comes from, I think), so it needs the line breaks. This slightly different test program: #include <db.h> __db_version DB_VERSION_MAJOR+0000; ...produces this: # 2 "test.c" __db_version # 2 "test.c" 3 4 4 # 2 "test.c" +0000; -- Hallvard

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by hyc＠symas.com 11 Feb '15

11 Feb '15

Jan Synacek wrote: > Howard Chu <hyc(a)symas.com> writes: >> jsynacek(a)redhat.com wrote: >>> Full_Name: Jan Synacek >>> Version: 2.4.40 >>> OS: GNU/Linux >>> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-libdb-dete… >>> Submission from: (NULL) (94.112.188.81) >>> >>> >>> The old cpp version generated: >>> __db_version 5 >>> >>> Configure then correctly picked up the version, since it greps for >>> "__db_version". >>> >>> The new output: >>> __db_version >>> 5 >>> >>> Grepping no longer works and configure fails. >>> >>> Running cpp with -P (inhibit linemarkers generation) fixes this when using gcc >>> 5. >>> Behavior with older versions of gcc is not changed. >> >> Your patch is simple enough but frankly this sounds like a bug in gcc >> 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle >> of lines, or inserting line breaks arbitrarily. > > Yes, probably. But in the meantime, I needed the package to build, so I > wrote this patch. Please file a bug with the gcc project and followup here with a link to that bug, for future reference. Thanks. Adding this patch to git master. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8054) Operation duration logging
by h.b.furuseth＠usit.uio.no 11 Feb '15

11 Feb '15

On 11. feb. 2015 12:38, Michael Ströder wrote: > h.b.furuseth(a)usit.uio.no wrote: >> Cool feture, but please use fewer characteres in the already >> bloated log. How about "time=<integer>us" or even omit the "us"? > > +1 > > But 'time' sounds a bit general. > How about 'tdu' or even 'td' as abbreviation for "time duration"? I don't think so. You can't see from that what it means unless you already know, so you have to look it up just to see if you're interested. 'time' you can decide to look up if you are interested. -- Hallvard

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by jsynacek＠redhat.com 11 Feb '15

11 Feb '15

--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Howard Chu <hyc(a)symas.com> writes: > jsynacek(a)redhat.com wrote: >> Full_Name: Jan Synacek >> Version: 2.4.40 >> OS: GNU/Linux >> URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-li= bdb-detection-with-gcc-5.patch >> Submission from: (NULL) (94.112.188.81) >> >> >> The old cpp version generated: >> __db_version 5 >> >> Configure then correctly picked up the version, since it greps for >> "__db_version". >> >> The new output: >> __db_version >> 5 >> >> Grepping no longer works and configure fails. >> >> Running cpp with -P (inhibit linemarkers generation) fixes this when usi= ng gcc >> 5. >> Behavior with older versions of gcc is not changed. > > Your patch is simple enough but frankly this sounds like a bug in gcc=20 > 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle=20 > of lines, or inserting line breaks arbitrarily. Yes, probably. But in the meantime, I needed the package to build, so I wrote this patch. Cheers, =2D-=20 Jan Synacek Software Engineer, Red Hat --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU22YfAAoJEL3BmMJQOtjBgz0P/0C6vOFzNeDmB/6gJApRB97j qQ+eAfs+VVi1nzanutQUZWIHM8F1wFFUm1ULp76z8dkxrquI9VSpTzWSj2kMPMqY iGZfK6fRM84Weog2iCR9LoVqXrNCkih1pOi3SBaQE8pLxZh0iLCg5ZEW3QEgoVam UMQz0fU5fFKtvKB85Xcy02drn64dTSn5zyF59H0CgVCTC3GBYP/tR2qp//ZPb2jj WsOMdSzx9ENf56Y/r6fmMRpKN3+c8jLHf7/zbStDIgVnCv6Haf8bLevgSYYejkus Av5U88rM9proraf6DvjwpJFfk6OCzvVo0eOcE63orw+uHyYQz/vWCLaK4/Wwo1e/ 84MekmHm1G9pQMpnrgOkUqQv/MYVQpeIgrL29DZC4y4nDa68iL7+WdNqova3s5ST 6onQTdIR8YBwVRXAfnV00SmJAEslzouhEH5MF7mcLCI+/06EnaKzqtMuTsQZvC1I 9oucRZRgdnax3jTyzDwyvxvei5/yvIESvj3NOx2vq35NxE2vqSpRqIGVucDM4cnN HVzk7fd6nFGhG9ZKWgv+2+kz6lZlH+3duIR0nJydgUJJPlRS8NxysNw439Q+Wu2D ql+Vfl9BglSrCwiE6+QrVmE9W5PLj1/I5AgE6Wrdl6zrAxYI2fj7LgiavM8tmWIp RvUpCjFNkI6AiD2KmmpV =bSRG -----END PGP SIGNATURE----- --=-=-=--

1 0

Re: (ITS#8056) [PATCH] libdb version is not detected correctly when using gcc5
by hyc＠symas.com 11 Feb '15

11 Feb '15

jsynacek(a)redhat.com wrote: > Full_Name: Jan Synacek > Version: 2.4.40 > OS: GNU/Linux > URL: https://jsynacek.fedorapeople.org/openldap/jsynacek-20150211-fix-libdb-dete… > Submission from: (NULL) (94.112.188.81) > > > The old cpp version generated: > __db_version 5 > > Configure then correctly picked up the version, since it greps for > "__db_version". > > The new output: > __db_version > 5 > > Grepping no longer works and configure fails. > > Running cpp with -P (inhibit linemarkers generation) fixes this when using gcc > 5. > Behavior with older versions of gcc is not changed. Your patch is simple enough but frankly this sounds like a bug in gcc 5's cpp. It shouldn't be inserting gratuitous whitespace in the middle of lines, or inserting line breaks arbitrarily. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs