openldap-bugs

openldap-bugs@openldap.org

1 participants
21003 discussions

Re: (ITS#8407) LMDB build warnings on Darwin/Clang for (s)printf
by hyc＠symas.com 20 Apr '16

20 Apr '16

joj(a)mac.com wrote: > Full_Name: Joakim Hassila > Version: > OS: Mac OS X 10.11 > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (90.141.153.214) > > > Minor code style issue with latest https://github.com/LMDB/lmdb. > There are three (harmless) warnings that clang caught. The code is correct. Closing this ITS. It is not the compiler's job to scold programmers about style. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8407) LMDB build warnings on Darwin/Clang for (s)printf
by joj＠mac.com 19 Apr '16

19 Apr '16

Full_Name: Joakim Hassila Version: OS: Mac OS X 10.11 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (90.141.153.214) Minor code style issue with latest https://github.com/LMDB/lmdb. There are three (harmless) warnings that clang caught. Essentially it is the same pattern for all three, usage of ternary operator yielding format strings with different number of arguments, whereby the last one is ignored for one of the format variants. To reproduce, just do "make" on a Mac with Xcode 7.3 installed (thus using clang as the compiler). +++++++++++++++ solid:liblmdb jocke$ make gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb.c mdb.c:10706:46: warning: data argument not used by format string [-Wformat-extra-args] (int)mr[i].mr_pid, (size_t)mr[i].mr_tid, txnid); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ /usr/include/secure/_stdio.h:47:56: note: expanded from macro 'sprintf' __builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__) ^~~~~~~~~~~ 1 warning generated. gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c midl.c ar rs liblmdb.a mdb.o midl.o ar: creating archive liblmdb.a gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -fPIC -c mdb.c -o mdb.lo mdb.c:10706:46: warning: data argument not used by format string [-Wformat-extra-args] (int)mr[i].mr_pid, (size_t)mr[i].mr_tid, txnid); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ /usr/include/secure/_stdio.h:47:56: note: expanded from macro 'sprintf' __builtin___sprintf_chk (str, 0, __darwin_obsz(str), __VA_ARGS__) ^~~~~~~~~~~ 1 warning generated. gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -fPIC -c midl.c -o midl.lo gcc -pthread -shared -o liblmdb.so mdb.lo midl.lo clang: warning: argument unused during compilation: '-pthre%2' gcc -pthread -O2 -g -W -Wall -Wno-unused-parameter -Wbad-function-cast -Wuninitialized -c mdb_stat.c mdb_stat.c:206:12: warning: data argument not used by format string [-Wformat-extra-args] pg, span); ^ 1 warning generated. +++++++++++++++

1 0

Re: (ITS#8406) LMDB: Assertion 'mc->mc_flags & C_INITIALIZED' with MDB_NEXT after mdb_cursor_del
by hyc＠symas.com 18 Apr '16

18 Apr '16

hyc(a)symas.com wrote: > akyrtzi(a)gmail.com wrote: >> Full_Name: Argyrios Kyrtzidis >> Version: LMDB master >> OS: OSX >> URL: >> Submission from: (NULL) (2601:646:8900:3c89:b9af:5cb2:7292:8835) >> >> >> With latest lmdb source (github mirror: >> 8fff90db7ed1e650395f39f9e8b22673aa74aa2b), there is an assertion hit when >> deleting the cursor and then doing mdb_cursor_get(MDB_NEXT) and 'entering' >> DUPSORT items. >> To demonstrate see below diff which modifies mtest3.c. When run you see this: > > For reference, this bug was exposed by ITS#8321 > b5ce8108e8bb92df00b2d27ef0e37bfe756d3752 > > (But that is not the root cause.) > Fixed now in git mdb.master -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

Re: (ITS#8406) LMDB: Assertion 'mc->mc_flags & C_INITIALIZED' with MDB_NEXT after mdb_cursor_del
by hyc＠symas.com 18 Apr '16

18 Apr '16

akyrtzi(a)gmail.com wrote: > Full_Name: Argyrios Kyrtzidis > Version: LMDB master > OS: OSX > URL: > Submission from: (NULL) (2601:646:8900:3c89:b9af:5cb2:7292:8835) > > > With latest lmdb source (github mirror: > 8fff90db7ed1e650395f39f9e8b22673aa74aa2b), there is an assertion hit when > deleting the cursor and then doing mdb_cursor_get(MDB_NEXT) and 'entering' > DUPSORT items. > To demonstrate see below diff which modifies mtest3.c. When run you see this: For reference, this bug was exposed by ITS#8321 b5ce8108e8bb92df00b2d27ef0e37bfe756d3752 (But that is not the root cause.) -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8406) LMDB: Assertion 'mc->mc_flags & C_INITIALIZED' with MDB_NEXT after mdb_cursor_del
by akyrtzi＠gmail.com 18 Apr '16

18 Apr '16

Full_Name: Argyrios Kyrtzidis Version: LMDB master OS: OSX URL: Submission from: (NULL) (2601:646:8900:3c89:b9af:5cb2:7292:8835) With latest lmdb source (github mirror: 8fff90db7ed1e650395f39f9e8b22673aa74aa2b), there is an assertion hit when deleting the cursor and then doing mdb_cursor_get(MDB_NEXT) and 'entering' DUPSORT items. To demonstrate see below diff which modifies mtest3.c. When run you see this: mdb.c:6424: Assertion 'mc->mc_flags & C_INITIALIZED' failed in mdb_cursor_next() ==== diff --git a/libraries/liblmdb/mtest3.c b/libraries/liblmdb/mtest3.c dedex 73ee6e2..a9eb011 100644 --- a/libraries/liblmdb/mtest3.c +++ b/libraries/liblmdb/mtest3.c @@ -62,6 +62,19 @@ int main(int argc,char * argv[]) data.mv_size = sizeof(sval); data.mv_data = sval; + memset(sval, sizeof(sval), 0); + memset(kval, sizeof(kval), 0); + kval[0] = 1; + mdb_put(txn, dbi, &key, &data, 0); + kval[0] = 2; + mdb_put(txn, dbi, &key, &data, 0); + sval[0] = 1; + mdb_put(txn, dbi, &key, &data, 0); + E(mdb_cursor_open(txn, dbi, &cursor)); + E(mdb_cursor_get(cursor, &key, &data, MDB_NEXT)); + E(mdb_cursor_del(cursor, 0)); + E(mdb_cursor_get(cursor, &key, &data, MDB_NEXT)); // Assertion hit. + printf("Adding %d values\n", count); for (i=0;i<count;i++) { if (!(i & 0x0f))

1 0

(ITS#8404) Fix for an assertion failure when olcDbRewrite is modified on a meta or asyncmeta database
by nivanova＠symas.com 14 Apr '16

14 Apr '16

Full_Name: Nadezhda Ivanova Version: 2.5 OS: Ubuntu 14.04 URL: ftp://ftp.openldap.org/incoming/nadezhda-ivanova-160414.patch Submission from: (NULL) (78.83.54.234) The problem was reproduced when attempting to modify the dynamic configuration of meta and asyncmeta rewrite engine. On a meta database that has rewrite enabled and some rewrite rules configured, execute ldapmodify with the following LDIF: dn: olcMetaSub={0}uri,olcDatabase={1}meta,cn=config replace: olcDbRewrite olcDbRewrite: rewriteEngine "off"

1 0

RE: (ITS#8402) indexing issue
by escriba＠cells.es 13 Apr '16

13 Apr '16

Mail system message that raised the alarm: Reporting-MTA: dns; mail01.xxxx.xx X-Postfix-Queue-ID: 24C5526003F X-Postfix-Sender: rfc822; xxxxx at xxx .xy Arrival-Date: Wed, 13 Apr 2016 16:30:34 +0200 (CEST) Final-Recipient: rfc822; xxxxx @ xxx .xy Original-Recipient: rfc822; xxxxxx at xxx .xy Action: failed Status: 5.1.1 Remote-MTA: dns; mail02.xxxx.xx Diagnostic-Code: smtp; 550 5.1.1 <xxxxxxx at xxx .xy >: Recipient address rejected: User unknown in local recipient table >From my point of view indexing, even if not needed, may never do the queries fail, isn't it? But seems something weird happened. Regards.

1 0

(ITS#8402) indexing issue
by escriba＠cells.es 13 Apr '16

13 Apr '16

Full_Name: Ramon Escriba Version: openldap2-2.4.23-11.3.1.x86_64 OS: openSUSE 11.4 URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (84.89.248.48) Hi, well, is not a bug, maybe an strange interaction between openldap & postfix +saslauth. I detected those logs: Apr 13 16:40:42 <myldap> slapd[23125]: <= bdb_equality_candidates: (mailhost) not indexed So I thought, indexing may solve it. "mailhost" user attribute may only have 2 values, mail01 or mail02. Yes, maybe is not the best thing to index, but I did a try. So I added index mailhost eq in slapd.conf. Slaptest ok. Rcldap stop; slapindex; rcldap start. But then, one mail system began to fail. I comment out the index, restarted daemons & works fine again. Saslauthd.conf query: ldap_filter: ( &(uid=%u) (mailhost=mail02) (mActive=1) (objectClass=CourierMailAlias)) Postfix queries: query_filter = ( &(mail=%s) (mailhost=mail02) (mActive=1) (objectClass=CourierMailAlias)) query_filter = ( &(maildrop=%s) (mailhost=mail02) (mActive=1) (objectClass=CourierMailAlias)) Is just for curiosity. What do you thing it may happen? Why indexing mailhost makes the query fail?? I think I miss something important. Regards.

1 0

Re: (ITS#8401) mdb_env_stat crashes if env is not open
by hyc＠symas.com 13 Apr '16

13 Apr '16

gahr(a)gahr.ch wrote: > Full_Name: Pietro Cerutti > Version: lmdb 0.9.18 > OS: FreeBSD > URL: ftp://ftp.openldap.org/incoming/ > Submission from: (NULL) (69.191.176.32) > > > mdb_env_stat crashes is the env was created but not opened. This happens because > mdb_env_stat calls mdb_env_pick_meta, which doesn't check whether the two pages > are NULL before dereferencing them. > > Please note that there is no mention of the fact that the env must have been > opened before calling mdb_env_stat in the documentation [1]. You're not reading carefully. http://symas.com/mdb/doc/group__mdb.html#gaad6be3d8dcd4ea01f8df436f41d158d4 "Before the handle may be used, it must be opened using mdb_env_open()." Closing this ITS. -- -- Howard Chu CTO, Symas Corp. http://www.symas.com Director, Highland Sun http://highlandsun.com/hyc/ Chief Architect, OpenLDAP http://www.openldap.org/project/

1 0

(ITS#8401) mdb_env_stat crashes if env is not open
by gahr＠gahr.ch 13 Apr '16

13 Apr '16

Full_Name: Pietro Cerutti Version: lmdb 0.9.18 OS: FreeBSD URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (69.191.176.32) mdb_env_stat crashes is the env was created but not opened. This happens because mdb_env_stat calls mdb_env_pick_meta, which doesn't check whether the two pages are NULL before dereferencing them. Please note that there is no mention of the fact that the env must have been opened before calling mdb_env_stat in the documentation [1]. The proposed patch is to check whether the environment is active before getting the most recent page: --- mdb.c.orig 2016-04-13 10:00:30.084676000 +0000 +"B2B mdb.c 2016-04-13 10:07:32.064085000 +0000 @@ -9432,7 +9432,7 @@ { MDB_meta *meta; - if (env == NULL || arg == NULL) + if (env == NULL || !(env->me_flags & MDB_ENV_ACTIVE) || arg == NULL) return EINVAL; meta = mdb_env_pick_meta(env); [1] http://symas.com/mdb/doc/group__mdb.html#gaf881dca452050efbd434cd16e4bae255

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs