openldap-bugs

openldap-bugs@openldap.org

1 participants
21001 discussions

Re: (ITS#9055) contrib/slapd-modules/passwd/totp improvements
by gv＠members.scinet.supercomputing.org 05 Sep '19

05 Sep '19

On Thu, Sep 05, 2019 at 11:52:45AM +0200, Ond??ej Kuzn??k wrote: > - could you split it in two patches, one to check the previous time step > (+doc) and one to support the new schemes (+doc)? Working on it, will have updated patches up shortly... > - I don't think you need to allocate a copy of the passwd just come in, > you can just frame it into separate bervals reusing the provided > buffer so long as you keep in mind they are not NUL-terminated > properly. Are you referring to the chk_totp_and_pw() function? If so, since the expected format is <password><totp> with no seperator, if I terminated the password part that would overwrite the first char of totp, yes? That's the reason I make a copy and allocate an extra byte for the NUL. > Just a style note, if there's an else coming, could you make sure both > the if and the else blocks are in {}? Implemented, it will be included in the updated patches. -- Greg Veldman

1 0

Re: (ITS#9055) contrib/slapd-modules/passwd/totp improvements
by ondra＠mistotebe.net 05 Sep '19

05 Sep '19

On Wed, Jul 31, 2019 at 08:14:55PM +0000, gv(a)members.scinet.supercomputing.org wrote: > v3 of the patch is available, which includes hashing functions > and documents the expected input format when using those functions. > I don't have the updated module on any of my servers yet, but > running slappasswd from my build directory does seem to yield > the same results as the non-password versions: > > $ ../../../../servers/slapd/slappasswd -T passwd -o module-load=`pwd`/.libs/pw-totp.so -h "{TOTP1}" > New password: > Re-enter new password: > {TOTP1}GAYA==== > > $ ../../../../servers/slapd/slappasswd -T passwd -o module-load=`pwd`/.libs/pw-totp.so -h "{TOTP1ANDPW}" > New password: > Re-enter new password: > {TOTP1ANDPW}GAYA====|{SSHA}Qo6WiIWWsWohlwZSo9oQkImKvSNArGio > > This is using an OTP seed of 00 and a password of foo > > https://scinet.supercomputing.org/~gv/slapd-totp-v3.txt Hi Greg, looking at the code, I think I'd be ok with this functionality and nothing major comes up for me. I would like to see a few changes though: - could you split it in two patches, one to check the previous time step (+doc) and one to support the new schemes (+doc)? - I don't think you need to allocate a copy of the passwd just come in, you can just frame it into separate bervals reusing the provided buffer so long as you keep in mind they are not NUL-terminated properly. Just a style note, if there's an else coming, could you make sure both the if and the else blocks are in {}? Regards, -- Ondřej Kuzník Senior Software Engineer Symas Corporation http://www.symas.com Packaged, certified, and supported LDAP solutions powered by OpenLDAP

1 0

答复: (ITS#9072) openLdap client problem
by feng.wang＠iquantex.com 01 Sep '19

01 Sep '19

--_6DA7EF0F-7766-481F-9373-22F0846C9405_ Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Thank you for your reply! =C2=A0=C2=A0=C2=A0=C2=A0 This problem has been solved, not the openldap pro= blem, but the problem with the use of the sssd service. Of course, I will c= onsider your suggestion to upgrade to version 2.4.48. =E5=8F=91=E9=80=81=E8=87=AA Windows 10 =E7=89=88=E9=82=AE=E4=BB=B6=E5=BA=94= =E7=94=A8 =E5=8F=91=E4=BB=B6=E4=BA=BA: Quanah Gibson-Mount =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2019=E5=B9=B48=E6=9C=8830=E6=97=A5 22= :07 =E6=94=B6=E4=BB=B6=E4=BA=BA: feng.wang(a)iquantex.com; openldap-its(a)OpenLDAP.= org =E4=B8=BB=E9=A2=98: Re: (ITS#9072) openLdap client problem --On Friday, August 30, 2019 7:14 AM +0000 feng.wang(a)iquantex.com wrote: > Thank you very much for getting support! > ???? In the production of openldap is the HA environment, other uses are > normal, only in the modification of the user to multiple groups (some > client new user information is updated, and some other host clients are > not updated). Please update to a current release of OpenLDAP, i.e, at least version=20 2.4.48 as numerous replication fixes have been made to the product since=20 that time. You were already told to upgrade in ITS#9053 as well. Please=20 stop filing ITSes until such a time as you have upgraded to a current=20 release. Regards, Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com> --_6DA7EF0F-7766-481F-9373-22F0846C9405_ Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset="utf-8" <html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc= hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of= fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40"><head><meta ht= tp-equiv=3DContent-Type content=3D"text/html; charset=3Dutf-8"><meta name= =3DGenerator content=3D"Microsoft Word 15 (filtered medium)"><style></style></head><body lang=3DZH-CN link=3Dblue vlink=3D"#954F72"><div cla= ss=3DWordSection1>Thank you for you= r reply!  &nbs= p;  This problem has been solved, not the openldap problem, but the pr= oblem with the use of the sssd service. Of course, I will consider your sug= gestion to upgrade to version 2.4.48.<o:p></o:p><o:p> </o:p>=E5=8F=91=E9=80=81=E8=87= =AA Windows 10 =E7=89=88<a hre= f=3D"https://go.microsoft.com/fwlink/?LinkId=3D550986"><= span lang=3DEN-US>=E9=82=AE=E4=BB=B6</a>=E5=BA=94=E7= =94=A8<o:p> </o:p><div style=3D'mso-element:= para-border-div;border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0c= m 0cm 0cm'>=E5=8F= =91=E4=BB=B6=E4=BA=BA: <a = href=3D"mailto:quanah@symas.com">Quanah Gibson-Mount</a> =E5= =8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2019=E5=B9=B48=E6=9C=8830=E6=97=A5 22:07 =E6=94=B6= =E4=BB=B6=E4=BA=BA: <a hre= f=3D"mailto:feng.wang@iquantex.com">feng.wang(a)iquantex.com</a>; <a href=3D"= mailto:openldap-its@OpenLDAP.org">openldap-its(a)OpenLDAP.org</a> <= b>=E4=B8=BB=E9=A2=98: Re: = (ITS#9072) openLdap client problem</div><sp= an lang=3DEN-US style=3D'font-size:12.0pt;font-family:SimSun'><o:p> </= o:p><o:p> </o:p></s= pan><o:p> </o:p></p= >--On Friday, August 30, 2019 7:14 = AM +0000 feng.wang(a)iquantex.com wrote:<span= lang=3DEN-US><o:p> </o:p>> Thank you very much for getting support!> ???? In the production of openldap is = the HA environment, other uses are> normal, only in the modification of the user to multiple gro= ups (some> client new= user information is updated, and some other host clients are> not updated).<o:p> </o:p>Please update to a current release of OpenLDAP, i.= e, at least version 2.4.= 48 as numerous replication fixes have been made to the product since </span= >that time.=C2=A0 You were alre= ady told to upgrade in ITS#9053 as well.=C2=A0 Please stop filing ITSes until such a time as you = have upgraded to a current release.<o:p> </= o:p>Regards,<= p class=3DMsoNormal>Quanah<o:p> </o:p><span= lang=3DEN-US><o:p> </o:p>--<o:p> </= o:p>Quanah Gibson-Mount<= /span>Product Architect<= /p>Symas CorporationPackaged, certified, and supported LDAP= solutions powered by OpenLDAP:<http://www.symas.com><o:p> </o:p></div></body></html>= --_6DA7EF0F-7766-481F-9373-22F0846C9405_--

1 0

Re: (ITS#8383) msys build error "portable.h:1116:19: error: two or more data types in declaration specifiers"
by ryan＠nardis.ca 01 Sep '19

01 Sep '19

I've run into this myself while trying to test ITS#9069 on Windows. In my MinGW environment, <sys/socket.h> does not define socklen_t, so portable.h:1116 does '#define socklen_t int'. However, <ac/socket.h> includes <ws2tcpip.h> which does typedef socklen_t. base64.c includes "portable.h" first and then <ac/socket.h> later. This second include triggers the error as the original typedef essentially becomes "typedef int int". I think we can fix it by searching the Windows header as well, avoiding the #define appearing in "portable.h". https://github.com/openldap/openldap/compare/openldap:master...rtandy:its83…

1 0

Re: (ITS#9073) md_cmp() called with zero size key
by juerg.bircher＠gmail.com 31 Aug '19

31 Aug '19

After having investigated more time on this issue and having changed = some parts of my code which could cause data corruption everything seems = to work fine. So most likely this issue can be closed.=

1 0

(ITS#9073) md_cmp() called with zero size key
by juerg.bircher＠gmail.com 31 Aug '19

31 Aug '19

Full_Name: Juerg Bircher Version: LMDB master OS: macOS / linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (84.75.150.99) I had the situation that my custom compare function was called with a MDB_val with zero size. I assume this should never happen as a key with zero length should not be valid? Unfortunately I do not have a simple case to reproduce it as it happens in large transaction with a lot of mdb_cursor_put() interleaved with mdb_cursor_get() calls. However it is reproducible. In mdb_cursor_set() at line mdb.c:6943 nodekey.mv_size is zero. rc = mc->mc_dbx->md_cmp(key, &nodekey); So the custom compare function is called with a value of zero length. A possible fix could be to surrond the code from line 6943 to 7007 with a check if (nodekey.mv_size > 0) { rc = mc->mc_dbx->md_cmp(key, &nodekey); if (rc == 0) { line 6943 to 7007 } I thank you in advance to inform me: a. if this fix is correct b. my assumption is wrong c. it needs another fix somewhere else

1 0

Re: (ITS#9072) openLdap client problem
by quanah＠symas.com 30 Aug '19

30 Aug '19

--On Friday, August 30, 2019 7:14 AM +0000 feng.wang(a)iquantex.com wrote: > Thank you very much for getting support! > ???? In the production of openldap is the HA environment, other uses are > normal, only in the modification of the user to multiple groups (some > client new user information is updated, and some other host clients are > not updated). Please update to a current release of OpenLDAP, i.e, at least version 2.4.48 as numerous replication fixes have been made to the product since that time. You were already told to upgrade in ITS#9053 as well. Please stop filing ITSes until such a time as you have upgraded to a current release. Regards, Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

(ITS#87) openLdap client problem
by feng.wang＠iquantex.com 29 Aug '19

29 Aug '19

Full_Name: wangfeng Version: 2.4.44 OS: linux URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (1.180.156.107) Thank you very much for getting support! In the production of openldap is the HA environment, other uses are normal, only in the modification of the user to multiple groups (some client new user information is updated, and some other host clients are not updated).

1 0

Re: (ITS#9070) Failing to include openssl1.1.1c with openLDAP
by quanah＠symas.com 29 Aug '19

29 Aug '19

--On Thursday, August 29, 2019 3:13 PM +0000 vishal.bafna307(a)gmail.com wrote: > I am trying to build openLDAP using openssl1.1.1c. > It is failing to locate the SSL/TLS package. > I have given the openssl lib and include paths in LDFLAGS and CPPFLAGS > respectively in the Makefile of LDAP. The Make file also has > --with-tls=openssl \ mentioned as config option The ITS system is for bug reports, not help requests on how to build the software. If you need help with building the software, please use the openldap-technical(a)openldap.org email list. <https://www.openldap.org/lists/mm/listinfo/openldap-technical> This ITS will be closed. Regards, Quanah -- Quanah Gibson-Mount Product Architect Symas Corporation Packaged, certified, and supported LDAP solutions powered by OpenLDAP: <http://www.symas.com>

1 0

(ITS#9071) Invalid olcDbStartTLS values generated on back-ldap conversion
by quanah＠openldap.org 29 Aug '19

29 Aug '19

Full_Name: Quanah Gibson-Mount Version: 2.4.48 OS: N/A URL: ftp://ftp.openldap.org/incoming/ Submission from: (NULL) (47.208.128.44) When converting this basic slapd.conf for back-ldap: include /usr/local/etc/openldap/schema/core.schema include /usr/local/etc/openldap/schema/cosine.schema include /usr/local/etc/openldap/schema/inetorgperson.schema include /usr/local/etc/openldap/schema/nis.schema include /usr/local/etc/openldap/schema/openldap.schema include /usr/local/etc/openldap/schema/ppolicy.schema include /usr/local/etc/openldap/schema/misc.schema loglevel 256 pidfile /var/run/slapd.pid argsfile /var/run/slapd.args modulepath /usr/local/libexec/openldap moduleload rwm moduleload back_ldap database ldap readonly yes protocol-version 3 rebind-as-user yes uri "ldaps://universe.example.com" suffix "dc=universe,dc=example,dc=com" overlay rwm rwm-map attribute uid sAMAccountName rwm-map attribute mail proxyAddresses chase-referrals yes idassert-bind bindmethod=simple binddn="cn=ldap_phone,ou=LDAP Access,dc=example,dc=com" credentials='Password1234' tls_cacert=/usr/local/etc/openldap/example_com_Universe_Root_CA.cer The resulting back-ldap configuration has an invalid olcDbStartTLS attribute: olcDbStartTLS: none starttls=no Per the man page, "none" is not valid at all, and also per the man page, since the URI is using ldaps, the value should be: olcDbStartTLS: ldaps Config is based off of a real life configuration from an end user, where things worked with slapd.conf but were broken post-conversion to cn=config. Fixing the olcDbStartTLS value to be valid resolved the issue.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

openldap-bugs