> Do you mind if I do some clean up on it?
>
> Mainly Perl::Critic and Perl::Tidy. There's a few tests missing and
> assumptions been made with opening files and system commands etc.
You might also highlight the fact that it seems to require at least 5.8
(due to the "qw()" lists).
I also don't like hard-wiring "/usr/bin/perl", as the system Perls are
rarely up to date. My favourite technique is:
#! /usr/bin/env perl -w
which finds Perl from $PATH.
Or just hard-wire "/usr/local/bin/perl" and let the sysadmin sort it
out...
--
Dave Horsfall DTM VK2KFU daveh(a)ci.com.au Ph: +61 2 9552-5509 (d) -5500 (sw)
Corinthian Eng'ng P/L, Ste 54 Jones Bay Whf, 26-32 Pirrama Rd, Pyrmont 2009, AU
Full_Name: Howard Chu
Version: 2.3/HEAD
OS:
URL: ftp://ftp.openldap.org/incoming/
Submission from: (NULL) (76.168.84.21)
Submitted by: hyc
If a minimal LDIF is slapadd'd to create the slapd configuration, any parameters
that are not specified on input will take on their default values. However,
these defaults will not be present in the config entries and will not be visible
upon subsequent slapcat/ldapsearch.
It would be nicer if after each entry is loaded from slapd.d and parsed, the
entire entry is regenerated internally, with all defaults populated.
Howard Chu wrote:
> A fresh pull (as of 2 minutes ago) builds fine for me.
>
> If the problem you're running into is that distclean left something from
> your previous build, then you need to tell us what your previous build
> invocation was as well.
>
> I suggest you try building with a separate object directory, so that you
> can just rm -rf the object tree when you want a fresh build.
Ok, it seems the build worked with a fresh CVS working dir.
You can close this ITS.
I'll file another one for make distclean though...
Ciao, Michael.
A fresh pull (as of 2 minutes ago) builds fine for me.
If the problem you're running into is that distclean left something from
your previous build, then you need to tell us what your previous build
invocation was as well.
I suggest you try building with a separate object directory, so that you
can just rm -rf the object tree when you want a fresh build. e.g.
mkdir head
cd head
cvs co ...
cd ..
mkdir obj
cd obj
../head/configure ...
make depend; make
Personally I have never used "make distclean" ...
michael(a)stroeder.com wrote:
> Full_Name: Michael Ströder
> Version: HEAD
> OS: SuSE Linux 10.1
> URL: ftp://ftp.openldap.org/incoming/
> Submission from: (NULL) (83.124.30.198)
>
>
> I tried to build without modules (after make distclean):
>
> ./configure \
> --prefix=${PREFIX} \
> --enable-dynamic \
> --enable-modules=no \
> --enable-backends=yes \
> --enable-overlays=yes \
> --enable-cleartext \
> --enable-crypt=yes \
> --enable-debug=yes \
> --enable-kpasswd=yes \
> --enable-lmpasswd=yes \
> --enable-rewrite=yes \
> --enable-rlookups=yes \
> --enable-slapi=yes \
> --enable-slp=yes \
> --enable-spasswd=yes \
> --enable-wrappers=no \
> --enable-aci=yes \
> --with-cyrus-sasl=yes \
> --with-kerberos=yes \
> --with-readline=yes \
> --with-threads=yes \
> --with-tls=yes
>
>
> But build fails:
>
> cc -g -O0 -I../../../include -I../../../include -I.. -I./.. -I./../slapi
> -I/opt/bdb-4.5/include -I/opt/sasl/include -I/opt/heimdal/include -c version.c
> -o version.o
> ar ruv libback_monitor.a `echo init.lo search.lo compare.lo modify.lo bind.lo
> operational.lo cache.lo entry.lo backend.lo database.lo thread.lo conn.lo rww.lo
> log.lo operation.lo sent.lo listener.lo time.lo overlay.lo | sed 's/\.lo/.o/g'`
> version.o
> ar: creating libback_monitor.a
> ar: init.o: No such file or directory
> make[3]: *** [libback_monitor.a] Error 1
> make[3]: Leaving directory
> `/home/michael/src/openldap-HEAD/ldap/servers/slapd/back-monitor'
> make[2]: *** [.backend] Error 1
> make[2]: Leaving directory `/home/michael/src/openldap-HEAD/ldap/servers/slapd'
> make[1]: *** [all-common] Error 1
> make[1]: Leaving directory `/home/michael/src/openldap-HEAD/ldap/servers'
> make: *** [all-common] Error 1
>
>
>
>
--
-- Howard Chu
Chief Architect, Symas Corp. http://www.symas.com
Director, Highland Sun http://highlandsun.com/hyc
OpenLDAP Core Team http://www.openldap.org/project/
Hi,
On Thursday, 2. November 2006 20:42, Quanah Gibson-Mount wrote:
> Peter S, Dave, Peter M, Frank, and Todd, do you also grant such a release
> for the work you've done with this script? :)
Granted !
Peter
--
Peter Marschall
peter(a)adpm.de